Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42145/?format=api
{ "id": 42145, "url": "http://patches.dpdk.org/api/patches/42145/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180703103119.15747-8-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180703103119.15747-8-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180703103119.15747-8-bruce.richardson@intel.com", "date": "2018-07-03T10:31:18", "name": "[v2,7/8] net/avp: fix 32-bit meson builds", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "509c10927526eef979be7ef7a6bbb12a907a91d3", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180703103119.15747-8-bruce.richardson@intel.com/mbox/", "series": [ { "id": 370, "url": "http://patches.dpdk.org/api/series/370/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=370", "date": "2018-07-03T10:31:11", "name": "Enable 32-bit native builds with meson", "version": 2, "mbox": "http://patches.dpdk.org/series/370/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42145/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1937D1BEEA;\n\tTue, 3 Jul 2018 12:32:18 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 615601BEEA\n\tfor <dev@dpdk.org>; Tue, 3 Jul 2018 12:32:16 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Jul 2018 03:32:15 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby fmsmga002.fm.intel.com with ESMTP; 03 Jul 2018 03:32:14 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,303,1526367600\"; d=\"scan'208\";a=\"63749977\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 3 Jul 2018 11:31:18 +0100", "Message-Id": "<20180703103119.15747-8-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180703103119.15747-1-bruce.richardson@intel.com>", "References": "<20180608163807.66737-1-bruce.richardson@intel.com>\n\t<20180703103119.15747-1-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 7/8] net/avp: fix 32-bit meson builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When compiling with meson, extra warnings are enabled about casting from\nintegers to different size pointers. This triggers an error in AVP as the\naddition of the offset to the pointer address causes the result to be a\n64-bit integer which doesn't fit a 32-bit pointer. The fix here is to\nexplicitly indicate that the offset is of type \"uintptr_t\" which prevents\nany promotion which would cause errors.\n\nFixes: c0ad584222b5 (\"net/avp: add device initialization\")\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Allain Legacy <allain.legacy@windriver.com>\nSeries-acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/net/avp/avp_ethdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c\nindex dc97e60e6..5e859c8dd 100644\n--- a/drivers/net/avp/avp_ethdev.c\n+++ b/drivers/net/avp/avp_ethdev.c\n@@ -383,7 +383,7 @@ avp_dev_translate_address(struct rte_eth_dev *eth_dev,\n \t\t\t(host_phys_addr < (map->phys_addr + map->length))) {\n \t\t\t/* address is within this segment */\n \t\t\toffset += (host_phys_addr - map->phys_addr);\n-\t\t\taddr = RTE_PTR_ADD(addr, offset);\n+\t\t\taddr = RTE_PTR_ADD(addr, (uintptr_t)offset);\n \n \t\t\tPMD_DRV_LOG(DEBUG, \"Translating host physical 0x%\" PRIx64 \" to guest virtual 0x%p\\n\",\n \t\t\t\t host_phys_addr, addr);\n", "prefixes": [ "v2", "7/8" ] }