Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42132/?format=api
http://patches.dpdk.org/api/patches/42132/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180702212750.16758-4-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180702212750.16758-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20180702212750.16758-4-thomas@monjalon.net", "date": "2018-07-02T21:27:48", "name": "[v2,3/5] ethdev: convert remaining apps to new offload API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0ed50689d7c3da465a5abd66f8836e5a1d6a6614", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180702212750.16758-4-thomas@monjalon.net/mbox/", "series": [ { "id": 366, "url": "http://patches.dpdk.org/api/series/366/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=366", "date": "2018-07-02T21:27:45", "name": "remove old ethdev offload API", "version": 2, "mbox": "http://patches.dpdk.org/series/366/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42132/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42132/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 14A8C1BDE8;\n\tMon, 2 Jul 2018 23:28:08 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 100A11BDCF\n\tfor <dev@dpdk.org>; Mon, 2 Jul 2018 23:28:02 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 91F6621B6B;\n\tMon, 2 Jul 2018 17:28:01 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Mon, 02 Jul 2018 17:28:01 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 6533410269;\n\tMon, 2 Jul 2018 17:28:00 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tcc:date:from:in-reply-to:message-id:references:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=wXCOnLgxOg5HcP\n\tQjY3SbUy45yCXPZZRFcgNaEro13bc=; b=lzix8bPir+ohTeXCFsuHvkRl4HOKDe\n\tmw6qWZJ9viiA1+gdZNNnlf/Chc2S8878tRHBgQv85P9K/lf1bdup9lN8w+Q6ubn7\n\tYfRCAKciERE4t7y5eshsaH869M4EvDbj+sGz8aV6sVaMhg+Wh+SvHnnpNg5jmTgQ\n\tZIhdqmfr83qVU=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm3; bh=wXCOnLgxOg5HcPQjY3SbUy45yCXPZZRFcgNaEro13bc=; b=fE9vepXh\n\tHEGYWNUr7Tt9ocC6skQxQExe27lkwmhQJrWDi8KLNUc9DDbdcvontVMtpgzb8i9n\n\t/LaXInYW6XsGkHiAnUdZ6poO3t1EcwhJwRx3keCnS89LzTat/9H3ODWtugd3Kk3n\n\t5vQFDJlJdhPeexTZyPAbqotp7AhHOlrS2dFvxjx35hMHAQSvfLvubM2A6tTVQsmp\n\t5MQAAOqWwwzVj3TW0fafayx2bJeghYbDrkPgI76Hd6Nr2g79CXpxFtZXeMiMsGiX\n\tRGdaByYs4LUzYFcYtf5j4dDWo7Ff/ZZZtAU1iemMoU12LipFCeyrGbEnjym2hJGP\n\tFKSxsy8PbLPm+A==" ], "X-ME-Proxy": "<xmx:4Zg6WyugWXYfBag_43ebZf-LJ1_RvUY4wIEmJMXbJOMjz7xvVErJ8A>\n\t<xmx:4Zg6W9WT-dvGuQSwldYxEatM4nxEeY9ceJwmHJXm3JfFF4VTTw91fQ>\n\t<xmx:4Zg6WwNwOX4yP1Fu6HIumEBGbw683fMkcM04dc7xX3QV_Qrn7Yj05w>\n\t<xmx:4Zg6W-UoMG9vLVfFhpF5S2ow7yXVRAuqZDu-X5pN5OF7mDSsw8TNPw>\n\t<xmx:4Zg6WzR1ylcmnfWDmA4fHE65e56XYJRYCX8mAnha78pxGWJcUaaE6Q>\n\t<xmx:4Zg6WyFRaXto0uX3UMV2DOh5_YCO0sS4K-S7oU76-VurnWPaHOUlPQ>", "X-ME-Sender": "<xms:4Zg6W1nfftJj0qlpgWuRLgfDtoRAK4ssaY6YipoBxOHyySrCF7PIGQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "ferruh.yigit@intel.com, arybchenko@solarflare.com, shahafs@mellanox.com", "Cc": "dev@dpdk.org, ravi1.kumar@amd.com, rasesh.mody@cavium.com,\n\tmaxime.coquelin@redhat.com", "Date": "Mon, 2 Jul 2018 23:27:48 +0200", "Message-Id": "<20180702212750.16758-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180702212750.16758-1-thomas@monjalon.net>", "References": "<1571938.317irMz1sZ@xps>\n\t<20180702212750.16758-1-thomas@monjalon.net>", "Subject": "[dpdk-dev] [PATCH v2 3/5] ethdev: convert remaining apps to new\n\toffload API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some test applications and examples were not converted\nto the new offload API introduced in 17.11.\n\nFor reference, see \"Hardware Offload\" in\n\tdoc/guides/prog_guide/poll_mode_drv.rst\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/test-eventdev/test_perf_common.c | 8 +----\n .../sample_app_ug/l2_forward_job_stats.rst | 19 ------------\n .../sample_app_ug/l2_forward_real_virtual.rst | 19 ------------\n doc/guides/sample_app_ug/link_status_intr.rst | 5 +---\n .../sample_app_ug/vmdq_dcb_forwarding.rst | 4 ---\n examples/bbdev_app/main.c | 6 +---\n examples/ip_pipeline/link.c | 11 +------\n test/test-pipeline/init.c | 6 +---\n test/test/test_kni.c | 6 +---\n test/test/test_link_bonding.c | 13 ++-------\n test/test/test_link_bonding_mode4.c | 6 +---\n test/test/test_link_bonding_rssconf.c | 12 ++------\n test/test/test_pmd_perf.c | 29 +++----------------\n 13 files changed, 15 insertions(+), 129 deletions(-)", "diff": "diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c\nindex d00f91802..eed80d1b1 100644\n--- a/app/test-eventdev/test_perf_common.c\n+++ b/app/test-eventdev/test_perf_common.c\n@@ -680,13 +680,7 @@ perf_ethdev_setup(struct evt_test *test, struct evt_options *opt)\n \t\t\t.mq_mode = ETH_MQ_RX_RSS,\n \t\t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n \t\t\t.split_hdr_size = 0,\n-\t\t\t.header_split = 0,\n-\t\t\t.hw_ip_checksum = 0,\n-\t\t\t.hw_vlan_filter = 0,\n-\t\t\t.hw_vlan_strip = 0,\n-\t\t\t.hw_vlan_extend = 0,\n-\t\t\t.jumbo_frame = 0,\n-\t\t\t.hw_strip_crc = 1,\n+\t\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t\t},\n \t\t.rx_adv_conf = {\n \t\t\t.rss_conf = {\ndiff --git a/doc/guides/sample_app_ug/l2_forward_job_stats.rst b/doc/guides/sample_app_ug/l2_forward_job_stats.rst\nindex d7219a293..ba73d8557 100644\n--- a/doc/guides/sample_app_ug/l2_forward_job_stats.rst\n+++ b/doc/guides/sample_app_ug/l2_forward_job_stats.rst\n@@ -218,25 +218,6 @@ The rte_eth_dev_configure() function is used to configure the number of queues f\n \"err=%d, port=%u\\n\",\n ret, portid);\n \n-The global configuration is stored in a static structure:\n-\n-.. code-block:: c\n-\n- static const struct rte_eth_conf port_conf = {\n- .rxmode = {\n- .split_hdr_size = 0,\n- .header_split = 0, /**< Header Split disabled */\n- .hw_ip_checksum = 0, /**< IP checksum offload disabled */\n- .hw_vlan_filter = 0, /**< VLAN filtering disabled */\n- .jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n- .hw_strip_crc= 0, /**< CRC stripped by hardware */\n- },\n-\n- .txmode = {\n- .mq_mode = ETH_DCB_NONE\n- },\n- };\n-\n RX Queue Initialization\n ~~~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst\nindex b459d4efe..2b2d5afa0 100644\n--- a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst\n+++ b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst\n@@ -245,25 +245,6 @@ The rte_eth_dev_configure() function is used to configure the number of queues f\n \"err=%d, port=%u\\n\",\n ret, portid);\n \n-The global configuration is stored in a static structure:\n-\n-.. code-block:: c\n-\n- static const struct rte_eth_conf port_conf = {\n- .rxmode = {\n- .split_hdr_size = 0,\n- .header_split = 0, /**< Header Split disabled */\n- .hw_ip_checksum = 0, /**< IP checksum offload disabled */\n- .hw_vlan_filter = 0, /**< VLAN filtering disabled */\n- .jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n- .hw_strip_crc= 0, /**< CRC stripped by hardware */\n- },\n-\n- .txmode = {\n- .mq_mode = ETH_DCB_NONE\n- },\n- };\n-\n .. _l2_fwd_app_rx_init:\n \n RX Queue Initialization\ndiff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst\nindex 8c11ba4ae..c7665fe5c 100644\n--- a/doc/guides/sample_app_ug/link_status_intr.rst\n+++ b/doc/guides/sample_app_ug/link_status_intr.rst\n@@ -137,10 +137,7 @@ The global configuration is stored in a static structure:\n static const struct rte_eth_conf port_conf = {\n .rxmode = {\n .split_hdr_size = 0,\n- .header_split = 0, /**< Header Split disabled */\n- .hw_ip_checksum = 0, /**< IP checksum offload disabled */\n- .hw_vlan_filter = 0, /**< VLAN filtering disabled */\n- .hw_strip_crc= 0, /**< CRC stripped by hardware */\n+ .offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n },\n .txmode = {},\n .intr_conf = {\ndiff --git a/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst b/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst\nindex 83fcdf637..0e9da9707 100644\n--- a/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst\n+++ b/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst\n@@ -102,10 +102,6 @@ a default structure is provided for VMDQ and DCB configuration to be filled in l\n .rxmode = {\n .mq_mode = ETH_MQ_RX_VMDQ_DCB,\n .split_hdr_size = 0,\n- .header_split = 0, /**< Header Split disabled */\n- .hw_ip_checksum = 0, /**< IP checksum offload disabled */\n- .hw_vlan_filter = 0, /**< VLAN filtering disabled */\n- .jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n },\n .txmode = {\n .mq_mode = ETH_MQ_TX_VMDQ_DCB,\ndiff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c\nindex 254cc0676..045a190b9 100644\n--- a/examples/bbdev_app/main.c\n+++ b/examples/bbdev_app/main.c\n@@ -64,11 +64,7 @@ static const struct rte_eth_conf port_conf = {\n \t\t.mq_mode = ETH_MQ_RX_NONE,\n \t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n \t\t.split_hdr_size = 0,\n-\t\t.header_split = 0, /**< Header Split disabled */\n-\t\t.hw_ip_checksum = 0, /**< IP checksum offload disabled */\n-\t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n-\t\t.jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc = 0, /**< CRC stripped by hardware */\n+\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\ndiff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c\nindex b8a431f3e..181c31f9c 100644\n--- a/examples/ip_pipeline/link.c\n+++ b/examples/ip_pipeline/link.c\n@@ -40,18 +40,9 @@ static struct rte_eth_conf port_conf_default = {\n \t.link_speeds = 0,\n \t.rxmode = {\n \t\t.mq_mode = ETH_MQ_RX_NONE,\n-\n-\t\t.header_split = 0, /* Header split */\n-\t\t.hw_ip_checksum = 0, /* IP checksum offload */\n-\t\t.hw_vlan_filter = 0, /* VLAN filtering */\n-\t\t.hw_vlan_strip = 0, /* VLAN strip */\n-\t\t.hw_vlan_extend = 0, /* Extended VLAN */\n-\t\t.jumbo_frame = 0, /* Jumbo frame support */\n-\t\t.hw_strip_crc = 1, /* CRC strip by HW */\n-\t\t.enable_scatter = 0, /* Scattered packets RX handler */\n-\n \t\t.max_rx_pkt_len = 9000, /* Jumbo frame max packet len */\n \t\t.split_hdr_size = 0, /* Header split buffer size */\n+\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.rx_adv_conf = {\n \t\t.rss_conf = {\ndiff --git a/test/test-pipeline/init.c b/test/test-pipeline/init.c\nindex 19cf04a6c..f33216c90 100644\n--- a/test/test-pipeline/init.c\n+++ b/test/test-pipeline/init.c\n@@ -70,11 +70,7 @@ struct app_params app = {\n static struct rte_eth_conf port_conf = {\n \t.rxmode = {\n \t\t.split_hdr_size = 0,\n-\t\t.header_split = 0, /* Header Split disabled */\n-\t\t.hw_ip_checksum = 1, /* IP checksum offload enabled */\n-\t\t.hw_vlan_filter = 0, /* VLAN filtering disabled */\n-\t\t.jumbo_frame = 0, /* Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc = 1, /* CRC stripped by hardware */\n+\t\t.offloads = DEV_RX_OFFLOAD_CHECKSUM | DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.rx_adv_conf = {\n \t\t.rss_conf = {\ndiff --git a/test/test/test_kni.c b/test/test/test_kni.c\nindex 56773c8a2..1b876719a 100644\n--- a/test/test/test_kni.c\n+++ b/test/test/test_kni.c\n@@ -71,11 +71,7 @@ static const struct rte_eth_txconf tx_conf = {\n \n static const struct rte_eth_conf port_conf = {\n \t.rxmode = {\n-\t\t.header_split = 0,\n-\t\t.hw_ip_checksum = 0,\n-\t\t.hw_vlan_filter = 0,\n-\t\t.jumbo_frame = 0,\n-\t\t.hw_strip_crc = 1,\n+\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_DCB_NONE,\ndiff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c\nindex d74c0ab4e..ff0576a54 100644\n--- a/test/test/test_link_bonding.c\n+++ b/test/test/test_link_bonding.c\n@@ -43,9 +43,6 @@\n #define TX_HTHRESH 0\n #define TX_WTHRESH 0\n #define TX_RSBIT_THRESH 32\n-#define TX_Q_FLAGS (ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOVLANOFFL |\\\n-\tETH_TXQ_FLAGS_NOXSUMSCTP | ETH_TXQ_FLAGS_NOXSUMUDP | \\\n-\tETH_TXQ_FLAGS_NOXSUMTCP)\n \n #define MBUF_CACHE_SIZE (250)\n #define BURST_SIZE (32)\n@@ -138,13 +135,9 @@ static uint16_t vlan_id = 0x100;\n static struct rte_eth_conf default_pmd_conf = {\n \t.rxmode = {\n \t\t.mq_mode = ETH_MQ_RX_NONE,\n-\t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n \t\t.split_hdr_size = 0,\n-\t\t.header_split = 0, /**< Header Split disabled */\n-\t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n-\t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n-\t\t.jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc = 1, /**< CRC stripped by hardware */\n+\t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n+\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\n@@ -170,8 +163,6 @@ static struct rte_eth_txconf tx_conf_default = {\n \t},\n \t.tx_free_thresh = TX_FREE_THRESH,\n \t.tx_rs_thresh = TX_RSBIT_THRESH,\n-\t.txq_flags = TX_Q_FLAGS\n-\n };\n \n static void free_virtualpmd_tx_queue(void);\ndiff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c\nindex 33c1fab01..9163f6313 100644\n--- a/test/test/test_link_bonding_mode4.c\n+++ b/test/test/test_link_bonding_mode4.c\n@@ -110,11 +110,7 @@ static struct rte_eth_conf default_pmd_conf = {\n \t\t.mq_mode = ETH_MQ_RX_NONE,\n \t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n \t\t.split_hdr_size = 0,\n-\t\t.header_split = 0, /**< Header Split disabled */\n-\t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n-\t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n-\t\t.jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc = 1, /**< CRC stripped by hardware */\n+\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\ndiff --git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c\nindex 6a1a28d23..e6e798f5b 100644\n--- a/test/test/test_link_bonding_rssconf.c\n+++ b/test/test/test_link_bonding_rssconf.c\n@@ -83,11 +83,7 @@ static struct rte_eth_conf default_pmd_conf = {\n \t\t.mq_mode = ETH_MQ_RX_NONE,\n \t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n \t\t.split_hdr_size = 0,\n-\t\t.header_split = 0, /**< Header Split disabled */\n-\t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n-\t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n-\t\t.jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc = 1, /**< CRC stripped by hardware */\n+\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\n@@ -100,11 +96,7 @@ static struct rte_eth_conf rss_pmd_conf = {\n \t\t.mq_mode = ETH_MQ_RX_RSS,\n \t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n \t\t.split_hdr_size = 0,\n-\t\t.header_split = 0, /**< Header Split disabled */\n-\t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n-\t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n-\t\t.jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc = 1, /**< CRC stripped by hardware */\n+\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\ndiff --git a/test/test/test_pmd_perf.c b/test/test/test_pmd_perf.c\nindex 54bc4f6b0..4549965fc 100644\n--- a/test/test/test_pmd_perf.c\n+++ b/test/test/test_pmd_perf.c\n@@ -65,14 +65,7 @@ static struct rte_eth_conf port_conf = {\n \t\t.mq_mode = ETH_MQ_RX_NONE,\n \t\t.max_rx_pkt_len = ETHER_MAX_LEN,\n \t\t.split_hdr_size = 0,\n-\t\t.header_split = 0, /**< Header Split disabled */\n-\t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n-\t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n-\t\t.hw_vlan_strip = 0, /**< VLAN strip enabled. */\n-\t\t.hw_vlan_extend = 0, /**< Extended VLAN disabled. */\n-\t\t.jumbo_frame = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc = 1, /**< CRC stripped by hardware */\n-\t\t.enable_scatter = 0, /**< scatter rx disabled */\n+\t\t.offloads = DEV_RX_OFFLOAD_CRC_STRIP,\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\n@@ -97,11 +90,6 @@ static struct rte_eth_txconf tx_conf = {\n \t},\n \t.tx_free_thresh = 32, /* Use PMD default values */\n \t.tx_rs_thresh = 32, /* Use PMD default values */\n-\t.txq_flags = (ETH_TXQ_FLAGS_NOMULTSEGS |\n-\t\t ETH_TXQ_FLAGS_NOVLANOFFL |\n-\t\t ETH_TXQ_FLAGS_NOXSUMSCTP |\n-\t\t ETH_TXQ_FLAGS_NOXSUMUDP |\n-\t\t ETH_TXQ_FLAGS_NOXSUMTCP)\n };\n \n enum {\n@@ -808,38 +796,29 @@ test_set_rxtx_conf(cmdline_fixed_string_t mode)\n \n \tif (!strcmp(mode, \"vector\")) {\n \t\t/* vector rx, tx */\n-\t\ttx_conf.txq_flags = 0xf01;\n \t\ttx_conf.tx_rs_thresh = 32;\n \t\ttx_conf.tx_free_thresh = 32;\n-\t\tport_conf.rxmode.hw_ip_checksum = 0;\n-\t\tport_conf.rxmode.enable_scatter = 0;\n \t\treturn 0;\n \t} else if (!strcmp(mode, \"scalar\")) {\n \t\t/* bulk alloc rx, full-featured tx */\n-\t\ttx_conf.txq_flags = 0;\n \t\ttx_conf.tx_rs_thresh = 32;\n \t\ttx_conf.tx_free_thresh = 32;\n-\t\tport_conf.rxmode.hw_ip_checksum = 1;\n-\t\tport_conf.rxmode.enable_scatter = 0;\n+\t\tport_conf.rxmode.offloads |= DEV_RX_OFFLOAD_CHECKSUM;\n \t\treturn 0;\n \t} else if (!strcmp(mode, \"hybrid\")) {\n \t\t/* bulk alloc rx, vector tx\n \t\t * when vec macro not define,\n \t\t * using the same rx/tx as scalar\n \t\t */\n-\t\ttx_conf.txq_flags = 0xf01;\n \t\ttx_conf.tx_rs_thresh = 32;\n \t\ttx_conf.tx_free_thresh = 32;\n-\t\tport_conf.rxmode.hw_ip_checksum = 1;\n-\t\tport_conf.rxmode.enable_scatter = 0;\n+\t\tport_conf.rxmode.offloads |= DEV_RX_OFFLOAD_CHECKSUM;\n \t\treturn 0;\n \t} else if (!strcmp(mode, \"full\")) {\n \t\t/* full feature rx,tx pair */\n-\t\ttx_conf.txq_flags = 0x0; /* must condition */\n \t\ttx_conf.tx_rs_thresh = 32;\n \t\ttx_conf.tx_free_thresh = 32;\n-\t\tport_conf.rxmode.hw_ip_checksum = 0;\n-\t\tport_conf.rxmode.enable_scatter = 1; /* must condition */\n+\t\tport_conf.rxmode.offloads |= DEV_RX_OFFLOAD_SCATTER;\n \t\treturn 0;\n \t}\n \n", "prefixes": [ "v2", "3/5" ] }{ "id": 42132, "url": "