Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/421/?format=api
{ "id": 421, "url": "http://patches.dpdk.org/api/patches/421/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1411036471-3822-2-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1411036471-3822-2-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1411036471-3822-2-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2014-09-18T10:34:29", "name": "[dpdk-dev,1/3] eal: add const in prefetch functions", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "12c4fd4e01f2ac02fd1cc50d9635eceaa1a63c3f", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1411036471-3822-2-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/421/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/421/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C61CAB3AC;\n\tThu, 18 Sep 2014 12:29:05 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 8A64C68C2\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 12:29:03 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 18 Sep 2014 03:34:33 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga001.fm.intel.com with ESMTP; 18 Sep 2014 03:34:32 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts8IAYWNg012107 for <dev@dpdk.org>; Thu, 18 Sep 2014 11:34:32 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s8IAYVCP003869\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 11:34:31 +0100", "(from pdelarax@localhost)\n\tby sivswdev02.ir.intel.com with id s8IAYVHx003865\n\tfor dev@dpdk.org; Thu, 18 Sep 2014 11:34:31 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,546,1406617200\"; d=\"scan'208\";a=\"593176858\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 18 Sep 2014 11:34:29 +0100", "Message-Id": "<1411036471-3822-2-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1411036471-3822-1-git-send-email-pablo.de.lara.guarch@intel.com>", "References": "<1411036471-3822-1-git-send-email-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/3] eal: add const in prefetch functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_prefetchX functions included volatile void *p as parameter,\nbut the function does not modify it, so it should be const.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n lib/librte_eal/common/include/rte_prefetch.h | 12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_prefetch.h b/lib/librte_eal/common/include/rte_prefetch.h\nindex 8a691ef..2d59009 100644\n--- a/lib/librte_eal/common/include/rte_prefetch.h\n+++ b/lib/librte_eal/common/include/rte_prefetch.h\n@@ -55,9 +55,9 @@ extern \"C\" {\n * @param p\n * Address to prefetch\n */\n-static inline void rte_prefetch0(volatile void *p)\n+static inline void rte_prefetch0(const volatile void *p)\n {\n-\tasm volatile (\"prefetcht0 %[p]\" : [p] \"+m\" (*(volatile char *)p));\n+\tasm volatile (\"prefetcht0 %[p]\" : : [p] \"m\" (*(const volatile char *)p));\n }\n \n /**\n@@ -65,9 +65,9 @@ static inline void rte_prefetch0(volatile void *p)\n * @param p\n * Address to prefetch\n */\n-static inline void rte_prefetch1(volatile void *p)\n+static inline void rte_prefetch1(const volatile void *p)\n {\n-\tasm volatile (\"prefetcht1 %[p]\" : [p] \"+m\" (*(volatile char *)p));\n+\tasm volatile (\"prefetcht1 %[p]\" : : [p] \"m\" (*(const volatile char *)p));\n }\n \n /**\n@@ -76,9 +76,9 @@ static inline void rte_prefetch1(volatile void *p)\n * @param p\n * Address to prefetch\n */\n-static inline void rte_prefetch2(volatile void *p)\n+static inline void rte_prefetch2(const volatile void *p)\n {\n-\tasm volatile (\"prefetcht2 %[p]\" : [p] \"+m\" (*(volatile char *)p));\n+\tasm volatile (\"prefetcht2 %[p]\" : : [p] \"m\" (*(const volatile char *)p));\n }\n \n #ifdef __cplusplus\n", "prefixes": [ "dpdk-dev", "1/3" ] }