Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41998/?format=api
{ "id": 41998, "url": "http://patches.dpdk.org/api/patches/41998/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/4f33bc7b137e7674d6054a4af38396e936f0b9e5.1530300158.git.rahul.lakkireddy@chelsio.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<4f33bc7b137e7674d6054a4af38396e936f0b9e5.1530300158.git.rahul.lakkireddy@chelsio.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4f33bc7b137e7674d6054a4af38396e936f0b9e5.1530300158.git.rahul.lakkireddy@chelsio.com", "date": "2018-06-29T19:23:51", "name": "[1/5] net/cxgbe: add link up and down ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ebca0f13a2d9bfca5c421e1dcd787e2a647c0cd1", "submitter": { "id": 241, "url": "http://patches.dpdk.org/api/people/241/?format=api", "name": "Rahul Lakkireddy", "email": "rahul.lakkireddy@chelsio.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/4f33bc7b137e7674d6054a4af38396e936f0b9e5.1530300158.git.rahul.lakkireddy@chelsio.com/mbox/", "series": [ { "id": 332, "url": "http://patches.dpdk.org/api/series/332/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=332", "date": "2018-06-29T19:23:50", "name": "net/cxgbe: feature updates and bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/332/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41998/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41998/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 657F31B96E;\n\tFri, 29 Jun 2018 21:25:23 +0200 (CEST)", "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n\tby dpdk.org (Postfix) with ESMTP id 947B31B96E\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 21:25:21 +0200 (CEST)", "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id w5TJPG5I028989; \n\tFri, 29 Jun 2018 12:25:17 -0700" ], "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "To": "dev@dpdk.org", "Cc": "surendra@chelsio.com, shaguna@chelsio.com, indranil@chelsio.com,\n\tnirranjan@chelsio.com", "Date": "Sat, 30 Jun 2018 00:53:51 +0530", "Message-Id": "<4f33bc7b137e7674d6054a4af38396e936f0b9e5.1530300158.git.rahul.lakkireddy@chelsio.com>", "X-Mailer": "git-send-email 2.5.3", "In-Reply-To": [ "<cover.1530300158.git.rahul.lakkireddy@chelsio.com>", "<cover.1530300158.git.rahul.lakkireddy@chelsio.com>" ], "References": [ "<cover.1530300158.git.rahul.lakkireddy@chelsio.com>", "<cover.1530300158.git.rahul.lakkireddy@chelsio.com>" ], "Subject": "[dpdk-dev] [PATCH 1/5] net/cxgbe: add link up and down ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add ops to set link up and down for both PF and VF. If wait_to_complete\nis set, poll for link update for up to 10 seconds max.\n\nOriginal work by Surendra Mobiya <surendra@chelsio.com>\n\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\n drivers/net/cxgbe/cxgbe.h | 5 +++\n drivers/net/cxgbe/cxgbe_ethdev.c | 72 ++++++++++++++++++++++++++++++++++++--\n drivers/net/cxgbe/cxgbe_main.c | 36 +++++++++++++------\n drivers/net/cxgbe/cxgbe_pfvf.h | 2 ++\n drivers/net/cxgbe/cxgbevf_ethdev.c | 2 ++\n 5 files changed, 103 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h\nindex 27d6e2b84..96a6a4084 100644\n--- a/drivers/net/cxgbe/cxgbe.h\n+++ b/drivers/net/cxgbe/cxgbe.h\n@@ -18,6 +18,10 @@\n #define CXGBE_MIN_RX_BUFSIZE ETHER_MIN_MTU /* min buf size */\n #define CXGBE_MAX_RX_PKTLEN (9000 + ETHER_HDR_LEN + ETHER_CRC_LEN) /* max pkt */\n \n+/* Max poll time is 100 * 100msec = 10 sec */\n+#define CXGBE_LINK_STATUS_POLL_MS 100 /* 100ms */\n+#define CXGBE_LINK_STATUS_POLL_CNT 100 /* Max number of times to poll */\n+\n #define CXGBE_DEFAULT_RSS_KEY_LEN 40 /* 320-bits */\n #define CXGBE_RSS_HF_ALL (ETH_RSS_IPV4 | ETH_RSS_IPV6 | \\\n \t\t\t ETH_RSS_NONFRAG_IPV4_TCP | \\\n@@ -32,6 +36,7 @@ bool force_linkup(struct adapter *adap);\n int cxgbe_probe(struct adapter *adapter);\n int cxgbevf_probe(struct adapter *adapter);\n void cxgbe_get_speed_caps(struct port_info *pi, u32 *speed_caps);\n+int cxgbe_set_link_status(struct port_info *pi, bool status);\n int cxgbe_up(struct adapter *adap);\n int cxgbe_down(struct port_info *pi);\n void cxgbe_close(struct adapter *adapter);\ndiff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c\nindex 713dc8fae..eb07a1f89 100644\n--- a/drivers/net/cxgbe/cxgbe_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbe_ethdev.c\n@@ -200,15 +200,27 @@ void cxgbe_dev_allmulticast_disable(struct rte_eth_dev *eth_dev)\n }\n \n int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,\n-\t\t\t __rte_unused int wait_to_complete)\n+\t\t\t int wait_to_complete)\n {\n \tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n \tstruct adapter *adapter = pi->adapter;\n \tstruct sge *s = &adapter->sge;\n \tstruct rte_eth_link new_link = { 0 };\n-\tunsigned int work_done, budget = 4;\n+\tunsigned int i, work_done, budget = 32;\n+\tu8 old_link = pi->link_cfg.link_ok;\n \n-\tcxgbe_poll(&s->fw_evtq, NULL, budget, &work_done);\n+\tfor (i = 0; i < CXGBE_LINK_STATUS_POLL_CNT; i++) {\n+\t\tcxgbe_poll(&s->fw_evtq, NULL, budget, &work_done);\n+\n+\t\t/* Exit if link status changed or always forced up */\n+\t\tif (pi->link_cfg.link_ok != old_link || force_linkup(adapter))\n+\t\t\tbreak;\n+\n+\t\tif (!wait_to_complete)\n+\t\t\tbreak;\n+\n+\t\trte_delay_ms(CXGBE_LINK_STATUS_POLL_MS);\n+\t}\n \n \tnew_link.link_status = force_linkup(adapter) ?\n \t\t\t ETH_LINK_UP : pi->link_cfg.link_ok;\n@@ -219,6 +231,58 @@ int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,\n \treturn rte_eth_linkstatus_set(eth_dev, &new_link);\n }\n \n+/**\n+ * Set device link up.\n+ */\n+int cxgbe_dev_set_link_up(struct rte_eth_dev *dev)\n+{\n+\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct adapter *adapter = pi->adapter;\n+\tunsigned int work_done, budget = 32;\n+\tstruct sge *s = &adapter->sge;\n+\tint ret;\n+\n+\t/* Flush all link events */\n+\tcxgbe_poll(&s->fw_evtq, NULL, budget, &work_done);\n+\n+\t/* If link already up, nothing to do */\n+\tif (pi->link_cfg.link_ok)\n+\t\treturn 0;\n+\n+\tret = cxgbe_set_link_status(pi, true);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tcxgbe_dev_link_update(dev, 1);\n+\treturn 0;\n+}\n+\n+/**\n+ * Set device link down.\n+ */\n+int cxgbe_dev_set_link_down(struct rte_eth_dev *dev)\n+{\n+\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct adapter *adapter = pi->adapter;\n+\tunsigned int work_done, budget = 32;\n+\tstruct sge *s = &adapter->sge;\n+\tint ret;\n+\n+\t/* Flush all link events */\n+\tcxgbe_poll(&s->fw_evtq, NULL, budget, &work_done);\n+\n+\t/* If link already down, nothing to do */\n+\tif (!pi->link_cfg.link_ok)\n+\t\treturn 0;\n+\n+\tret = cxgbe_set_link_status(pi, false);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tcxgbe_dev_link_update(dev, 0);\n+\treturn 0;\n+}\n+\n int cxgbe_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n {\n \tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n@@ -1031,6 +1095,8 @@ static const struct eth_dev_ops cxgbe_eth_dev_ops = {\n \t.dev_infos_get\t\t= cxgbe_dev_info_get,\n \t.dev_supported_ptypes_get = cxgbe_dev_supported_ptypes_get,\n \t.link_update\t\t= cxgbe_dev_link_update,\n+\t.dev_set_link_up = cxgbe_dev_set_link_up,\n+\t.dev_set_link_down = cxgbe_dev_set_link_down,\n \t.mtu_set\t\t= cxgbe_dev_mtu_set,\n \t.tx_queue_setup = cxgbe_dev_tx_queue_setup,\n \t.tx_queue_start\t\t= cxgbe_dev_tx_queue_start,\ndiff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c\nindex 21ad380ae..edbb4df28 100644\n--- a/drivers/net/cxgbe/cxgbe_main.c\n+++ b/drivers/net/cxgbe/cxgbe_main.c\n@@ -1434,6 +1434,30 @@ void cxgbe_get_speed_caps(struct port_info *pi, u32 *speed_caps)\n \t\t*speed_caps |= ETH_LINK_SPEED_FIXED;\n }\n \n+/**\n+ * cxgbe_set_link_status - Set device link up or down.\n+ * @pi: Underlying port's info\n+ * @status: 0 - down, 1 - up\n+ *\n+ * Set the device link up or down.\n+ */\n+int cxgbe_set_link_status(struct port_info *pi, bool status)\n+{\n+\tstruct adapter *adapter = pi->adapter;\n+\tint err = 0;\n+\n+\terr = t4_enable_vi(adapter, adapter->mbox, pi->viid, status, status);\n+\tif (err) {\n+\t\tdev_err(adapter, \"%s: disable_vi failed: %d\\n\", __func__, err);\n+\t\treturn err;\n+\t}\n+\n+\tif (!status)\n+\t\tt4_reset_link_config(adapter, pi->pidx);\n+\n+\treturn 0;\n+}\n+\n /**\n * cxgb_up - enable the adapter\n * @adap: adapter being enabled\n@@ -1459,17 +1483,7 @@ int cxgbe_up(struct adapter *adap)\n */\n int cxgbe_down(struct port_info *pi)\n {\n-\tstruct adapter *adapter = pi->adapter;\n-\tint err = 0;\n-\n-\terr = t4_enable_vi(adapter, adapter->mbox, pi->viid, false, false);\n-\tif (err) {\n-\t\tdev_err(adapter, \"%s: disable_vi failed: %d\\n\", __func__, err);\n-\t\treturn err;\n-\t}\n-\n-\tt4_reset_link_config(adapter, pi->pidx);\n-\treturn 0;\n+\treturn cxgbe_set_link_status(pi, false);\n }\n \n /*\ndiff --git a/drivers/net/cxgbe/cxgbe_pfvf.h b/drivers/net/cxgbe/cxgbe_pfvf.h\nindex 2bba97423..8d0a105aa 100644\n--- a/drivers/net/cxgbe/cxgbe_pfvf.h\n+++ b/drivers/net/cxgbe/cxgbe_pfvf.h\n@@ -35,6 +35,8 @@ int cxgbe_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu);\n int cxgbe_dev_start(struct rte_eth_dev *eth_dev);\n int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,\n \t\t\t int wait_to_complete);\n+int cxgbe_dev_set_link_up(struct rte_eth_dev *dev);\n+int cxgbe_dev_set_link_down(struct rte_eth_dev *dev);\n uint16_t cxgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t uint16_t nb_pkts);\n uint16_t cxgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\ndiff --git a/drivers/net/cxgbe/cxgbevf_ethdev.c b/drivers/net/cxgbe/cxgbevf_ethdev.c\nindex a942ba6b6..b4770e0c5 100644\n--- a/drivers/net/cxgbe/cxgbevf_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbevf_ethdev.c\n@@ -85,6 +85,8 @@ static const struct eth_dev_ops cxgbevf_eth_dev_ops = {\n \t.dev_infos_get = cxgbe_dev_info_get,\n \t.dev_supported_ptypes_get = cxgbe_dev_supported_ptypes_get,\n \t.link_update = cxgbe_dev_link_update,\n+\t.dev_set_link_up = cxgbe_dev_set_link_up,\n+\t.dev_set_link_down = cxgbe_dev_set_link_down,\n \t.mtu_set = cxgbe_dev_mtu_set,\n \t.tx_queue_setup = cxgbe_dev_tx_queue_setup,\n \t.tx_queue_start = cxgbe_dev_tx_queue_start,\n", "prefixes": [ "1/5" ] }