Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41971/?format=api
{ "id": 41971, "url": "http://patches.dpdk.org/api/patches/41971/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530280448-12920-4-git-send-email-rk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530280448-12920-4-git-send-email-rk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530280448-12920-4-git-send-email-rk@semihalf.com", "date": "2018-06-29T13:54:07", "name": "[v5,3/4] eal: enable WC during resources mapping", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d66e34d6a002a99c01aadd37183175f975e8f1f4", "submitter": { "id": 951, "url": "http://patches.dpdk.org/api/people/951/?format=api", "name": "Rafal Kozik", "email": "rk@semihalf.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530280448-12920-4-git-send-email-rk@semihalf.com/mbox/", "series": [ { "id": 323, "url": "http://patches.dpdk.org/api/series/323/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=323", "date": "2018-06-29T13:54:04", "name": "Support for write combining.", "version": 5, "mbox": "http://patches.dpdk.org/series/323/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41971/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41971/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 56E951B4F0;\n\tFri, 29 Jun 2018 15:54:21 +0200 (CEST)", "from mail-lf0-f65.google.com (mail-lf0-f65.google.com\n\t[209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 11C061B4A4\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 15:54:18 +0200 (CEST)", "by mail-lf0-f65.google.com with SMTP id m13-v6so6848538lfb.12\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 06:54:18 -0700 (PDT)", "from rafalkozik.semihalf.local\n\t(31-172-191-173.noc.fibertech.net.pl. [31.172.191.173])\n\tby smtp.gmail.com with ESMTPSA id\n\tv136-v6sm114122lfa.10.2018.06.29.06.54.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 29 Jun 2018 06:54:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bCyk0WZ4THRNJ/IBJn0I/XHc1heLtjSlv0e9RSFQ5H0=;\n\tb=m0FU+4Tard0CexGQRZiHYlLpUoyfMOsHY2s+u7qqtIueC1Nqgus0Tt3KGZMtLe/zhk\n\tBZ0LLKHjlVmfOk7dqqiRXUO6nIEttQk50cjq1j1l8PjXqjcWk7U8/aMjny3j7/1nbLR6\n\tNaz6bWmc7ntpvuMPKMMZ55+Gca+DMXe8Jmq37lBUGWddLkKvf25PRP817KE/cavkPaeF\n\tznvBUK31bgL8EXvDbdAM2tL6P+3/9fJM0IdWbNf4l+ZNoXUMThTfE9gg2BVkUBEAhnDK\n\tPTB22bNt19iFTe+yWQJ4w8C9mdwSb9UQ8TUvnuW2s9zWKIDvSiRvtrZ6noImX/eP9iqg\n\tz9FA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bCyk0WZ4THRNJ/IBJn0I/XHc1heLtjSlv0e9RSFQ5H0=;\n\tb=jLfaOx51ZD7EhZzcObcbXCvTP75tsP0W73qsYNVQwYYcJkHdvVbY9DlUbBHJ8YKCzy\n\t1cyQs4yRD+imDfyjhAqPLiM/o5/HJfimG+L8cSuJH/oh8CGIqItbl/oAzEjUrtQxxoX1\n\tFmfW3GGg86EJsl8nbN0zTo4LE/D61R6fsfW4cNTCsVEXrWRjFY7bXfAYzenyT8BToPhR\n\tv3e96279aou8rDFSJrKusbtzeI6YEAbO1HbtjMljCW8F5KiZHEx9DGzl+VTXcEfjkZ26\n\tlFceFHUxoHcSIF/VOIimbpA79JuER2/alkJoib0v+AIL0UqFxgd0j13zElI7FkZTrjYV\n\tC90A==", "X-Gm-Message-State": "APt69E3CLcv8dhgEEt1P8bFFp+RBW9n/52qxtx0tf+wDeGAHC/HpqMIp\n\tFrCa2fjqcOQfxfBzJWJSgOs7+7ar4+TJZA==", "X-Google-Smtp-Source": "AAOMgpfuLHoW7z88ZRdA8GvGa/iPl6S+jGzwrdbjtmHj8KlA3dmgXpgV2OTKotrGt61svrQPisCmzA==", "X-Received": "by 2002:a19:e1cc:: with SMTP id\n\tl73-v6mr9608022lfk.102.1530280457471; \n\tFri, 29 Jun 2018 06:54:17 -0700 (PDT)", "From": "Rafal Kozik <rk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n\tmatua@amazon.com, igorch@amazon.com, thomas@monjalon.net,\n\tferruh.yigit@intel.com, Kozik <rk@semihalf.com>", "Date": "Fri, 29 Jun 2018 15:54:07 +0200", "Message-Id": "<1530280448-12920-4-git-send-email-rk@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530280448-12920-1-git-send-email-rk@semihalf.com>", "References": "<1530267873-7236-2-git-send-email-rk@semihalf.com>\n\t<1530280448-12920-1-git-send-email-rk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v5 3/4] eal: enable WC during resources mapping", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kozik <rk@semihalf.com>\n\nWrite combining (WC) increases NIC performance by making better\nutilization of PCI bus, but cannot be used by all PMDs.\n\nIt will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in\ndrivers flags. For proper work also igb_uio driver must be loaded with\nwc_activate set to 1.\n\nWhen mapping PCI resources, firstly check if it support WC\nand then try to us it.\nIn case of failure, it will fallback to normal mode.\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/bus/pci/linux/pci_uio.c | 47 ++++++++++++++++++++++++++++++-----------\n drivers/bus/pci/rte_bus_pci.h | 2 ++\n 2 files changed, 37 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c\nindex d423e4b..a7c1442 100644\n--- a/drivers/bus/pci/linux/pci_uio.c\n+++ b/drivers/bus/pci/linux/pci_uio.c\n@@ -282,22 +282,19 @@ int\n pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx,\n \t\tstruct mapped_pci_resource *uio_res, int map_idx)\n {\n-\tint fd;\n+\tint fd = -1;\n \tchar devname[PATH_MAX];\n \tvoid *mapaddr;\n \tstruct rte_pci_addr *loc;\n \tstruct pci_map *maps;\n+\tint wc_activate = 0;\n+\n+\tif (dev->driver != NULL)\n+\t\twc_activate = dev->driver->drv_flags & RTE_PCI_DRV_WC_ACTIVATE;\n \n \tloc = &dev->addr;\n \tmaps = uio_res->maps;\n \n-\t/* update devname for mmap */\n-\tsnprintf(devname, sizeof(devname),\n-\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d\",\n-\t\t\trte_pci_get_sysfs_path(),\n-\t\t\tloc->domain, loc->bus, loc->devid,\n-\t\t\tloc->function, res_idx);\n-\n \t/* allocate memory to keep path */\n \tmaps[map_idx].path = rte_malloc(NULL, strlen(devname) + 1, 0);\n \tif (maps[map_idx].path == NULL) {\n@@ -309,11 +306,37 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx,\n \t/*\n \t * open resource file, to mmap it\n \t */\n-\tfd = open(devname, O_RDWR);\n-\tif (fd < 0) {\n-\t\tRTE_LOG(ERR, EAL, \"Cannot open %s: %s\\n\",\n+\tif (wc_activate) {\n+\t\t/* update devname for mmap */\n+\t\tsnprintf(devname, sizeof(devname),\n+\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d_wc\",\n+\t\t\trte_pci_get_sysfs_path(),\n+\t\t\tloc->domain, loc->bus, loc->devid,\n+\t\t\tloc->function, res_idx);\n+\n+\t\tif (access(devname, R_OK|W_OK) != -1) {\n+\t\t\tfd = open(devname, O_RDWR);\n+\t\t\tif (fd < 0)\n+\t\t\t\tRTE_LOG(INFO, EAL, \"%s cannot be mapped. \"\n+\t\t\t\t\t\"Fall-back to non prefetchable mode.\\n\",\n+\t\t\t\t\tdevname);\n+\t\t}\n+\t}\n+\n+\tif (!wc_activate || fd < 0) {\n+\t\tsnprintf(devname, sizeof(devname),\n+\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d\",\n+\t\t\trte_pci_get_sysfs_path(),\n+\t\t\tloc->domain, loc->bus, loc->devid,\n+\t\t\tloc->function, res_idx);\n+\n+\t\t/* then try to map resource file */\n+\t\tfd = open(devname, O_RDWR);\n+\t\tif (fd < 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"Cannot open %s: %s\\n\",\n \t\t\t\tdevname, strerror(errno));\n-\t\tgoto error;\n+\t\t\tgoto error;\n+\t\t}\n \t}\n \n \t/* try mapping somewhere close to the end of hugepages */\ndiff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h\nindex 458e6d0..828acc5 100644\n--- a/drivers/bus/pci/rte_bus_pci.h\n+++ b/drivers/bus/pci/rte_bus_pci.h\n@@ -135,6 +135,8 @@ struct rte_pci_bus {\n \n /** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */\n #define RTE_PCI_DRV_NEED_MAPPING 0x0001\n+/** Device needs PCI BAR mapping with enabled write combining (wc) */\n+#define RTE_PCI_DRV_WC_ACTIVATE 0x0002\n /** Device driver supports link state interrupt */\n #define RTE_PCI_DRV_INTR_LSC\t0x0008\n /** Device driver supports device removal interrupt */\n", "prefixes": [ "v5", "3/4" ] }