Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41969/?format=api
{ "id": 41969, "url": "http://patches.dpdk.org/api/patches/41969/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530280448-12920-2-git-send-email-rk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530280448-12920-2-git-send-email-rk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530280448-12920-2-git-send-email-rk@semihalf.com", "date": "2018-06-29T13:54:05", "name": "[v5,1/4] igb_uio: add wc option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "575cabb82fc1ec3ca47afc350794a2211de69073", "submitter": { "id": 951, "url": "http://patches.dpdk.org/api/people/951/?format=api", "name": "Rafal Kozik", "email": "rk@semihalf.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530280448-12920-2-git-send-email-rk@semihalf.com/mbox/", "series": [ { "id": 323, "url": "http://patches.dpdk.org/api/series/323/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=323", "date": "2018-06-29T13:54:04", "name": "Support for write combining.", "version": 5, "mbox": "http://patches.dpdk.org/series/323/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41969/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41969/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1AD301B4DD;\n\tFri, 29 Jun 2018 15:54:18 +0200 (CEST)", "from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 2D2711B4BA\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 15:54:14 +0200 (CEST)", "by mail-lf0-f66.google.com with SMTP id m12-v6so6298393lfc.10\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 06:54:14 -0700 (PDT)", "from rafalkozik.semihalf.local\n\t(31-172-191-173.noc.fibertech.net.pl. [31.172.191.173])\n\tby smtp.gmail.com with ESMTPSA id\n\tv136-v6sm114122lfa.10.2018.06.29.06.54.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 29 Jun 2018 06:54:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=bb0WXuTybfPE5wmSh4PlFqB0LfNZw9JYypanDyzqf/o=;\n\tb=lkMyXEYtSsLQCwMjwqeGjVgRY4CerMYHjDfRISjRG5IDJjl02ONfeb6QvEG3DOzmkp\n\tfLcvZiLLCoOFjZmINxWVNjUpdLtBoAfYn7hkpJDpIIPaipRGllTWEG5sCpmy4CTqpSQr\n\tV+Ev2QDFLWzPVMpCy4dNlxygad5bRMZdsJj6dqEnUk2UAROLrisIwXEzS6PALF6VTsqo\n\tx09u8gBuhOFAwOX+7vvzzCYF2l3/p7skRJwch57Ew+/ju9uHUtzrNy1C0PG/gdNZFJXz\n\tmHF3nR3eQOPk0XC3jYwtD94fnP1LIC5ij066lI2ZTSVE24rRIg71BkxmbnQfFBbhU0So\n\t7KuQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=bb0WXuTybfPE5wmSh4PlFqB0LfNZw9JYypanDyzqf/o=;\n\tb=qMkrCUF+L3dbQsueh9cy5jdCNe4XjY2cEPT2D0C8FoKmjIhxV950IJEba9b5EbvktW\n\tJ67Cm5A/Cum2QPS78Z9+553zzVqqm7o+yHVsWFaFt4LpRrPhW9765l15h00QkvOFTfV5\n\tcI0XB5UBYV9Kwd15lP4aFgBenwOvRzhrMFlEOUJR2loKrp7J/BzgrTjaKEGj+//YZBkd\n\t8jwuZhnnyD0bmSYskNIhB3YMnMu47bCmLXbrGOIM+jXF9+GFZtndd0mdYo8trtsPZn4v\n\tHSjZevEJVoEdeJHkhJYOIVKMbmxwPkggiVeiTN/BaLG4k2Yovf/j5fZ8WNMGK/MJ1SGe\n\tlrcA==", "X-Gm-Message-State": "APt69E3UNR+wmJRo05b+oXr4LO92MN1glxEZ/slBS8j9+gzNsStgdcIO\n\tR6khH89E+X4JO3r4voNyYU4PdCnucHZiPg==", "X-Google-Smtp-Source": "AAOMgpcfQggiy2r5WdQrpQgMZQ6AU03fAFXvcr0N0hxh1vazbm7ek5XhtrrWwVhOREnzAUjOiKBdhw==", "X-Received": "by 2002:a19:4e06:: with SMTP id\n\tc6-v6mr10384821lfb.30.1530280453631; \n\tFri, 29 Jun 2018 06:54:13 -0700 (PDT)", "From": "Rafal Kozik <rk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n\tmatua@amazon.com, igorch@amazon.com, thomas@monjalon.net,\n\tferruh.yigit@intel.com, Kozik <rk@semihalf.com>", "Date": "Fri, 29 Jun 2018 15:54:05 +0200", "Message-Id": "<1530280448-12920-2-git-send-email-rk@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530280448-12920-1-git-send-email-rk@semihalf.com>", "References": "<1530267873-7236-2-git-send-email-rk@semihalf.com>\n\t<1530280448-12920-1-git-send-email-rk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v5 1/4] igb_uio: add wc option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kozik <rk@semihalf.com>\n\nWrite combining (WC) increases NIC performance by making better\nutilization of PCI bus, but cannot be use by all PMD.\n\nTo get internal_addr memory need to be mapped. But as memory could not be\nmapped twice: with and without WC it should be skipped for WC. [1]\n\nTo do not spoil other drivers that potentially could use internal_addr,\nparameter wc_activate adds possibility to skip it for those PMDs,\nthat do not use it.\n\n[1] https://www.kernel.org/doc/ols/2008/ols2008v2-pages-135-144.pdf\n\tsection 5.3 and 5.4\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n kernel/linux/igb_uio/igb_uio.c | 20 +++++++++++++++++---\n 1 file changed, 17 insertions(+), 3 deletions(-)", "diff": "diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c\nindex b3233f1..3398eac 100644\n--- a/kernel/linux/igb_uio/igb_uio.c\n+++ b/kernel/linux/igb_uio/igb_uio.c\n@@ -30,6 +30,7 @@ struct rte_uio_pci_dev {\n \tint refcnt;\n };\n \n+static int wc_activate;\n static char *intr_mode;\n static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;\n /* sriov sysfs */\n@@ -375,9 +376,13 @@ igbuio_pci_setup_iomem(struct pci_dev *dev, struct uio_info *info,\n \tlen = pci_resource_len(dev, pci_bar);\n \tif (addr == 0 || len == 0)\n \t\treturn -1;\n-\tinternal_addr = ioremap(addr, len);\n-\tif (internal_addr == NULL)\n-\t\treturn -1;\n+\tif (wc_activate == 0) {\n+\t\tinternal_addr = ioremap(addr, len);\n+\t\tif (internal_addr == NULL)\n+\t\t\treturn -1;\n+\t} else {\n+\t\tinternal_addr = NULL;\n+\t}\n \tinfo->mem[n].name = name;\n \tinfo->mem[n].addr = addr;\n \tinfo->mem[n].internal_addr = internal_addr;\n@@ -626,6 +631,9 @@ igbuio_pci_init_module(void)\n \t\treturn -EINVAL;\n \t}\n \n+\tif (wc_activate != 0)\n+\t\tpr_info(\"wc_activate is set\\n\");\n+\n \tret = igbuio_config_intr_mode(intr_mode);\n \tif (ret < 0)\n \t\treturn ret;\n@@ -650,6 +658,12 @@ MODULE_PARM_DESC(intr_mode,\n \" \" RTE_INTR_MODE_LEGACY_NAME \" Use Legacy interrupt\\n\"\n \"\\n\");\n \n+module_param(wc_activate, int, 0);\n+MODULE_PARM_DESC(wc_activate,\n+\"Activate support for write combining (WC) (default=0)\\n\"\n+\" 0 - disable\\n\"\n+\" other - enable\\n\");\n+\n MODULE_DESCRIPTION(\"UIO driver for Intel IGB PCI cards\");\n MODULE_LICENSE(\"GPL\");\n MODULE_AUTHOR(\"Intel Corporation\");\n", "prefixes": [ "v5", "1/4" ] }