Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41959/?format=api
{ "id": 41959, "url": "http://patches.dpdk.org/api/patches/41959/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530274637-10156-2-git-send-email-rk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530274637-10156-2-git-send-email-rk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530274637-10156-2-git-send-email-rk@semihalf.com", "date": "2018-06-29T12:17:14", "name": "[v4,1/4] igb_uio: add wc option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "db8f0d4857a2e320e77d767ab34cbf945f31706d", "submitter": { "id": 951, "url": "http://patches.dpdk.org/api/people/951/?format=api", "name": "Rafal Kozik", "email": "rk@semihalf.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530274637-10156-2-git-send-email-rk@semihalf.com/mbox/", "series": [ { "id": 317, "url": "http://patches.dpdk.org/api/series/317/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=317", "date": "2018-06-29T12:17:13", "name": "Support for write combining.", "version": 4, "mbox": "http://patches.dpdk.org/series/317/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41959/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41959/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 378311B597;\n\tFri, 29 Jun 2018 14:17:26 +0200 (CEST)", "from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 484E71B592\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 14:17:24 +0200 (CEST)", "by mail-lf0-f66.google.com with SMTP id g21-v6so6651710lfb.4\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 05:17:24 -0700 (PDT)", "from rafalkozik.semihalf.local\n\t(31-172-191-173.noc.fibertech.net.pl. [31.172.191.173])\n\tby smtp.gmail.com with ESMTPSA id\n\tr21-v6sm1527333lja.92.2018.06.29.05.17.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 29 Jun 2018 05:17:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=wWNxw0r4wrgI9Kp+M4NlaTVhfNuYhqp7kmjUW/FoeEc=;\n\tb=RtaoyvrJiSyNjd/6pnpBle55XJLJFGeaREg8SmPw5cKR4Loy9MmEmdUQByKOEWRtMk\n\twRHIgpY16dQ4evukNDaTlIeQ1VH4CetzykY43JXOYlY/MwlyygHpXUQKnNXPvOvvvGQF\n\t+lh8BnwR1M6g+P0p/pIb0sPc6y/Cgv1tqdVC6vv9cKV9TvhZPfTBYuvKD5lqxVsVj2ze\n\t9pAYMCTJF8Zi7lHW4ijoHaiAHQFQ8MqKNBfczQ0gXdmCZeExrol/CjYSyJmYfi71E08G\n\tFuhTfLOQvmS7qHIt3fZ7MR+u9xYRw6Iww41ftg1Bv7IotBqk+YItFzYJAg3WS9gbCUKq\n\tWCGQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=wWNxw0r4wrgI9Kp+M4NlaTVhfNuYhqp7kmjUW/FoeEc=;\n\tb=NJdOkJh9MHTrwdHvykHragbBfijnyHGseI1lCNp/0LLmo7MXXLqze338pCyLzjxYk9\n\tQ7JzthAHD1+5hM7zQILQTEPy2wqMfmDPEOalc7dqU94VOlANjU8u24468QdsWzc0Fpny\n\tujkimLdOLREWJsSjzwqmrRpFLi6KSxIM8zjECNPvLC/+QeeqMB/xNUc2XZ0+FTMoi/Xm\n\t4rIGvH5YS/DBq1TYf9hI1TmBqSi8BMh47TY22imudoqlODNTG76edmYBtN1auqnGv7Zj\n\tIZ2KVMDInpF/LOumlR0W4DuMwSSZ+vXLkE9KNlDcsBbgjlAc8SQglKZbs8avE+dIm/ly\n\tnCGw==", "X-Gm-Message-State": "APt69E3A/NsuhTpGNI3pArbeNpvZIMBzghdorRRQE16ZAzrujGaiL5KT\n\tR9E6mw3OujdYW7QXfXe8ZASQyP+c8zCmRg==", "X-Google-Smtp-Source": "AAOMgpcbpqnCPOlK19b25dCvkEO/ebwWJJh99NWlWAIC11UxuyZCI2YtfrVMPlE/5A1ACmxhM01nyw==", "X-Received": "by 2002:a19:1003:: with SMTP id\n\tf3-v6mr10103100lfi.116.1530274643647; \n\tFri, 29 Jun 2018 05:17:23 -0700 (PDT)", "From": "Rafal Kozik <rk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n\tmatua@amazon.com, igorch@amazon.com, thomas@monjalon.net,\n\tferruh.yigit@intel.com, Kozik <rk@semihalf.com>", "Date": "Fri, 29 Jun 2018 14:17:14 +0200", "Message-Id": "<1530274637-10156-2-git-send-email-rk@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530274637-10156-1-git-send-email-rk@semihalf.com>", "References": "<1530267873-7236-2-git-send-email-rk@semihalf.com>\n\t<1530274637-10156-1-git-send-email-rk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v4 1/4] igb_uio: add wc option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kozik <rk@semihalf.com>\n\nWrite combining (WC) increases NIC performance by making better\nutilization of PCI bus, but cannot be use by all PMD.\n\nTo get internal_addr memory need to be mapped. But as memory could not be\nmapped twice: with and without WC it should be skipped for WC. [1]\n\nTo do not spoil other drivers that potentially could use internal_addr,\nparameter wc_activate adds possibility to skip it for those PMDs,\nthat do not use it.\n\n[1] https://www.kernel.org/doc/ols/2008/ols2008v2-pages-135-144.pdf\n\tsection 5.3 and 5.4\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n kernel/linux/igb_uio/igb_uio.c | 18 +++++++++++++++---\n 1 file changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c\nindex b3233f1..e16e760 100644\n--- a/kernel/linux/igb_uio/igb_uio.c\n+++ b/kernel/linux/igb_uio/igb_uio.c\n@@ -30,6 +30,7 @@ struct rte_uio_pci_dev {\n \tint refcnt;\n };\n \n+static int wc_activate;\n static char *intr_mode;\n static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;\n /* sriov sysfs */\n@@ -375,9 +376,14 @@ igbuio_pci_setup_iomem(struct pci_dev *dev, struct uio_info *info,\n \tlen = pci_resource_len(dev, pci_bar);\n \tif (addr == 0 || len == 0)\n \t\treturn -1;\n-\tinternal_addr = ioremap(addr, len);\n-\tif (internal_addr == NULL)\n-\t\treturn -1;\n+\tif (wc_activate == 0) {\n+\t\tinternal_addr = ioremap(addr, len);\n+\t\tif (internal_addr == NULL)\n+\t\t\treturn -1;\n+\t} else {\n+\t\tinternal_addr = NULL;\n+\t\tpr_info(\"wc_activate is set\\n\");\n+\t}\n \tinfo->mem[n].name = name;\n \tinfo->mem[n].addr = addr;\n \tinfo->mem[n].internal_addr = internal_addr;\n@@ -650,6 +656,12 @@ MODULE_PARM_DESC(intr_mode,\n \" \" RTE_INTR_MODE_LEGACY_NAME \" Use Legacy interrupt\\n\"\n \"\\n\");\n \n+module_param(wc_activate, int, 0);\n+MODULE_PARM_DESC(wc_activate,\n+\"Activate support for write combining (WC) (default=0)\\n\"\n+\" 0 - disable\\n\"\n+\" other - enable\\n\");\n+\n MODULE_DESCRIPTION(\"UIO driver for Intel IGB PCI cards\");\n MODULE_LICENSE(\"GPL\");\n MODULE_AUTHOR(\"Intel Corporation\");\n", "prefixes": [ "v4", "1/4" ] }