Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41936/?format=api
{ "id": 41936, "url": "http://patches.dpdk.org/api/patches/41936/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530267873-7236-4-git-send-email-rk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530267873-7236-4-git-send-email-rk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530267873-7236-4-git-send-email-rk@semihalf.com", "date": "2018-06-29T10:24:32", "name": "[v3,3/4] eal: enable WC during resources mapping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1583eeb0fe62b4693f6767e2929faa4177bceac7", "submitter": { "id": 951, "url": "http://patches.dpdk.org/api/people/951/?format=api", "name": "Rafal Kozik", "email": "rk@semihalf.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530267873-7236-4-git-send-email-rk@semihalf.com/mbox/", "series": [ { "id": 313, "url": "http://patches.dpdk.org/api/series/313/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=313", "date": "2018-06-29T10:24:29", "name": "support for write combining", "version": 3, "mbox": "http://patches.dpdk.org/series/313/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41936/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41936/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 10EB81B4E9;\n\tFri, 29 Jun 2018 12:24:47 +0200 (CEST)", "from mail-lf0-f68.google.com (mail-lf0-f68.google.com\n\t[209.85.215.68]) by dpdk.org (Postfix) with ESMTP id E39C51B4DE\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 12:24:43 +0200 (CEST)", "by mail-lf0-f68.google.com with SMTP id n96-v6so6437946lfi.1\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 03:24:43 -0700 (PDT)", "from rafalkozik.semihalf.local\n\t(31-172-191-173.noc.fibertech.net.pl. [31.172.191.173])\n\tby smtp.gmail.com with ESMTPSA id\n\td79-v6sm745514ljd.50.2018.06.29.03.24.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 29 Jun 2018 03:24:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=lKm5iTnEQ6Sk/dL/jb/9lbPgyy2fSSjwpCqErLvTbqQ=;\n\tb=GIz3NuDLma9dfgJY0byVA81lygCG3Mmxl+ccCnbI+GSgBH1DjiWcK5Vz4Xm8+Fe17y\n\tPw9AyVsARtTKZIA8rn0uMB/v2qn/uQ9p/0JbOth8iVOL2cAmrrCFhpddQg5P/gB2w/UQ\n\t8cPQgKwtFOhmC8LdUwy7XyqhnlbkOLbwz58jC7yZk1qzv5zXOovboU5S0hFyd1Tc+WSv\n\tbtNsWrtLBP0Kb0Leg8s1QgF/mJe72cv9+JOfyt05G+swS7OJEwPImLMcg9JBoGPr/VQ/\n\tuuY7IqfdmRndy3mZ6nkiQj0tzGlLD5qseNGvOPqDIDlTIkomEPvdJ/iR/Av0UCodTsyY\n\tZxMA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=lKm5iTnEQ6Sk/dL/jb/9lbPgyy2fSSjwpCqErLvTbqQ=;\n\tb=JSSxU0xNX4+7uwE018k8hRcgXuRVU2ET76qyaCvi/7fFJ0VYroj8rTUTAData4FAOu\n\t0OoE2dhVYkXL7xBYuI9RbfGVLyWaMz2FmspDJ2WQsKGvjeuU8dxl6nhtG6FR48P4hoqz\n\tQSBNrsJr6jJGZUgnnMKG+3x8LFvUW1SKC/C3wkwnO6RuHTyvM0X5BMsz6igLDlusvmAs\n\tnwuFrG2LIJDCNEP049mtMQbAPi8eI8r0ubfyOnYMpxZ1QLkN0/XlAEIProM8MS7+xFMW\n\t51+Y6bpO7nltIAOXK4MxI35a4RLTv0h92iKN7uerkif6lU5R4eSO8Oz0G8w6cSeXvkdQ\n\tRCnA==", "X-Gm-Message-State": "APt69E0b0ibH60FixmwBp1feuMkuBMo8++dUjKyMQcHKD7BxwyLeot6m\n\tL5FhePDcHSP1ys5qwysB6rbhFR03hN8fvQ==", "X-Google-Smtp-Source": "AAOMgpcd0qLtEuPn8rNol5RoQ2/gl/KqbiinPVk3V2+CdG8OacR5PAblRo537VL1aspvb/JYediSrQ==", "X-Received": "by 2002:a19:c64c:: with SMTP id\n\tw73-v6mr8952178lff.2.1530267883151; \n\tFri, 29 Jun 2018 03:24:43 -0700 (PDT)", "From": "Rafal Kozik <rk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n\tmatua@amazon.com, igorch@amazon.com, thomas@monjalon.net,\n\tferruh.yigit@intel.com, Rafal Kozik <rk@semihalf.com>", "Date": "Fri, 29 Jun 2018 12:24:32 +0200", "Message-Id": "<1530267873-7236-4-git-send-email-rk@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530267873-7236-1-git-send-email-rk@semihalf.com>", "References": "<1530191753-18689-2-git-send-email-rk@semihalf.com>\n\t<1530267873-7236-1-git-send-email-rk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v3 3/4] eal: enable WC during resources mapping", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Write combining (WC) increases NIC performance by making better\nutilization of PCI bus, but cannot be used by all PMDs.\n\nIt will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in\ndrivers flags. For proper work also igb_uio driver must be loaded with\nwc_activate set to 1.\n\nWhen mapping PCI resources, firstly try to us WC.\nIf it is not supported it will fallback to normal mode.\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/bus/pci/linux/pci_uio.c | 44 ++++++++++++++++++++++++++++++-----------\n drivers/bus/pci/rte_bus_pci.h | 2 ++\n 2 files changed, 34 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c\nindex d423e4b..fb02f0a 100644\n--- a/drivers/bus/pci/linux/pci_uio.c\n+++ b/drivers/bus/pci/linux/pci_uio.c\n@@ -282,22 +282,19 @@ int\n pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx,\n \t\tstruct mapped_pci_resource *uio_res, int map_idx)\n {\n-\tint fd;\n+\tint fd = -1;\n \tchar devname[PATH_MAX];\n \tvoid *mapaddr;\n \tstruct rte_pci_addr *loc;\n \tstruct pci_map *maps;\n+\tint wc_activate = 0;\n+\n+\tif (dev->driver != NULL)\n+\t\twc_activate = dev->driver->drv_flags & RTE_PCI_DRV_WC_ACTIVATE;\n \n \tloc = &dev->addr;\n \tmaps = uio_res->maps;\n \n-\t/* update devname for mmap */\n-\tsnprintf(devname, sizeof(devname),\n-\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d\",\n-\t\t\trte_pci_get_sysfs_path(),\n-\t\t\tloc->domain, loc->bus, loc->devid,\n-\t\t\tloc->function, res_idx);\n-\n \t/* allocate memory to keep path */\n \tmaps[map_idx].path = rte_malloc(NULL, strlen(devname) + 1, 0);\n \tif (maps[map_idx].path == NULL) {\n@@ -309,11 +306,34 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx,\n \t/*\n \t * open resource file, to mmap it\n \t */\n-\tfd = open(devname, O_RDWR);\n-\tif (fd < 0) {\n-\t\tRTE_LOG(ERR, EAL, \"Cannot open %s: %s\\n\",\n+\tif (wc_activate) {\n+\t\t/* update devname for mmap */\n+\t\tsnprintf(devname, sizeof(devname),\n+\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d_wc\",\n+\t\t\trte_pci_get_sysfs_path(),\n+\t\t\tloc->domain, loc->bus, loc->devid,\n+\t\t\tloc->function, res_idx);\n+\n+\t\tfd = open(devname, O_RDWR);\n+\t\tif (fd >= 0)\n+\t\t\tRTE_LOG(INFO, EAL, \"%s mapped\\n\", devname);\n+\t}\n+\n+\tif (!wc_activate || fd < 0) {\n+\t\tsnprintf(devname, sizeof(devname),\n+\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d\",\n+\t\t\trte_pci_get_sysfs_path(),\n+\t\t\tloc->domain, loc->bus, loc->devid,\n+\t\t\tloc->function, res_idx);\n+\n+\t\t/* then try to map resource file */\n+\t\tfd = open(devname, O_RDWR);\n+\t\tif (fd < 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"Cannot open %s: %s\\n\",\n \t\t\t\tdevname, strerror(errno));\n-\t\tgoto error;\n+\t\t\tgoto error;\n+\t\t}\n+\t\tRTE_LOG(INFO, EAL, \"%s mapped\\n\", devname);\n \t}\n \n \t/* try mapping somewhere close to the end of hugepages */\ndiff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h\nindex 458e6d0..828acc5 100644\n--- a/drivers/bus/pci/rte_bus_pci.h\n+++ b/drivers/bus/pci/rte_bus_pci.h\n@@ -135,6 +135,8 @@ struct rte_pci_bus {\n \n /** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */\n #define RTE_PCI_DRV_NEED_MAPPING 0x0001\n+/** Device needs PCI BAR mapping with enabled write combining (wc) */\n+#define RTE_PCI_DRV_WC_ACTIVATE 0x0002\n /** Device driver supports link state interrupt */\n #define RTE_PCI_DRV_INTR_LSC\t0x0008\n /** Device driver supports device removal interrupt */\n", "prefixes": [ "v3", "3/4" ] }