Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41917/?format=api
{ "id": 41917, "url": "http://patches.dpdk.org/api/patches/41917/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180629092944.15576-5-johndale@cisco.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180629092944.15576-5-johndale@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180629092944.15576-5-johndale@cisco.com", "date": "2018-06-29T09:29:33", "name": "[v2,04/15] net/enic: initialize RQ fetch index before enabling RQ", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9698980ea207d86a5d3d15475cde3bf3b186dfb4", "submitter": { "id": 359, "url": "http://patches.dpdk.org/api/people/359/?format=api", "name": "John Daley (johndale)", "email": "johndale@cisco.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180629092944.15576-5-johndale@cisco.com/mbox/", "series": [ { "id": 308, "url": "http://patches.dpdk.org/api/series/308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=308", "date": "2018-06-29T09:29:29", "name": "enic PMD fixes and performance improvements", "version": 2, "mbox": "http://patches.dpdk.org/series/308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41917/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41917/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 202E21B454;\n\tFri, 29 Jun 2018 11:31:29 +0200 (CEST)", "from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73])\n\tby dpdk.org (Postfix) with ESMTP id 21A501B435\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 11:31:26 +0200 (CEST)", "from rcdn-core-4.cisco.com ([173.37.93.155])\n\tby rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jun 2018 09:31:26 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id w5T9VQk0012873;\n\tFri, 29 Jun 2018 09:31:26 GMT", "by cisco.com (Postfix, from userid 392789)\n\tid 2625E20F2001; Fri, 29 Jun 2018 02:31:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=1283; q=dns/txt; s=iport;\n\tt=1530264687; x=1531474287;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=hElbvEo+lbK1WLzGfEm3Pal6WbsdopkRyVGnhRTAELI=;\n\tb=LfN/9U96jyZ3R1oL8Q3dMPqhlLIhPWOpTIBghg2ZXfI9HTD0zkn5HZqM\n\t/k2oOfeXNGiCubv3mW94mCflMSf/D7tAi1/ct0Kit37NiTfVH0wtVEz/Y\n\thuLCIdXDQFoKyE4v0HR4NvZWQa9/BL0/QOtM6vZwIsuOs2dZuBIL/3iMn E=;", "X-IronPort-AV": "E=Sophos;i=\"5.51,285,1526342400\"; d=\"scan'208\";a=\"420189199\"", "From": "John Daley <johndale@cisco.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>", "Date": "Fri, 29 Jun 2018 02:29:33 -0700", "Message-Id": "<20180629092944.15576-5-johndale@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20180629092944.15576-1-johndale@cisco.com>", "References": "<20180628031940.17397-1-johndale@cisco.com>\n\t<20180629092944.15576-1-johndale@cisco.com>", "Subject": "[dpdk-dev] [PATCH v2 04/15] net/enic: initialize RQ fetch index\n\tbefore enabling RQ", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hyong Youb Kim <hyonkim@cisco.com>\n\nThe fetch index must be initialized only when RQ is\ndisabled. Otherwise, it may lead to stale entries in IG descriptor\ncache on the VIC.\n\nFixes: a74629cfa3a1 (\"net/enic: enable RQ first and then post Rx buffers\")\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\nReviewed-by: John Daley <johndale@cisco.com>\n---\n drivers/net/enic/enic_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex aba2ff5a7..863d2463c 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -320,6 +320,8 @@ enic_alloc_rx_queue_mbufs(struct enic *enic, struct vnic_rq *rq)\n \t * enic_start_rq().\n \t */\n \trq->need_initial_post = true;\n+\t/* Initialize fetch index while RQ is disabled */\n+\tiowrite32(0, &rq->ctrl->fetch_index);\n \treturn 0;\n }\n \n@@ -345,7 +347,6 @@ enic_initial_post_rx(struct enic *enic, struct vnic_rq *rq)\n \tdev_debug(enic, \"port=%u, qidx=%u, Write %u posted idx, %u sw held\\n\",\n \t\tenic->port_id, rq->index, rq->posted_index, rq->rx_nb_hold);\n \tiowrite32(rq->posted_index, &rq->ctrl->posted_index);\n-\tiowrite32(0, &rq->ctrl->fetch_index);\n \trte_rmb();\n \trq->need_initial_post = false;\n }\n", "prefixes": [ "v2", "04/15" ] }