Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41886/?format=api
{ "id": 41886, "url": "http://patches.dpdk.org/api/patches/41886/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-24-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180628201549.3507-24-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180628201549.3507-24-ajit.khaparde@broadcom.com", "date": "2018-06-28T20:15:49", "name": "[v2,23/23] net/bnxt: use correct flags during VLAN configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b7602204a4b3033cc50cbde3046abb5061191988", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-24-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 300, "url": "http://patches.dpdk.org/api/series/300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=300", "date": "2018-06-28T20:15:29", "name": "bnxt patchset", "version": 2, "mbox": "http://patches.dpdk.org/series/300/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41886/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41886/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 91B931B5CA;\n\tThu, 28 Jun 2018 22:16:55 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id ECE2A1B4FE;\n\tThu, 28 Jun 2018 22:16:00 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 3B07A30C03B;\n\tThu, 28 Jun 2018 13:16:00 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id A3728AC079C;\n\tThu, 28 Jun 2018 13:15:59 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 3B07A30C03B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1530216960;\n\tbh=papcztf6i+YhZhAyiphuvLgptNHVUyyk8sU7zoj6aMY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A7ARrdFiPRugmjz9dhg8yPVz8OREJmJSGrWDHCbUbaTahFEQU08sZauCxojQ4+5ZJ\n\tWBAWNJVUOMEYnbxgt8VPPuBlJdnI43aaUdUkWkhfo8JqMw36eGGhvfImqDv0AzON+k\n\tWUmwMlB8GAIAbaUaH3IF+n3mSVJmFz+JellSqQjg=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Somnath Kotur <somnath.kotur@broadcom.com>,\n\tstable@dpdk.org", "Date": "Thu, 28 Jun 2018 13:15:49 -0700", "Message-Id": "<20180628201549.3507-24-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.2 (Apple Git-101.1)", "In-Reply-To": "<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "References": "<f02289d7-4111-ab00-9ce9-00dd5c8b3c18@intel.com>\n\t<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 23/23] net/bnxt: use correct flags during VLAN\n\tconfiguration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nSetting of VLAN filter cmd was being done with incorrect flag value.\nWe need to use inner vlan fields instead of outer vlan.\n\nFixes: 7fe5668d2ea3 (\"net/bnxt: support VLAN filter and strip\")\nCc: stable@dpdk.org\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----\n drivers/net/bnxt/bnxt_hwrm.c | 4 ++--\n 2 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex a1f835ed9..418d3bede 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1327,9 +1327,9 @@ static int bnxt_add_vlan_filter(struct bnxt *bp, uint16_t vlan_id)\n \tstruct bnxt_vnic_info *vnic;\n \tunsigned int i;\n \tint rc = 0;\n-\tuint32_t en = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_OVLAN |\n-\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_OVLAN_MASK;\n-\tuint32_t chk = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_OVLAN;\n+\tuint32_t en = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_IVLAN |\n+\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_IVLAN_MASK;\n+\tuint32_t chk = HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_IVLAN;\n \n \t/* Cycle through all VNICs */\n \tfor (i = 0; i < bp->nr_vnics; i++) {\n@@ -1376,8 +1376,8 @@ static int bnxt_add_vlan_filter(struct bnxt *bp, uint16_t vlan_id)\n \t\t\t\tmemcpy(new_filter->l2_addr, filter->l2_addr,\n \t\t\t\t ETHER_ADDR_LEN);\n \t\t\t\t/* MAC + VLAN ID filter */\n-\t\t\t\tnew_filter->l2_ovlan = vlan_id;\n-\t\t\t\tnew_filter->l2_ovlan_mask = 0xF000;\n+\t\t\t\tnew_filter->l2_ivlan = vlan_id;\n+\t\t\t\tnew_filter->l2_ivlan_mask = 0xF000;\n \t\t\t\tnew_filter->enables |= en;\n \t\t\t\trc = bnxt_hwrm_set_l2_filter(bp,\n \t\t\t\t\t\t\t vnic->fw_vnic_id,\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 37aefbdc9..02562f78c 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -388,13 +388,13 @@ int bnxt_hwrm_set_l2_filter(struct bnxt *bp,\n \t\treq.l2_ovlan = filter->l2_ovlan;\n \tif (enables &\n \t HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_IVLAN)\n-\t\treq.l2_ovlan = filter->l2_ivlan;\n+\t\treq.l2_ivlan = filter->l2_ivlan;\n \tif (enables &\n \t HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_OVLAN_MASK)\n \t\treq.l2_ovlan_mask = filter->l2_ovlan_mask;\n \tif (enables &\n \t HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_IVLAN_MASK)\n-\t\treq.l2_ovlan_mask = filter->l2_ivlan_mask;\n+\t\treq.l2_ivlan_mask = filter->l2_ivlan_mask;\n \tif (enables & HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_SRC_ID)\n \t\treq.src_id = rte_cpu_to_le_32(filter->src_id);\n \tif (enables & HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_SRC_TYPE)\n", "prefixes": [ "v2", "23/23" ] }