Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41879/?format=api
http://patches.dpdk.org/api/patches/41879/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-18-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180628201549.3507-18-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180628201549.3507-18-ajit.khaparde@broadcom.com", "date": "2018-06-28T20:15:43", "name": "[v2,17/23] net/bnxt: fix set MTU", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ec79078ff66a325e7f941c17553a3e5d578afd0d", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-18-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 300, "url": "http://patches.dpdk.org/api/series/300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=300", "date": "2018-06-28T20:15:29", "name": "bnxt patchset", "version": 2, "mbox": "http://patches.dpdk.org/series/300/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41879/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41879/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6C2D41B599;\n\tThu, 28 Jun 2018 22:16:39 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 64E341B51C;\n\tThu, 28 Jun 2018 22:15:59 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 3E7E730C01A;\n\tThu, 28 Jun 2018 13:15:58 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id B1550AC079C;\n\tThu, 28 Jun 2018 13:15:57 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 3E7E730C01A", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1530216958;\n\tbh=Fhf3J/CGT1lCwXxVcSKmY8MybB2Fdr4Zh0knxoUysMA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YDefKawkCDY2KfZ+xNLWVAO9VvFJ/v12UoMpm40SN4OWz87AVQbnkMeCVE+PC87fD\n\tV6TOs/Try87e4FYtPnarYvLI1PmALFBBW4eT7YIPerZeVfhoz4UiGAmTe7Mylmq5gZ\n\t+aaswXJcw7AxF3O66EKaNm/faCyXq46rl3JJs93M=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tstable@dpdk.org", "Date": "Thu, 28 Jun 2018 13:15:43 -0700", "Message-Id": "<20180628201549.3507-18-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.2 (Apple Git-101.1)", "In-Reply-To": "<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "References": "<f02289d7-4111-ab00-9ce9-00dd5c8b3c18@intel.com>\n\t<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 17/23] net/bnxt: fix set MTU", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no need to update bnxt_hwrm_vnic_plcmode_cfg if new MTU is\nnot greater than the max data the mbuf can accommodate.\n\nFixes: daef48efe5e5 (\"net/bnxt: support set MTU\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n--\nv1->v2: update commit log\n---\n drivers/net/bnxt/bnxt_ethdev.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex ab3f5c8e7..fe95e01ca 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1581,6 +1581,7 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n \n \tfor (i = 0; i < bp->nr_vnics; i++) {\n \t\tstruct bnxt_vnic_info *vnic = &bp->vnic_info[i];\n+\t\tuint16_t size = 0;\n \n \t\tvnic->mru = bp->eth_dev->data->mtu + ETHER_HDR_LEN +\n \t\t\t\t\tETHER_CRC_LEN + VLAN_TAG_SIZE * 2;\n@@ -1588,9 +1589,14 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n \t\tif (rc)\n \t\t\tbreak;\n \n-\t\trc = bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);\n-\t\tif (rc)\n-\t\t\treturn rc;\n+\t\tsize = rte_pktmbuf_data_room_size(bp->rx_queues[0]->mb_pool);\n+\t\tsize -= RTE_PKTMBUF_HEADROOM;\n+\n+\t\tif (size < new_mtu) {\n+\t\t\trc = bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);\n+\t\t\tif (rc)\n+\t\t\t\treturn rc;\n+\t\t}\n \t}\n \n \treturn rc;\n", "prefixes": [ "v2", "17/23" ] }{ "id": 41879, "url": "