Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41872/?format=api
{ "id": 41872, "url": "http://patches.dpdk.org/api/patches/41872/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-8-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180628201549.3507-8-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180628201549.3507-8-ajit.khaparde@broadcom.com", "date": "2018-06-28T20:15:33", "name": "[v2,07/23] net/bnxt: fix HW Tx checksum offload check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "43cb81623bd801e32317fb8323360c8d97bdf21d", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-8-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 300, "url": "http://patches.dpdk.org/api/series/300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=300", "date": "2018-06-28T20:15:29", "name": "bnxt patchset", "version": 2, "mbox": "http://patches.dpdk.org/series/300/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41872/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41872/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C37961B55A;\n\tThu, 28 Jun 2018 22:16:23 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 95F7B1B4FF;\n\tThu, 28 Jun 2018 22:15:58 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 62D4030C026;\n\tThu, 28 Jun 2018 13:15:54 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 301A1AC078F;\n\tThu, 28 Jun 2018 13:15:54 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 62D4030C026", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1530216954;\n\tbh=CcMZWr6Zs9EQLO1m7AspRpu4b3CdmF7DBZvc7SlQhjg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QWBn/VNpknqPXiNXSIE9F5i88zSMIiBpD/QpnikA4QS+Ve5aNVBYK6glWKirLC8+Z\n\tw5Am1NVFu2d7h/OYCdPjF9X4ppSUh1pNuAiGE2KCV+F1nApPvkwPK9cwfYzN4f3gvY\n\tgmAl8rPjJaqpj6xKtAxiMcz60zkV7r0EGza4onmo=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stable@dpdk.org,\n\tXiaoxin Peng <xiaoxin.peng@broadcom.com>", "Date": "Thu, 28 Jun 2018 13:15:33 -0700", "Message-Id": "<20180628201549.3507-8-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.2 (Apple Git-101.1)", "In-Reply-To": "<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "References": "<f02289d7-4111-ab00-9ce9-00dd5c8b3c18@intel.com>\n\t<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 07/23] net/bnxt: fix HW Tx checksum offload\n\tcheck", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add more checks for checksum calculation offload.\nAlso check for tunnel frames and select the proper\nbuffer descriptor size.\n\nFixes: 6eb3cc2294fd (\"net/bnxt: add initial Tx code\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiaoxin Peng <xiaoxin.peng@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Jason He <jason.he@broadcom.com>\nReviewed-by: Qingmin Liu <qingmin.liu@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txr.c | 51 ++++++++++++++++++++++++++++++++++++++++++---\n drivers/net/bnxt/bnxt_txr.h | 10 +++++++++\n 2 files changed, 58 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 0fdf0fd08..68645b2f7 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -135,7 +135,9 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \n \tif (tx_pkt->ol_flags & (PKT_TX_TCP_SEG | PKT_TX_TCP_CKSUM |\n \t\t\t\tPKT_TX_UDP_CKSUM | PKT_TX_IP_CKSUM |\n-\t\t\t\tPKT_TX_VLAN_PKT | PKT_TX_OUTER_IP_CKSUM))\n+\t\t\t\tPKT_TX_VLAN_PKT | PKT_TX_OUTER_IP_CKSUM |\n+\t\t\t\tPKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN |\n+\t\t\t\tPKT_TX_TUNNEL_GENEVE))\n \t\tlong_bd = true;\n \n \ttx_buf = &txr->tx_buf_ring[txr->tx_prod];\n@@ -203,16 +205,46 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\t\t/* Outer IP, Inner IP, Inner TCP/UDP CSO */\n \t\t\ttxbd1->lflags |= TX_BD_FLG_TIP_IP_TCP_UDP_CHKSUM;\n \t\t\ttxbd1->mss = 0;\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_OIP_IIP_TCP_CKSUM) ==\n+\t\t\t PKT_TX_OIP_IIP_TCP_CKSUM) {\n+\t\t\t/* Outer IP, Inner IP, Inner TCP/UDP CSO */\n+\t\t\ttxbd1->lflags |= TX_BD_FLG_TIP_IP_TCP_UDP_CHKSUM;\n+\t\t\ttxbd1->mss = 0;\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_OIP_IIP_UDP_CKSUM) ==\n+\t\t\t PKT_TX_OIP_IIP_UDP_CKSUM) {\n+\t\t\t/* Outer IP, Inner IP, Inner TCP/UDP CSO */\n+\t\t\ttxbd1->lflags |= TX_BD_FLG_TIP_IP_TCP_UDP_CHKSUM;\n+\t\t\ttxbd1->mss = 0;\n \t\t} else if ((tx_pkt->ol_flags & PKT_TX_IIP_TCP_UDP_CKSUM) ==\n \t\t\t PKT_TX_IIP_TCP_UDP_CKSUM) {\n \t\t\t/* (Inner) IP, (Inner) TCP/UDP CSO */\n \t\t\ttxbd1->lflags |= TX_BD_FLG_IP_TCP_UDP_CHKSUM;\n \t\t\ttxbd1->mss = 0;\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_IIP_UDP_CKSUM) ==\n+\t\t\t PKT_TX_IIP_UDP_CKSUM) {\n+\t\t\t/* (Inner) IP, (Inner) TCP/UDP CSO */\n+\t\t\ttxbd1->lflags |= TX_BD_FLG_IP_TCP_UDP_CHKSUM;\n+\t\t\ttxbd1->mss = 0;\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_IIP_TCP_CKSUM) ==\n+\t\t\t PKT_TX_IIP_TCP_CKSUM) {\n+\t\t\t/* (Inner) IP, (Inner) TCP/UDP CSO */\n+\t\t\ttxbd1->lflags |= TX_BD_FLG_IP_TCP_UDP_CHKSUM;\n+\t\t\ttxbd1->mss = 0;\n \t\t} else if ((tx_pkt->ol_flags & PKT_TX_OIP_TCP_UDP_CKSUM) ==\n \t\t\t PKT_TX_OIP_TCP_UDP_CKSUM) {\n \t\t\t/* Outer IP, (Inner) TCP/UDP CSO */\n \t\t\ttxbd1->lflags |= TX_BD_FLG_TIP_TCP_UDP_CHKSUM;\n \t\t\ttxbd1->mss = 0;\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_OIP_UDP_CKSUM) ==\n+\t\t\t PKT_TX_OIP_UDP_CKSUM) {\n+\t\t\t/* Outer IP, (Inner) TCP/UDP CSO */\n+\t\t\ttxbd1->lflags |= TX_BD_FLG_TIP_TCP_UDP_CHKSUM;\n+\t\t\ttxbd1->mss = 0;\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_OIP_TCP_CKSUM) ==\n+\t\t\t PKT_TX_OIP_TCP_CKSUM) {\n+\t\t\t/* Outer IP, (Inner) TCP/UDP CSO */\n+\t\t\ttxbd1->lflags |= TX_BD_FLG_TIP_TCP_UDP_CHKSUM;\n+\t\t\ttxbd1->mss = 0;\n \t\t} else if ((tx_pkt->ol_flags & PKT_TX_OIP_IIP_CKSUM) ==\n \t\t\t PKT_TX_OIP_IIP_CKSUM) {\n \t\t\t/* Outer IP, Inner IP CSO */\n@@ -223,11 +255,23 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\t\t/* TCP/UDP CSO */\n \t\t\ttxbd1->lflags |= TX_BD_LONG_LFLAGS_TCP_UDP_CHKSUM;\n \t\t\ttxbd1->mss = 0;\n-\t\t} else if (tx_pkt->ol_flags & PKT_TX_IP_CKSUM) {\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_TCP_CKSUM) ==\n+\t\t\t PKT_TX_TCP_CKSUM) {\n+\t\t\t/* TCP/UDP CSO */\n+\t\t\ttxbd1->lflags |= TX_BD_LONG_LFLAGS_TCP_UDP_CHKSUM;\n+\t\t\ttxbd1->mss = 0;\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_UDP_CKSUM) ==\n+\t\t\t PKT_TX_UDP_CKSUM) {\n+\t\t\t/* TCP/UDP CSO */\n+\t\t\ttxbd1->lflags |= TX_BD_LONG_LFLAGS_TCP_UDP_CHKSUM;\n+\t\t\ttxbd1->mss = 0;\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_IP_CKSUM) ==\n+\t\t\t PKT_TX_IP_CKSUM) {\n \t\t\t/* IP CSO */\n \t\t\ttxbd1->lflags |= TX_BD_LONG_LFLAGS_IP_CHKSUM;\n \t\t\ttxbd1->mss = 0;\n-\t\t} else if (tx_pkt->ol_flags & PKT_TX_OUTER_IP_CKSUM) {\n+\t\t} else if ((tx_pkt->ol_flags & PKT_TX_OUTER_IP_CKSUM) ==\n+\t\t\t PKT_TX_OUTER_IP_CKSUM) {\n \t\t\t/* IP CSO */\n \t\t\ttxbd1->lflags |= TX_BD_LONG_LFLAGS_T_IP_CHKSUM;\n \t\t\ttxbd1->mss = 0;\n@@ -251,6 +295,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t}\n \n \ttxbd->flags_type |= TX_BD_LONG_FLAGS_PACKET_END;\n+\ttxbd1->lflags = rte_cpu_to_le_32(txbd1->lflags);\n \n \ttxr->tx_prod = RING_NEXT(txr->tx_ring_struct, txr->tx_prod);\n \ndiff --git a/drivers/net/bnxt/bnxt_txr.h b/drivers/net/bnxt/bnxt_txr.h\nindex 15c7e5a09..7f3c7cdb0 100644\n--- a/drivers/net/bnxt/bnxt_txr.h\n+++ b/drivers/net/bnxt/bnxt_txr.h\n@@ -45,10 +45,20 @@ int bnxt_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n \n #define PKT_TX_OIP_IIP_TCP_UDP_CKSUM\t(PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM | \\\n \t\t\t\t\tPKT_TX_IP_CKSUM | PKT_TX_OUTER_IP_CKSUM)\n+#define PKT_TX_OIP_IIP_UDP_CKSUM\t(PKT_TX_UDP_CKSUM | \\\n+\t\t\t\t\tPKT_TX_IP_CKSUM | PKT_TX_OUTER_IP_CKSUM)\n+#define PKT_TX_OIP_IIP_TCP_CKSUM\t(PKT_TX_TCP_CKSUM | \\\n+\t\t\t\t\tPKT_TX_IP_CKSUM | PKT_TX_OUTER_IP_CKSUM)\n #define PKT_TX_IIP_TCP_UDP_CKSUM\t(PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM | \\\n \t\t\t\t\tPKT_TX_IP_CKSUM)\n+#define PKT_TX_IIP_TCP_CKSUM\t\t(PKT_TX_TCP_CKSUM | PKT_TX_IP_CKSUM)\n+#define PKT_TX_IIP_UDP_CKSUM\t\t(PKT_TX_UDP_CKSUM | PKT_TX_IP_CKSUM)\n #define PKT_TX_OIP_TCP_UDP_CKSUM\t(PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM | \\\n \t\t\t\t\tPKT_TX_OUTER_IP_CKSUM)\n+#define PKT_TX_OIP_UDP_CKSUM\t\t(PKT_TX_UDP_CKSUM | \\\n+\t\t\t\t\tPKT_TX_OUTER_IP_CKSUM)\n+#define PKT_TX_OIP_TCP_CKSUM\t\t(PKT_TX_TCP_CKSUM | \\\n+\t\t\t\t\tPKT_TX_OUTER_IP_CKSUM)\n #define PKT_TX_OIP_IIP_CKSUM\t\t(PKT_TX_IP_CKSUM |\t\\\n \t\t\t\t\t PKT_TX_OUTER_IP_CKSUM)\n #define PKT_TX_TCP_UDP_CKSUM\t\t(PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM)\n", "prefixes": [ "v2", "07/23" ] }