get:
Show a patch.

patch:
Update a patch.

put:
Update a patch.

GET /api/patches/41865/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41865,
    "url": "http://patches.dpdk.org/api/patches/41865/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-3-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180628201549.3507-3-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180628201549.3507-3-ajit.khaparde@broadcom.com",
    "date": "2018-06-28T20:15:28",
    "name": "[v2,02/23] net/bnxt: add Tx batching support",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "e02ef60c0ecb809615a0229a73e9489937225ab1",
    "submitter": {
        "id": 501,
        "url": "http://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-3-ajit.khaparde@broadcom.com/mbox/",
    "series": [
        {
            "id": 300,
            "url": "http://patches.dpdk.org/api/series/300/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=300",
            "date": "2018-06-28T20:15:29",
            "name": "bnxt patchset",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/300/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/41865/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/41865/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 10B281B51E;\n\tThu, 28 Jun 2018 22:16:07 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 55AB81B4F3\n\tfor <dev@dpdk.org>; Thu, 28 Jun 2018 22:15:57 +0200 (CEST)",
            "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 4385B30C01E;\n\tThu, 28 Jun 2018 13:15:53 -0700 (PDT)",
            "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id BECBAAC079C;\n\tThu, 28 Jun 2018 13:15:52 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 4385B30C01E",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1530216953;\n\tbh=26KaAge6dYxc4oDhoMQV5VnFLd/+3SZPHfL/UStpQQQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lgNdLjlt6X932lG4DuVqSxku9GDDD+oSl7XBM9eidbzkfMHrCNL3gEDp8ouo/D8pn\n\tGvKbpxL1GTeQDkrdbJkHJGIQz9kKaVW/y+fJWE+LAy0IPnE0gPeary9x/AX6gwwTv+\n\tuxiLB3PdLKqxlE2HLfQ+7+noSrSKs22jQ/SCYgY0=",
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com",
        "Date": "Thu, 28 Jun 2018 13:15:28 -0700",
        "Message-Id": "<20180628201549.3507-3-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.15.2 (Apple Git-101.1)",
        "In-Reply-To": "<20180628201549.3507-1-ajit.khaparde@broadcom.com>",
        "References": "<f02289d7-4111-ab00-9ce9-00dd5c8b3c18@intel.com>\n\t<20180628201549.3507-1-ajit.khaparde@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH v2 02/23] net/bnxt: add Tx batching support",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Batch more than one Tx requests such that only one completion\nis generarted by the HW. We request a Tx completion for first\nand last Tx request in the batch.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.h | 12 ++++++\n drivers/net/bnxt/bnxt_txq.h |  1 +\n drivers/net/bnxt/bnxt_txr.c | 97 +++++++++++++++++++++++++++++----------------\n 3 files changed, 75 insertions(+), 35 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.h b/drivers/net/bnxt/bnxt_cpr.h\nindex 6c1e6d2b0..c7af56983 100644\n--- a/drivers/net/bnxt/bnxt_cpr.h\n+++ b/drivers/net/bnxt/bnxt_cpr.h\n@@ -22,12 +22,20 @@\n #define ADV_RAW_CMP(idx, n)\t((idx) + (n))\n #define NEXT_RAW_CMP(idx)\tADV_RAW_CMP(idx, 1)\n #define RING_CMP(ring, idx)\t((idx) & (ring)->ring_mask)\n+#define RING_CMPL(ring_mask, idx)\t((idx) & (ring_mask))\n #define NEXT_CMP(idx)\t\tRING_CMP(ADV_RAW_CMP(idx, 1))\n #define FLIP_VALID(cons, mask, val)\t((cons) >= (mask) ? !(val) : (val))\n \n #define DB_CP_REARM_FLAGS\t(DB_KEY_CP | DB_IDX_VALID)\n #define DB_CP_FLAGS\t\t(DB_KEY_CP | DB_IDX_VALID | DB_IRQ_DIS)\n \n+#define NEXT_CMPL(cpr, idx, v, inc)\tdo { \\\n+\t(idx) += (inc); \\\n+\tif (unlikely((idx) == (cpr)->cp_ring_struct->ring_size)) { \\\n+\t\t(v) = !(v); \\\n+\t\t(idx) = 0; \\\n+\t} \\\n+} while (0)\n #define B_CP_DB_REARM(cpr, raw_cons)\t\t\t\t\t\\\n \trte_write32((DB_CP_REARM_FLAGS |\t\t\t\t\\\n \t\t    RING_CMP(((cpr)->cp_ring_struct), raw_cons)),\t\\\n@@ -50,6 +58,10 @@\n \trte_write32((DB_CP_FLAGS |\t\t\t\t\t\\\n \t\t    RING_CMP(((cpr)->cp_ring_struct), raw_cons)),\t\\\n \t\t    ((cpr)->cp_doorbell))\n+#define B_CP_DB(cpr, raw_cons, ring_mask)\t\t\t\t\\\n+\trte_write32((DB_CP_FLAGS |\t\t\t\t\t\\\n+\t\t    RING_CMPL((ring_mask), raw_cons)),\t\\\n+\t\t    ((cpr)->cp_doorbell))\n \n struct bnxt_ring;\n struct bnxt_cp_ring_info {\ndiff --git a/drivers/net/bnxt/bnxt_txq.h b/drivers/net/bnxt/bnxt_txq.h\nindex 720ca90cf..f2c712a75 100644\n--- a/drivers/net/bnxt/bnxt_txq.h\n+++ b/drivers/net/bnxt/bnxt_txq.h\n@@ -24,6 +24,7 @@ struct bnxt_tx_queue {\n \tuint8_t\t\t\twthresh; /* Write-back threshold reg */\n \tuint32_t\t\tctx_curr; /* Hardware context states */\n \tuint8_t\t\t\ttx_deferred_start; /* not in global dev start */\n+\tuint8_t\t\t\tcmpl_next; /* Next BD to trigger a compl */\n \n \tstruct bnxt\t\t*bp;\n \tint\t\t\tindex;\ndiff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 470fddd56..0fdf0fd08 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -114,7 +114,9 @@ static inline uint32_t bnxt_tx_avail(struct bnxt_tx_ring_info *txr)\n }\n \n static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n-\t\t\t\tstruct bnxt_tx_queue *txq)\n+\t\t\t\tstruct bnxt_tx_queue *txq,\n+\t\t\t\tuint16_t *coal_pkts,\n+\t\t\t\tuint16_t *cmpl_next)\n {\n \tstruct bnxt_tx_ring_info *txr = txq->tx_ring;\n \tstruct tx_bd_long *txbd;\n@@ -146,8 +148,15 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\treturn -ENOMEM;\n \n \ttxbd = &txr->tx_desc_ring[txr->tx_prod];\n-\ttxbd->opaque = txr->tx_prod;\n+\ttxbd->opaque = *coal_pkts;\n \ttxbd->flags_type = tx_buf->nr_bds << TX_BD_LONG_FLAGS_BD_CNT_SFT;\n+\ttxbd->flags_type |= TX_BD_SHORT_FLAGS_COAL_NOW;\n+\tif (!*cmpl_next) {\n+\t\ttxbd->flags_type |= TX_BD_LONG_FLAGS_NO_CMPL;\n+\t} else {\n+\t\t*coal_pkts = 0;\n+\t\t*cmpl_next = false;\n+\t}\n \ttxbd->len = tx_pkt->data_len;\n \tif (txbd->len >= 2014)\n \t\ttxbd->flags_type |= TX_BD_LONG_FLAGS_LHINT_GTE2K;\n@@ -235,7 +244,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \n \t\ttxbd = &txr->tx_desc_ring[txr->tx_prod];\n \t\ttxbd->address = rte_cpu_to_le_32(rte_mbuf_data_iova(m_seg));\n-\t\ttxbd->flags_type = TX_BD_SHORT_TYPE_TX_BD_SHORT;\n+\t\ttxbd->flags_type |= TX_BD_SHORT_TYPE_TX_BD_SHORT;\n \t\ttxbd->len = m_seg->data_len;\n \n \t\tm_seg = m_seg->next;\n@@ -278,35 +287,44 @@ static int bnxt_handle_tx_cp(struct bnxt_tx_queue *txq)\n \tstruct bnxt_cp_ring_info *cpr = txq->cp_ring;\n \tuint32_t raw_cons = cpr->cp_raw_cons;\n \tuint32_t cons;\n-\tint nb_tx_pkts = 0;\n+\tuint32_t nb_tx_pkts = 0;\n \tstruct tx_cmpl *txcmp;\n+\tstruct cmpl_base *cp_desc_ring = cpr->cp_desc_ring;\n+\tstruct bnxt_ring *cp_ring_struct = cpr->cp_ring_struct;\n+\tuint32_t ring_mask = cp_ring_struct->ring_mask;\n+\tuint32_t opaque = 0;\n \n-\tif ((txq->tx_ring->tx_ring_struct->ring_size -\n-\t\t\t(bnxt_tx_avail(txq->tx_ring))) >\n-\t\t\ttxq->tx_free_thresh) {\n-\t\twhile (1) {\n-\t\t\tcons = RING_CMP(cpr->cp_ring_struct, raw_cons);\n-\t\t\ttxcmp = (struct tx_cmpl *)&cpr->cp_desc_ring[cons];\n-\n-\t\t\tif (!CMP_VALID(txcmp, raw_cons, cpr->cp_ring_struct))\n-\t\t\t\tbreak;\n-\t\t\tcpr->valid = FLIP_VALID(cons,\n-\t\t\t\t\t\tcpr->cp_ring_struct->ring_mask,\n-\t\t\t\t\t\tcpr->valid);\n-\n-\t\t\tif (CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2)\n-\t\t\t\tnb_tx_pkts++;\n-\t\t\telse\n-\t\t\t\tRTE_LOG_DP(DEBUG, PMD,\n-\t\t\t\t\t\t\"Unhandled CMP type %02x\\n\",\n-\t\t\t\t\t\tCMP_TYPE(txcmp));\n-\t\t\traw_cons = NEXT_RAW_CMP(raw_cons);\n-\t\t}\n-\t\tif (nb_tx_pkts)\n-\t\t\tbnxt_tx_cmp(txq, nb_tx_pkts);\n+\tif (((txq->tx_ring->tx_prod - txq->tx_ring->tx_cons) &\n+\t\ttxq->tx_ring->tx_ring_struct->ring_mask) < txq->tx_free_thresh)\n+\t\treturn 0;\n+\n+\tdo {\n+\t\tcons = RING_CMPL(ring_mask, raw_cons);\n+\t\ttxcmp = (struct tx_cmpl *)&cpr->cp_desc_ring[cons];\n+\t\trte_prefetch_non_temporal(&cp_desc_ring[(cons + 2) &\n+\t\t\t\t\t\t\tring_mask]);\n+\n+\t\tif (!CMPL_VALID(txcmp, cpr->valid))\n+\t\t\tbreak;\n+\t\topaque = rte_cpu_to_le_32(txcmp->opaque);\n+\t\tNEXT_CMPL(cpr, cons, cpr->valid, 1);\n+\t\trte_prefetch0(&cp_desc_ring[cons]);\n+\n+\t\tif (CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2)\n+\t\t\tnb_tx_pkts += opaque;\n+\t\telse\n+\t\t\tRTE_LOG_DP(ERR, PMD,\n+\t\t\t\t\t\"Unhandled CMP type %02x\\n\",\n+\t\t\t\t\tCMP_TYPE(txcmp));\n+\t\traw_cons = cons;\n+\t} while (nb_tx_pkts < ring_mask);\n+\n+\tif (nb_tx_pkts) {\n+\t\tbnxt_tx_cmp(txq, nb_tx_pkts);\n \t\tcpr->cp_raw_cons = raw_cons;\n-\t\tB_CP_DIS_DB(cpr, cpr->cp_raw_cons);\n+\t\tB_CP_DB(cpr, cpr->cp_raw_cons, ring_mask);\n \t}\n+\n \treturn nb_tx_pkts;\n }\n \n@@ -315,8 +333,8 @@ uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n {\n \tstruct bnxt_tx_queue *txq = tx_queue;\n \tuint16_t nb_tx_pkts = 0;\n-\tuint16_t db_mask = txq->tx_ring->tx_ring_struct->ring_size >> 2;\n-\tuint16_t last_db_mask = 0;\n+\tuint16_t coal_pkts = 0;\n+\tuint16_t cmpl_next = txq->cmpl_next;\n \n \t/* Handle TX completions */\n \tbnxt_handle_tx_cp(txq);\n@@ -326,16 +344,25 @@ uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\tPMD_DRV_LOG(DEBUG, \"Tx q stopped;return\\n\");\n \t\treturn 0;\n \t}\n+\n+\ttxq->cmpl_next = 0;\n \t/* Handle TX burst request */\n \tfor (nb_tx_pkts = 0; nb_tx_pkts < nb_pkts; nb_tx_pkts++) {\n-\t\tif (bnxt_start_xmit(tx_pkts[nb_tx_pkts], txq)) {\n+\t\tint rc;\n+\n+\t\t/* Request a completion on first and last packet */\n+\t\tcmpl_next |= (nb_pkts == nb_tx_pkts + 1);\n+\t\tcoal_pkts++;\n+\t\trc = bnxt_start_xmit(tx_pkts[nb_tx_pkts], txq,\n+\t\t\t\t&coal_pkts, &cmpl_next);\n+\n+\t\tif (unlikely(rc)) {\n+\t\t\t/* Request a completion in next cycle */\n+\t\t\ttxq->cmpl_next = 1;\n \t\t\tbreak;\n-\t\t} else if ((nb_tx_pkts & db_mask) != last_db_mask) {\n-\t\t\tB_TX_DB(txq->tx_ring->tx_doorbell,\n-\t\t\t\t\ttxq->tx_ring->tx_prod);\n-\t\t\tlast_db_mask = nb_tx_pkts & db_mask;\n \t\t}\n \t}\n+\n \tif (nb_tx_pkts)\n \t\tB_TX_DB(txq->tx_ring->tx_doorbell, txq->tx_ring->tx_prod);\n \n",
    "prefixes": [
        "v2",
        "02/23"
    ]
}