Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41844/?format=api
{ "id": 41844, "url": "http://patches.dpdk.org/api/patches/41844/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530191753-18689-4-git-send-email-rk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530191753-18689-4-git-send-email-rk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530191753-18689-4-git-send-email-rk@semihalf.com", "date": "2018-06-28T13:15:52", "name": "[v2,3/4] eal: enable WC during resources mapping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f051c16420204aed8e1403f5b4e2582f2d3f4144", "submitter": { "id": 951, "url": "http://patches.dpdk.org/api/people/951/?format=api", "name": "Rafal Kozik", "email": "rk@semihalf.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530191753-18689-4-git-send-email-rk@semihalf.com/mbox/", "series": [ { "id": 293, "url": "http://patches.dpdk.org/api/series/293/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=293", "date": "2018-06-28T13:15:49", "name": "support for write combining", "version": 2, "mbox": "http://patches.dpdk.org/series/293/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41844/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41844/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D4B71B3A8;\n\tThu, 28 Jun 2018 15:16:19 +0200 (CEST)", "from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67]) by dpdk.org (Postfix) with ESMTP id 6DDD28DAF\n\tfor <dev@dpdk.org>; Thu, 28 Jun 2018 15:16:15 +0200 (CEST)", "by mail-lf0-f67.google.com with SMTP id j26-v6so4178659lfb.11\n\tfor <dev@dpdk.org>; Thu, 28 Jun 2018 06:16:15 -0700 (PDT)", "from rafalkozik.semihalf.local\n\t(31-172-191-173.noc.fibertech.net.pl. [31.172.191.173])\n\tby smtp.gmail.com with ESMTPSA id\n\to196-v6sm1303246lfe.95.2018.06.28.06.16.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 28 Jun 2018 06:16:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=kBGocbdujXKlEP/+cvIvqTMZ+v6g682daABO2jktBhE=;\n\tb=YG+t7fyPwIOzegi9LRj4sA82ch6A9fqBTSYg8WpOb2RCJvvHY70UoJ3A0S2rR8dYo1\n\t5aPb8VnsQXY1J6ZS8tmJbvFtvpDWMSl86sadusB2im8da+O9f5+FZHIku7LM/7Nht1B3\n\t4L+kyDhfy2LXpenycTgfAPkCFUrs5mJya2Fk61gK3bm6Juq/hN6BbvE8HzzucF+XMlhA\n\tgtHTbQ4sV0HypC9utndc6QBMXumgt9MbGIFpRhhYNN55IfMfMCQexyO3b64YYrf9fvj6\n\tViMzzsCwT5/3y1yI1gzkH7oaF06Dh5tZqnJPsWdKwm8aeVzTwoHpq7nHYh1wWedxtuG3\n\tRJZA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=kBGocbdujXKlEP/+cvIvqTMZ+v6g682daABO2jktBhE=;\n\tb=JTa9Zv6wWWenS0A3pkjLLi1k1+WLGdUzn58B7L8qEv8KgNmgc5gAXCJm9SfP3vusAb\n\tPOP077m8Hy3SXV9FhWWvjqwYvZYt7Hx2L3gAI3+9qB4+t1TjDdFLF0wqQq5A+KjwMER+\n\t6iTyev1CJQyZ/gaplC9o3j4uYLrHFJRCSG77Zsj2mG9rBNHmsaEmWhowNJ22OK+jqjWo\n\tm5adO7kdOHPaH6CCT0hDTrrK03LST3hdyzCaJcnNM200Vx9hBCTQbMBlTKX6XBNm5XSf\n\tA33nWulASul4B3eWsZQFBP5um4fVXbAfGYnrpYHWfEvKLcFLtBSihXKI5S+m+wOZK9f8\n\t/tBw==", "X-Gm-Message-State": "APt69E2E7DVZp+6z0MqZcKGt4XQGMBnhJRKP1IQkFlmBPMHMMPKyjct2\n\tugZQ0zouAq3RJZ4/Dl4GncvBS0SQ2MPB+g==", "X-Google-Smtp-Source": "AAOMgpd/Z54njFqZ3DkX+5zJZURWke/UNgAp8tvhjtK/C8ZkB+jnzmwPnaVBSqumC4dahEMRQXCZmA==", "X-Received": "by 2002:a19:e546:: with SMTP id\n\tc67-v6mr7309057lfh.135.1530191774880; \n\tThu, 28 Jun 2018 06:16:14 -0700 (PDT)", "From": "Rafal Kozik <rk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n\tmatua@amazon.com, igorch@amazon.com, thomas@monjalon.net,\n\tferruh.yigit@intel.com, Rafal Kozik <rk@semihalf.com>", "Date": "Thu, 28 Jun 2018 15:15:52 +0200", "Message-Id": "<1530191753-18689-4-git-send-email-rk@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530191753-18689-1-git-send-email-rk@semihalf.com>", "References": "<CAMG3L49v=nNc9RNweJn4WCpuKeNfCk18o-xv2vq29AUo5CKc=g@mail.gmail.com>\n\t<1530191753-18689-1-git-send-email-rk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v2 3/4] eal: enable WC during resources mapping", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Write combining (WC) increases NIC performance by making better\nutilization of PCI bus, but cannot be used by all PMDs.\n\nIt will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in\ndrivers flags. For proper work also igb_uio driver must be loaded with\nwc_activate set to 1.\n\nWhen mapping PCI resources, firstly try to us WC.\nIf it is not supported it will fallback to normal mode.\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/bus/pci/linux/pci_uio.c | 41 +++++++++++++++++++++++++++++------------\n drivers/bus/pci/rte_bus_pci.h | 2 ++\n 2 files changed, 31 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c\nindex d423e4b..e3947c2 100644\n--- a/drivers/bus/pci/linux/pci_uio.c\n+++ b/drivers/bus/pci/linux/pci_uio.c\n@@ -282,22 +282,19 @@ int\n pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx,\n \t\tstruct mapped_pci_resource *uio_res, int map_idx)\n {\n-\tint fd;\n+\tint fd = -1;\n \tchar devname[PATH_MAX];\n \tvoid *mapaddr;\n \tstruct rte_pci_addr *loc;\n \tstruct pci_map *maps;\n+\tint wc_activate = 0;\n+\n+\tif (dev->driver != NULL)\n+\t\twc_activate = dev->driver->drv_flags & RTE_PCI_DRV_WC_ACTIVATE;\n \n \tloc = &dev->addr;\n \tmaps = uio_res->maps;\n \n-\t/* update devname for mmap */\n-\tsnprintf(devname, sizeof(devname),\n-\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d\",\n-\t\t\trte_pci_get_sysfs_path(),\n-\t\t\tloc->domain, loc->bus, loc->devid,\n-\t\t\tloc->function, res_idx);\n-\n \t/* allocate memory to keep path */\n \tmaps[map_idx].path = rte_malloc(NULL, strlen(devname) + 1, 0);\n \tif (maps[map_idx].path == NULL) {\n@@ -309,11 +306,31 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx,\n \t/*\n \t * open resource file, to mmap it\n \t */\n-\tfd = open(devname, O_RDWR);\n-\tif (fd < 0) {\n-\t\tRTE_LOG(ERR, EAL, \"Cannot open %s: %s\\n\",\n+\tif (wc_activate) {\n+\t\t/* update devname for mmap */\n+\t\tsnprintf(devname, sizeof(devname),\n+\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d_wc\",\n+\t\t\trte_pci_get_sysfs_path(),\n+\t\t\tloc->domain, loc->bus, loc->devid,\n+\t\t\tloc->function, res_idx);\n+\n+\t\tfd = open(devname, O_RDWR);\n+\t}\n+\n+\tif (!wc_activate || fd < 0) {\n+\t\tsnprintf(devname, sizeof(devname),\n+\t\t\t\"%s/\" PCI_PRI_FMT \"/resource%d\",\n+\t\t\trte_pci_get_sysfs_path(),\n+\t\t\tloc->domain, loc->bus, loc->devid,\n+\t\t\tloc->function, res_idx);\n+\n+\t\t/* then try to map resource file */\n+\t\tfd = open(devname, O_RDWR);\n+\t\tif (fd < 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"Cannot open %s: %s\\n\",\n \t\t\t\tdevname, strerror(errno));\n-\t\tgoto error;\n+\t\t\tgoto error;\n+\t\t}\n \t}\n \n \t/* try mapping somewhere close to the end of hugepages */\ndiff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h\nindex 458e6d0..828acc5 100644\n--- a/drivers/bus/pci/rte_bus_pci.h\n+++ b/drivers/bus/pci/rte_bus_pci.h\n@@ -135,6 +135,8 @@ struct rte_pci_bus {\n \n /** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */\n #define RTE_PCI_DRV_NEED_MAPPING 0x0001\n+/** Device needs PCI BAR mapping with enabled write combining (wc) */\n+#define RTE_PCI_DRV_WC_ACTIVATE 0x0002\n /** Device driver supports link state interrupt */\n #define RTE_PCI_DRV_INTR_LSC\t0x0008\n /** Device driver supports device removal interrupt */\n", "prefixes": [ "v2", "3/4" ] }