Show a patch.

GET /api/patches/41811/
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41811,
    "url": "http://patches.dpdk.org/api/patches/41811/",
    "web_url": "http://patches.dpdk.org/patch/41811/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<20180628005304.26544-15-pablo.de.lara.guarch@intel.com>",
    "date": "2018-06-28T00:53:02",
    "name": "[v3,14/16] cryptodev: remove attach/detach session API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "3c7422f2fff0056181f1f89f8ee71429c5f6ba4b",
    "submitter": {
        "id": 9,
        "url": "http://patches.dpdk.org/api/people/9/",
        "name": "Pablo de Lara",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "http://patches.dpdk.org/api/users/22/",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "http://patches.dpdk.org/patch/41811/mbox/",
    "series": [
        {
            "id": 286,
            "url": "http://patches.dpdk.org/api/series/286/",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=286",
            "date": "2018-06-28T00:52:48",
            "name": "Cryptodev API changes for 18.08",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/286/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/41811/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/41811/checks/",
    "tags": {},
    "headers": {
        "X-Mailman-Version": "2.1.15",
        "X-ExtLoop1": "1",
        "Errors-To": "dev-bounces@dpdk.org",
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Mailer": "git-send-email 2.14.4",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6EBA31B3A1;\n\tThu, 28 Jun 2018 11:00:12 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 00CD11B009\n\tfor <dev@dpdk.org>; Thu, 28 Jun 2018 10:59:50 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Jun 2018 01:59:42 -0700",
            "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Jun 2018 01:59:38 -0700"
        ],
        "References": "<20180608220234.10170-1-pablo.de.lara.guarch@intel.com>\n\t<20180628005304.26544-1-pablo.de.lara.guarch@intel.com>",
        "X-Amp-File-Uploaded": "False",
        "X-BeenThere": "dev@dpdk.org",
        "Message-Id": "<20180628005304.26544-15-pablo.de.lara.guarch@intel.com>",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,282,1526367600\"; d=\"scan'208\";a=\"70667200\"",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "Precedence": "list",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "X-Original-To": "patchwork@dpdk.org",
        "List-Post": "<mailto:dev@dpdk.org>",
        "Return-Path": "<dev-bounces@dpdk.org>",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "In-Reply-To": "<20180628005304.26544-1-pablo.de.lara.guarch@intel.com>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "To": "declan.doherty@intel.com, akhil.goyal@nxp.com,\n\tshally.verma@caviumnetworks.com, ravi1.kumar@amd.com,\n\tjerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com,\n\tfiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com",
        "Delivered-To": "patchwork@dpdk.org",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "Date": "Thu, 28 Jun 2018 01:53:02 +0100",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "Subject": "[dpdk-dev] [PATCH v3 14/16] cryptodev: remove attach/detach session\n\tAPI"
    },
    "content": "As announced in the previous release,\nThe API to attach/dettach a session to a queue pair\nis removed, as it was only used in DPAA, and it is not\nactually needed.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n doc/guides/rel_notes/deprecation.rst           |  8 ----\n doc/guides/rel_notes/release_18_08.rst         |  2 +\n drivers/crypto/dpaa_sec/dpaa_sec.c             | 32 +--------------\n drivers/crypto/virtio/virtio_cryptodev.c       |  4 +-\n lib/librte_cryptodev/rte_cryptodev.c           | 54 --------------------------\n lib/librte_cryptodev/rte_cryptodev.h           | 36 -----------------\n lib/librte_cryptodev/rte_cryptodev_pmd.h       | 30 --------------\n lib/librte_cryptodev/rte_cryptodev_version.map |  2 -\n 8 files changed, 4 insertions(+), 164 deletions(-)",
    "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 62d635b74..8bdaaaf5d 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -97,11 +97,3 @@ Deprecation Notices\n   - ``rte_pdump_set_socket_dir`` will be removed;\n   - The parameter, ``path``, of ``rte_pdump_init`` will be removed;\n   - The enum ``rte_pdump_socktype`` will be removed.\n-\n-* cryptodev: The following changes will be made in the library\n-  for 18.08:\n-\n-  - Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and\n-    ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from\n-    18.05 and removed in 18.08, as there are no drivers doing anything useful\n-    with them.\ndiff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst\nindex 2a136d88c..ba824c094 100644\n--- a/doc/guides/rel_notes/release_18_08.rst\n+++ b/doc/guides/rel_notes/release_18_08.rst\n@@ -69,6 +69,8 @@ API Changes\n \n   - ``rte_cryptodev_queue_pair_start``\n   - ``rte_cryptodev_queue_pair_stop``\n+  - ``rte_cryptodev_queue_pair_attach_sym_session``\n+  - ``rte_cryptodev_queue_pair_detach_sym_session``\n \n * cryptodev: Following functions were deprecated and are replaced by\n   other functions in 18.08:\ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex 8ad25f2be..3de7df93c 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -1734,34 +1734,6 @@ dpaa_sec_attach_sess_q(struct dpaa_sec_qp *qp, dpaa_sec_session *sess)\n \treturn ret;\n }\n \n-static int\n-dpaa_sec_qp_attach_sess(struct rte_cryptodev *dev __rte_unused,\n-\t\t\tuint16_t qp_id __rte_unused,\n-\t\t\tvoid *ses __rte_unused)\n-{\n-\tPMD_INIT_FUNC_TRACE();\n-\treturn 0;\n-}\n-\n-static int\n-dpaa_sec_qp_detach_sess(struct rte_cryptodev *dev,\n-\t\t\tuint16_t qp_id  __rte_unused,\n-\t\t\tvoid *ses)\n-{\n-\tdpaa_sec_session *sess = ses;\n-\tstruct dpaa_sec_dev_private *qi = dev->data->dev_private;\n-\n-\tPMD_INIT_FUNC_TRACE();\n-\n-\tif (sess->inq)\n-\t\tdpaa_sec_detach_rxq(qi, sess->inq);\n-\tsess->inq = NULL;\n-\n-\tsess->qp = NULL;\n-\n-\treturn 0;\n-}\n-\n static int\n dpaa_sec_set_session_parameters(struct rte_cryptodev *dev,\n \t\t\t    struct rte_crypto_sym_xform *xform,\tvoid *sess)\n@@ -2210,9 +2182,7 @@ static struct rte_cryptodev_ops crypto_ops = {\n \t.queue_pair_count     = dpaa_sec_queue_pair_count,\n \t.session_get_size     = dpaa_sec_session_get_size,\n \t.session_configure    = dpaa_sec_session_configure,\n-\t.session_clear        = dpaa_sec_session_clear,\n-\t.qp_attach_session    = dpaa_sec_qp_attach_sess,\n-\t.qp_detach_session    = dpaa_sec_qp_detach_sess,\n+\t.session_clear        = dpaa_sec_session_clear\n };\n \n static const struct rte_security_capability *\ndiff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c\nindex 0be435c8c..f7021b38b 100644\n--- a/drivers/crypto/virtio/virtio_cryptodev.c\n+++ b/drivers/crypto/virtio/virtio_cryptodev.c\n@@ -520,9 +520,7 @@ static struct rte_cryptodev_ops virtio_crypto_dev_ops = {\n \t/* Crypto related operations */\n \t.session_get_size\t= virtio_crypto_sym_get_session_private_size,\n \t.session_configure\t= virtio_crypto_sym_configure_session,\n-\t.session_clear\t\t= virtio_crypto_sym_clear_session,\n-\t.qp_attach_session = NULL,\n-\t.qp_detach_session = NULL\n+\t.session_clear\t\t= virtio_crypto_sym_clear_session\n };\n \n static void\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 15110661b..8c3f324c0 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -1095,60 +1095,6 @@ rte_cryptodev_sym_session_create(struct rte_mempool *mp)\n \treturn sess;\n }\n \n-int\n-rte_cryptodev_queue_pair_attach_sym_session(uint8_t dev_id, uint16_t qp_id,\n-\t\tstruct rte_cryptodev_sym_session *sess)\n-{\n-\tstruct rte_cryptodev *dev;\n-\n-\tif (!rte_cryptodev_pmd_is_valid_dev(dev_id)) {\n-\t\tCDEV_LOG_ERR(\"Invalid dev_id=%d\", dev_id);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tdev = &rte_crypto_devices[dev_id];\n-\n-\t/* The API is optional, not returning error if driver do not suuport */\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->qp_attach_session, 0);\n-\n-\tvoid *sess_priv = get_session_private_data(sess, dev->driver_id);\n-\n-\tif (dev->dev_ops->qp_attach_session(dev, qp_id, sess_priv)) {\n-\t\tCDEV_LOG_ERR(\"dev_id %d failed to attach qp: %d with session\",\n-\t\t\t\tdev_id, qp_id);\n-\t\treturn -EPERM;\n-\t}\n-\n-\treturn 0;\n-}\n-\n-int\n-rte_cryptodev_queue_pair_detach_sym_session(uint8_t dev_id, uint16_t qp_id,\n-\t\tstruct rte_cryptodev_sym_session *sess)\n-{\n-\tstruct rte_cryptodev *dev;\n-\n-\tif (!rte_cryptodev_pmd_is_valid_dev(dev_id)) {\n-\t\tCDEV_LOG_ERR(\"Invalid dev_id=%d\", dev_id);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tdev = &rte_crypto_devices[dev_id];\n-\n-\t/* The API is optional, not returning error if driver do not suuport */\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->qp_detach_session, 0);\n-\n-\tvoid *sess_priv = get_session_private_data(sess, dev->driver_id);\n-\n-\tif (dev->dev_ops->qp_detach_session(dev, qp_id, sess_priv)) {\n-\t\tCDEV_LOG_ERR(\"dev_id %d failed to detach qp: %d from session\",\n-\t\t\t\tdev_id, qp_id);\n-\t\treturn -EPERM;\n-\t}\n-\n-\treturn 0;\n-}\n-\n int\n rte_cryptodev_sym_session_clear(uint8_t dev_id,\n \t\tstruct rte_cryptodev_sym_session *sess)\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h\nindex 6dc7107bb..32a210b00 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.h\n+++ b/lib/librte_cryptodev/rte_cryptodev.h\n@@ -945,42 +945,6 @@ rte_cryptodev_sym_get_header_session_size(void);\n unsigned int\n rte_cryptodev_sym_get_private_session_size(uint8_t dev_id);\n \n-/**\n- * @deprecated\n- * Attach queue pair with sym session.\n- *\n- * @param\tdev_id\t\tDevice to which the session will be attached.\n- * @param\tqp_id\t\tQueue pair to which the session will be attached.\n- * @param\tsession\t\tSession pointer previously allocated by\n- *\t\t\t\t*rte_cryptodev_sym_session_create*.\n- *\n- * @return\n- *  - On success, zero.\n- *  - On failure, a negative value.\n- */\n-__rte_deprecated\n-int\n-rte_cryptodev_queue_pair_attach_sym_session(uint8_t dev_id, uint16_t qp_id,\n-\t\tstruct rte_cryptodev_sym_session *session);\n-\n-/**\n- * @deprecated\n- * Detach queue pair with sym session.\n- *\n- * @param\tdev_id\t\tDevice to which the session is attached.\n- * @param\tqp_id\t\tQueue pair to which the session is attached.\n- * @param\tsession\t\tSession pointer previously allocated by\n- *\t\t\t\t*rte_cryptodev_sym_session_create*.\n- *\n- * @return\n- *  - On success, zero.\n- *  - On failure, a negative value.\n- */\n-__rte_deprecated\n-int\n-rte_cryptodev_queue_pair_detach_sym_session(uint8_t dev_id, uint16_t qp_id,\n-\t\tstruct rte_cryptodev_sym_session *session);\n-\n /**\n  * Provide driver identifier.\n  *\ndiff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h\nindex 641dd1369..ec4f1ecfb 100644\n--- a/lib/librte_cryptodev/rte_cryptodev_pmd.h\n+++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h\n@@ -278,32 +278,6 @@ typedef int (*cryptodev_sym_configure_session_t)(struct rte_cryptodev *dev,\n typedef void (*cryptodev_sym_free_session_t)(struct rte_cryptodev *dev,\n \t\tstruct rte_cryptodev_sym_session *sess);\n \n-/**\n- * Optional API for drivers to attach sessions with queue pair.\n- * @param\tdev\t\tCrypto device pointer\n- * @param\tqp_id\t\tqueue pair id for attaching session\n- * @param\tpriv_sess       Pointer to cryptodev's private session structure\n- * @return\n- *  - Return 0 on success\n- */\n-typedef int (*cryptodev_sym_queue_pair_attach_session_t)(\n-\t\t  struct rte_cryptodev *dev,\n-\t\t  uint16_t qp_id,\n-\t\t  void *session_private);\n-\n-/**\n- * Optional API for drivers to detach sessions from queue pair.\n- * @param\tdev\t\tCrypto device pointer\n- * @param\tqp_id\t\tqueue pair id for detaching session\n- * @param\tpriv_sess       Pointer to cryptodev's private session structure\n- * @return\n- *  - Return 0 on success\n- */\n-typedef int (*cryptodev_sym_queue_pair_detach_session_t)(\n-\t\t  struct rte_cryptodev *dev,\n-\t\t  uint16_t qp_id,\n-\t\t  void *session_private);\n-\n /** Crypto device operations function pointer table */\n struct rte_cryptodev_ops {\n \tcryptodev_configure_t dev_configure;\t/**< Configure device. */\n@@ -331,10 +305,6 @@ struct rte_cryptodev_ops {\n \t/**< Configure a Crypto session. */\n \tcryptodev_sym_free_session_t session_clear;\n \t/**< Clear a Crypto sessions private data. */\n-\tcryptodev_sym_queue_pair_attach_session_t qp_attach_session;\n-\t/**< Attach session to queue pair. */\n-\tcryptodev_sym_queue_pair_detach_session_t qp_detach_session;\n-\t/**< Detach session from queue pair. */\n };\n \n \ndiff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map\nindex 0ab6d5195..77abd8ddc 100644\n--- a/lib/librte_cryptodev/rte_cryptodev_version.map\n+++ b/lib/librte_cryptodev/rte_cryptodev_version.map\n@@ -50,8 +50,6 @@ DPDK_17.05 {\n \n \trte_cryptodev_get_auth_algo_enum;\n \trte_cryptodev_get_cipher_algo_enum;\n-\trte_cryptodev_queue_pair_attach_sym_session;\n-\trte_cryptodev_queue_pair_detach_sym_session;\n \n } DPDK_17.02;\n \n",
    "prefixes": [
        "v3",
        "14/16"
    ]
}