Show a patch.

GET /api/patches/41810/
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41810,
    "url": "http://patches.dpdk.org/api/patches/41810/",
    "web_url": "http://patches.dpdk.org/patch/41810/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<20180628005304.26544-14-pablo.de.lara.guarch@intel.com>",
    "date": "2018-06-28T00:53:01",
    "name": "[v3,13/16] cryptodev: replace mbuf scatter gather flag",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d814a731d19fb6d08c0d129d7a2c21e61737a4f7",
    "submitter": {
        "id": 9,
        "url": "http://patches.dpdk.org/api/people/9/",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "http://patches.dpdk.org/api/users/22/",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "http://patches.dpdk.org/patch/41810/mbox/",
    "series": [
        {
            "id": 286,
            "url": "http://patches.dpdk.org/api/series/286/",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=286",
            "date": "2018-06-28T00:52:48",
            "name": "Cryptodev API changes for 18.08",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/286/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/41810/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/41810/checks/",
    "tags": {},
    "headers": {
        "X-Mailman-Version": "2.1.15",
        "X-ExtLoop1": "1",
        "Errors-To": "dev-bounces@dpdk.org",
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Mailer": "git-send-email 2.14.4",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 733111B39E;\n\tThu, 28 Jun 2018 11:00:10 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 1B9A41B064\n\tfor <dev@dpdk.org>; Thu, 28 Jun 2018 10:59:49 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Jun 2018 01:59:41 -0700",
            "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Jun 2018 01:59:35 -0700"
        ],
        "References": "<20180608220234.10170-1-pablo.de.lara.guarch@intel.com>\n\t<20180628005304.26544-1-pablo.de.lara.guarch@intel.com>",
        "X-Amp-File-Uploaded": "False",
        "X-BeenThere": "dev@dpdk.org",
        "Message-Id": "<20180628005304.26544-14-pablo.de.lara.guarch@intel.com>",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,282,1526367600\"; d=\"scan'208\";a=\"70667171\"",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "Precedence": "list",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "X-Original-To": "patchwork@dpdk.org",
        "List-Post": "<mailto:dev@dpdk.org>",
        "Return-Path": "<dev-bounces@dpdk.org>",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "In-Reply-To": "<20180628005304.26544-1-pablo.de.lara.guarch@intel.com>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "To": "declan.doherty@intel.com, akhil.goyal@nxp.com,\n\tshally.verma@caviumnetworks.com, ravi1.kumar@amd.com,\n\tjerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com,\n\tfiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com",
        "Delivered-To": "patchwork@dpdk.org",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "Date": "Thu, 28 Jun 2018 01:53:01 +0100",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "Subject": "[dpdk-dev] [PATCH v3 13/16] cryptodev: replace mbuf scatter gather\n\tflag"
    },
    "content": "The current mbuf scatter gatter feature flag is\ntoo ambiguous, as it is not clear if input and/or output\nbuffers can be scatter gather mbufs or not, plus\nif in-place and/or out-of-place is supported.\n\nTherefore, five new flags will replace this flag:\n- RTE_CRYPTODEV_FF_IN_PLACE_SGL\n- RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT\n- RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT\n- RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT\n- RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n doc/guides/rel_notes/deprecation.rst        |  2 --\n doc/guides/rel_notes/release_18_08.rst      |  8 +++++\n drivers/crypto/aesni_gcm/aesni_gcm_pmd.c    |  2 +-\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c |  6 +++-\n drivers/crypto/dpaa_sec/dpaa_sec.c          |  6 +++-\n drivers/crypto/null/null_crypto_pmd.c       |  2 +-\n drivers/crypto/openssl/rte_openssl_pmd.c    |  2 +-\n drivers/crypto/qat/qat_sym_pmd.c            |  6 +++-\n lib/librte_cryptodev/rte_cryptodev.c        | 12 ++++++--\n lib/librte_cryptodev/rte_cryptodev.h        | 46 +++++++++++++++++++----------\n test/test/test_cryptodev.c                  | 31 +++++++++++++------\n test/test/test_cryptodev_blockcipher.c      | 21 ++++++++++---\n 12 files changed, 106 insertions(+), 38 deletions(-)",
    "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 9a73b1d8e..62d635b74 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -105,5 +105,3 @@ Deprecation Notices\n     ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from\n     18.05 and removed in 18.08, as there are no drivers doing anything useful\n     with them.\n-  - Some feature flags such as ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` are ambiguous,\n-    so some will be replaced by more explicit flags.\ndiff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst\nindex e482d3d5f..2a136d88c 100644\n--- a/doc/guides/rel_notes/release_18_08.rst\n+++ b/doc/guides/rel_notes/release_18_08.rst\n@@ -78,6 +78,14 @@ API Changes\n   - ``rte_cryptodev_get_private_session_size`` is replaced with\n     ``rte_cryptodev_sym_get_private_session_size``\n \n+* cryptodev: Feature flag ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` is\n+  replaced with the following more explicit flags:\n+  - ``RTE_CRYPTODEV_FF_IN_PLACE_SGL``\n+  - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT``\n+  - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT``\n+  - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT``\n+  - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT``\n+\n \n ABI Changes\n -----------\ndiff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\nindex cd5b1952b..03917f220 100644\n--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n@@ -492,7 +492,7 @@ aesni_gcm_create(const char *name,\n \tdev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |\n \t\t\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n \t\t\tRTE_CRYPTODEV_FF_CPU_AESNI |\n-\t\t\tRTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER;\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT;\n \n \tswitch (vector_mode) {\n \tcase RTE_AESNI_GCM_SSE:\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 1b1c30d85..4daee5f59 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -2762,7 +2762,11 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev)\n \t\t\tRTE_CRYPTODEV_FF_HW_ACCELERATED |\n \t\t\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n \t\t\tRTE_CRYPTODEV_FF_SECURITY |\n-\t\t\tRTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER;\n+\t\t\tRTE_CRYPTODEV_FF_IN_PLACE_SGL |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT;\n \n \tinternals = cryptodev->data->dev_private;\n \ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex b96552c57..8ad25f2be 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -2271,7 +2271,11 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev)\n \t\t\tRTE_CRYPTODEV_FF_HW_ACCELERATED |\n \t\t\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n \t\t\tRTE_CRYPTODEV_FF_SECURITY |\n-\t\t\tRTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER;\n+\t\t\tRTE_CRYPTODEV_FF_IN_PLACE_SGL |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT;\n \n \tinternals = cryptodev->data->dev_private;\n \tinternals->max_nb_queue_pairs = RTE_DPAA_MAX_NB_SEC_QPS;\ndiff --git a/drivers/crypto/null/null_crypto_pmd.c b/drivers/crypto/null/null_crypto_pmd.c\nindex 478ac0b62..224ba7233 100644\n--- a/drivers/crypto/null/null_crypto_pmd.c\n+++ b/drivers/crypto/null/null_crypto_pmd.c\n@@ -177,7 +177,7 @@ cryptodev_null_create(const char *name,\n \n \tdev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |\n \t\t\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n-\t\t\tRTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER;\n+\t\t\tRTE_CRYPTODEV_FF_IN_PLACE_SGL;\n \n \tinternals = dev->data->dev_private;\n \ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex 972e2adfe..94b6e2de9 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -1660,7 +1660,7 @@ cryptodev_openssl_create(const char *name,\n \tdev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |\n \t\t\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n \t\t\tRTE_CRYPTODEV_FF_CPU_AESNI |\n-\t\t\tRTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER;\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT;\n \n \t/* Set vector instructions mode supported */\n \tinternals = dev->data->dev_private;\ndiff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c\nindex ee8633b85..629904e2f 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.c\n+++ b/drivers/crypto/qat/qat_sym_pmd.c\n@@ -274,7 +274,11 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev)\n \tcryptodev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |\n \t\t\tRTE_CRYPTODEV_FF_HW_ACCELERATED |\n \t\t\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n-\t\t\tRTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER;\n+\t\t\tRTE_CRYPTODEV_FF_IN_PLACE_SGL |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT;\n \n \tinternals = cryptodev->data->dev_private;\n \tinternals->qat_dev = qat_pci_dev;\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 381330f3d..15110661b 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -361,8 +361,16 @@ rte_cryptodev_get_feature_name(uint64_t flag)\n \t\treturn \"CPU_AESNI\";\n \tcase RTE_CRYPTODEV_FF_HW_ACCELERATED:\n \t\treturn \"HW_ACCELERATED\";\n-\tcase RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER:\n-\t\treturn \"MBUF_SCATTER_GATHER\";\n+\tcase RTE_CRYPTODEV_FF_IN_PLACE_SGL:\n+\t\treturn \"IN_PLACE_SGL\";\n+\tcase RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT:\n+\t\treturn \"OUT_OF_PLACE_SGL_IN_SGL_OUT\";\n+\tcase RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT:\n+\t\treturn \"OUT_OF_PLACE_SGL_IN_FB_OUT\";\n+\tcase RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT:\n+\t\treturn \"OUT_OF_PLACE_FB_IN_SGL_OUT\";\n+\tcase RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT:\n+\t\treturn \"OUT_OF_PLACE_FB_IN_FB_OUT\";\n \tcase RTE_CRYPTODEV_FF_CPU_NEON:\n \t\treturn \"CPU_NEON\";\n \tcase RTE_CRYPTODEV_FF_CPU_ARM_CE:\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h\nindex fc491a83b..6dc7107bb 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.h\n+++ b/lib/librte_cryptodev/rte_cryptodev.h\n@@ -300,31 +300,47 @@ rte_cryptodev_get_aead_algo_enum(enum rte_crypto_aead_algorithm *algo_enum,\n  *\n  * Keep these flags synchronised with rte_cryptodev_get_feature_name()\n  */\n-#define\tRTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO\t(1ULL << 0)\n+#define\tRTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO\t\t(1ULL << 0)\n /**< Symmetric crypto operations are supported */\n-#define\tRTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO\t(1ULL << 1)\n+#define\tRTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO\t\t(1ULL << 1)\n /**< Asymmetric crypto operations are supported */\n-#define\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING\t(1ULL << 2)\n+#define\tRTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING\t\t(1ULL << 2)\n /**< Chaining symmetric crypto operations are supported */\n-#define\tRTE_CRYPTODEV_FF_CPU_SSE\t\t(1ULL << 3)\n+#define\tRTE_CRYPTODEV_FF_CPU_SSE\t\t\t(1ULL << 3)\n /**< Utilises CPU SIMD SSE instructions */\n-#define\tRTE_CRYPTODEV_FF_CPU_AVX\t\t(1ULL << 4)\n+#define\tRTE_CRYPTODEV_FF_CPU_AVX\t\t\t(1ULL << 4)\n /**< Utilises CPU SIMD AVX instructions */\n-#define\tRTE_CRYPTODEV_FF_CPU_AVX2\t\t(1ULL << 5)\n+#define\tRTE_CRYPTODEV_FF_CPU_AVX2\t\t\t(1ULL << 5)\n /**< Utilises CPU SIMD AVX2 instructions */\n-#define\tRTE_CRYPTODEV_FF_CPU_AESNI\t\t(1ULL << 6)\n+#define\tRTE_CRYPTODEV_FF_CPU_AESNI\t\t\t(1ULL << 6)\n /**< Utilises CPU AES-NI instructions */\n-#define\tRTE_CRYPTODEV_FF_HW_ACCELERATED\t\t(1ULL << 7)\n-/**< Operations are off-loaded to an external hardware accelerator */\n-#define\tRTE_CRYPTODEV_FF_CPU_AVX512\t\t(1ULL << 8)\n+#define\tRTE_CRYPTODEV_FF_HW_ACCELERATED\t\t\t(1ULL << 7)\n+/**< Operations are off-loaded to an\n+ * external hardware accelerator\n+ */\n+#define\tRTE_CRYPTODEV_FF_CPU_AVX512\t\t\t(1ULL << 8)\n /**< Utilises CPU SIMD AVX512 instructions */\n-#define\tRTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER\t(1ULL << 9)\n-/**< Scatter-gather mbufs are supported */\n-#define\tRTE_CRYPTODEV_FF_CPU_NEON\t\t(1ULL << 10)\n+#define\tRTE_CRYPTODEV_FF_IN_PLACE_SGL\t\t\t(1ULL << 9)\n+/**< In-place Scatter-gather (SGL) mbufs are supported */\n+#define RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT\t(1ULL << 10)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are\n+ * supported in input and output\n+ */\n+#define RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT\t(1ULL << 11)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are supported\n+ * in input, combined with flat buffers (FB) in output\n+ */\n+#define RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT\t(1ULL << 12)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are supported\n+ * in output, combined with flat buffers (FB) in input\n+ */\n+#define RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT\t(1ULL << 13)\n+/**< Out-of-place flat buffers (FB) are supported in input and output */\n+#define\tRTE_CRYPTODEV_FF_CPU_NEON\t\t\t(1ULL << 14)\n /**< Utilises CPU NEON instructions */\n-#define\tRTE_CRYPTODEV_FF_CPU_ARM_CE\t\t(1ULL << 11)\n+#define\tRTE_CRYPTODEV_FF_CPU_ARM_CE\t\t\t(1ULL << 15)\n /**< Utilises ARM CPU Cryptographic Extensions */\n-#define\tRTE_CRYPTODEV_FF_SECURITY\t\t(1ULL << 12)\n+#define\tRTE_CRYPTODEV_FF_SECURITY\t\t\t(1ULL << 16)\n /**< Support Security Protocol Processing */\n \n \ndiff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c\nindex 73aadaced..84fcf0651 100644\n--- a/test/test/test_cryptodev.c\n+++ b/test/test/test_cryptodev.c\n@@ -3160,8 +3160,11 @@ test_kasumi_encryption_sgl(const struct kasumi_test_data *tdata)\n \tstruct rte_cryptodev_info dev_info;\n \n \trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n-\tif (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER)) {\n-\t\tprintf(\"Device doesn't support scatter-gather. \"\n+\n+\tuint64_t feat_flags = dev_info.feature_flags;\n+\n+\tif (!(feat_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) {\n+\t\tprintf(\"Device doesn't support in-place scatter-gather. \"\n \t\t\t\t\"Test Skipped.\\n\");\n \t\treturn 0;\n \t}\n@@ -3308,8 +3311,11 @@ test_kasumi_encryption_oop_sgl(const struct kasumi_test_data *tdata)\n \tstruct rte_cryptodev_info dev_info;\n \n \trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n-\tif (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER)) {\n-\t\tprintf(\"Device doesn't support scatter-gather. \"\n+\n+\tuint64_t feat_flags = dev_info.feature_flags;\n+\tif (!(feat_flags & RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT)) {\n+\t\tprintf(\"Device doesn't support out-of-place scatter-gather \"\n+\t\t\t\t\"in both input and output mbufs. \"\n \t\t\t\t\"Test Skipped.\\n\");\n \t\treturn 0;\n \t}\n@@ -3659,8 +3665,12 @@ test_snow3g_encryption_oop_sgl(const struct snow3g_test_data *tdata)\n \tstruct rte_cryptodev_info dev_info;\n \n \trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n-\tif (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER)) {\n-\t\tprintf(\"Device doesn't support scatter-gather. \"\n+\n+\tuint64_t feat_flags = dev_info.feature_flags;\n+\n+\tif (!(feat_flags & RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT)) {\n+\t\tprintf(\"Device doesn't support out-of-place scatter-gather \"\n+\t\t\t\t\"in both input and output mbufs. \"\n \t\t\t\t\"Test Skipped.\\n\");\n \t\treturn 0;\n \t}\n@@ -4493,10 +4503,13 @@ test_zuc_encryption_sgl(const struct wireless_test_data *tdata)\n \t\treturn -ENOTSUP;\n \n \trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n-\tif (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER)) {\n-\t\tprintf(\"Device doesn't support scatter-gather. \"\n+\n+\tuint64_t feat_flags = dev_info.feature_flags;\n+\n+\tif (!(feat_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) {\n+\t\tprintf(\"Device doesn't support in-place scatter-gather. \"\n \t\t\t\t\"Test Skipped.\\n\");\n-\t\treturn -ENOTSUP;\n+\t\treturn 0;\n \t}\n \n \tplaintext_len = ceil_byte_length(tdata->plaintext.len);\ndiff --git a/test/test/test_cryptodev_blockcipher.c b/test/test/test_cryptodev_blockcipher.c\nindex 256a7daa2..7a11b3af8 100644\n--- a/test/test/test_cryptodev_blockcipher.c\n+++ b/test/test/test_cryptodev_blockcipher.c\n@@ -77,12 +77,25 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,\n \n \tif (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_SG) {\n \t\trte_cryptodev_info_get(dev_id, &dev_info);\n-\t\tif (!(dev_info.feature_flags &\n-\t\t\t\tRTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER)) {\n-\t\t\tprintf(\"Device doesn't support scatter-gather. \"\n+\t\tuint64_t feat_flags = dev_info.feature_flags;\n+\t\tuint64_t oop_flag = RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT;\n+\n+\t\tif (t->feature_mask && BLOCKCIPHER_TEST_FEATURE_OOP) {\n+\t\t\tif (!(feat_flags & oop_flag)) {\n+\t\t\t\tprintf(\"Device doesn't support out-of-place \"\n+\t\t\t\t\t\"scatter-gather in input mbuf. \"\n+\t\t\t\t\t\"Test Skipped.\\n\");\n+\t\t\t\treturn 0;\n+\t\t\t}\n+\t\t} else {\n+\t\t\tif (!(feat_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) {\n+\t\t\t\tprintf(\"Device doesn't support in-place \"\n+\t\t\t\t\t\"scatter-gather mbufs. \"\n \t\t\t\t\t\"Test Skipped.\\n\");\n-\t\t\treturn 0;\n+\t\t\t\treturn 0;\n+\t\t\t}\n \t\t}\n+\n \t\tnb_segs = 3;\n \t}\n \n",
    "prefixes": [
        "v3",
        "13/16"
    ]
}