Show a patch.

GET /api/patches/41800/
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41800,
    "url": "http://patches.dpdk.org/api/patches/41800/",
    "web_url": "http://patches.dpdk.org/patch/41800/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<20180628005304.26544-2-pablo.de.lara.guarch@intel.com>",
    "date": "2018-06-28T00:52:49",
    "name": "[v3,01/16] cryptodev: replace bus specific struct with generic dev",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "67fa994105798aad8f2db2d8fd27b128f14e1384",
    "submitter": {
        "id": 9,
        "url": "http://patches.dpdk.org/api/people/9/",
        "name": "De Lara Guarch, Pablo",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "http://patches.dpdk.org/api/users/22/",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "http://patches.dpdk.org/patch/41800/mbox/",
    "series": [
        {
            "id": 286,
            "url": "http://patches.dpdk.org/api/series/286/",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=286",
            "date": "2018-06-28T00:52:48",
            "name": "Cryptodev API changes for 18.08",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/286/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/41800/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/41800/checks/",
    "tags": {},
    "headers": {
        "X-Mailman-Version": "2.1.15",
        "X-ExtLoop1": "1",
        "Errors-To": "dev-bounces@dpdk.org",
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Mailer": "git-send-email 2.14.4",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 890388E73;\n\tThu, 28 Jun 2018 10:59:31 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 315277CB0\n\tfor <dev@dpdk.org>; Thu, 28 Jun 2018 10:59:21 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Jun 2018 01:59:19 -0700",
            "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Jun 2018 01:59:00 -0700"
        ],
        "References": "<20180608220234.10170-1-pablo.de.lara.guarch@intel.com>\n\t<20180628005304.26544-1-pablo.de.lara.guarch@intel.com>",
        "X-Amp-File-Uploaded": "False",
        "X-BeenThere": "dev@dpdk.org",
        "Message-Id": "<20180628005304.26544-2-pablo.de.lara.guarch@intel.com>",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,282,1526367600\"; d=\"scan'208\";a=\"70667009\"",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "Precedence": "list",
        "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "X-Original-To": "patchwork@dpdk.org",
        "List-Post": "<mailto:dev@dpdk.org>",
        "Return-Path": "<dev-bounces@dpdk.org>",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "In-Reply-To": "<20180628005304.26544-1-pablo.de.lara.guarch@intel.com>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "To": "declan.doherty@intel.com, akhil.goyal@nxp.com,\n\tshally.verma@caviumnetworks.com, ravi1.kumar@amd.com,\n\tjerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com,\n\tfiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com",
        "Delivered-To": "patchwork@dpdk.org",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "Date": "Thu, 28 Jun 2018 01:52:49 +0100",
        "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "Subject": "[dpdk-dev] [PATCH v3 01/16] cryptodev: replace bus specific struct\n\twith generic dev"
    },
    "content": "Structure rte_cryptodev_info has currently PCI device\ninformation (\"struct rte_pci_device\") in it.\n\nThis information is not generic to all devices,\nso this gets replaced with the generic \"rte_device\" structure,\ncompatible with all crypto devices.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nAcked-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n doc/guides/prog_guide/cryptodev_lib.rst  | 2 +-\n doc/guides/rel_notes/deprecation.rst     | 2 --\n doc/guides/rel_notes/release_18_08.rst   | 5 ++++-\n drivers/crypto/qat/qat_sym_pmd.c         | 1 -\n drivers/crypto/virtio/virtio_cryptodev.c | 1 -\n lib/librte_cryptodev/rte_cryptodev.c     | 1 +\n lib/librte_cryptodev/rte_cryptodev.h     | 6 +++---\n 7 files changed, 9 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst\nindex 30f0bcf7a..d02bb7514 100644\n--- a/doc/guides/prog_guide/cryptodev_lib.rst\n+++ b/doc/guides/prog_guide/cryptodev_lib.rst\n@@ -269,7 +269,7 @@ relevant information for the device.\n     struct rte_cryptodev_info {\n         const char *driver_name;\n         uint8_t driver_id;\n-        struct rte_pci_device *pci_dev;\n+        struct rte_device *device;\n \n         uint64_t feature_flags;\n \ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 1ce692eac..b71080bb8 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -104,8 +104,6 @@ Deprecation Notices\n   - Removal of ``sym`` structure in ``rte_cryptodev_info`` structure,\n     containing fields not relevant anymore since the session mempool\n     is not internal in the crypto device anymore.\n-  - Replacement of ``pci_dev`` field with the more generic ``rte_device``\n-    structure.\n   - Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and\n     ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from\n     18.05 and removed in 18.08, as there are no drivers doing anything useful\ndiff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst\nindex bc0124295..6bf53dc31 100644\n--- a/doc/guides/rel_notes/release_18_08.rst\n+++ b/doc/guides/rel_notes/release_18_08.rst\n@@ -60,6 +60,9 @@ API Changes\n    Also, make sure to start the actual text at the margin.\n    =========================================================\n \n+* cryptodev: In struct ``struct rte_cryptodev_info``, field ``rte_pci_device *pci_dev``\n+  has been replaced with field ``struct rte_device *device``.\n+\n \n ABI Changes\n -----------\n@@ -118,7 +121,7 @@ The libraries prepended with a plus sign were incremented in this version.\n      librte_cmdline.so.2\n      librte_common_octeontx.so.1\n      librte_compressdev.so.1\n-     librte_cryptodev.so.4\n+   + librte_cryptodev.so.5\n      librte_distributor.so.1\n      librte_eal.so.7\n      librte_ethdev.so.9\ndiff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c\nindex 115639089..0bc042a75 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.c\n+++ b/drivers/crypto/qat/qat_sym_pmd.c\n@@ -74,7 +74,6 @@ static void qat_sym_dev_info_get(struct rte_cryptodev *dev,\n \t\tinfo->capabilities = internals->qat_dev_capabilities;\n \t\tinfo->sym.max_nb_sessions = QAT_SYM_PMD_MAX_NB_SESSIONS;\n \t\tinfo->driver_id = cryptodev_qat_driver_id;\n-\t\tinfo->pci_dev = RTE_DEV_TO_PCI(dev->device);\n \t}\n }\n \ndiff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c\nindex df88953f6..482edea1a 100644\n--- a/drivers/crypto/virtio/virtio_cryptodev.c\n+++ b/drivers/crypto/virtio/virtio_cryptodev.c\n@@ -1409,7 +1409,6 @@ virtio_crypto_dev_info_get(struct rte_cryptodev *dev,\n \n \tif (info != NULL) {\n \t\tinfo->driver_id = cryptodev_virtio_driver_id;\n-\t\tinfo->pci_dev = RTE_DEV_TO_PCI(dev->device);\n \t\tinfo->feature_flags = dev->feature_flags;\n \t\tinfo->max_nb_queue_pairs = hw->max_dataqueues;\n \t\tinfo->sym.max_nb_sessions =\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 7e5821246..457ac5670 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -966,6 +966,7 @@ rte_cryptodev_info_get(uint8_t dev_id, struct rte_cryptodev_info *dev_info)\n \t(*dev->dev_ops->dev_infos_get)(dev, dev_info);\n \n \tdev_info->driver_name = dev->device->driver->name;\n+\tdev_info->device = dev->device;\n }\n \n \ndiff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h\nindex b7a4cf0a2..62a5566ba 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.h\n+++ b/lib/librte_cryptodev/rte_cryptodev.h\n@@ -342,9 +342,9 @@ rte_cryptodev_get_feature_name(uint64_t flag);\n \n /**  Crypto device information */\n struct rte_cryptodev_info {\n-\tconst char *driver_name;\t\t/**< Driver name. */\n-\tuint8_t driver_id;\t\t\t/**< Driver identifier */\n-\tstruct rte_pci_device *pci_dev;\t\t/**< PCI information. */\n+\tconst char *driver_name;\t/**< Driver name. */\n+\tuint8_t driver_id;\t\t/**< Driver identifier */\n+\tstruct rte_device *device;\t/**< Generic device information. */\n \n \tuint64_t feature_flags;\n \t/**< Feature flags exposes HW/SW features for the given device */\n",
    "prefixes": [
        "v3",
        "01/16"
    ]
}