Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41691/?format=api
{ "id": 41691, "url": "http://patches.dpdk.org/api/patches/41691/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/5e9bb490cd3cccb660e11ea0c7ca256e0fd73cc7.1530111623.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5e9bb490cd3cccb660e11ea0c7ca256e0fd73cc7.1530111623.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5e9bb490cd3cccb660e11ea0c7ca256e0fd73cc7.1530111623.git.nelio.laranjeiro@6wind.com", "date": "2018-06-27T15:07:49", "name": "[v2,17/20] net/mlx5: add flow VXLAN-GPE item", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e94705d83fc85f5f70361ef6861dcd0424dd0c6a", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/5e9bb490cd3cccb660e11ea0c7ca256e0fd73cc7.1530111623.git.nelio.laranjeiro@6wind.com/mbox/", "series": [ { "id": 268, "url": "http://patches.dpdk.org/api/series/268/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=268", "date": "2018-06-27T15:07:32", "name": "net/mlx5: flow rework", "version": 2, "mbox": "http://patches.dpdk.org/series/268/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41691/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41691/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C8AE01C012;\n\tWed, 27 Jun 2018 17:08:11 +0200 (CEST)", "from mail-wr0-f195.google.com (mail-wr0-f195.google.com\n\t[209.85.128.195]) by dpdk.org (Postfix) with ESMTP id A72A61BFCC\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 17:07:49 +0200 (CEST)", "by mail-wr0-f195.google.com with SMTP id c13-v6so2410130wrq.2\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 08:07:49 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tk17-v6sm4872513wrp.19.2018.06.27.08.07.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Jun 2018 08:07:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=Gd7i2AsWX41QgQk8Ar7YsqHX/20TGthlM9YUUXpSoxo=;\n\tb=L1bAmyNDhpvWls+SjkmsH634Lmi9nifbfFPIUqk50cUUbXnuy9dHvat8dumBEycorZ\n\tteXCJAgkUO7YTtuX7+g2bcFBwU8K9ebfXTRH7zdGxgITvA2ZtiuRW0gCPbafLLciioH3\n\tqgqWEXAoBvhW3llmd5Ah4yVNrGPEsqRuBTYwo8LcnME2BJ5BCpemgubn2ntOoyMjTWLo\n\tkAQ+1R9eEHoMLWuxGLgXlytBKuNOFRPZRVL/dH1fMGabBDS4m4B5AzAFXQ8DbVUS1TvV\n\ta1LbJ4LspF6ZsZc9NoFWwdPUrzdnRaUaX0p47p/ImW07gabXuksSDEj+Ze2DR4FmfPq9\n\t+DOA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Gd7i2AsWX41QgQk8Ar7YsqHX/20TGthlM9YUUXpSoxo=;\n\tb=gSPoBQTCeYaOTh6co1D3PLbC0MBvktpCp1by1P6Ysbd5DgX4En1+mwly6KXrTzZC0S\n\tfT07iEiY4wqs3buPXArFJ7a0zde2jNfwGVexfGzALBuYsqc6tRui6dR6aeOrT8cn5ys4\n\tSY4e/QRZ51TQf1YkKK68CZ8vGHI6kQh8g2DKqN5eYUZowD0uJOY5ZAJoD5e62o4Iri4X\n\t11ce60fZlY1KmcwqhsTptR9wTNoSCCD/xOuHFbA2XNj+e0+Oqck/czEe71Mp1cAKmP5e\n\tlsbHfKpnGDeiLDn+JS/f9qONfNRZQh+XoHbjmw4egzSKOXIHTGW0hTHoROGGui2vYOWQ\n\tifbA==", "X-Gm-Message-State": "APt69E0VILXfSbwWFbBLogNSq/PgkRqdHXMbuR8uidNXcn8we0AomkZ8\n\tUEW0ljQX95HSZ8lQb34+hYdKvFIVSA==", "X-Google-Smtp-Source": "AAOMgpesZ/MW35jhUfyT/RUEqNA3MyI4LuEbRPiJp9iag25rPhW/MlDYYBjM2IEyMYLF8EuQ/YuK5w==", "X-Received": "by 2002:adf:8895:: with SMTP id\n\tf21-v6mr5608758wrf.250.1530112069072; \n\tWed, 27 Jun 2018 08:07:49 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tYongseok Koh <yskoh@mellanox.com>", "Date": "Wed, 27 Jun 2018 17:07:49 +0200", "Message-Id": "<5e9bb490cd3cccb660e11ea0c7ca256e0fd73cc7.1530111623.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>", "References": "<cover.1527506071.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530111623.git.nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 17/20] net/mlx5: add flow VXLAN-GPE item", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 123 ++++++++++++++++++++++++++++++++++-\n 1 file changed, 120 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex daf5b9b5a..47c55b426 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -53,6 +53,7 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;\n \n /* Pattern tunnel Layer bits. */\n #define MLX5_FLOW_LAYER_VXLAN (1u << 12)\n+#define MLX5_FLOW_LAYER_VXLAN_GPE (1u << 13)\n \n /* Outer Masks. */\n #define MLX5_FLOW_LAYER_OUTER_L3 \\\n@@ -64,7 +65,8 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;\n \t MLX5_FLOW_LAYER_OUTER_L4)\n \n /* Tunnel masks. */\n-#define MLX5_FLOW_LAYER_TUNNEL MLX5_FLOW_LAYER_VXLAN\n+#define MLX5_FLOW_LAYER_TUNNEL \\\n+\t(MLX5_FLOW_LAYER_VXLAN | MLX5_FLOW_LAYER_VXLAN_GPE)\n \n /* Inner Masks. */\n #define MLX5_FLOW_LAYER_INNER_L3 \\\n@@ -1302,9 +1304,118 @@ mlx5_flow_item_vxlan(const struct rte_flow_item *item, struct rte_flow *flow,\n \treturn size;\n }\n \n+/**\n+ * Validate VXLAN-GPE layer and possibly create the Verbs specification.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ * @param item[in]\n+ * Item specification.\n+ * @param flow[in, out]\n+ * Pointer to flow structure.\n+ * @param flow_size[in]\n+ * Size in bytes of the available space for to store the flow information.\n+ * @param error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * size in bytes necessary for the conversion, a negative errno value\n+ * otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_flow_item_vxlan_gpe(struct rte_eth_dev *dev,\n+\t\t\t const struct rte_flow_item *item,\n+\t\t\t struct rte_flow *flow, const size_t flow_size,\n+\t\t\t struct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_item_vxlan_gpe *spec = item->spec;\n+\tconst struct rte_flow_item_vxlan_gpe *mask = item->mask;\n+\tconst uint32_t layers = mlx5_flow_layers(flow);\n+\tunsigned int size = sizeof(struct ibv_flow_spec_tunnel);\n+\tstruct ibv_flow_spec_tunnel vxlan_gpe = {\n+\t\t.type = IBV_FLOW_SPEC_VXLAN_TUNNEL,\n+\t\t.size = size,\n+\t};\n+\tint ret;\n+\tunion vni {\n+\t\tuint32_t vlan_id;\n+\t\tuint8_t vni[4];\n+\t} id = { .vlan_id = 0, };\n+\n+\tif (!((struct priv *)dev->data->dev_private)->config.l3_vxlan_en)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"L3 VXLAN is not enabled by device\"\n+\t\t\t\t\t \" parameter and/or not configured in\"\n+\t\t\t\t\t \" firmware\");\n+\tif (layers & MLX5_FLOW_LAYER_TUNNEL)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"a tunnel is already present\");\n+\t/*\n+\t * Verify only UDPv4 is present as defined in\n+\t * https://tools.ietf.org/html/rfc7348\n+\t */\n+\tif (!(layers & MLX5_FLOW_LAYER_OUTER_L4_UDP))\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"no outer UDP layer found\");\n+\tif (!mask)\n+\t\tmask = &rte_flow_item_vxlan_gpe_mask;\n+\tret = mlx5_flow_item_validate\n+\t\t(item, (const uint8_t *)mask,\n+\t\t (const uint8_t *)&rte_flow_item_vxlan_gpe_mask,\n+\t\t sizeof(struct rte_flow_item_vxlan_gpe), error);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\tif (spec) {\n+\t\tmemcpy(&id.vni[1], spec->vni, 3);\n+\t\tvxlan_gpe.val.tunnel_id = id.vlan_id;\n+\t\tmemcpy(&id.vni[1], mask->vni, 3);\n+\t\tvxlan_gpe.mask.tunnel_id = id.vlan_id;\n+\t\tif (spec->protocol)\n+\t\t\treturn rte_flow_error_set\n+\t\t\t\t(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t item,\n+\t\t\t\t \"VxLAN-GPE protocol not supported\");\n+\t\t/* Remove unwanted bits from values. */\n+\t\tvxlan_gpe.val.tunnel_id &= vxlan_gpe.mask.tunnel_id;\n+\t}\n+\t/*\n+\t * Tunnel id 0 is equivalent as not adding a VXLAN layer, if only this\n+\t * layer is defined in the Verbs specification it is interpreted as\n+\t * wildcard and all packets will match this rule, if it follows a full\n+\t * stack layer (ex: eth / ipv4 / udp), all packets matching the layers\n+\t * before will also match this rule. To avoid such situation, VNI 0\n+\t * is currently refused.\n+\t */\n+\tif (!vxlan_gpe.val.tunnel_id)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"VXLAN-GPE vni cannot be 0\");\n+\tif (!(layers & MLX5_FLOW_LAYER_OUTER))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"VXLAN-GPE tunnel must be fully\"\n+\t\t\t\t\t \" defined\");\n+\tif (size <= flow_size)\n+\t\tmlx5_flow_spec_verbs_add(flow, &vxlan_gpe, size);\n+\tmlx5_flow_layers_update(flow, MLX5_FLOW_LAYER_VXLAN_GPE);\n+\tflow->ptype = RTE_PTYPE_TUNNEL_VXLAN_GPE | RTE_PTYPE_L4_UDP;\n+\treturn size;\n+}\n+\n /**\n * Validate items provided by the user.\n *\n+ * @param dev\n+ * Pointer to Ethernet device.\n * @param items\n * Pointer to flow items array.\n * @param flow\n@@ -1319,7 +1430,8 @@ mlx5_flow_item_vxlan(const struct rte_flow_item *item, struct rte_flow *flow,\n * otherwise and rte_errno is set.\n */\n static int\n-mlx5_flow_items(const struct rte_flow_item items[],\n+mlx5_flow_items(struct rte_eth_dev *dev,\n+\t\tconst struct rte_flow_item items[],\n \t\tstruct rte_flow *flow, const size_t flow_size,\n \t\tstruct rte_flow_error *error)\n {\n@@ -1353,6 +1465,10 @@ mlx5_flow_items(const struct rte_flow_item items[],\n \t\tcase RTE_FLOW_ITEM_TYPE_VXLAN:\n \t\t\tret = mlx5_flow_item_vxlan(items, flow, remain, error);\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_VXLAN_GPE:\n+\t\t\tret = mlx5_flow_item_vxlan_gpe(dev, items, flow,\n+\t\t\t\t\t\t remain, error);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n@@ -1962,7 +2078,8 @@ mlx5_flow_merge(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\t\t\t(void *)(flow->cur_verbs->attr + 1);\n \t\t}\n \t\tret = mlx5_flow_items\n-\t\t\t((const struct rte_flow_item *)buf->patterns[i],\n+\t\t\t(dev,\n+\t\t\t (const struct rte_flow_item *)buf->patterns[i],\n \t\t\t flow, remain, error);\n \t\tif (ret < 0)\n \t\t\tgoto error;\n", "prefixes": [ "v2", "17/20" ] }