Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41685,
    "url": "http://patches.dpdk.org/api/patches/41685/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/2e0decb7243290b23f782e7e4d9a4f689d9afbd4.1530111623.git.nelio.laranjeiro@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<2e0decb7243290b23f782e7e4d9a4f689d9afbd4.1530111623.git.nelio.laranjeiro@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/2e0decb7243290b23f782e7e4d9a4f689d9afbd4.1530111623.git.nelio.laranjeiro@6wind.com",
    "date": "2018-06-27T15:07:43",
    "name": "[v2,11/20] net/mlx5: add flow TCP item",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "a172aa8cd936a7edefc607a1307ab1e9e681effd",
    "submitter": {
        "id": 243,
        "url": "http://patches.dpdk.org/api/people/243/?format=api",
        "name": "Nélio Laranjeiro",
        "email": "nelio.laranjeiro@6wind.com"
    },
    "delegate": {
        "id": 6624,
        "url": "http://patches.dpdk.org/api/users/6624/?format=api",
        "username": "shahafs",
        "first_name": "Shahaf",
        "last_name": "Shuler",
        "email": "shahafs@mellanox.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/2e0decb7243290b23f782e7e4d9a4f689d9afbd4.1530111623.git.nelio.laranjeiro@6wind.com/mbox/",
    "series": [
        {
            "id": 268,
            "url": "http://patches.dpdk.org/api/series/268/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=268",
            "date": "2018-06-27T15:07:32",
            "name": "net/mlx5: flow rework",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/268/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/41685/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/41685/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5A18C1BFEB;\n\tWed, 27 Jun 2018 17:07:59 +0200 (CEST)",
            "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67]) by dpdk.org (Postfix) with ESMTP id A9F2B1BFBD\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 17:07:44 +0200 (CEST)",
            "by mail-wm0-f67.google.com with SMTP id v16-v6so6258393wmv.5\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 08:07:44 -0700 (PDT)",
            "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tk17-v6sm4872513wrp.19.2018.06.27.08.07.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Jun 2018 08:07:43 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=Frq/IvDC/kZVPBS4+K4m6e76igHSD27sGRakRKDd7dc=;\n\tb=beh8fQWkfTOjdgPy+J1QMkiZJweqzsez3+zYg3YRHjEqqrQFJfsEmTj3oKGq7MqxlD\n\tO62tynaK2BcSIyohvcICYLWg7p8IapHwhrHZyh65ZgpZbI8Dw/wwDtmuoio3wAy8Lqdo\n\tLp6Z14X6lB4YWKOJnSnv6zIm3tky5ojFRx0Mafd7yI3J0uEdRTAQnJ3xvw7t4GoCQeck\n\tTdkUXVuJbdIJnFT/uBtCCMmhnYJOD5XDUtyQSfR5qOBxjhtlVVwcCo5TCE+bhkZTN8y5\n\tRYhep1O7RiLdxdSLBomxZqf384muElGkdD7skC93hTR8J0EHxkXNJkhKvjr91j6h+FFq\n\t1C5Q==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Frq/IvDC/kZVPBS4+K4m6e76igHSD27sGRakRKDd7dc=;\n\tb=e7JVpPgAkiF3FjADxYVLc3QFng6an475CjKfMM//Kr35OZbrQyd3BlvJ+4wS0owwSv\n\t32Qn2I7kLN/vUA6vdQtTV+e3/dNCSz8yaCVauTd8JJj7PoVvrL1q6XikybJ5ehnsAEja\n\tVX5tRb9+AfD7s2uk0rb03c9sPRmmEVWxQxW5/kgiOZpqqS3SC5x6hrESX+slDyMFBWov\n\t6otSQUszsiOuJCeUPP4ZRGOim7drJhzLsITLT7nEK3O9Yzw/2d0PYnhlpWJDXiabUWiQ\n\tJIdu48zcnY63UOb9UM1ps4zA9K0xT4XaUDGpnmrLdPac6s+3Ay+ffUfTZ4TBNvlnwtwK\n\tpaLA==",
        "X-Gm-Message-State": "APt69E1xe40aqJc08ylb52RCPRzDOEj7n5PIM4adfIt7mzS/5A6MrSrw\n\tL4eQxZ8TPKPndBEV+V8TBZURAfzXAQ==",
        "X-Google-Smtp-Source": "AAOMgpeg/p/WDC5nwrC8y6dJ5k0n+xLmhkUGeoEYLXipzQxNeeVFTLJXOtD3ssyhmzYr76fyyNWIjQ==",
        "X-Received": "by 2002:a1c:4405:: with SMTP id\n\tr5-v6mr4984882wma.62.1530112064230; \n\tWed, 27 Jun 2018 08:07:44 -0700 (PDT)",
        "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>",
        "To": "dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tYongseok Koh <yskoh@mellanox.com>",
        "Date": "Wed, 27 Jun 2018 17:07:43 +0200",
        "Message-Id": "<2e0decb7243290b23f782e7e4d9a4f689d9afbd4.1530111623.git.nelio.laranjeiro@6wind.com>",
        "X-Mailer": "git-send-email 2.18.0",
        "In-Reply-To": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>",
        "References": "<cover.1527506071.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530111623.git.nelio.laranjeiro@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v2 11/20] net/mlx5: add flow TCP item",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 65 ++++++++++++++++++++++++++++++++++++\n 1 file changed, 65 insertions(+)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 06b4b7f41..57f072c03 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -787,6 +787,68 @@ mlx5_flow_item_udp(const struct rte_flow_item *item, struct rte_flow *flow,\n \treturn size;\n }\n \n+/**\n+ * Validate TCP layer and possibly create the Verbs specification.\n+ *\n+ * @param item[in]\n+ *   Item specification.\n+ * @param flow[in, out]\n+ *   Pointer to flow structure.\n+ * @param flow_size[in]\n+ *   Size in bytes of the available space for to store the flow information.\n+ * @param error\n+ *   Pointer to error structure.\n+ *\n+ * @return\n+ *   size in bytes necessary for the conversion, a negative errno value\n+ *   otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_flow_item_tcp(const struct rte_flow_item *item, struct rte_flow *flow,\n+\t\t   const size_t flow_size, struct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_item_tcp *spec = item->spec;\n+\tconst struct rte_flow_item_tcp *mask = item->mask;\n+\tunsigned int size = sizeof(struct ibv_flow_spec_tcp_udp);\n+\tstruct ibv_flow_spec_tcp_udp tcp = {\n+\t\t.type = IBV_FLOW_SPEC_TCP,\n+\t\t.size = size,\n+\t};\n+\tint ret;\n+\n+\tif (!(flow->layers & MLX5_FLOW_LAYER_OUTER_L3))\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t  item,\n+\t\t\t\t\t  \"L3 is mandatory to filter on L4\");\n+\tif (flow->layers & MLX5_FLOW_LAYER_OUTER_L4)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t  item,\n+\t\t\t\t\t  \"L4 layer is already present\");\n+\tif (!mask)\n+\t\tmask = &rte_flow_item_tcp_mask;\n+\tret = mlx5_flow_item_validate(item, (const uint8_t *)mask,\n+\t\t\t\t      (const uint8_t *)&rte_flow_item_tcp_mask,\n+\t\t\t\t      sizeof(struct rte_flow_item_tcp), error);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\tflow->layers |= MLX5_FLOW_LAYER_OUTER_L4_TCP;\n+\tif (size > flow_size)\n+\t\treturn size;\n+\tif (spec) {\n+\t\ttcp.val.dst_port = spec->hdr.dst_port;\n+\t\ttcp.val.src_port = spec->hdr.src_port;\n+\t\ttcp.mask.dst_port = mask->hdr.dst_port;\n+\t\ttcp.mask.src_port = mask->hdr.src_port;\n+\t\t/* Remove unwanted bits from values. */\n+\t\ttcp.val.src_port &= tcp.mask.src_port;\n+\t\ttcp.val.dst_port &= tcp.mask.dst_port;\n+\t}\n+\tmlx5_flow_spec_verbs_add(flow, &tcp, size);\n+\treturn size;\n+}\n+\n /**\n  * Validate items provided by the user.\n  *\n@@ -832,6 +894,9 @@ mlx5_flow_items(const struct rte_flow_item items[],\n \t\tcase RTE_FLOW_ITEM_TYPE_UDP:\n \t\t\tret = mlx5_flow_item_udp(items, flow, remain, error);\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_TCP:\n+\t\t\tret = mlx5_flow_item_tcp(items, flow, remain, error);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ITEM,\n",
    "prefixes": [
        "v2",
        "11/20"
    ]
}