Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41672/?format=api
{ "id": 41672, "url": "http://patches.dpdk.org/api/patches/41672/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180627144959.17277-8-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180627144959.17277-8-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180627144959.17277-8-maxime.coquelin@redhat.com", "date": "2018-06-27T14:49:59", "name": "[v3,7/7] vhost: improve prefetching in enqueue path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f6157d8a0ae9674dcbac9cd6b82dee6d7a696945", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180627144959.17277-8-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 266, "url": "http://patches.dpdk.org/api/series/266/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=266", "date": "2018-06-27T14:49:52", "name": "vhost: generalize buffer vectors", "version": 3, "mbox": "http://patches.dpdk.org/series/266/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41672/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41672/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8194F1BF7A;\n\tWed, 27 Jun 2018 16:50:30 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id D67701BF59\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 16:50:22 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 62E08407C570;\n\tWed, 27 Jun 2018 14:50:22 +0000 (UTC)", "from localhost.localdomain (ovpn-112-39.ams2.redhat.com\n\t[10.36.112.39])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5793220389E0;\n\tWed, 27 Jun 2018 14:50:21 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "tiwei.bie@intel.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 27 Jun 2018 16:49:59 +0200", "Message-Id": "<20180627144959.17277-8-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180627144959.17277-1-maxime.coquelin@redhat.com>", "References": "<20180627144959.17277-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.7]); Wed, 27 Jun 2018 14:50:22 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.7]); \n\tWed, 27 Jun 2018 14:50:22 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [PATCH v3 7/7] vhost: improve prefetching in enqueue path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is an optimization to prefetch next buffer while the\ncurrent one is being processed.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/virtio_net.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex ff6fa8d61..81377e79a 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -393,6 +393,9 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \tbuf_iova = buf_vec[vec_idx].buf_iova;\n \tbuf_len = buf_vec[vec_idx].buf_len;\n \n+\tif (nr_vec > 1)\n+\t\trte_prefetch0((void *)(uintptr_t)buf_vec[1].buf_addr);\n+\n \tif (unlikely(buf_len < dev->vhost_hlen && nr_vec <= 1)) {\n \t\terror = -1;\n \t\tgoto out;\n@@ -404,7 +407,6 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\thdr = &tmp_hdr;\n \telse\n \t\thdr = (struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)hdr_addr;\n-\trte_prefetch0((void *)(uintptr_t)hdr_addr);\n \n \tVHOST_LOG_DEBUG(VHOST_DATA, \"(%d) RX: num merge buffers %d\\n\",\n \t\tdev->vid, num_buffers);\n@@ -436,8 +438,10 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t\tbuf_iova = buf_vec[vec_idx].buf_iova;\n \t\t\tbuf_len = buf_vec[vec_idx].buf_len;\n \n-\t\t\t/* Prefetch buffer address. */\n-\t\t\trte_prefetch0((void *)(uintptr_t)buf_addr);\n+\t\t\t/* Prefetch next buffer address. */\n+\t\t\tif (vec_idx + 1 < nr_vec)\n+\t\t\t\trte_prefetch0((void *)(uintptr_t)\n+\t\t\t\t\t\tbuf_vec[vec_idx + 1].buf_addr);\n \t\t\tbuf_offset = 0;\n \t\t\tbuf_avail = buf_len;\n \t\t}\n@@ -579,6 +583,8 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,\n \t\t\tbreak;\n \t\t}\n \n+\t\trte_prefetch0((void *)(uintptr_t)buf_vec[0].buf_addr);\n+\n \t\tVHOST_LOG_DEBUG(VHOST_DATA, \"(%d) current index %d | end index %d\\n\",\n \t\t\tdev->vid, vq->last_avail_idx,\n \t\t\tvq->last_avail_idx + num_buffers);\n", "prefixes": [ "v3", "7/7" ] }