Patch Comment List
List patch comments
GET /api/patches/41638/comments/?format=api
[ { "id": 82735, "web_url": "http://patches.dpdk.org/comment/82735/", "msgid": "<ac7a997e-2534-c668-deb8-59d25b58480f@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/ac7a997e-2534-c668-deb8-59d25b58480f@redhat.com", "date": "2018-06-27T08:24:25", "subject": "Re: [dpdk-dev] [PATCH v5 23/24] net/vhost: enable port detach on\n\tsecondary process", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "content": "On 06/27/2018 09:17 AM, Qi Zhang wrote:\n> Previously, detach port on secondary process will mess primary\n> process and cause same device can't be attached again, by take\n> advantage of rte_eth_release_port_private, we can support this\n> with minor change.\n> \n> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>\n> ---\n> drivers/net/vhost/rte_eth_vhost.c | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\n> index ba9d768a0..f773711b4 100644\n> --- a/drivers/net/vhost/rte_eth_vhost.c\n> +++ b/drivers/net/vhost/rte_eth_vhost.c\n> @@ -1353,6 +1353,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)\n> \t\t}\n> \t\t/* TODO: request info from primary to set up Rx and Tx */\n> \t\teth_dev->dev_ops = &ops;\n> +\t\teth_dev->device = &dev->device;\n> \t\trte_eth_dev_probing_finish(eth_dev);\n> \t\treturn 0;\n> \t}\n> @@ -1435,6 +1436,16 @@ rte_pmd_vhost_remove(struct rte_vdev_device *dev)\n> \tif (eth_dev == NULL)\n> \t\treturn -ENODEV;\n> \n> +\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n> +\t\t/* detach device on local pprocess only */\n> +\t\tif (strlen(rte_vdev_device_args(dev)) == 0)\n> +\t\t\treturn rte_eth_dev_release_port_private(eth_dev);\n> +\t\t/**\n> +\t\t * else this is a private device for current process\n> +\t\t * so continue with normal detach scenario\n> +\t\t */\n> +\t}\n> +\n\nIMHO, the driver shouldn't have to manage primary/secondary process\nstuff. It does not look like the right place to me.\n\n> \teth_dev_close(eth_dev);\n> \n> \trte_free(vring_states[eth_dev->data->port_id]);\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0DF061BE93;\n\tWed, 27 Jun 2018 10:24:33 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id 8091C1BE8D\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 10:24:31 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0103F40201CF;\n\tWed, 27 Jun 2018 08:24:31 +0000 (UTC)", "from [10.36.112.39] (ovpn-112-39.ams2.redhat.com [10.36.112.39])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id A75F91117656;\n\tWed, 27 Jun 2018 08:24:28 +0000 (UTC)" ], "To": "Qi Zhang <qi.z.zhang@intel.com>, thomas@monjalon.net,\n\tanatoly.burakov@intel.com", "Cc": "konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, \n\tferruh.yigit@intel.com, benjamin.h.shelton@intel.com,\n\tnarender.vangati@intel.com", "References": "<20180607123849.14439-1-qi.z.zhang@intel.com>\n\t<20180627071740.19870-1-qi.z.zhang@intel.com>\n\t<20180627071740.19870-24-qi.z.zhang@intel.com>", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Message-ID": "<ac7a997e-2534-c668-deb8-59d25b58480f@redhat.com>", "Date": "Wed, 27 Jun 2018 10:24:25 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0", "MIME-Version": "1.0", "In-Reply-To": "<20180627071740.19870-24-qi.z.zhang@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.3", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.6]); Wed, 27 Jun 2018 08:24:31 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.6]); \n\tWed, 27 Jun 2018 08:24:31 +0000 (UTC) for IP:'10.11.54.3'\n\tDOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "Re: [dpdk-dev] [PATCH v5 23/24] net/vhost: enable port detach on\n\tsecondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]