Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41597/?format=api
{ "id": 41597, "url": "http://patches.dpdk.org/api/patches/41597/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/e02b51d41c65405993ed2cc56e82302e49d88e7a.1530031921.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e02b51d41c65405993ed2cc56e82302e49d88e7a.1530031921.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e02b51d41c65405993ed2cc56e82302e49d88e7a.1530031921.git.gaetan.rivet@6wind.com", "date": "2018-06-26T16:56:14", "name": "[v8,11/21] eal/dev: implement device iteration initialization", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6cac7b2e36c8b0e90d8382809fed5db0adacc11a", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/e02b51d41c65405993ed2cc56e82302e49d88e7a.1530031921.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 249, "url": "http://patches.dpdk.org/api/series/249/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=249", "date": "2018-06-26T16:56:03", "name": "Device querying", "version": 8, "mbox": "http://patches.dpdk.org/series/249/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41597/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41597/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6D8481BE49;\n\tTue, 26 Jun 2018 18:57:18 +0200 (CEST)", "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 3F62C1BE21\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 18:57:04 +0200 (CEST)", "by mail-wm0-f67.google.com with SMTP id l15-v6so15794560wmc.1\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 09:57:04 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tp5-v6sm2680880wre.83.2018.06.26.09.57.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Jun 2018 09:57:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=CQP7HwETJDS1+r4uLUc7OtartxXupr/yoyp7uskGZdo=;\n\tb=opZOC7kuDGLpvedNVf1V+OTQdWBWcDyN03gPMrd48AXzDg5iSnM6iwmMBNEiLmk9QM\n\tjj8ilWAgfd/E6moM2IaDRTLaOWmQXxlUgVKHMT5vGNocZQRJTS6jZ8HO8wNU44Ht4s0r\n\tXUyce+SQMc4ee4lbmki5SeFeE9YU+C9XrAGJxjJdNAdS8I9ducHiiyHsOXxA0Zyhd/ht\n\t5xkoXIsjbXU1UCH1qkhrSIkeU90uKEJvT++WZSt1mHDEE2x1KricwK8nFWm4mH4vx/QY\n\t/9CDUNPzFh/L3uH3kMMxsBDTWZSPhP5n0WX3ubgPEbDJ5jLMVbn7ia777HsOUFGPCe+p\n\tUC8Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=CQP7HwETJDS1+r4uLUc7OtartxXupr/yoyp7uskGZdo=;\n\tb=PQjM4dTDj54Y9IbLvLbIXXq/IPTlDap53giz1CE6ya68LpJcTlrutxD/2j2d1EGk1o\n\tQ6e9ojP1qjClNfEYowd+Ztil6jt8YxHRMPDOpNgPxvYRW7Ys/qW0FjgYY02rAbEWuSsC\n\tcT50q2ZTzsjZLy3ImQwYDwizGREI59lZVGIDvlytY2GRpHX1bIJ5vKSzn++EzZr6CXs8\n\twnoE7SCvwZe93fZ1JD5UJx24wl/cAHaeJeourMqdo2oBCAGYNZ72gO7YqfW+OlmmoYHM\n\tV4YhCwb7VkEu+PbgIuE4f1BssAY/kL2Vph/wUabO7lYkJYC0eNa68cB2fa+TRmRreuoR\n\tBTwQ==", "X-Gm-Message-State": "APt69E2iRtFi0HN0u0M+bAD+uDqRv7kWK9bNMtnZGGMwfzI6RD5/T+4A\n\t20yDKlB5CGtpgcpnswo8HzeDMUqp", "X-Google-Smtp-Source": "AAOMgpdqF0kGlM7+5s84LqTP8AJqLVrjZaDdi/Hqd/G0yxpfo9jKPtYqDZz5Rm+Ep4hJM7kJVt3NBg==", "X-Received": "by 2002:a1c:e846:: with SMTP id\n\tf67-v6mr2265522wmh.63.1530032223480; \n\tTue, 26 Jun 2018 09:57:03 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Tue, 26 Jun 2018 18:56:14 +0200", "Message-Id": "<e02b51d41c65405993ed2cc56e82302e49d88e7a.1530031921.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": [ "<cover.1530031921.git.gaetan.rivet@6wind.com>", "<cover.1530031921.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1521124599.git.gaetan.rivet@6wind.com>\n\t<cover.1530031921.git.gaetan.rivet@6wind.com>", "<cover.1530031921.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v8 11/21] eal/dev: implement device iteration\n\tinitialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Parse a device description.\nSplit this description in their relevant part for each layers.\nNo dynamic allocation is performed.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/Makefile | 1 +\n lib/librte_eal/bsdapp/eal/Makefile | 1 +\n lib/librte_eal/common/eal_common_dev.c | 55 +++++++++++++++++++++++++++++++++\n lib/librte_eal/common/include/rte_dev.h | 24 ++++++++++++++\n lib/librte_eal/linuxapp/eal/Makefile | 1 +\n lib/librte_eal/rte_eal_version.map | 1 +\n 6 files changed, 83 insertions(+)", "diff": "diff --git a/lib/Makefile b/lib/Makefile\nindex 8a65525cd..afa604e20 100644\n--- a/lib/Makefile\n+++ b/lib/Makefile\n@@ -7,6 +7,7 @@ DIRS-y += librte_compat\n DIRS-$(CONFIG_RTE_LIBRTE_KVARGS) += librte_kvargs\n DEPDIRS-librte_kvargs := librte_compat\n DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_eal\n+DEPDIRS-librte_eal := librte_kvargs\n DIRS-$(CONFIG_RTE_LIBRTE_PCI) += librte_pci\n DEPDIRS-librte_pci := librte_eal\n DIRS-$(CONFIG_RTE_LIBRTE_RING) += librte_ring\ndiff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile\nindex b0a1c880a..67b10ae0d 100644\n--- a/lib/librte_eal/bsdapp/eal/Makefile\n+++ b/lib/librte_eal/bsdapp/eal/Makefile\n@@ -18,6 +18,7 @@ CFLAGS += $(WERROR_FLAGS) -O3\n LDLIBS += -lexecinfo\n LDLIBS += -lpthread\n LDLIBS += -lgcc_s\n+LDLIBS += -lrte_kvargs\n \n EXPORT_MAP := ../../rte_eal_version.map\n \ndiff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex ce4b51469..5b7956d17 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -10,9 +10,12 @@\n \n #include <rte_compat.h>\n #include <rte_bus.h>\n+#include <rte_class.h>\n #include <rte_dev.h>\n #include <rte_devargs.h>\n #include <rte_debug.h>\n+#include <rte_errno.h>\n+#include <rte_kvargs.h>\n #include <rte_log.h>\n #include <rte_spinlock.h>\n #include <rte_malloc.h>\n@@ -343,3 +346,55 @@ dev_callback_process(char *device_name, enum rte_dev_event_type event)\n \t}\n \trte_spinlock_unlock(&dev_event_lock);\n }\n+\n+__rte_experimental\n+int\n+rte_dev_iterator_init(struct rte_dev_iterator *it,\n+\t\t const char *devstr)\n+{\n+\tstruct rte_devargs da;\n+\tstruct rte_class *cls = NULL;\n+\tstruct rte_bus *bus = NULL;\n+\n+\t/* Having both busstr and clsstr NULL is illegal,\n+\t * marking this iterator as invalid unless\n+\t * everything goes well.\n+\t */\n+\tit->busstr = NULL;\n+\tit->clsstr = NULL;\n+\n+\tda.data = devstr;\n+\tif (rte_devargs_layers_parse(&da, devstr))\n+\t\tgoto get_out;\n+\n+\tbus = da.bus;\n+\tcls = da.cls;\n+\t/* The string should have at least\n+\t * one layer specified.\n+\t */\n+\tif (bus == NULL && cls == NULL) {\n+\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\"Either bus or class must be specified.\\n\");\n+\t\trte_errno = EINVAL;\n+\t\tgoto get_out;\n+\t}\n+\tif (bus != NULL && bus->dev_iterate == NULL) {\n+\t\tRTE_LOG(ERR, EAL, \"Bus %s not supported\\n\", bus->name);\n+\t\trte_errno = ENOTSUP;\n+\t\tgoto get_out;\n+\t}\n+\tif (cls != NULL && cls->dev_iterate == NULL) {\n+\t\tRTE_LOG(ERR, EAL, \"Class %s not supported\\n\", cls->name);\n+\t\trte_errno = ENOTSUP;\n+\t\tgoto get_out;\n+\t}\n+\tit->busstr = da.busstr;\n+\tit->clsstr = da.clsstr;\n+\tit->devstr = devstr;\n+\tit->bus = bus;\n+\tit->cls = cls;\n+\tit->device = NULL;\n+\tit->class_device = NULL;\n+get_out:\n+\treturn -rte_errno;\n+}\ndiff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h\nindex 120df729f..7b7bd83bc 100644\n--- a/lib/librte_eal/common/include/rte_dev.h\n+++ b/lib/librte_eal/common/include/rte_dev.h\n@@ -332,6 +332,30 @@ typedef void *(*rte_dev_iterate_t)(const void *start,\n \t\t\t\t const char *devstr,\n \t\t\t\t const struct rte_dev_iterator *it);\n \n+/**\n+ * Initializes a device iterator.\n+ *\n+ * This iterator allows accessing a list of devices matching a criteria.\n+ * The device matching is made among all buses and classes currently registered,\n+ * filtered by the device description given as parameter.\n+ *\n+ * This function will not allocate any memory. It is safe to stop the\n+ * iteration at any moment and let the iterator go out of context.\n+ *\n+ * @param it\n+ * Device iterator handle.\n+ *\n+ * @param str\n+ * Device description string.\n+ *\n+ * @return\n+ * 0 on successful initialization.\n+ * <0 on error.\n+ */\n+__rte_experimental\n+int\n+rte_dev_iterator_init(struct rte_dev_iterator *it, const char *str);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile\nindex babc8617a..885c48110 100644\n--- a/lib/librte_eal/linuxapp/eal/Makefile\n+++ b/lib/librte_eal/linuxapp/eal/Makefile\n@@ -27,6 +27,7 @@ LDLIBS += -lrt\n ifeq ($(CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES),y)\n LDLIBS += -lnuma\n endif\n+LDLIBS += -lrte_kvargs\n \n # specific to linuxapp exec-env\n SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) := eal.c\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 19d36b4c7..ac04120d6 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -251,6 +251,7 @@ EXPERIMENTAL {\n \trte_dev_event_callback_unregister;\n \trte_dev_event_monitor_start;\n \trte_dev_event_monitor_stop;\n+\trte_dev_iterator_init;\n \trte_devargs_add;\n \trte_devargs_dump;\n \trte_devargs_insert;\n", "prefixes": [ "v8", "11/21" ] }