Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41554/?format=api
{ "id": 41554, "url": "http://patches.dpdk.org/api/patches/41554/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/39abdf03ff35813b987875249ebba6b968932752.1530009564.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<39abdf03ff35813b987875249ebba6b968932752.1530009564.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/39abdf03ff35813b987875249ebba6b968932752.1530009564.git.anatoly.burakov@intel.com", "date": "2018-06-26T10:53:13", "name": "[v2,2/7] eal/linux: use glibc malloc in interrupt handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "add9b19bfa348a7bda49530fe49787c41b507758", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/39abdf03ff35813b987875249ebba6b968932752.1530009564.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 238, "url": "http://patches.dpdk.org/api/series/238/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=238", "date": "2018-06-26T10:53:12", "name": "Remove asynchronous IPC thread", "version": 2, "mbox": "http://patches.dpdk.org/series/238/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41554/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41554/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7E7441B505;\n\tTue, 26 Jun 2018 12:53:26 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 498EA1B45C\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 12:53:23 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 03:53:22 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga006.jf.intel.com with ESMTP; 26 Jun 2018 03:53:19 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw5QArJFt026438; Tue, 26 Jun 2018 11:53:19 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w5QArJWf021188;\n\tTue, 26 Jun 2018 11:53:19 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w5QArJ4N021184;\n\tTue, 26 Jun 2018 11:53:19 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"52974027\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Jianfeng Tan <jianfeng.tan@intel.com>, konstantin.ananyev@intel.com,\n\tthomas@monjalon.net, bruce.richardson@intel.com, qi.z.zhang@intel.com", "Date": "Tue, 26 Jun 2018 11:53:13 +0100", "Message-Id": "<39abdf03ff35813b987875249ebba6b968932752.1530009564.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1530009564.git.anatoly.burakov@intel.com>", "<cover.1530009564.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1530009564.git.anatoly.burakov@intel.com>", "<cover.1529071026.git.anatoly.burakov@intel.com>\n\t<cover.1530009564.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v2 2/7] eal/linux: use glibc malloc in interrupt\n\thandling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jianfeng Tan <jianfeng.tan@intel.com>\n\nIPC uses interrupts API internally, and memory subsystem uses IPC.\nTherefore, IPC should not use rte_malloc to avoid circular dependency.\nSwitch to using regular glibc malloc in interrupts API.\n\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_interrupts.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\nindex 056d41c12..180c0378a 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n@@ -30,7 +30,6 @@\n #include <rte_branch_prediction.h>\n #include <rte_debug.h>\n #include <rte_log.h>\n-#include <rte_malloc.h>\n #include <rte_errno.h>\n #include <rte_spinlock.h>\n #include <rte_pause.h>\n@@ -405,8 +404,7 @@ rte_intr_callback_register(const struct rte_intr_handle *intr_handle,\n \t}\n \n \t/* allocate a new interrupt callback entity */\n-\tcallback = rte_zmalloc(\"interrupt callback list\",\n-\t\t\t\tsizeof(*callback), 0);\n+\tcallback = calloc(1, sizeof(*callback));\n \tif (callback == NULL) {\n \t\tRTE_LOG(ERR, EAL, \"Can not allocate memory\\n\");\n \t\treturn -ENOMEM;\n@@ -431,10 +429,10 @@ rte_intr_callback_register(const struct rte_intr_handle *intr_handle,\n \n \t/* no existing callbacks for this - add new source */\n \tif (src == NULL) {\n-\t\tif ((src = rte_zmalloc(\"interrupt source list\",\n-\t\t\t\tsizeof(*src), 0)) == NULL) {\n+\t\tsrc = calloc(1, sizeof(*src));\n+\t\tif (src == NULL) {\n \t\t\tRTE_LOG(ERR, EAL, \"Can not allocate memory\\n\");\n-\t\t\trte_free(callback);\n+\t\t\tfree(callback);\n \t\t\tret = -ENOMEM;\n \t\t} else {\n \t\t\tsrc->intr_handle = *intr_handle;\n@@ -501,7 +499,7 @@ rte_intr_callback_unregister(const struct rte_intr_handle *intr_handle,\n \t\t\tif (cb->cb_fn == cb_fn && (cb_arg == (void *)-1 ||\n \t\t\t\t\tcb->cb_arg == cb_arg)) {\n \t\t\t\tTAILQ_REMOVE(&src->callbacks, cb, next);\n-\t\t\t\trte_free(cb);\n+\t\t\t\tfree(cb);\n \t\t\t\tret++;\n \t\t\t}\n \t\t}\n@@ -509,7 +507,7 @@ rte_intr_callback_unregister(const struct rte_intr_handle *intr_handle,\n \t\t/* all callbacks for that source are removed. */\n \t\tif (TAILQ_EMPTY(&src->callbacks)) {\n \t\t\tTAILQ_REMOVE(&intr_sources, src, next);\n-\t\t\trte_free(src);\n+\t\t\tfree(src);\n \t\t}\n \t}\n \n", "prefixes": [ "v2", "2/7" ] }