Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41537/?format=api
{ "id": 41537, "url": "http://patches.dpdk.org/api/patches/41537/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/07e4d536-edd6-292d-5adb-c05793731623@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<07e4d536-edd6-292d-5adb-c05793731623@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/07e4d536-edd6-292d-5adb-c05793731623@intel.com", "date": "2018-06-26T09:02:50", "name": "[v2] kni: fix build with gcc 8.1", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5841a65652b50cc49dbb1741d2588fbe818c94ff", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/07e4d536-edd6-292d-5adb-c05793731623@intel.com/mbox/", "series": [ { "id": 233, "url": "http://patches.dpdk.org/api/series/233/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=233", "date": "2018-06-26T09:02:50", "name": "[v2] kni: fix build with gcc 8.1", "version": 2, "mbox": "http://patches.dpdk.org/series/233/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41537/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41537/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1A7AB1B43A;\n\tTue, 26 Jun 2018 11:03:14 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 316B81B426;\n\tTue, 26 Jun 2018 11:03:12 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 02:03:10 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.83])\n\t([10.237.221.83])\n\tby fmsmga002.fm.intel.com with ESMTP; 26 Jun 2018 02:02:54 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"61349900\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, stephen@networkplumber.org, pablo.de.lara.guarch@intel.com,\n\tstable@dpdk.org", "References": "<20180619120855.78207-1-ferruh.yigit@intel.com>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n\txsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n\tqbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n\t+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n\tGWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n\t+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n\tYK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n\tezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n\tCmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n\t1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n\tcBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln\n\taXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE\n\tFgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E\n\tTS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62\n\tFwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4\n\tjQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB\n\tc34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF\n\tHmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd\n\tfmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1\n\tyC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p\n\tmsjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg\n\tHiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW\n\tta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN\n\tipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy\n\tK4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X\n\tpAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq\n\tvOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM\n\tn44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1\n\tEd3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj\n\t8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s\n\tDWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9\n\t+P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB\n\tZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J\n\tEE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG\n\t+jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17\n\tQc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj\n\tccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+\n\tFJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og\n\t77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB\n\tLki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90\n\tNu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa\n\t2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA\n\tQ6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu\n\tUhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG\n\tZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ\n\tzT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU\n\tNyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK\n\tFYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs\n\ttFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC\n\tx41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA\n\tbLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ\n\tqZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3\n\tXphVR5G70mnca1E2vzC77z+XSlTyRA==", "Message-ID": "<07e4d536-edd6-292d-5adb-c05793731623@intel.com>", "Date": "Tue, 26 Jun 2018 10:02:50 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0", "MIME-Version": "1.0", "In-Reply-To": "<20180619120855.78207-1-ferruh.yigit@intel.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] kni: fix build with gcc 8.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is\nenabled.\n\nbuild error:\nIn function ‘strncpy’,\n inlined from ‘igb_get_drvinfo’ at\n .../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2:\n .../include/linux/string.h:246:9: error: ‘__builtin_strncpy’ output\n may be truncated copying 31 bytes from a string of length 42\n [-Werror=stringop-truncation]\n return __builtin_strncpy(p, q, size);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nFixed by using strlcpy instead of strncpy.\n\nadapter->fw_version size kept same because of\nc3698192940c (\"kni: fix build with gcc 7.1\")\n\nAlso next line strncpy usage replaced with strlcpy while arround.\n\nFixes: c3698192940c (\"kni: fix build with gcc 7.1\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nv2:\n* used strlcpy instead of strncpy\n* Updated strncpy usage in next line to strlcpy too\n* Added fixes line\n---\n kernel/linux/kni/ethtool/igb/igb_ethtool.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)\n\n2.17.1", "diff": "diff --git a/kernel/linux/kni/ethtool/igb/igb_ethtool.c\nb/kernel/linux/kni/ethtool/igb/igb_ethtool.c\nindex 064528bcf..002f75c48 100644\n--- a/kernel/linux/kni/ethtool/igb/igb_ethtool.c\n+++ b/kernel/linux/kni/ethtool/igb/igb_ethtool.c\n@@ -811,9 +811,10 @@ static void igb_get_drvinfo(struct net_device *netdev,\n \tstrncpy(drvinfo->driver, igb_driver_name, sizeof(drvinfo->driver) - 1);\n \tstrncpy(drvinfo->version, igb_driver_version, sizeof(drvinfo->version) - 1);\n -\tstrncpy(drvinfo->fw_version, adapter->fw_version,\n-\t\tsizeof(drvinfo->fw_version) - 1);\n-\tstrncpy(drvinfo->bus_info, pci_name(adapter->pdev), sizeof(drvinfo->bus_info) -1);\n+\tstrlcpy(drvinfo->fw_version, adapter->fw_version,\n+\t\tsizeof(drvinfo->fw_version));\n+\tstrlcpy(drvinfo->bus_info, pci_name(adapter->pdev),\n+\t\tsizeof(drvinfo->bus_info));\n \tdrvinfo->n_stats = IGB_STATS_LEN;\n \tdrvinfo->testinfo_len = IGB_TEST_LEN;\n \tdrvinfo->regdump_len = igb_get_regs_len(netdev);\n-- \n", "prefixes": [ "v2" ] }