Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41534/?format=api
{ "id": 41534, "url": "http://patches.dpdk.org/api/patches/41534/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530001064-32174-3-git-send-email-tomaszx.jozwiak@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530001064-32174-3-git-send-email-tomaszx.jozwiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530001064-32174-3-git-send-email-tomaszx.jozwiak@intel.com", "date": "2018-06-26T08:17:43", "name": "[v3,2/3] crypto/qat: re-organise build file content", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a0b08acab7025fe84a7b47e804d40ac7f8195574", "submitter": { "id": 949, "url": "http://patches.dpdk.org/api/people/949/?format=api", "name": "Tomasz Jozwiak", "email": "tomaszx.jozwiak@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530001064-32174-3-git-send-email-tomaszx.jozwiak@intel.com/mbox/", "series": [ { "id": 231, "url": "http://patches.dpdk.org/api/series/231/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=231", "date": "2018-06-26T08:15:53", "name": "crypto/qat: move files to drivers/common directory", "version": 3, "mbox": "http://patches.dpdk.org/series/231/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41534/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/41534/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3B3D41B05F;\n\tTue, 26 Jun 2018 10:17:56 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 2F96F1B04F\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 10:17:52 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 01:17:50 -0700", "from tjozwiax-mobl.ger.corp.intel.com (HELO localhost.localdomain)\n\t([10.103.104.42])\n\tby orsmga002.jf.intel.com with ESMTP; 26 Jun 2018 01:17:48 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"70055345\"", "From": "Tomasz Jozwiak <tomaszx.jozwiak@intel.com>", "To": "fiona.trahe@intel.com,\n\ttomaszx.jozwiak@intel.com,\n\tdev@dpdk.org", "Date": "Tue, 26 Jun 2018 10:17:43 +0200", "Message-Id": "<1530001064-32174-3-git-send-email-tomaszx.jozwiak@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530001064-32174-1-git-send-email-tomaszx.jozwiak@intel.com>", "References": "<1526971901-9281-1-git-send-email-tomaszx.jozwiak@intel.com>\n\t<1530001064-32174-1-git-send-email-tomaszx.jozwiak@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 2/3] crypto/qat: re-organise build file content", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch groups sources and related dependencies into\ncommon and sym sections in build files.\n\nSigned-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>\nAcked-by: Fiona Trahe <fiona.trahe@intel.com>\n---\n drivers/crypto/qat/Makefile | 25 ++++++++++++++-----------\n drivers/crypto/qat/meson.build | 14 ++++++++------\n drivers/crypto/qat/qat_sym.h | 2 +-\n drivers/crypto/qat/qat_sym_pmd.h | 3 +--\n 4 files changed, 24 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/Makefile b/drivers/crypto/qat/Makefile\nindex 64f39fd..a939eca 100644\n--- a/drivers/crypto/qat/Makefile\n+++ b/drivers/crypto/qat/Makefile\n@@ -15,19 +15,22 @@ CFLAGS += -O3\n \n # external library include paths\n CFLAGS += -I$(SRCDIR)/qat_adf\n-LDLIBS += -lcrypto\n-LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring\n+\n+# library common source files\n+SRCS-y += qat_device.c\n+SRCS-y += qat_common.c\n+SRCS-y += qat_logs.c\n+SRCS-y += qat_qp.c\n+\n+# library symetric crypto source files\n LDLIBS += -lrte_cryptodev\n-LDLIBS += -lrte_pci -lrte_bus_pci\n+LDLIBS += -lcrypto\n+SRCS-y += qat_sym.c\n+SRCS-y += qat_sym_session.c\n+SRCS-y += qat_sym_pmd.c\n \n-# library source files\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_sym.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_device.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_qp.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_sym_session.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_common.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_logs.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_sym_pmd.c\n+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool\n+LDLIBS += -lrte_pci -lrte_bus_pci\n \n # export include files\n SYMLINK-y-include +=\ndiff --git a/drivers/crypto/qat/meson.build b/drivers/crypto/qat/meson.build\nindex 6d01dac..db4af2c 100644\n--- a/drivers/crypto/qat/meson.build\n+++ b/drivers/crypto/qat/meson.build\n@@ -2,15 +2,17 @@\n # Copyright(c) 2017-2018 Intel Corporation\n \n dep = dependency('libcrypto', required: false)\n-if not dep.found()\n-\tbuild = false\n-endif\n+\n sources = files('qat_common.c',\n \t\t'qat_qp.c',\n \t\t'qat_device.c',\n-\t\t'qat_logs.c',\n-\t\t'qat_sym_pmd.c', 'qat_sym.c', 'qat_sym_session.c')\n+\t\t'qat_logs.c')\n+\n+if dep.found()\n+\tsources += files('qat_sym_pmd.c', 'qat_sym.c', 'qat_sym_session.c')\n+\tpkgconfig_extra_libs += '-lcrypto'\n+endif\n+\n includes += include_directories('qat_adf')\n deps += ['bus_pci']\n ext_deps += dep\n-pkgconfig_extra_libs += '-lcrypto'\ndiff --git a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h\nindex f9e72a6..126c191 100644\n--- a/drivers/crypto/qat/qat_sym.h\n+++ b/drivers/crypto/qat/qat_sym.h\n@@ -6,7 +6,6 @@\n #define _QAT_SYM_H_\n \n #include <rte_cryptodev_pmd.h>\n-\n #include <openssl/evp.h>\n \n #include \"qat_common.h\"\n@@ -153,4 +152,5 @@ qat_sym_process_response(void **op, uint8_t *resp)\n \t}\n \t*op = (void *)rx_op;\n }\n+\n #endif /* _QAT_SYM_H_ */\ndiff --git a/drivers/crypto/qat/qat_sym_pmd.h b/drivers/crypto/qat/qat_sym_pmd.h\nindex 80a1987..1e2344c 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.h\n+++ b/drivers/crypto/qat/qat_sym_pmd.h\n@@ -10,7 +10,6 @@\n #include \"qat_sym_capabilities.h\"\n #include \"qat_device.h\"\n \n-\n /**< Intel(R) QAT Symmetric Crypto PMD device name */\n #define CRYPTODEV_NAME_QAT_SYM_PMD\tcrypto_qat\n #define QAT_SYM_PMD_MAX_NB_SESSIONS\t2048\n@@ -31,10 +30,10 @@ struct qat_sym_dev_private {\n \t/* QAT device symmetric crypto capabilities */\n };\n \n-\n int\n qat_sym_dev_create(struct qat_pci_device *qat_pci_dev);\n \n int\n qat_sym_dev_destroy(struct qat_pci_device *qat_pci_dev);\n+\n #endif /* _QAT_SYM_PMD_H_ */\n", "prefixes": [ "v3", "2/3" ] }