Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41533/?format=api
{ "id": 41533, "url": "http://patches.dpdk.org/api/patches/41533/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530001064-32174-2-git-send-email-tomaszx.jozwiak@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530001064-32174-2-git-send-email-tomaszx.jozwiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530001064-32174-2-git-send-email-tomaszx.jozwiak@intel.com", "date": "2018-06-26T08:17:42", "name": "[v3,1/3] crypto/qat: add weak functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "16f83e908d3d0a66a5742c9a8f4991ff8403cf93", "submitter": { "id": 949, "url": "http://patches.dpdk.org/api/people/949/?format=api", "name": "Tomasz Jozwiak", "email": "tomaszx.jozwiak@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530001064-32174-2-git-send-email-tomaszx.jozwiak@intel.com/mbox/", "series": [ { "id": 231, "url": "http://patches.dpdk.org/api/series/231/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=231", "date": "2018-06-26T08:15:53", "name": "crypto/qat: move files to drivers/common directory", "version": 3, "mbox": "http://patches.dpdk.org/series/231/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41533/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41533/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 664CB1B059;\n\tTue, 26 Jun 2018 10:17:54 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id B64F68E60\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 10:17:51 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 01:17:48 -0700", "from tjozwiax-mobl.ger.corp.intel.com (HELO localhost.localdomain)\n\t([10.103.104.42])\n\tby orsmga002.jf.intel.com with ESMTP; 26 Jun 2018 01:17:47 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"70055339\"", "From": "Tomasz Jozwiak <tomaszx.jozwiak@intel.com>", "To": "fiona.trahe@intel.com,\n\ttomaszx.jozwiak@intel.com,\n\tdev@dpdk.org", "Date": "Tue, 26 Jun 2018 10:17:42 +0200", "Message-Id": "<1530001064-32174-2-git-send-email-tomaszx.jozwiak@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530001064-32174-1-git-send-email-tomaszx.jozwiak@intel.com>", "References": "<1526971901-9281-1-git-send-email-tomaszx.jozwiak@intel.com>\n\t<1530001064-32174-1-git-send-email-tomaszx.jozwiak@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 1/3] crypto/qat: add weak functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds following weak functions to facilitate conditional\ncompilation of code for those services:\n - qat_sym_dev_create\n - qat_asym_dev_create\n - qat_comp_dev_create\n - qat_sym_dev_destroy\n - qat_asym_dev_destroy\n - qat_comp_dev_destroy\nand removes unused files with empty definitions of above functions.\n\nSigned-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>\nAcked-by: Fiona Trahe <fiona.trahe@intel.com>\n---\n drivers/crypto/qat/Makefile | 2 --\n drivers/crypto/qat/meson.build | 4 +---\n drivers/crypto/qat/qat_asym_pmd.c | 17 -----------------\n drivers/crypto/qat/qat_asym_pmd.h | 15 ---------------\n drivers/crypto/qat/qat_comp_pmd.c | 18 ------------------\n drivers/crypto/qat/qat_comp_pmd.h | 29 -----------------------------\n drivers/crypto/qat/qat_device.c | 39 +++++++++++++++++++++++++++++++++++++--\n drivers/crypto/qat/qat_device.h | 20 ++++++++++++++++++++\n 8 files changed, 58 insertions(+), 86 deletions(-)\n delete mode 100644 drivers/crypto/qat/qat_asym_pmd.c\n delete mode 100644 drivers/crypto/qat/qat_asym_pmd.h\n delete mode 100644 drivers/crypto/qat/qat_comp_pmd.c\n delete mode 100644 drivers/crypto/qat/qat_comp_pmd.h", "diff": "diff --git a/drivers/crypto/qat/Makefile b/drivers/crypto/qat/Makefile\nindex ef4a567..64f39fd 100644\n--- a/drivers/crypto/qat/Makefile\n+++ b/drivers/crypto/qat/Makefile\n@@ -28,8 +28,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_sym_session.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_common.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_logs.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_sym_pmd.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_asym_pmd.c\n-SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_comp_pmd.c\n \n # export include files\n SYMLINK-y-include +=\ndiff --git a/drivers/crypto/qat/meson.build b/drivers/crypto/qat/meson.build\nindex bcab16e..6d01dac 100644\n--- a/drivers/crypto/qat/meson.build\n+++ b/drivers/crypto/qat/meson.build\n@@ -9,9 +9,7 @@ sources = files('qat_common.c',\n \t\t'qat_qp.c',\n \t\t'qat_device.c',\n \t\t'qat_logs.c',\n-\t\t'qat_sym_pmd.c', 'qat_sym.c', 'qat_sym_session.c',\n-\t\t'qat_asym_pmd.c',\n-\t\t'qat_comp_pmd.c')\n+\t\t'qat_sym_pmd.c', 'qat_sym.c', 'qat_sym_session.c')\n includes += include_directories('qat_adf')\n deps += ['bus_pci']\n ext_deps += dep\ndiff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/qat_asym_pmd.c\ndeleted file mode 100644\nindex 8d36300..0000000\n--- a/drivers/crypto/qat/qat_asym_pmd.c\n+++ /dev/null\n@@ -1,17 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2018 Intel Corporation\n- */\n-\n-#include \"qat_asym_pmd.h\"\n-\n-int\n-qat_asym_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused)\n-{\n-\treturn 0;\n-}\n-\n-int\n-qat_asym_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)\n-{\n-\treturn 0;\n-}\ndiff --git a/drivers/crypto/qat/qat_asym_pmd.h b/drivers/crypto/qat/qat_asym_pmd.h\ndeleted file mode 100644\nindex 0465e03..0000000\n--- a/drivers/crypto/qat/qat_asym_pmd.h\n+++ /dev/null\n@@ -1,15 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2018 Intel Corporation\n- */\n-\n-#ifndef _QAT_ASYM_PMD_H_\n-#define _QAT_ASYM_PMD_H_\n-\n-#include \"qat_device.h\"\n-\n-int\n-qat_asym_dev_create(struct qat_pci_device *qat_pci_dev);\n-\n-int\n-qat_asym_dev_destroy(struct qat_pci_device *qat_pci_dev);\n-#endif /* _QAT_ASYM_PMD_H_ */\ndiff --git a/drivers/crypto/qat/qat_comp_pmd.c b/drivers/crypto/qat/qat_comp_pmd.c\ndeleted file mode 100644\nindex 547b3db..0000000\n--- a/drivers/crypto/qat/qat_comp_pmd.c\n+++ /dev/null\n@@ -1,18 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2018 Intel Corporation\n- */\n-\n-#include \"qat_comp_pmd.h\"\n-\n-\n-int\n-qat_comp_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused)\n-{\n-\treturn 0;\n-}\n-\n-int\n-qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)\n-{\n-\treturn 0;\n-}\ndiff --git a/drivers/crypto/qat/qat_comp_pmd.h b/drivers/crypto/qat/qat_comp_pmd.h\ndeleted file mode 100644\nindex cc31246..0000000\n--- a/drivers/crypto/qat/qat_comp_pmd.h\n+++ /dev/null\n@@ -1,29 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2018 Intel Corporation\n- */\n-\n-#ifndef _QAT_COMP_PMD_H_\n-#define _QAT_COMP_PMD_H_\n-\n-#include \"qat_device.h\"\n-\n-\n-/**< Intel(R) QAT Compression PMD device name */\n-#define COMPRESSDEV_NAME_QAT_PMD\tcomp_qat\n-\n-\n-/** private data structure for a QAT compression device.\n- * This QAT device is a device offering only a compression service,\n- * there can be one of these on each qat_pci_device (VF).\n- */\n-struct qat_comp_dev_private {\n-\tstruct qat_pci_device *qat_dev;\n-\t/**< The qat pci device hosting the service */\n-};\n-\n-int\n-qat_comp_dev_create(struct qat_pci_device *qat_pci_dev);\n-\n-int\n-qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev);\n-#endif /* _QAT_COMP_PMD_H_ */\ndiff --git a/drivers/crypto/qat/qat_device.c b/drivers/crypto/qat/qat_device.c\nindex 4b97c84..64f236e 100644\n--- a/drivers/crypto/qat/qat_device.c\n+++ b/drivers/crypto/qat/qat_device.c\n@@ -5,8 +5,6 @@\n #include \"qat_device.h\"\n #include \"adf_transport_access_macros.h\"\n #include \"qat_sym_pmd.h\"\n-#include \"qat_asym_pmd.h\"\n-#include \"qat_comp_pmd.h\"\n \n /* Hardware device information per generation */\n __extension__\n@@ -238,5 +236,42 @@ static struct rte_pci_driver rte_qat_pmd = {\n \t.probe = qat_pci_probe,\n \t.remove = qat_pci_remove\n };\n+\n+__attribute__((weak)) int\n+qat_sym_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+__attribute__((weak)) int\n+qat_asym_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+__attribute__((weak)) int\n+qat_sym_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+__attribute__((weak)) int\n+qat_asym_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+__attribute__((weak)) int\n+qat_comp_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+__attribute__((weak)) int\n+qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n RTE_PMD_REGISTER_PCI(QAT_PCI_NAME, rte_qat_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(QAT_PCI_NAME, pci_id_qat_map);\ndiff --git a/drivers/crypto/qat/qat_device.h b/drivers/crypto/qat/qat_device.h\nindex e18c8a7..0cb370c 100644\n--- a/drivers/crypto/qat/qat_device.h\n+++ b/drivers/crypto/qat/qat_device.h\n@@ -69,10 +69,30 @@ extern struct qat_gen_hw_data qat_gen_config[];\n \n struct qat_pci_device *\n qat_pci_device_allocate(struct rte_pci_device *pci_dev);\n+\n int\n qat_pci_device_release(struct rte_pci_device *pci_dev);\n+\n struct qat_pci_device *\n qat_get_qat_dev_from_pci_dev(struct rte_pci_device *pci_dev);\n \n+/* declaration needed for weak functions */\n+int\n+qat_sym_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused);\n+\n+int\n+qat_asym_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused);\n+\n+int\n+qat_sym_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused);\n+\n+int\n+qat_asym_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused);\n+\n+int\n+qat_comp_dev_create(struct qat_pci_device *qat_pci_dev __rte_unused);\n+\n+int\n+qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused);\n \n #endif /* _QAT_DEVICE_H_ */\n", "prefixes": [ "v3", "1/3" ] }