Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41516/?format=api
{ "id": 41516, "url": "http://patches.dpdk.org/api/patches/41516/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180626070832.3055-10-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180626070832.3055-10-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180626070832.3055-10-qi.z.zhang@intel.com", "date": "2018-06-26T07:08:17", "name": "[v4,09/24] net/i40e: enable port detach on secondary process", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "59856376656db3a0924a5067972adf6c1d14a7af", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180626070832.3055-10-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 230, "url": "http://patches.dpdk.org/api/series/230/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=230", "date": "2018-06-26T07:08:08", "name": "enable hotplug on multi-process", "version": 4, "mbox": "http://patches.dpdk.org/series/230/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41516/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B0DA5F11;\n\tTue, 26 Jun 2018 09:08:30 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 5716458C4\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 09:08:15 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 00:08:15 -0700", "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby fmsmga006.fm.intel.com with ESMTP; 26 Jun 2018 00:08:13 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,273,1526367600\"; d=\"scan'208\";a=\"240660011\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "thomas@monjalon.net,\n\tanatoly.burakov@intel.com", "Cc": "konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, \n\tferruh.yigit@intel.com, benjamin.h.shelton@intel.com,\n\tnarender.vangati@intel.com, Qi Zhang <qi.z.zhang@intel.com>", "Date": "Tue, 26 Jun 2018 15:08:17 +0800", "Message-Id": "<20180626070832.3055-10-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180626070832.3055-1-qi.z.zhang@intel.com>", "References": "<20180607123849.14439-1-qi.z.zhang@intel.com>\n\t<20180626070832.3055-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 09/24] net/i40e: enable port detach on\n\tsecondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previously, detach port on secondary process will mess primary\nprocess and cause same device can't be attached again, by take\nadvantage of rte_eth_release_port_private, we can support this\nwith minor change.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 2 ++\n drivers/net/i40e/i40e_ethdev_vf.c | 9 +++++++++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 13c5d3296..7d1f98422 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -678,6 +678,8 @@ static int eth_i40e_pci_remove(struct rte_pci_device *pci_dev)\n \tif (!ethdev)\n \t\treturn -ENODEV;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn rte_eth_dev_release_port_private(ethdev);\n \n \tif (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n \t\treturn rte_eth_dev_destroy(ethdev, i40e_vf_representor_uninit);\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 804e44530..fc6f079d5 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1500,6 +1500,15 @@ static int eth_i40evf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \n static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)\n {\n+\tstruct rte_eth_dev *ethdev;\n+\t\tethdev = rte_eth_dev_allocated(pci_dev->device.name);\n+\n+\tif (!ethdev)\n+\t\treturn -ENODEV;\n+\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn rte_eth_dev_release_port_private(ethdev);\n+\n \treturn rte_eth_dev_pci_generic_remove(pci_dev, i40evf_dev_uninit);\n }\n \n", "prefixes": [ "v4", "09/24" ] }