Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41499/?format=api
{ "id": 41499, "url": "http://patches.dpdk.org/api/patches/41499/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180625084856.25205-12-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180625084856.25205-12-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180625084856.25205-12-pablo.de.lara.guarch@intel.com", "date": "2018-06-25T08:48:52", "name": "[v2,11/15] cryptodev: remove queue start/stop functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9e0be020cfaa55d748c5dbd5f90a66b6a72d6101", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180625084856.25205-12-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 226, "url": "http://patches.dpdk.org/api/series/226/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=226", "date": "2018-06-25T08:48:41", "name": "Cryptodev API changes for 18.08", "version": 2, "mbox": "http://patches.dpdk.org/series/226/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41499/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41499/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0A5B75B40;\n\tMon, 25 Jun 2018 18:55:17 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id C2E6B5920\n\tfor <dev@dpdk.org>; Mon, 25 Jun 2018 18:55:07 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2018 09:55:07 -0700", "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby fmsmga004.fm.intel.com with ESMTP; 25 Jun 2018 09:55:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,270,1526367600\"; d=\"scan'208\";a=\"66194025\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com, akhil.goyal@nxp.com,\n\tshally.verma@caviumnetworks.com, ravi1.kumar@amd.com,\n\tjerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com,\n\tfiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Mon, 25 Jun 2018 09:48:52 +0100", "Message-Id": "<20180625084856.25205-12-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.14.4", "In-Reply-To": "<20180625084856.25205-1-pablo.de.lara.guarch@intel.com>", "References": "<20180608220234.10170-1-pablo.de.lara.guarch@intel.com>\n\t<20180625084856.25205-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 11/15] cryptodev: remove queue start/stop\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Removed cryptodev queue start/stop functions,\nas they were marked deprecated in 18.05, since they\nwere not implemented by any driver.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nAcked-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n doc/guides/rel_notes/deprecation.rst | 4 ---\n doc/guides/rel_notes/release_18_08.rst | 5 +++\n drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 18 -----------\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 18 -----------\n drivers/crypto/armv8/rte_armv8_pmd_ops.c | 18 -----------\n drivers/crypto/ccp/ccp_pmd_ops.c | 16 ----------\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 22 -------------\n drivers/crypto/dpaa_sec/dpaa_sec.c | 22 -------------\n drivers/crypto/kasumi/rte_kasumi_pmd_ops.c | 18 -----------\n drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 28 ----------------\n drivers/crypto/null/null_crypto_pmd_ops.c | 18 -----------\n drivers/crypto/openssl/rte_openssl_pmd_ops.c | 18 -----------\n drivers/crypto/qat/qat_sym_pmd.c | 2 --\n drivers/crypto/scheduler/scheduler_pmd_ops.c | 18 -----------\n drivers/crypto/snow3g/rte_snow3g_pmd_ops.c | 18 -----------\n drivers/crypto/virtio/virtio_cryptodev.c | 2 --\n drivers/crypto/zuc/rte_zuc_pmd_ops.c | 18 -----------\n lib/librte_cryptodev/rte_cryptodev.c | 44 --------------------------\n lib/librte_cryptodev/rte_cryptodev.h | 37 ----------------------\n lib/librte_cryptodev/rte_cryptodev_pmd.h | 26 ---------------\n lib/librte_cryptodev/rte_cryptodev_version.map | 2 --\n 21 files changed, 5 insertions(+), 367 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex dc014da21..91592534e 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -105,10 +105,6 @@ Deprecation Notices\n ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from\n 18.05 and removed in 18.08, as there are no drivers doing anything useful\n with them.\n- - Functions ``rte_cryptodev_queue_pair_start()`` and\n- ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.05\n- and removed in 18.08, as there are no drivers doing anything useful\n- with them.\n - Some feature flags such as ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` are ambiguous,\n so some will be replaced by more explicit flags.\n - Function ``rte_cryptodev_get_header_session_size()`` will be deprecated\ndiff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst\nindex 2b994ee78..cfb2885a1 100644\n--- a/doc/guides/rel_notes/release_18_08.rst\n+++ b/doc/guides/rel_notes/release_18_08.rst\n@@ -65,6 +65,11 @@ API Changes\n Value 0 is accepted in ``sym.max_nb_sessions``, meaning that a device\n supports an unlimited number of sessions.\n \n+* cryptodev: Following functions were deprecated and are removed in 18.08:\n+\n+ - ``rte_cryptodev_queue_pair_start``\n+ - ``rte_cryptodev_queue_pair_stop``\n+\n \n ABI Changes\n -----------\ndiff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c\nindex 796ccdbd8..e24453a7e 100644\n--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c\n+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c\n@@ -243,22 +243,6 @@ aesni_gcm_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair */\n-static int\n-aesni_gcm_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-aesni_gcm_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n aesni_gcm_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -340,8 +324,6 @@ struct rte_cryptodev_ops aesni_gcm_pmd_ops = {\n \n \t\t.queue_pair_setup\t= aesni_gcm_pmd_qp_setup,\n \t\t.queue_pair_release\t= aesni_gcm_pmd_qp_release,\n-\t\t.queue_pair_start\t= aesni_gcm_pmd_qp_start,\n-\t\t.queue_pair_stop\t= aesni_gcm_pmd_qp_stop,\n \t\t.queue_pair_count\t= aesni_gcm_pmd_qp_count,\n \n \t\t.session_get_size\t= aesni_gcm_pmd_session_get_size,\ndiff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\nindex 101fdc5c6..6eb37a5bf 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\n@@ -509,22 +509,6 @@ aesni_mb_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair */\n-static int\n-aesni_mb_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-aesni_mb_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n aesni_mb_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -607,8 +591,6 @@ struct rte_cryptodev_ops aesni_mb_pmd_ops = {\n \n \t\t.queue_pair_setup\t= aesni_mb_pmd_qp_setup,\n \t\t.queue_pair_release\t= aesni_mb_pmd_qp_release,\n-\t\t.queue_pair_start\t= aesni_mb_pmd_qp_start,\n-\t\t.queue_pair_stop\t= aesni_mb_pmd_qp_stop,\n \t\t.queue_pair_count\t= aesni_mb_pmd_qp_count,\n \n \t\t.session_get_size\t= aesni_mb_pmd_session_get_size,\ndiff --git a/drivers/crypto/armv8/rte_armv8_pmd_ops.c b/drivers/crypto/armv8/rte_armv8_pmd_ops.c\nindex b654f7528..5e8a5a292 100644\n--- a/drivers/crypto/armv8/rte_armv8_pmd_ops.c\n+++ b/drivers/crypto/armv8/rte_armv8_pmd_ops.c\n@@ -258,22 +258,6 @@ armv8_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair */\n-static int\n-armv8_crypto_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-armv8_crypto_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n armv8_crypto_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -354,8 +338,6 @@ struct rte_cryptodev_ops armv8_crypto_pmd_ops = {\n \n \t\t.queue_pair_setup\t= armv8_crypto_pmd_qp_setup,\n \t\t.queue_pair_release\t= armv8_crypto_pmd_qp_release,\n-\t\t.queue_pair_start\t= armv8_crypto_pmd_qp_start,\n-\t\t.queue_pair_stop\t= armv8_crypto_pmd_qp_stop,\n \t\t.queue_pair_count\t= armv8_crypto_pmd_qp_count,\n \n \t\t.session_get_size\t= armv8_crypto_pmd_session_get_size,\ndiff --git a/drivers/crypto/ccp/ccp_pmd_ops.c b/drivers/crypto/ccp/ccp_pmd_ops.c\nindex dbe545c10..1cb944406 100644\n--- a/drivers/crypto/ccp/ccp_pmd_ops.c\n+++ b/drivers/crypto/ccp/ccp_pmd_ops.c\n@@ -748,20 +748,6 @@ ccp_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-static int\n-ccp_pmd_qp_start(struct rte_cryptodev *dev __rte_unused,\n-\t\t uint16_t queue_pair_id __rte_unused)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-static int\n-ccp_pmd_qp_stop(struct rte_cryptodev *dev __rte_unused,\n-\t\tuint16_t queue_pair_id __rte_unused)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n static uint32_t\n ccp_pmd_qp_count(struct rte_cryptodev *dev)\n {\n@@ -837,8 +823,6 @@ struct rte_cryptodev_ops ccp_ops = {\n \n \t\t.queue_pair_setup\t= ccp_pmd_qp_setup,\n \t\t.queue_pair_release\t= ccp_pmd_qp_release,\n-\t\t.queue_pair_start\t= ccp_pmd_qp_start,\n-\t\t.queue_pair_stop\t= ccp_pmd_qp_stop,\n \t\t.queue_pair_count\t= ccp_pmd_qp_count,\n \n \t\t.session_get_size\t= ccp_pmd_session_get_size,\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex bc091c560..1b1c30d85 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -1470,26 +1470,6 @@ dpaa2_sec_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn retcode;\n }\n \n-/** Start queue pair */\n-static int\n-dpaa2_sec_queue_pair_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t\t __rte_unused uint16_t queue_pair_id)\n-{\n-\tPMD_INIT_FUNC_TRACE();\n-\n-\treturn 0;\n-}\n-\n-/** Stop queue pair */\n-static int\n-dpaa2_sec_queue_pair_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t\t __rte_unused uint16_t queue_pair_id)\n-{\n-\tPMD_INIT_FUNC_TRACE();\n-\n-\treturn 0;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n dpaa2_sec_queue_pair_count(struct rte_cryptodev *dev)\n@@ -2716,8 +2696,6 @@ static struct rte_cryptodev_ops crypto_ops = {\n \t.stats_reset\t = dpaa2_sec_stats_reset,\n \t.queue_pair_setup = dpaa2_sec_queue_pair_setup,\n \t.queue_pair_release = dpaa2_sec_queue_pair_release,\n-\t.queue_pair_start = dpaa2_sec_queue_pair_start,\n-\t.queue_pair_stop = dpaa2_sec_queue_pair_stop,\n \t.queue_pair_count = dpaa2_sec_queue_pair_count,\n \t.session_get_size = dpaa2_sec_session_get_size,\n \t.session_configure = dpaa2_sec_session_configure,\ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex 73cae483b..b96552c57 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -1585,26 +1585,6 @@ dpaa_sec_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn 0;\n }\n \n-/** Start queue pair */\n-static int\n-dpaa_sec_queue_pair_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t\t __rte_unused uint16_t queue_pair_id)\n-{\n-\tPMD_INIT_FUNC_TRACE();\n-\n-\treturn 0;\n-}\n-\n-/** Stop queue pair */\n-static int\n-dpaa_sec_queue_pair_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t\t __rte_unused uint16_t queue_pair_id)\n-{\n-\tPMD_INIT_FUNC_TRACE();\n-\n-\treturn 0;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n dpaa_sec_queue_pair_count(struct rte_cryptodev *dev)\n@@ -2227,8 +2207,6 @@ static struct rte_cryptodev_ops crypto_ops = {\n \t.dev_infos_get = dpaa_sec_dev_infos_get,\n \t.queue_pair_setup = dpaa_sec_queue_pair_setup,\n \t.queue_pair_release = dpaa_sec_queue_pair_release,\n-\t.queue_pair_start = dpaa_sec_queue_pair_start,\n-\t.queue_pair_stop = dpaa_sec_queue_pair_stop,\n \t.queue_pair_count = dpaa_sec_queue_pair_count,\n \t.session_get_size = dpaa_sec_session_get_size,\n \t.session_configure = dpaa_sec_session_configure,\ndiff --git a/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c b/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c\nindex e72f2ae0b..4174f1f80 100644\n--- a/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c\n+++ b/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c\n@@ -229,22 +229,6 @@ kasumi_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair */\n-static int\n-kasumi_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-kasumi_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n kasumi_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -325,8 +309,6 @@ struct rte_cryptodev_ops kasumi_pmd_ops = {\n \n \t\t.queue_pair_setup = kasumi_pmd_qp_setup,\n \t\t.queue_pair_release = kasumi_pmd_qp_release,\n-\t\t.queue_pair_start = kasumi_pmd_qp_start,\n-\t\t.queue_pair_stop = kasumi_pmd_qp_stop,\n \t\t.queue_pair_count = kasumi_pmd_qp_count,\n \n \t\t.session_get_size = kasumi_pmd_session_get_size,\ndiff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c\nindex 07850098b..8710ba3b7 100644\n--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c\n+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c\n@@ -596,32 +596,6 @@ mrvl_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair (PMD ops callback) - not supported.\n- *\n- * @param dev Pointer to the device structure.\n- * @param qp_id ID of the Queue Pair.\n- * @returns -ENOTSUP. Always.\n- */\n-static int\n-mrvl_crypto_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair (PMD ops callback) - not supported.\n- *\n- * @param dev Pointer to the device structure.\n- * @param qp_id ID of the Queue Pair.\n- * @returns -ENOTSUP. Always.\n- */\n-static int\n-mrvl_crypto_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs (PMD ops callback).\n *\n * @param dev Pointer to the device structure.\n@@ -739,8 +713,6 @@ static struct rte_cryptodev_ops mrvl_crypto_pmd_ops = {\n \n \t\t.queue_pair_setup\t= mrvl_crypto_pmd_qp_setup,\n \t\t.queue_pair_release\t= mrvl_crypto_pmd_qp_release,\n-\t\t.queue_pair_start\t= mrvl_crypto_pmd_qp_start,\n-\t\t.queue_pair_stop\t= mrvl_crypto_pmd_qp_stop,\n \t\t.queue_pair_count\t= mrvl_crypto_pmd_qp_count,\n \n \t\t.session_get_size\t= mrvl_crypto_pmd_session_get_size,\ndiff --git a/drivers/crypto/null/null_crypto_pmd_ops.c b/drivers/crypto/null/null_crypto_pmd_ops.c\nindex 2842498af..e43fba7db 100644\n--- a/drivers/crypto/null/null_crypto_pmd_ops.c\n+++ b/drivers/crypto/null/null_crypto_pmd_ops.c\n@@ -240,22 +240,6 @@ null_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair */\n-static int\n-null_crypto_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-null_crypto_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n null_crypto_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -336,8 +320,6 @@ struct rte_cryptodev_ops pmd_ops = {\n \n \t\t.queue_pair_setup\t= null_crypto_pmd_qp_setup,\n \t\t.queue_pair_release\t= null_crypto_pmd_qp_release,\n-\t\t.queue_pair_start\t= null_crypto_pmd_qp_start,\n-\t\t.queue_pair_stop\t= null_crypto_pmd_qp_stop,\n \t\t.queue_pair_count\t= null_crypto_pmd_qp_count,\n \n \t\t.session_get_size\t= null_crypto_pmd_session_get_size,\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\nindex d194e3657..554177d20 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n@@ -648,22 +648,6 @@ openssl_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair */\n-static int\n-openssl_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-openssl_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n openssl_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -746,8 +730,6 @@ struct rte_cryptodev_ops openssl_pmd_ops = {\n \n \t\t.queue_pair_setup\t= openssl_pmd_qp_setup,\n \t\t.queue_pair_release\t= openssl_pmd_qp_release,\n-\t\t.queue_pair_start\t= openssl_pmd_qp_start,\n-\t\t.queue_pair_stop\t= openssl_pmd_qp_stop,\n \t\t.queue_pair_count\t= openssl_pmd_qp_count,\n \n \t\t.session_get_size\t= openssl_pmd_session_get_size,\ndiff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c\nindex 84dd5bec8..ee8633b85 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.c\n+++ b/drivers/crypto/qat/qat_sym_pmd.c\n@@ -202,8 +202,6 @@ static struct rte_cryptodev_ops crypto_qat_ops = {\n \t\t.stats_reset\t\t= qat_sym_stats_reset,\n \t\t.queue_pair_setup\t= qat_sym_qp_setup,\n \t\t.queue_pair_release\t= qat_sym_qp_release,\n-\t\t.queue_pair_start\t= NULL,\n-\t\t.queue_pair_stop\t= NULL,\n \t\t.queue_pair_count\t= NULL,\n \n \t\t/* Crypto related operations */\ndiff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c b/drivers/crypto/scheduler/scheduler_pmd_ops.c\nindex 16a8021c8..f363e3257 100644\n--- a/drivers/crypto/scheduler/scheduler_pmd_ops.c\n+++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c\n@@ -439,22 +439,6 @@ scheduler_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn 0;\n }\n \n-/** Start queue pair */\n-static int\n-scheduler_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-scheduler_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n scheduler_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -535,8 +519,6 @@ struct rte_cryptodev_ops scheduler_pmd_ops = {\n \n \t\t.queue_pair_setup\t= scheduler_pmd_qp_setup,\n \t\t.queue_pair_release\t= scheduler_pmd_qp_release,\n-\t\t.queue_pair_start\t= scheduler_pmd_qp_start,\n-\t\t.queue_pair_stop\t= scheduler_pmd_qp_stop,\n \t\t.queue_pair_count\t= scheduler_pmd_qp_count,\n \n \t\t.session_get_size\t= scheduler_pmd_session_get_size,\ndiff --git a/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c b/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c\nindex 6f8b9e2c6..fe882c366 100644\n--- a/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c\n+++ b/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c\n@@ -231,22 +231,6 @@ snow3g_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair */\n-static int\n-snow3g_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-snow3g_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n snow3g_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -327,8 +311,6 @@ struct rte_cryptodev_ops snow3g_pmd_ops = {\n \n \t\t.queue_pair_setup = snow3g_pmd_qp_setup,\n \t\t.queue_pair_release = snow3g_pmd_qp_release,\n-\t\t.queue_pair_start = snow3g_pmd_qp_start,\n-\t\t.queue_pair_stop = snow3g_pmd_qp_stop,\n \t\t.queue_pair_count = snow3g_pmd_qp_count,\n \n \t\t.session_get_size = snow3g_pmd_session_get_size,\ndiff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c\nindex 1da4ae871..0be435c8c 100644\n--- a/drivers/crypto/virtio/virtio_cryptodev.c\n+++ b/drivers/crypto/virtio/virtio_cryptodev.c\n@@ -515,8 +515,6 @@ static struct rte_cryptodev_ops virtio_crypto_dev_ops = {\n \n \t.queue_pair_setup = virtio_crypto_qp_setup,\n \t.queue_pair_release = virtio_crypto_qp_release,\n-\t.queue_pair_start = NULL,\n-\t.queue_pair_stop = NULL,\n \t.queue_pair_count = NULL,\n \n \t/* Crypto related operations */\ndiff --git a/drivers/crypto/zuc/rte_zuc_pmd_ops.c b/drivers/crypto/zuc/rte_zuc_pmd_ops.c\nindex b39e35b9f..79326d8f5 100644\n--- a/drivers/crypto/zuc/rte_zuc_pmd_ops.c\n+++ b/drivers/crypto/zuc/rte_zuc_pmd_ops.c\n@@ -231,22 +231,6 @@ zuc_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n-/** Start queue pair */\n-static int\n-zuc_pmd_qp_start(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n-/** Stop queue pair */\n-static int\n-zuc_pmd_qp_stop(__rte_unused struct rte_cryptodev *dev,\n-\t\t__rte_unused uint16_t queue_pair_id)\n-{\n-\treturn -ENOTSUP;\n-}\n-\n /** Return the number of allocated queue pairs */\n static uint32_t\n zuc_pmd_qp_count(struct rte_cryptodev *dev)\n@@ -327,8 +311,6 @@ struct rte_cryptodev_ops zuc_pmd_ops = {\n \n \t\t.queue_pair_setup = zuc_pmd_qp_setup,\n \t\t.queue_pair_release = zuc_pmd_qp_release,\n-\t\t.queue_pair_start = zuc_pmd_qp_start,\n-\t\t.queue_pair_stop = zuc_pmd_qp_stop,\n \t\t.queue_pair_count = zuc_pmd_qp_count,\n \n \t\t.session_get_size = zuc_pmd_session_get_size,\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 457ac5670..a07904fb9 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -702,50 +702,6 @@ rte_cryptodev_queue_pairs_config(struct rte_cryptodev *dev, uint16_t nb_qpairs,\n \treturn 0;\n }\n \n-int\n-rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id)\n-{\n-\tstruct rte_cryptodev *dev;\n-\n-\tif (!rte_cryptodev_pmd_is_valid_dev(dev_id)) {\n-\t\tCDEV_LOG_ERR(\"Invalid dev_id=%\" PRIu8, dev_id);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tdev = &rte_crypto_devices[dev_id];\n-\tif (queue_pair_id >= dev->data->nb_queue_pairs) {\n-\t\tCDEV_LOG_ERR(\"Invalid queue_pair_id=%d\", queue_pair_id);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_pair_start, -ENOTSUP);\n-\n-\treturn dev->dev_ops->queue_pair_start(dev, queue_pair_id);\n-\n-}\n-\n-int\n-rte_cryptodev_queue_pair_stop(uint8_t dev_id, uint16_t queue_pair_id)\n-{\n-\tstruct rte_cryptodev *dev;\n-\n-\tif (!rte_cryptodev_pmd_is_valid_dev(dev_id)) {\n-\t\tCDEV_LOG_ERR(\"Invalid dev_id=%\" PRIu8, dev_id);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tdev = &rte_crypto_devices[dev_id];\n-\tif (queue_pair_id >= dev->data->nb_queue_pairs) {\n-\t\tCDEV_LOG_ERR(\"Invalid queue_pair_id=%d\", queue_pair_id);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_pair_stop, -ENOTSUP);\n-\n-\treturn dev->dev_ops->queue_pair_stop(dev, queue_pair_id);\n-\n-}\n-\n int\n rte_cryptodev_configure(uint8_t dev_id, struct rte_cryptodev_config *config)\n {\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h\nindex 64ffbafca..0d994397d 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.h\n+++ b/lib/librte_cryptodev/rte_cryptodev.h\n@@ -601,43 +601,6 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,\n \t\tconst struct rte_cryptodev_qp_conf *qp_conf, int socket_id,\n \t\tstruct rte_mempool *session_pool);\n \n-/**\n- * @deprecated\n- * Start a specified queue pair of a device. It is used\n- * when deferred_start flag of the specified queue is true.\n- *\n- * @param\tdev_id\t\tThe identifier of the device\n- * @param\tqueue_pair_id\tThe index of the queue pair to start. The value\n- *\t\t\t\tmust be in the range [0, nb_queue_pair - 1]\n- *\t\t\t\tpreviously supplied to\n- *\t\t\t\trte_crypto_dev_configure().\n- * @return\n- * - 0: Success, the transmit queue is correctly set up.\n- * - -EINVAL: The dev_id or the queue_id out of range.\n- * - -ENOTSUP: The function not supported in PMD driver.\n- */\n-__rte_deprecated\n-extern int\n-rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);\n-\n-/**\n- * @deprecated\n- * Stop specified queue pair of a device\n- *\n- * @param\tdev_id\t\tThe identifier of the device\n- * @param\tqueue_pair_id\tThe index of the queue pair to stop. The value\n- *\t\t\t\tmust be in the range [0, nb_queue_pair - 1]\n- *\t\t\t\tpreviously supplied to\n- *\t\t\t\trte_cryptodev_configure().\n- * @return\n- * - 0: Success, the transmit queue is correctly set up.\n- * - -EINVAL: The dev_id or the queue_id out of range.\n- * - -ENOTSUP: The function not supported in PMD driver.\n- */\n-__rte_deprecated\n-extern int\n-rte_cryptodev_queue_pair_stop(uint8_t dev_id, uint16_t queue_pair_id);\n-\n /**\n * Get the number of queue pairs on a specific crypto device\n *\ndiff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h\nindex 0739ce065..b47730eaf 100644\n--- a/lib/librte_cryptodev/rte_cryptodev_pmd.h\n+++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h\n@@ -211,28 +211,6 @@ typedef void (*cryptodev_stats_reset_t)(struct rte_cryptodev *dev);\n typedef void (*cryptodev_info_get_t)(struct rte_cryptodev *dev,\n \t\t\t\tstruct rte_cryptodev_info *dev_info);\n \n-/**\n- * Start queue pair of a device.\n- *\n- * @param\tdev\tCrypto device pointer\n- * @param\tqp_id\tQueue Pair Index\n- *\n- * @return\tReturns 0 on success.\n- */\n-typedef int (*cryptodev_queue_pair_start_t)(struct rte_cryptodev *dev,\n-\t\t\t\tuint16_t qp_id);\n-\n-/**\n- * Stop queue pair of a device.\n- *\n- * @param\tdev\tCrypto device pointer\n- * @param\tqp_id\tQueue Pair Index\n- *\n- * @return\tReturns 0 on success.\n- */\n-typedef int (*cryptodev_queue_pair_stop_t)(struct rte_cryptodev *dev,\n-\t\t\t\tuint16_t qp_id);\n-\n /**\n * Setup a queue pair for a device.\n *\n@@ -371,10 +349,6 @@ struct rte_cryptodev_ops {\n \t/**< Set up a device queue pair. */\n \tcryptodev_queue_pair_release_t queue_pair_release;\n \t/**< Release a queue pair. */\n-\tcryptodev_queue_pair_start_t queue_pair_start;\n-\t/**< Start a queue pair. */\n-\tcryptodev_queue_pair_stop_t queue_pair_stop;\n-\t/**< Stop a queue pair. */\n \tcryptodev_queue_pair_count_t queue_pair_count;\n \t/**< Get count of the queue pairs. */\n \ndiff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map\nindex be8f4c1a7..020b45754 100644\n--- a/lib/librte_cryptodev/rte_cryptodev_version.map\n+++ b/lib/librte_cryptodev/rte_cryptodev_version.map\n@@ -22,8 +22,6 @@ DPDK_16.04 {\n \trte_cryptodev_stop;\n \trte_cryptodev_queue_pair_count;\n \trte_cryptodev_queue_pair_setup;\n-\trte_cryptodev_queue_pair_start;\n-\trte_cryptodev_queue_pair_stop;\n \trte_crypto_op_pool_create;\n \n \tlocal: *;\n", "prefixes": [ "v2", "11/15" ] }