Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41470/?format=api
{ "id": 41470, "url": "http://patches.dpdk.org/api/patches/41470/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180625151710.29437-2-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180625151710.29437-2-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180625151710.29437-2-yong.liu@intel.com", "date": "2018-06-25T15:17:03", "name": "[v2,1/8] vhost: announce VIRTIO_F_IN_ORDER support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "367a51db71703a0f887fd1d056b37c005e733fa9", "submitter": { "id": 17, "url": "http://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180625151710.29437-2-yong.liu@intel.com/mbox/", "series": [ { "id": 223, "url": "http://patches.dpdk.org/api/series/223/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=223", "date": "2018-06-25T15:17:02", "name": "support VIRTIO_F_IN_ORDER feature", "version": 2, "mbox": "http://patches.dpdk.org/series/223/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41470/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41470/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1B6C95F30;\n\tMon, 25 Jun 2018 09:31:18 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id A371D5F28\n\tfor <dev@dpdk.org>; Mon, 25 Jun 2018 09:31:12 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2018 00:31:11 -0700", "from dpdk-test32.sh.intel.com ([10.67.119.193])\n\tby fmsmga006.fm.intel.com with ESMTP; 25 Jun 2018 00:31:10 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,269,1526367600\"; d=\"scan'208\";a=\"240338537\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com,\n\ttiwei.bie@intel.com", "Cc": "zhihong.wang@intel.com,\n\tdev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Mon, 25 Jun 2018 23:17:03 +0800", "Message-Id": "<20180625151710.29437-2-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.0", "In-Reply-To": "<20180625151710.29437-1-yong.liu@intel.com>", "References": "<20180625151710.29437-1-yong.liu@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/8] vhost: announce VIRTIO_F_IN_ORDER support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If devices always use descriptors in the same order in which they have\nbeen made available. These devices can offer the VIRTIO_F_IN_ORDER\nfeature. If negotiated, this knowledge allows devices to notify the use\nof a batch of buffers to virtio driver by only writing used ring index.\n\nVhost user device has supported this feature by default. If vhost\ndequeue zero is enabled, should disable VIRTIO_F_IN_ORDER as vhost can’t\nassure that descriptors returned from NIC are in order.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex 0399c37bc..d63031747 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -853,6 +853,12 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n \tvsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;\n \tvsocket->features = VIRTIO_NET_SUPPORTED_FEATURES;\n \n+\t/* Dequeue zero copy can't assure descriptors returned in order */\n+\tif (vsocket->dequeue_zero_copy) {\n+\t\tvsocket->supported_features &= ~(1ULL << VIRTIO_F_IN_ORDER);\n+\t\tvsocket->features &= ~(1ULL << VIRTIO_F_IN_ORDER);\n+\t}\n+\n \tif (!(flags & RTE_VHOST_USER_IOMMU_SUPPORT)) {\n \t\tvsocket->supported_features &= ~(1ULL << VIRTIO_F_IOMMU_PLATFORM);\n \t\tvsocket->features &= ~(1ULL << VIRTIO_F_IOMMU_PLATFORM);\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 58c425a5c..7539b0621 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -191,6 +191,13 @@ struct vhost_msg {\n #define VIRTIO_F_VERSION_1 32\n #endif\n \n+/*\n+ * Available and used descs are in same order\n+ */\n+#ifndef VIRTIO_F_IN_ORDER\n+#define VIRTIO_F_IN_ORDER 35\n+#endif\n+\n /* Features supported by this builtin vhost-user net driver. */\n #define VIRTIO_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \\\n \t\t\t\t(1ULL << VIRTIO_F_ANY_LAYOUT) | \\\n@@ -214,7 +221,8 @@ struct vhost_msg {\n \t\t\t\t(1ULL << VIRTIO_NET_F_GUEST_ECN) | \\\n \t\t\t\t(1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \\\n \t\t\t\t(1ULL << VIRTIO_RING_F_EVENT_IDX) | \\\n-\t\t\t\t(1ULL << VIRTIO_NET_F_MTU) | \\\n+\t\t\t\t(1ULL << VIRTIO_NET_F_MTU) | \\\n+\t\t\t\t(1ULL << VIRTIO_F_IN_ORDER) | \\\n \t\t\t\t(1ULL << VIRTIO_F_IOMMU_PLATFORM))\n \n \n", "prefixes": [ "v2", "1/8" ] }