Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 4146,
    "url": "http://patches.dpdk.org/api/patches/4146/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1427353496-21965-1-git-send-email-michael.qiu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1427353496-21965-1-git-send-email-michael.qiu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1427353496-21965-1-git-send-email-michael.qiu@intel.com",
    "date": "2015-03-26T07:04:56",
    "name": "[dpdk-dev] vhost: Fix Segmentation fault of NULL address",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "643dd52516eb76df7e6a35ab39e4ebddc6ed986d",
    "submitter": {
        "id": 101,
        "url": "http://patches.dpdk.org/api/people/101/?format=api",
        "name": "Michael Qiu",
        "email": "michael.qiu@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1427353496-21965-1-git-send-email-michael.qiu@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/4146/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/4146/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D054437A4;\n\tThu, 26 Mar 2015 08:05:05 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id BE1453238\n\tfor <dev@dpdk.org>; Thu, 26 Mar 2015 08:05:03 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 26 Mar 2015 00:05:02 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 26 Mar 2015 00:05:02 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t2Q74x21002692;\n\tThu, 26 Mar 2015 15:04:59 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t2Q74vOM021999; Thu, 26 Mar 2015 15:04:59 +0800",
            "(from dayuqiu@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t2Q74vgF021995; \n\tThu, 26 Mar 2015 15:04:57 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.11,469,1422950400\"; d=\"scan'208\";a=\"670801692\"",
        "From": "Michael Qiu <michael.qiu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 26 Mar 2015 15:04:56 +0800",
        "Message-Id": "<1427353496-21965-1-git-send-email-michael.qiu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Subject": "[dpdk-dev] [PATCH] vhost: Fix Segmentation fault of NULL address",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Function gpa_to_vva() could return zero, while this will lead\na Segmentation fault.\n\nThis patch is to fix this issue.\n\nSigned-off-by: Michael Qiu <michael.qiu@intel.com>\n---\n lib/librte_vhost/vhost_rxtx.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c\nindex 535c7a1..23c8acb 100644\n--- a/lib/librte_vhost/vhost_rxtx.c\n+++ b/lib/librte_vhost/vhost_rxtx.c\n@@ -587,6 +587,9 @@ rte_vhost_dequeue_burst(struct virtio_net *dev, uint16_t queue_id,\n \n \t\t/* Buffer address translation. */\n \t\tvb_addr = gpa_to_vva(dev, desc->addr);\n+\t\tif (!vb_addr)\n+\t\t\treturn entry_success;\n+\n \t\t/* Prefetch buffer address. */\n \t\trte_prefetch0((void *)(uintptr_t)vb_addr);\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}