Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41442/?format=api
{ "id": 41442, "url": "http://patches.dpdk.org/api/patches/41442/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com", "date": "2018-06-25T05:23:02", "name": "crypto/kasumi: add dynamic logging to kasumi", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "019e7adae9ede7a870d670731adbb8bae6591b83", "submitter": { "id": 1053, "url": "http://patches.dpdk.org/api/people/1053/?format=api", "name": "Naga Suresh Somarowthu", "email": "naga.sureshx.somarowthu@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com/mbox/", "series": [ { "id": 219, "url": "http://patches.dpdk.org/api/series/219/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=219", "date": "2018-06-25T05:23:02", "name": "crypto/kasumi: add dynamic logging to kasumi", "version": 1, "mbox": "http://patches.dpdk.org/series/219/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41442/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41442/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 00D7258C4;\n\tMon, 25 Jun 2018 07:23:09 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 961A52E41\n\tfor <dev@dpdk.org>; Mon, 25 Jun 2018 07:23:07 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Jun 2018 22:23:06 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga007.jf.intel.com with ESMTP; 24 Jun 2018 22:23:05 -0700", "from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com\n\t[10.102.246.100])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw5P5N4SY021007; Mon, 25 Jun 2018 06:23:04 +0100", "from wgcvswdev001.ir.intel.com (localhost [127.0.0.1])\n\tby wgcvswdev001.ir.intel.com with ESMTP id w5P5N4n3008971;\n\tMon, 25 Jun 2018 06:23:04 +0100", "(from jmparthx@localhost)\n\tby wgcvswdev001.ir.intel.com with ? id w5P5N4fH008967;\n\tMon, 25 Jun 2018 06:23:04 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,269,1526367600\"; d=\"scan'208\";a=\"51623878\"", "From": "Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, reshma.pattan@intel.com,\n\tNaga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>", "Date": "Mon, 25 Jun 2018 06:23:02 +0100", "Message-Id": "<1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "Subject": "[dpdk-dev] [PATCH] crypto/kasumi: add dynamic logging to kasumi", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1.added new logtype for kasumi driver.\n2.registered new logtype.\n3.KASUMI_LOG_ERR and CDEV_LOG_ERR are\n replaced with new logtype name KASUMI_PMD_LOG.\n\nSigned-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>\nReviewed-by: Reshma Pattan <reshma.pattan@intel.com>\n---\n drivers/crypto/kasumi/rte_kasumi_pmd.c | 29 +++++++++++++++++---------\n drivers/crypto/kasumi/rte_kasumi_pmd_ops.c | 14 ++++++-------\n drivers/crypto/kasumi/rte_kasumi_pmd_private.h | 26 +++++++----------------\n 3 files changed, 33 insertions(+), 36 deletions(-)", "diff": "diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c b/drivers/crypto/kasumi/rte_kasumi_pmd.c\nindex 205dc1de7..bf48b7006 100644\n--- a/drivers/crypto/kasumi/rte_kasumi_pmd.c\n+++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2016-2017 Intel Corporation\n+ * Copyright(c) 2016-2018 Intel Corporation\n */\n \n #include <rte_common.h>\n@@ -79,18 +79,19 @@ kasumi_set_session_parameters(struct kasumi_session *sess,\n \t\tbreak;\n \tcase KASUMI_OP_NOT_SUPPORTED:\n \tdefault:\n-\t\tKASUMI_LOG_ERR(\"Unsupported operation chain order parameter\");\n+\t\tKASUMI_PMD_LOG(ERR, \"Unsupported operation chain order parameter\");\n \t\treturn -ENOTSUP;\n \t}\n \n \tif (cipher_xform) {\n \t\t/* Only KASUMI F8 supported */\n \t\tif (cipher_xform->cipher.algo != RTE_CRYPTO_CIPHER_KASUMI_F8)\n+\t\t\tKASUMI_PMD_LOG(ERR, \"Unsupported cipher algorithm \");\n \t\t\treturn -ENOTSUP;\n \n \t\tsess->cipher_iv_offset = cipher_xform->cipher.iv.offset;\n \t\tif (cipher_xform->cipher.iv.length != KASUMI_IV_LENGTH) {\n-\t\t\tKASUMI_LOG_ERR(\"Wrong IV length\");\n+\t\t\tKASUMI_PMD_LOG(ERR, \"Wrong IV length\");\n \t\t\treturn -EINVAL;\n \t\t}\n \n@@ -102,10 +103,11 @@ kasumi_set_session_parameters(struct kasumi_session *sess,\n \tif (auth_xform) {\n \t\t/* Only KASUMI F9 supported */\n \t\tif (auth_xform->auth.algo != RTE_CRYPTO_AUTH_KASUMI_F9)\n+\t\t\tKASUMI_PMD_LOG(ERR, \"Unsupported authentication\");\n \t\t\treturn -ENOTSUP;\n \n \t\tif (auth_xform->auth.digest_length != KASUMI_DIGEST_LENGTH) {\n-\t\t\tKASUMI_LOG_ERR(\"Wrong digest length\");\n+\t\t\tKASUMI_PMD_LOG(ERR, \"Wrong digest length\");\n \t\t\treturn -EINVAL;\n \t\t}\n \n@@ -213,7 +215,7 @@ process_kasumi_cipher_op_bit(struct rte_crypto_op *op,\n \tsrc = rte_pktmbuf_mtod(op->sym->m_src, uint8_t *);\n \tif (op->sym->m_dst == NULL) {\n \t\top->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n-\t\tKASUMI_LOG_ERR(\"bit-level in-place not supported\\n\");\n+\t\tKASUMI_PMD_LOG(ERR, \"bit-level in-place not supported\");\n \t\treturn 0;\n \t}\n \tdst = rte_pktmbuf_mtod(op->sym->m_dst, uint8_t *);\n@@ -244,7 +246,7 @@ process_kasumi_hash_op(struct kasumi_qp *qp, struct rte_crypto_op **ops,\n \t\t/* Data must be byte aligned */\n \t\tif ((ops[i]->sym->auth.data.offset % BYTE_LEN) != 0) {\n \t\t\tops[i]->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n-\t\t\tKASUMI_LOG_ERR(\"offset\");\n+\t\t\tKASUMI_PMD_LOG(ERR, \"Invalid Offset\");\n \t\t\tbreak;\n \t\t}\n \n@@ -409,9 +411,9 @@ kasumi_pmd_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\t\t\t(curr_c_op->sym->m_dst != NULL &&\n \t\t\t\t!rte_pktmbuf_is_contiguous(\n \t\t\t\t\t\tcurr_c_op->sym->m_dst))) {\n-\t\t\tKASUMI_LOG_ERR(\"PMD supports only contiguous mbufs, \"\n+\t\t\tKASUMI_PMD_LOG(ERR, \"PMD supports only contiguous mbufs, \"\n \t\t\t\t\"op (%p) provides noncontiguous mbuf as \"\n-\t\t\t\t\"source/destination buffer.\\n\", curr_c_op);\n+\t\t\t\t\"source/destination buffer.\", curr_c_op);\n \t\t\tcurr_c_op->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n \t\t\tbreak;\n \t\t}\n@@ -531,7 +533,7 @@ cryptodev_kasumi_create(const char *name,\n \n \tdev = rte_cryptodev_pmd_create(name, &vdev->device, init_params);\n \tif (dev == NULL) {\n-\t\tKASUMI_LOG_ERR(\"failed to create cryptodev vdev\");\n+\t\tKASUMI_PMD_LOG(ERR, \"failed to create cryptodev vdev\");\n \t\tgoto init_error;\n \t}\n \n@@ -559,7 +561,7 @@ cryptodev_kasumi_create(const char *name,\n \n \treturn 0;\n init_error:\n-\tKASUMI_LOG_ERR(\"driver %s: cryptodev_kasumi_create failed\",\n+\tKASUMI_PMD_LOG(ERR, \"driver %s: failed\",\n \t\t\tinit_params->name);\n \n \tcryptodev_kasumi_remove(vdev);\n@@ -621,3 +623,10 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_KASUMI_PMD,\n \t\"socket_id=<int>\");\n RTE_PMD_REGISTER_CRYPTO_DRIVER(kasumi_crypto_drv,\n \t\tcryptodev_kasumi_pmd_drv.driver, cryptodev_driver_id);\n+\n+RTE_INIT(kasumi_init_log);\n+static void\n+kasumi_init_log(void)\n+{\n+\tkasumi_logtype_driver = rte_log_register(\"pmd.crypto.kasumi\");\n+}\ndiff --git a/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c b/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c\nindex a388dbb63..7a0f26ab2 100644\n--- a/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c\n+++ b/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2016-2017 Intel Corporation\n+ * Copyright(c) 2016-2018 Intel Corporation\n */\n \n #include <string.h>\n@@ -171,13 +171,13 @@ kasumi_pmd_qp_create_processed_ops_ring(struct kasumi_qp *qp,\n \tr = rte_ring_lookup(qp->name);\n \tif (r) {\n \t\tif (rte_ring_get_size(r) == ring_size) {\n-\t\t\tKASUMI_LOG_INFO(\"Reusing existing ring %s\"\n+\t\t\tKASUMI_PMD_LOG(INFO, \"Reusing existing ring %s\"\n \t\t\t\t\t\" for processed packets\",\n \t\t\t\t\t qp->name);\n \t\t\treturn r;\n \t\t}\n \n-\t\tKASUMI_LOG_ERR(\"Unable to reuse existing ring %s\"\n+\t\tKASUMI_PMD_LOG(ERR, \"Unable to reuse existing ring %s\"\n \t\t\t\t\" for processed packets\",\n \t\t\t\t qp->name);\n \t\treturn NULL;\n@@ -269,19 +269,19 @@ kasumi_pmd_session_configure(struct rte_cryptodev *dev __rte_unused,\n \tint ret;\n \n \tif (unlikely(sess == NULL)) {\n-\t\tKASUMI_LOG_ERR(\"invalid session struct\");\n+\t\tKASUMI_PMD_LOG(ERR, \"invalid session struct\");\n \t\treturn -EINVAL;\n \t}\n \n \tif (rte_mempool_get(mempool, &sess_private_data)) {\n-\t\tCDEV_LOG_ERR(\n-\t\t\t\"Couldn't get object from session mempool\");\n+\t\tKASUMI_PMD_LOG(ERR,\n+\t\t\t\t\"Couldn't get object from session mempool\");\n \t\treturn -ENOMEM;\n \t}\n \n \tret = kasumi_set_session_parameters(sess_private_data, xform);\n \tif (ret != 0) {\n-\t\tKASUMI_LOG_ERR(\"failed configure session parameters\");\n+\t\tKASUMI_PMD_LOG(ERR, \"failed configure session parameters\");\n \n \t\t/* Return session to mempool */\n \t\trte_mempool_put(mempool, sess_private_data);\ndiff --git a/drivers/crypto/kasumi/rte_kasumi_pmd_private.h b/drivers/crypto/kasumi/rte_kasumi_pmd_private.h\nindex a397bee65..13223980c 100644\n--- a/drivers/crypto/kasumi/rte_kasumi_pmd_private.h\n+++ b/drivers/crypto/kasumi/rte_kasumi_pmd_private.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2016-2017 Intel Corporation\n+ * Copyright(c) 2016-2018 Intel Corporation\n */\n \n #ifndef _RTE_KASUMI_PMD_PRIVATE_H_\n@@ -10,25 +10,13 @@\n #define CRYPTODEV_NAME_KASUMI_PMD\tcrypto_kasumi\n /**< KASUMI PMD device name */\n \n-#define KASUMI_LOG_ERR(fmt, args...) \\\n-\tRTE_LOG(ERR, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tRTE_STR(CRYPTODEV_NAME_KASUMI_PMD), \\\n-\t\t\t__func__, __LINE__, ## args)\n+/** KASUMI PMD LOGTYPE DRIVER */\n+int kasumi_logtype_driver;\n \n-#ifdef RTE_LIBRTE_KASUMI_DEBUG\n-#define KASUMI_LOG_INFO(fmt, args...) \\\n-\tRTE_LOG(INFO, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tRTE_STR(CRYPTODEV_NAME_KASUMI_PMD), \\\n-\t\t\t__func__, __LINE__, ## args)\n-\n-#define KASUMI_LOG_DBG(fmt, args...) \\\n-\tRTE_LOG(DEBUG, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tRTE_STR(CRYPTODEV_NAME_KASUMI_PMD), \\\n-\t\t\t__func__, __LINE__, ## args)\n-#else\n-#define KASUMI_LOG_INFO(fmt, args...)\n-#define KASUMI_LOG_DBG(fmt, args...)\n-#endif\n+#define KASUMI_PMD_LOG(level, fmt, ...) \\\n+\trte_log(RTE_LOG_ ## level, kasumi_logtype_driver, \\\n+\t\t\t\"%s() line %u: \" fmt \"\\n\", __func__, __LINE__, \\\n+\t\t\t\t\t## __VA_ARGS__)\n \n #define KASUMI_DIGEST_LENGTH 4\n \n", "prefixes": [] }