Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41418/?format=api
{ "id": 41418, "url": "http://patches.dpdk.org/api/patches/41418/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180623071127.22999-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180623071127.22999-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180623071127.22999-3-maxime.coquelin@redhat.com", "date": "2018-06-23T07:11:22", "name": "[v2,2/7] vhost: make gpa to hpa failure an error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8af76da6dcd40e289b071c5175e307f602d2d674", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180623071127.22999-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 212, "url": "http://patches.dpdk.org/api/series/212/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=212", "date": "2018-06-23T07:11:20", "name": "vhost: generalize buffer vectors", "version": 2, "mbox": "http://patches.dpdk.org/series/212/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41418/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41418/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 259E51BDE4;\n\tSat, 23 Jun 2018 13:45:32 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id D70A81BB12\n\tfor <dev@dpdk.org>; Sat, 23 Jun 2018 09:11:44 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7DEA68A9F1;\n\tSat, 23 Jun 2018 07:11:44 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.112.10])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8528F2156889;\n\tSat, 23 Jun 2018 07:11:43 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "tiwei.bie@intel.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Sat, 23 Jun 2018 09:11:22 +0200", "Message-Id": "<20180623071127.22999-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180623071127.22999-1-maxime.coquelin@redhat.com>", "References": "<20180623071127.22999-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.2]); Sat, 23 Jun 2018 07:11:44 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.2]); \n\tSat, 23 Jun 2018 07:11:44 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [PATCH v2 2/7] vhost: make gpa to hpa failure an error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "CVE-2018-1059 fix makes sure gpa contiguous memory is\nalso contiguous in hva space. Incidentally, it also makes\nsure it is contiguous in hpa space.\n\nSo we can simplify the code by making gpa contiguous memory\ndiscontiguous in hpa space an error.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/virtio_net.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 7e70a927f..ec4bcc400 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -884,13 +884,13 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \n \t\tcpy_len = RTE_MIN(desc_chunck_len, mbuf_avail);\n \n-\t\t/*\n-\t\t * A desc buf might across two host physical pages that are\n-\t\t * not continuous. In such case (gpa_to_hpa returns 0), data\n-\t\t * will be copied even though zero copy is enabled.\n-\t\t */\n-\t\tif (unlikely(dev->dequeue_zero_copy && (hpa = gpa_to_hpa(dev,\n-\t\t\t\t\tdesc_gaddr + desc_offset, cpy_len)))) {\n+\t\tif (unlikely(dev->dequeue_zero_copy)) {\n+\t\t\thpa = gpa_to_hpa(dev,\n+\t\t\t\t\tdesc_gaddr + desc_offset, cpy_len);\n+\t\t\tif (unlikely(!hpa)) {\n+\t\t\t\terror = -1;\n+\t\t\t\tgoto out;\n+\t\t\t}\n \t\t\tcur->data_len = cpy_len;\n \t\t\tcur->data_off = 0;\n \t\t\tcur->buf_addr = (void *)(uintptr_t)(desc_addr\n", "prefixes": [ "v2", "2/7" ] }