Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41373/?format=api
{ "id": 41373, "url": "http://patches.dpdk.org/api/patches/41373/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180621181450.91425-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180621181450.91425-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180621181450.91425-1-ferruh.yigit@intel.com", "date": "2018-06-21T18:14:50", "name": "net/thunderx: fix build with gcc optimization on", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0a03ed3c153ed861dd087237493c16f2dbb1508d", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180621181450.91425-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 196, "url": "http://patches.dpdk.org/api/series/196/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=196", "date": "2018-06-21T18:14:50", "name": "net/thunderx: fix build with gcc optimization on", "version": 1, "mbox": "http://patches.dpdk.org/series/196/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41373/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41373/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F09881BADD;\n\tThu, 21 Jun 2018 19:15:16 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 1180D1BAD7;\n\tThu, 21 Jun 2018 19:15:13 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Jun 2018 10:15:13 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.222.212])\n\tby fmsmga008.fm.intel.com with ESMTP; 21 Jun 2018 10:15:12 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,252,1526367600\"; d=\"scan'208\";a=\"49527459\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Jerin Jacob <jerin.jacob@caviumnetworks.com>,\n\tMaciej Czekaj <maciej.czekaj@caviumnetworks.com>", "Cc": "dev@dpdk.org,\n\tFerruh Yigit <ferruh.yigit@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 21 Jun 2018 19:14:50 +0100", "Message-Id": "<20180621181450.91425-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/thunderx: fix build with gcc optimization on", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "build error gcc version 6.3.1 20161221 (Red Hat 6.3.1-1),\nwith EXTRA_CFLAGS=\"-O3\":\n\n.../drivers/net/thunderx/nicvf_ethdev.c:907:9:\n error: ‘txq’ may be used uninitialized in this function\n [-Werror=maybe-uninitialized]\n if (txq->pool_free == nicvf_single_pool_free_xmited_buffers)\n ~~~^~~~~~~~~~~\n.../drivers/net/thunderx/nicvf_ethdev.c:886:20:\n note: ‘txq’ was declared here\n struct nicvf_txq *txq;\n ^~~\n\nSame error on function 'nicvf_eth_dev_init' and 'nicvf_dev_start', it\nseems 'nicvf_set_tx_function' inlined when optimization enabled.\n\nInitialize the txq and add NULL check before using it to fix.\n\nFixes: 7413feee662d (\"net/thunderx: add device start/stop and close\")\nCc: stable@dpdk.org\n\nReported-by: Richard Walsh <richard.walsh@intel.com>\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n\nBtw, no compiler optimization enabled, only nicvf_rxtx.c has -Ofast,\nis this intentional?\n---\n drivers/net/thunderx/nicvf_ethdev.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c\nindex 99fcd516b..4ab1bfbe6 100644\n--- a/drivers/net/thunderx/nicvf_ethdev.c\n+++ b/drivers/net/thunderx/nicvf_ethdev.c\n@@ -883,7 +883,7 @@ nicvf_dev_tx_queue_release(void *sq)\n static void\n nicvf_set_tx_function(struct rte_eth_dev *dev)\n {\n-\tstruct nicvf_txq *txq;\n+\tstruct nicvf_txq *txq = NULL;\n \tsize_t i;\n \tbool multiseg = false;\n \n@@ -904,6 +904,9 @@ nicvf_set_tx_function(struct rte_eth_dev *dev)\n \t\tdev->tx_pkt_burst = nicvf_xmit_pkts;\n \t}\n \n+\tif (!txq)\n+\t\treturn;\n+\n \tif (txq->pool_free == nicvf_single_pool_free_xmited_buffers)\n \t\tPMD_DRV_LOG(DEBUG, \"Using single-mempool tx free method\");\n \telse\n", "prefixes": [] }