Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41356/?format=api
{ "id": 41356, "url": "http://patches.dpdk.org/api/patches/41356/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1529574244-18997-8-git-send-email-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1529574244-18997-8-git-send-email-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1529574244-18997-8-git-send-email-hemant.agrawal@nxp.com", "date": "2018-06-21T09:44:02", "name": "[08/10] net/dpaa2: fix the prefetch Rx to honor nb pkts", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "701bb73051757f54ab65fbea706a1a5449ca6f59", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1529574244-18997-8-git-send-email-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 191, "url": "http://patches.dpdk.org/api/series/191/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=191", "date": "2018-06-21T09:43:55", "name": "[01/10] bus/dpaa: fix phandle support for kernel 4.16", "version": 1, "mbox": "http://patches.dpdk.org/series/191/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41356/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8542C1BDFC;\n\tThu, 21 Jun 2018 11:45:59 +0200 (CEST)", "from EUR02-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr20080.outbound.protection.outlook.com [40.107.2.80])\n\tby dpdk.org (Postfix) with ESMTP id 059F61BDDE;\n\tThu, 21 Jun 2018 11:45:52 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (14.142.187.166) by\n\tAM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16;\n\tThu, 21 Jun 2018 09:45:49 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=pZ2GAnx77W/FRW6xRRiWNQx3G3XSFb3aJGvlEkuvzy8=;\n\tb=HI6u9Rpjm1TSGA4Df6lVugfdKAtl7AJfkqdU0D3ocsY+b7rXUg0Ou1O0eKVAV/g4ChaxFME2EFe0p0EvHe5cST9543NC/5SjCFfIJkzsi5Lm2FOugWxnIcvJ3lnvlqVIB9CahDNPXpa+SE5qTax0MetA+vRPCkam5ghoPasXlNw=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=hemant.agrawal@nxp.com; ", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tstable@dpdk.org", "Date": "Thu, 21 Jun 2018 15:14:02 +0530", "Message-Id": "<1529574244-18997-8-git-send-email-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1529574244-18997-1-git-send-email-hemant.agrawal@nxp.com>", "References": "<1529574244-18997-1-git-send-email-hemant.agrawal@nxp.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[14.142.187.166]", "X-ClientProxiedBy": "BM1PR0101CA0035.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:1a::21) To AM2PR04MB0755.eurprd04.prod.outlook.com\n\t(2a01:111:e400:8411::15)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "4c6333d1-758d-4812-d854-08d5d75bc5a6", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020);\n\tSRVR:AM2PR04MB0755; ", "X-Microsoft-Exchange-Diagnostics": [ "1; AM2PR04MB0755;\n\t3:jmbyigMTUUiiGfZi0bHkmPasoCLK290DfsrGs4dxLiT8ncTiGhD8OrhD5WgkhHJ9fRfgpbur3Shf64MFPJR7nSGORPM2ZRGMzKhoLK8nD0WjpoCEGsAjbQgSNCm+XdHzP+6sBt84l2pk9E/ZGiIQ3OhU1rKZQKy4uNIctvFX1RVwwwrzCFFcNYaXAaIsvp+ZiwvGIvuUB/XII/AUD29WGoJfpFYQJI0h4Y53MLaKmtuOjvOqcf2ou7Gqpns6/Vnh;\n\t25:vtZPn8o1CkQF3blsa2JskEcUjbQv7gFONxAAtP1Q+Ix5PnmD6dJtXiCdBPsAn/5lOZ2YodhTFgjtR/WgshFCojNCHKyuT1XaKuMXGibBE+t8PIP1GNHhk0jL9dc6K7mjFLgGGdOpCtQ5QsFUS5dkGySIog1FVb39upA2lj1QsyoHZK0sJhqoNYdFoxMmM9MYr9BLKCvlVbD6i7kx0EbSiasklFWWZLivnInJ177KVaO419rB3vDB9A1jJhEYx004L4htnli2fZl3XyOFHPHiOHS0rZnCVqej2AdPoBsVX5p0s+hrrcQEFinoDgxozY4tqRFIKt4iqE62hWicaFKj4w==;\n\t31:2Iz10DrfdGSPQAmhFIxzJ1s36LZfLgVRD02Xa/NENj7LUhWPSz/5POSTX3ilkXiZo81j9ngZWi9i0cauC4VjH+hh+ehreWEYGgvHqk4jp4kVz4OddGKMI9PUtBPCRK+h820aq300QhQ+ypoZytP/iw1Ghy0s1xLZyqWObD3IUb8xJdQi2V9EseED/12LJMQRF66IocHdXeucvcKCYsTi9z7p+YgcoyMh2plX/AKruWU=", "1; AM2PR04MB0755;\n\t20:F9/idkCAGbwtVjWLxOXOv1tkHAGG1VSG7CnUvhuskg3MEMvGK+EwzWJ1KNHJVj+kSXFwVcnHn9WGC284PmrIYJGHD6MP7cZhPISogxj/oZfwkVwsRg606x1Z0LYqezh5VW3wz/2n178FbazIkuGj+FchExE6mKimujd8MuErweeiuCzFGORqdQ/tEOdx74GlRnQmmkNQGkCV6ZNkZaKKz7op8Ciq1+J3izCrxTS86H+f7YkALfKrbL+wLG+CDTfsvraQmJHsBRxfn2FmdSFRfijPr4hqn7SSp4rx/jx0dz8XwmjXOlaupuCrKvADgKSdjXvOc/XmpTYQ37/DLsfJM5j0oJxQe/oCFLGpr+4cOHXrUHLFgvq2R9CI4JQjkKZqy45+HUtGf5pFAk7Vgv+upVVwhIpthL+ML2WbONQzvIveH98sH7Ai6uuDZti3RLoma6YD2qg/CuV7CVrWawvj6c1ywelbiaPbe8MynNgn+0h8y0WFpIVXT/PsnhmjWC5R;\n\t4:fU3B6O1hmzdQeuRtSgzCrA0RGUIrh0dLt/z7aLz/aOeSpxFgBai8XfnMPC7QLkjZP+3nivr4VpxNnorhI38Y1074MRq0GpOAhyMkryWHfOE4qB8tM0CMbSl8qoNYvTmdLDPARW854NLFhjPRCF55Y1YBpNWwVilHH7ea/neCUbtF4inzSLCAXLVZmNX9+c3OYH0HUA0tvR/twpUaji+GPB4zALNImOwlybZFywA605UaFbQY/sFkHQlk12SCAEH0BssH+TCVVSA+Q+SQ39e0QH+DV0zZDTPFGTMDe2NmVfLVfTI6lGzleAA64pOUZqFd", "=?us-ascii?Q?1; AM2PR04MB0755;\n\t23:g0XHz50EW2P1barwIIYHzsE5qmEKlG+hFOd1fpBQS?=\n\tdhgKNauPWiAGZGtVMaGiyMEEq7WsQ1763ywbuOHtMAlZ8oWh4o+OxKcjne/Wi+BxxxRHHBxZFdxxcW1l2/jlDYZ1tmCdzfV/gK31v0nWBs4aNHCKxUiyzJuwwqeU/EmfSCQNbG/fN1jZWhvrK6LDPiZUa6+OuDbxg/nBa0tMDy/WYR0ExfJSg/bxnJvbY5hPSZ4bBqN2DKXjQ10zNZBhBaFkOEGgyzVn/97S9iy02kcVhr7BH85k+E5dGeG6VRH1x0jWtme7jI5VdVqGZ9YNC/7/xo7VLgtt1lK9dCnICYthxGEmCZxYd1iONBR9RIW5frTXcmQF4gnIxquyqRPoJCBI4BkI97AV6myAPn3V0IfQE+gjh1qseqCy/9LOpNa5vz2x/qQNy2aCgWYQRw9EAVHKAloY7nqlid1J+bBLNTZ/3DodbH4ZvencSBVsB4OufjvAnBH3vJp3ZbTpZZ5yiWQwbvpHtSlLAK0Ek6LGzPxvIu1pZ9sXpe9tqkY+6x/VQJc8RyxGz9KznuZolczfIyGTO/IvpbVksYkgb6b79NrOPlirT6wmXZetl+EGkUwNbO2nNvRrOelqyrei67KLpiB3ros+VQGL+ETPhpRyX0AJIG9FTmPcz85r+hEW+3ezmXxSepqOTL+8xCE/yBvqvrdpp4O9JJfkUp91dWLLY0SdWAV3FClZsfpjnI7tJvMJxmNS6QPWx8PrUINIto7iy3+pFubQx0S1RDNXAZs7wH0ChIMW+Cq1pCvxn12xiovkhcMhWCYeFOB06afCzanMhCe4GUMa5aUpIZ69kDkrUSrPdkmWMwS5FzxFAFfHINalk4S8/7WLxq99gLJ4k+jsOqIakOZjQ0AlnyMNoxK+gMm/NU/MUfNuCqgeUVy89rc8kDK6+z9rMvisQ3trwH5ChGM5CBv8PMsIohYahiuua1h6gdn3B6wVeM2Wf7cA7W6YQIOpbQGrVQMpwfoWKHOzSepbzUJT2ZQOZKbvIwS6qJxAJJsnxJ47pho40DbQO8x+DtqiiHX26NKTU6NHOvpfwepbDkmIqaI0Q6lk+YbkvjLYWe4/T3Kniv8mG/YwPXofsy8gPwzyx9+V1yfHId9pumHfLKfEL++w1clUYpi8vzDiLkhvDppRR/yUaFiupkRPlD2dN1FQ6a38yVjwmyNMxl/gxS5gNo6ciBJFwvKOb+X63ZzLyZBRQEJ7E0tHhcTxc3KShuTYw2MJhnbykGq9ShI82DAtTaSqkCYifUTB16vr2LCvEu6h4A0dEcC7MoXB4nJdo8zihphZ2g/SiQjsjfR", "1; AM2PR04MB0755;\n\t6:74Jk265aJYArMJYIJ4zPY5fVCqgef/FbSV94IjodMsT09iOKGuRsR9EkogLBancG/u0zrr2rGhdErmTcgQhszykO5Tnp8to6XYfS2SRG1THdznVtVtEq2CbKbeyhg15o1sY0mNG1yXLHqgZ6kNPPB3NDEs039PMsQWZFdG8NdTU20DQ+8SD2jiPJaELSDhrrhhkbf7E0KQco3ALvFT+7zY/Mwm402deN8fBtTRAgEIAFHLl1G2drsPnaur9e0cGN+ZCQbQ5EDTRsdsZa8bM2tb3OKgJNcPuKeLpbBZGZr05VP0Iu7B8HbVxabb24keYjFq9FFkfDrA4eKQt+BpR/Gd3N/K//Yiq18Rx7fkxtNBXS+utNCfKnMLzEIx3VJ+RaqCjWdwFjNziM0JFv2lKAieUQP4e9NwTNpMhW72nAxvEAvId1lvN4gYBvH4boIhkFzx/pi/bSAblS/GxLKMXxOg==;\n\t5:48357RT+bld76LH9HzaqMprswImj1bF/jazveEnYc7BPzZXhqsGjR4wOKECGBQqfEjcO+PzRFD3zaWH3iPhe44s9nVuFO4fck1tXpnfyUk9aUaTTWlJ8XR2kyGMDYOcs/O1ngOBjXNQczq0sfYQdA+YJOuhN4geXcKSMHEq6UL0=;\n\t24:FBvZcR/W+SwRRrUhcYsyWt+oncGM71H1U/EvmsrfwlSWqZa4TGmDfL0okO21jsqvfHn3nnkEE8PXPSwUaLMaLuQJg1idOsDZ8VlZd3aof6E=", "1; AM2PR04MB0755;\n\t7:NKaYXqO5/19pIWa13z/JjFA7pwVFCL9Y7R4V9Y42Rv82luOjF9aS0/dNAoSRBFrdyQ4JCyWg9YJxtRaTZ93sXutOtBoO1WC8d87KL5Ll6FU1mLESXJHPhGohyUPpRNwOXnQiOY00VlHcygy1jxW+/PM/Ltprr4FSjul3Y8HBEQDEVK/xG9m1jYcxX/Z1iN5fKAMl8Q+d9pQv0iO4DD0Sa8GdOxcXH10RuSpyOFRkd4Kpm9c/BET3n7uKNL18bEXy" ], "X-MS-TrafficTypeDiagnostic": "AM2PR04MB0755:", "X-Microsoft-Antispam-PRVS": "<AM2PR04MB075540945075663505237CEA89760@AM2PR04MB0755.eurprd04.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197);", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016);\n\tSRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; ", "X-Forefront-PRVS": "07106EF9B9", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(376002)(366004)(39860400002)(346002)(39380400002)(199004)(189003)(50466002)(6116002)(6506007)(55236004)(76176011)(59450400001)(2906002)(6512007)(478600001)(51416003)(48376002)(52116002)(3846002)(2361001)(186003)(26005)(16526019)(956004)(11346002)(97736004)(2351001)(5009440100003)(386003)(446003)(4326008)(8936002)(8676002)(476003)(486006)(7736002)(81156014)(81166006)(305945005)(16586007)(6916009)(6486002)(105586002)(106356001)(2616005)(47776003)(53936002)(36756003)(50226002)(44832011)(86362001)(68736007)(25786009)(5660300001)(316002)(6666003)(66066001)(110426005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755;\n\tH:bf-netperf1.ap.freescale.net; \n\tFPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; ", "Received-SPF": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "N2eCBxJkFmvyOmNzDC0/BrQau2yweuGKjVeu5P5gblqRlytc5my3h6eq4I2mGQn66UrmrsPosoIuVbltcJe0zvypQgfo0PrzCOcAbYkdai5RlGxHUgAydY43DkvMFgXAacwIde8JVmHYTp0PKFnNxTbShLcIz1QTwsAMDmMSSgtDNvDzRr2aGe+kkPGEC0Fk9Uk/z8R7VHjmjn/Phb3Gnrxif10r+fVXxfvfKKB6kxhRP4SXsGc7PXOpk44ztV6WuxQiPB/TJfHMf44g3D/nxxE9LaQzCgBF2CGachHJCoApbBB7nVxIoyUz4sutlMuEA0PARbktdmbVzz4VGwGeGA==", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Jun 2018 09:45:49.2118\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "4c6333d1-758d-4812-d854-08d5d75bc5a6", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM2PR04MB0755", "Subject": "[dpdk-dev] [PATCH 08/10] net/dpaa2: fix the prefetch Rx to honor nb\n\tpkts", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fix the prefetch rx routine to\nset the next prefetch request to the size of nb_pkts.\nThis will assume that next request will ideally will be\nof same size.\n\nFixes: 4bc5ab88dbd6 (\"net/dpaa2: fix Tx only mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/net/dpaa2/dpaa2_rxtx.c | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c\nindex dac086d..311861c 100644\n--- a/drivers/net/dpaa2/dpaa2_rxtx.c\n+++ b/drivers/net/dpaa2/dpaa2_rxtx.c\n@@ -447,6 +447,12 @@ eth_copy_mbuf_to_fd(struct rte_mbuf *mbuf,\n return 0;\n }\n \n+/* This function assumes that you will be keeping the same value for nb_pkts\n+ * across calls per queue, if that is not the case, better use non-prefetch\n+ * version of rx call.\n+ * It will return the packets as request in the previous call without honoring\n+ * the current nb_pkts or bufs space.\n+ */\n uint16_t\n dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n {\n@@ -454,7 +460,7 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct dpaa2_queue *dpaa2_q = (struct dpaa2_queue *)queue;\n \tstruct qbman_result *dq_storage, *dq_storage1 = NULL;\n \tuint32_t fqid = dpaa2_q->fqid;\n-\tint ret, num_rx = 0;\n+\tint ret, num_rx = 0, pull_size;\n \tuint8_t pending, status;\n \tstruct qbman_swp *swp;\n \tconst struct qbman_fd *fd, *next_fd;\n@@ -470,12 +476,12 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t}\n \t}\n \tswp = DPAA2_PER_LCORE_ETHRX_PORTAL;\n-\n+\tpull_size = (nb_pkts > DPAA2_DQRR_RING_SIZE) ?\n+\t\t\t\t\t DPAA2_DQRR_RING_SIZE : nb_pkts;\n \tif (unlikely(!q_storage->active_dqs)) {\n \t\tq_storage->toggle = 0;\n \t\tdq_storage = q_storage->dq_storage[q_storage->toggle];\n-\t\tq_storage->last_num_pkts = (nb_pkts > DPAA2_DQRR_RING_SIZE) ?\n-\t\t\t\t\t DPAA2_DQRR_RING_SIZE : nb_pkts;\n+\t\tq_storage->last_num_pkts = pull_size;\n \t\tqbman_pull_desc_clear(&pulldesc);\n \t\tqbman_pull_desc_set_numframes(&pulldesc,\n \t\t\t\t\t q_storage->last_num_pkts);\n@@ -514,7 +520,7 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tq_storage->toggle ^= 1;\n \tdq_storage1 = q_storage->dq_storage[q_storage->toggle];\n \tqbman_pull_desc_clear(&pulldesc);\n-\tqbman_pull_desc_set_numframes(&pulldesc, DPAA2_DQRR_RING_SIZE);\n+\tqbman_pull_desc_set_numframes(&pulldesc, pull_size);\n \tqbman_pull_desc_set_fq(&pulldesc, fqid);\n \tqbman_pull_desc_set_storage(&pulldesc, dq_storage1,\n \t\t(uint64_t)(DPAA2_VADDR_TO_IOVA(dq_storage1)), 1);\n", "prefixes": [ "08/10" ] }