Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41287/?format=api
{ "id": 41287, "url": "http://patches.dpdk.org/api/patches/41287/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-16-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180619213058.12273-16-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180619213058.12273-16-ajit.khaparde@broadcom.com", "date": "2018-06-19T21:30:42", "name": "[15/31] net/bnxt: code cleanup style of bnxt txq", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2860af1f6247674b3889e2796bbb564162070769", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-16-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 171, "url": "http://patches.dpdk.org/api/series/171/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=171", "date": "2018-06-19T21:30:31", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/171/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41287/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41287/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0374E1B44A;\n\tTue, 19 Jun 2018 23:31:46 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id BC1571B05E\n\tfor <dev@dpdk.org>; Tue, 19 Jun 2018 23:31:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 3129A30C064;\n\tTue, 19 Jun 2018 14:31:06 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 14FFFAC06AD;\n\tTue, 19 Jun 2018 14:31:06 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 3129A30C064", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1529443866;\n\tbh=F3ra/gFjRStqTHaJOSyvtanMgVlacVKLeeqazN0b5q0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pu9JLguzV70lGpIp8nEDY3NAt8L03nv3WH1QM9SguoSu0KETEIR1iCOwu6KutTg1Y\n\tcz+JhtEiLplvf7/QADvJDRgIYmS6g7VjFIzKUGq2Xs+bhv3zOiBAJePn3ODx7tC7kg\n\tNQ5YBcvMW2u7uWGoxuJzL7NpJJlrj96RKZEig4jM=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tScott Branden <scott.branden@broadcom.com>", "Date": "Tue, 19 Jun 2018 14:30:42 -0700", "Message-Id": "<20180619213058.12273-16-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.1 (Apple Git-101)", "In-Reply-To": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "References": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 15/31] net/bnxt: code cleanup style of bnxt txq", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Scott Branden <scott.branden@broadcom.com>\n\nCleanup alignment, brackets, debug string style of bnxt_txq\n\nSigned-off-by: Scott Branden <scott.branden@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txq.c | 24 ++++++++++++++----------\n drivers/net/bnxt/bnxt_txq.h | 9 +++++----\n 2 files changed, 19 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c\nindex b9b975e4c..677bb9692 100644\n--- a/drivers/net/bnxt/bnxt_txq.c\n+++ b/drivers/net/bnxt/bnxt_txq.c\n@@ -74,10 +74,10 @@ void bnxt_tx_queue_release_op(void *tx_queue)\n }\n \n int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n-\t\t\t uint16_t queue_idx,\n-\t\t\t uint16_t nb_desc,\n-\t\t\t unsigned int socket_id,\n-\t\t\t const struct rte_eth_txconf *tx_conf)\n+\t\t\t uint16_t queue_idx,\n+\t\t\t uint16_t nb_desc,\n+\t\t\t unsigned int socket_id,\n+\t\t\t const struct rte_eth_txconf *tx_conf)\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct bnxt_tx_queue *txq;\n@@ -91,7 +91,7 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \t}\n \n \tif (!nb_desc || nb_desc > MAX_TX_DESC_CNT) {\n-\t\tPMD_DRV_LOG(ERR, \"nb_desc %d is invalid\", nb_desc);\n+\t\tPMD_DRV_LOG(ERR, \"nb_desc %d is invalid\\n\", nb_desc);\n \t\trc = -EINVAL;\n \t\tgoto out;\n \t}\n@@ -106,7 +106,7 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \ttxq = rte_zmalloc_socket(\"bnxt_tx_queue\", sizeof(struct bnxt_tx_queue),\n \t\t\t\t RTE_CACHE_LINE_SIZE, socket_id);\n \tif (!txq) {\n-\t\tPMD_DRV_LOG(ERR, \"bnxt_tx_queue allocation failed!\");\n+\t\tPMD_DRV_LOG(ERR, \"bnxt_tx_queue allocation failed!\\n\");\n \t\trc = -ENOMEM;\n \t\tgoto out;\n \t}\n@@ -122,16 +122,20 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \ttxq->port_id = eth_dev->data->port_id;\n \n \t/* Allocate TX ring hardware descriptors */\n-\tif (bnxt_alloc_rings(bp, queue_idx, txq, NULL, txq->cp_ring,\n-\t\t\t\"txr\")) {\n-\t\tPMD_DRV_LOG(ERR, \"ring_dma_zone_reserve for tx_ring failed!\");\n+\tif (bnxt_alloc_rings(bp,\n+\t\t\t queue_idx,\n+\t\t\t txq,\n+\t\t\t NULL,\n+\t\t\t txq->cp_ring,\n+\t\t\t \"txr\")) {\n+\t\tPMD_DRV_LOG(ERR, \"ring_dma_zone_reserve for tx_ring failed!\\n\");\n \t\tbnxt_tx_queue_release_op(txq);\n \t\trc = -ENOMEM;\n \t\tgoto out;\n \t}\n \n \tif (bnxt_init_one_tx_ring(txq)) {\n-\t\tPMD_DRV_LOG(ERR, \"bnxt_init_one_tx_ring failed!\");\n+\t\tPMD_DRV_LOG(ERR, \"bnxt_init_one_tx_ring failed!\\n\");\n \t\tbnxt_tx_queue_release_op(txq);\n \t\trc = -ENOMEM;\n \t\tgoto out;\ndiff --git a/drivers/net/bnxt/bnxt_txq.h b/drivers/net/bnxt/bnxt_txq.h\nindex f2c712a75..9da8f39d8 100644\n--- a/drivers/net/bnxt/bnxt_txq.h\n+++ b/drivers/net/bnxt/bnxt_txq.h\n@@ -40,8 +40,9 @@ void bnxt_free_txq_stats(struct bnxt_tx_queue *txq);\n void bnxt_free_tx_mbufs(struct bnxt *bp);\n void bnxt_tx_queue_release_op(void *tx_queue);\n int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,\n-\t\t\t uint16_t queue_idx,\n-\t\t\t uint16_t nb_desc,\n-\t\t\t unsigned int socket_id,\n-\t\t\t const struct rte_eth_txconf *tx_conf);\n+\t\t\t uint16_t queue_idx,\n+\t\t\t uint16_t nb_desc,\n+\t\t\t unsigned int socket_id,\n+\t\t\t const struct rte_eth_txconf *tx_conf);\n+\n #endif\n", "prefixes": [ "15/31" ] }