Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41282/?format=api
{ "id": 41282, "url": "http://patches.dpdk.org/api/patches/41282/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-15-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180619213058.12273-15-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180619213058.12273-15-ajit.khaparde@broadcom.com", "date": "2018-06-19T21:30:41", "name": "[14/31] net/bnxt: code cleanup style of bnxt vnic", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "dd52c467c39c691df4f2762422777e84a5194025", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-15-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 171, "url": "http://patches.dpdk.org/api/series/171/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=171", "date": "2018-06-19T21:30:31", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/171/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41282/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41282/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D157E1B42B;\n\tTue, 19 Jun 2018 23:31:35 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 0CE2C1B05C\n\tfor <dev@dpdk.org>; Tue, 19 Jun 2018 23:31:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 8D3A530C06A;\n\tTue, 19 Jun 2018 14:31:05 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id C0B00AC0799;\n\tTue, 19 Jun 2018 14:31:05 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 8D3A530C06A", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1529443865;\n\tbh=/aDSiIGrNVnDiQJzYcFL7TQLzOFACF9AzID83WnVEpQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jfihG/YM4+gIaH8m6jiRQSD3eA2kC4JvvYLCT47Q3mK1j7WJPml4Eyd4bH8Oyraz3\n\tD5Z1DL+84lGFSztfuaFh8088zCckKoYZGCgwRScBds9y/Bk4JRaVjIiKYKRVXhR2HR\n\t7PHpFDVcMxo/NFe206f7l92YTSejmdJuOK+VyxSU=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tScott Branden <scott.branden@broadcom.com>", "Date": "Tue, 19 Jun 2018 14:30:41 -0700", "Message-Id": "<20180619213058.12273-15-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.1 (Apple Git-101)", "In-Reply-To": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "References": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 14/31] net/bnxt: code cleanup style of bnxt vnic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Scott Branden <scott.branden@broadcom.com>\n\nCleanup alignment, brackets, debug string style of bnxt_vnic\n\nSigned-off-by: Scott Branden <scott.branden@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_vnic.c | 26 +++++++++++++-------------\n drivers/net/bnxt/bnxt_vnic.h | 8 ++++++--\n 2 files changed, 19 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 19d06af55..5d9d369a3 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -64,8 +64,9 @@ void bnxt_init_vnics(struct bnxt *bp)\n \t\tSTAILQ_INIT(&bp->ff_pool[i]);\n }\n \n-int bnxt_free_vnic(struct bnxt *bp, struct bnxt_vnic_info *vnic,\n-\t\t\t int pool)\n+int bnxt_free_vnic(struct bnxt *bp,\n+\t\t struct bnxt_vnic_info *vnic,\n+\t\t int pool)\n {\n \tstruct bnxt_vnic_info *temp;\n \n@@ -143,14 +144,16 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp)\n \tstruct rte_pci_device *pdev = bp->pdev;\n \tconst struct rte_memzone *mz;\n \tchar mz_name[RTE_MEMZONE_NAMESIZE];\n-\tuint32_t entry_length = RTE_CACHE_LINE_ROUNDUP(\n-\t\t\t\tHW_HASH_INDEX_SIZE * sizeof(*vnic->rss_table) +\n-\t\t\t\tHW_HASH_KEY_SIZE +\n-\t\t\t\tBNXT_MAX_MC_ADDRS * ETHER_ADDR_LEN);\n+\tuint32_t entry_length;\n \tuint16_t max_vnics;\n \tint i;\n \trte_iova_t mz_phys_addr;\n \n+\tentry_length = RTE_CACHE_LINE_ROUNDUP\n+\t\t\t(HW_HASH_INDEX_SIZE * sizeof(*vnic->rss_table) +\n+\t\t\t HW_HASH_KEY_SIZE +\n+\t\t\t BNXT_MAX_MC_ADDRS * ETHER_ADDR_LEN);\n+\n \tmax_vnics = bp->max_vnics;\n \tsnprintf(mz_name, RTE_MEMZONE_NAMESIZE,\n \t\t \"bnxt_%04x:%02x:%02x:%02x_vnicattr\", pdev->addr.domain,\n@@ -168,14 +171,11 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp)\n \t}\n \tmz_phys_addr = mz->iova;\n \tif ((unsigned long)mz->addr == mz_phys_addr) {\n-\t\tPMD_DRV_LOG(WARNING,\n-\t\t\t\"Memzone physical address same as virtual.\\n\");\n-\t\tPMD_DRV_LOG(WARNING,\n-\t\t\t\"Using rte_mem_virt2iova()\\n\");\n+\t\tPMD_DRV_LOG(WARNING, \"Memzone phys addr == virtual\\n\");\n+\t\tPMD_DRV_LOG(WARNING, \"Using rte_mem_virt2iova()\\n\");\n \t\tmz_phys_addr = rte_mem_virt2iova(mz->addr);\n \t\tif (mz_phys_addr == 0) {\n-\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\"unable to map vnic address to physical memory\\n\");\n+\t\t\tPMD_DRV_LOG(ERR, \"unable to map vnic addr\\n\");\n \t\t\treturn -ENOMEM;\n \t\t}\n \t}\n@@ -234,7 +234,7 @@ int bnxt_alloc_vnic_mem(struct bnxt *bp)\n \tvnic_mem = rte_zmalloc(\"bnxt_vnic_info\",\n \t\t\t max_vnics * sizeof(struct bnxt_vnic_info), 0);\n \tif (vnic_mem == NULL) {\n-\t\tPMD_DRV_LOG(ERR, \"Failed to alloc memory for %d VNICs\",\n+\t\tPMD_DRV_LOG(ERR, \"Failed to alloc memory for %d VNICs\\n\",\n \t\t\tmax_vnics);\n \t\treturn -ENOMEM;\n \t}\ndiff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h\nindex c521d7e5a..3401ae098 100644\n--- a/drivers/net/bnxt/bnxt_vnic.h\n+++ b/drivers/net/bnxt/bnxt_vnic.h\n@@ -58,12 +58,16 @@ struct bnxt_vnic_info {\n \n struct bnxt;\n void bnxt_init_vnics(struct bnxt *bp);\n-int bnxt_free_vnic(struct bnxt *bp, struct bnxt_vnic_info *vnic,\n-\t\t\t int pool);\n+\n+int bnxt_free_vnic(struct bnxt *bp,\n+\t\t struct bnxt_vnic_info *vnic,\n+\t\t int pool);\n+\n struct bnxt_vnic_info *bnxt_alloc_vnic(struct bnxt *bp);\n void bnxt_free_all_vnics(struct bnxt *bp);\n void bnxt_free_vnic_attributes(struct bnxt *bp);\n int bnxt_alloc_vnic_attributes(struct bnxt *bp);\n void bnxt_free_vnic_mem(struct bnxt *bp);\n int bnxt_alloc_vnic_mem(struct bnxt *bp);\n+\n #endif\n", "prefixes": [ "14/31" ] }