Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41277/?format=api
{ "id": 41277, "url": "http://patches.dpdk.org/api/patches/41277/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-11-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180619213058.12273-11-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180619213058.12273-11-ajit.khaparde@broadcom.com", "date": "2018-06-19T21:30:37", "name": "[10/31] net/bnxt: code cleanup style of bnxt cpr", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c69ecc83be43b4d77565e2c0562b161df5cae514", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-11-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 171, "url": "http://patches.dpdk.org/api/series/171/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=171", "date": "2018-06-19T21:30:31", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/171/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41277/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41277/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4A8D91B1FC;\n\tTue, 19 Jun 2018 23:31:25 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id E34481B053\n\tfor <dev@dpdk.org>; Tue, 19 Jun 2018 23:31:08 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 9924130C10E;\n\tTue, 19 Jun 2018 14:31:04 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 934E9AC07B1;\n\tTue, 19 Jun 2018 14:31:04 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 9924130C10E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1529443864;\n\tbh=4iZbli53Rg0B4H0NwTNpNcJ/8mHTwbLBeM98EEllsLE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Stibj0XOhnwRi3kx1bTCin8jhfiojZfo1HQ/V+tV8Xf4GuLyNO367QZlR+vbomZ5Y\n\tOdtR7qd1F2bK4Udu1bq5xvztAN4veL7B/PXwxzRGab6QDz0sdzh15Z7vn4vtYcEct8\n\ts/BybmtjIt9HbBMuX5THaCSImkghToQtdFqFYDxI=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tScott Branden <scott.branden@broadcom.com>", "Date": "Tue, 19 Jun 2018 14:30:37 -0700", "Message-Id": "<20180619213058.12273-11-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.1 (Apple Git-101)", "In-Reply-To": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "References": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 10/31] net/bnxt: code cleanup style of bnxt cpr", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Scott Branden <scott.branden@broadcom.com>\n\nCleanup alignment, brackets, debug string style of bnxt_cpr\n\nSigned-off-by: Scott Branden <scott.branden@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Qingmin Liu <qingmin.liu@broadcom.com>\nReviewed-by: Ray Jui <ray.jui@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 22 ++++++++++------------\n 1 file changed, 10 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex ff20b6fdf..7257bbedc 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -74,12 +74,12 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl)\n \tfwd_cmd = (struct input *)bp->pf.vf_info[vf_id].req_buf;\n \n \tif (fw_vf_id < bp->pf.first_vf_id ||\n-\t fw_vf_id >= (bp->pf.first_vf_id) + bp->pf.active_vfs) {\n+\t fw_vf_id >= bp->pf.first_vf_id + bp->pf.active_vfs) {\n \t\tPMD_DRV_LOG(ERR,\n-\t\t\"FWD req's source_id 0x%x out of range 0x%x - 0x%x (%d %d)\\n\",\n-\t\t\tfw_vf_id, bp->pf.first_vf_id,\n-\t\t\t(bp->pf.first_vf_id) + bp->pf.active_vfs - 1,\n-\t\t\tbp->pf.first_vf_id, bp->pf.active_vfs);\n+\t\t\t \"FWD req 0x%x out of range 0x%x - 0x%x (%d %d)\\n\",\n+\t\t\t fw_vf_id, bp->pf.first_vf_id,\n+\t\t\t bp->pf.first_vf_id + bp->pf.active_vfs - 1,\n+\t\t\t bp->pf.first_vf_id, bp->pf.active_vfs);\n \t\tgoto reject;\n \t}\n \n@@ -95,7 +95,7 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl)\n \t\t\tif (vfc->enables &\n \t\t\t HWRM_FUNC_VF_CFG_INPUT_ENABLES_DFLT_MAC_ADDR) {\n \t\t\t\tbnxt_hwrm_func_vf_mac(bp, vf_id,\n-\t\t\t\t(const uint8_t *)\"\\x00\\x00\\x00\\x00\\x00\");\n+\t\t\t\t (const uint8_t *)\"\\x00\\x00\\x00\\x00\\x00\");\n \t\t\t}\n \t\t}\n \t\tif (fwd_cmd->req_type == HWRM_CFA_L2_SET_RX_MASK) {\n@@ -104,10 +104,10 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl)\n \n \t\t\tsrm->vlan_tag_tbl_addr = rte_cpu_to_le_64(0);\n \t\t\tsrm->num_vlan_tags = rte_cpu_to_le_32(0);\n-\t\t\tsrm->mask &= ~rte_cpu_to_le_32(\n-\t\t\t\tHWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLANONLY |\n-\t\t\t HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLAN_NONVLAN |\n-\t\t\t HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ANYVLAN_NONVLAN);\n+\t\t\tsrm->mask &= ~rte_cpu_to_le_32\n+\t\t\t (HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLANONLY |\n+\t\t\t HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLAN_NONVLAN |\n+\t\t\t HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ANYVLAN_NONVLAN);\n \t\t}\n \t\t/* Forward */\n \t\trc = bnxt_hwrm_exec_fwd_resp(bp, fw_vf_id, fwd_cmd, req_len);\n@@ -128,8 +128,6 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl)\n \t\t\tfw_vf_id - bp->pf.first_vf_id,\n \t\t\trte_le_to_cpu_16(fwd_cmd->req_type));\n \t}\n-\n-\treturn;\n }\n \n int bnxt_event_hwrm_resp_handler(struct bnxt *bp, struct cmpl_base *cmp)\n", "prefixes": [ "10/31" ] }