Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41232/?format=api
{ "id": 41232, "url": "http://patches.dpdk.org/api/patches/41232/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1529351589-173939-1-git-send-email-dariuszx.stojaczyk@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1529351589-173939-1-git-send-email-dariuszx.stojaczyk@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1529351589-173939-1-git-send-email-dariuszx.stojaczyk@intel.com", "date": "2018-06-18T19:53:09", "name": "memory: do not use base-virtaddr in secondary processes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "55fef4c4620fd09f74fb520e50636666549b3bf3", "submitter": { "id": 744, "url": "http://patches.dpdk.org/api/people/744/?format=api", "name": "Stojaczyk, DariuszX", "email": "dariuszx.stojaczyk@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1529351589-173939-1-git-send-email-dariuszx.stojaczyk@intel.com/mbox/", "series": [ { "id": 155, "url": "http://patches.dpdk.org/api/series/155/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=155", "date": "2018-06-18T19:53:09", "name": "memory: do not use base-virtaddr in secondary processes", "version": 1, "mbox": "http://patches.dpdk.org/series/155/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41232/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41232/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CC0922629;\n\tMon, 18 Jun 2018 18:12:37 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 164BA235;\n\tMon, 18 Jun 2018 18:12:35 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Jun 2018 09:12:35 -0700", "from kraken.imu.intel.com (HELO Sent) ([10.217.246.153])\n\tby fmsmga001.fm.intel.com with SMTP; 18 Jun 2018 09:12:32 -0700", "by Sent (sSMTP sendmail emulation); Mon, 18 Jun 2018 21:53:10 +0200" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,240,1526367600\"; d=\"scan'208\";a=\"65109076\"", "From": "Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>", "To": "dev@dpdk.org,\n\tAnatoly Burakov <anatoly.burakov@intel.com>", "Cc": "Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>,\n\tstable@dpdk.org", "Date": "Mon, 18 Jun 2018 21:53:09 +0200", "Message-Id": "<1529351589-173939-1-git-send-email-dariuszx.stojaczyk@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] memory: do not use base-virtaddr in secondary\n\tprocesses", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since secondary process' address space is highly dictated\nby the primary process' mappings, it doesn't make much\nsense to use base-virtaddr for secondary processes.\n\nThis patch is intended to fix PCI resource mapping\nin secondary processes using the same base-virtaddr\nas their primary processes. PCI uses the end of the hugepage\nmemory area to map all resources. [pci_find_max_end_va()]\nIt works for primary processes, but can't be mapped 1:1\nby secondary ones, as the same addresses are currently always\noccupied by shadow memseg lists, which were created with\neal_get_virtual_area(NULL, ...).\n\n```\nPRIMARY PROCESS\n0x6e00e00000 388K rw-s- fbarray_memseg-2048k-1-3\n0x6e01000000 16777216K r---- [ anon ]\n0x7201000000 16K rw-s- resource0\n\nSECONDARY PROCESS\n0x6e00e00000 388K rw-s- fbarray_memseg-2048k-1-3\n0x6e01000000 16777216K r---- [ anon ]\n0x7201000000 4K rw-s- fbarray_memseg-1048576k-0-0_203213\n```\n\nFixes: 524e43c2ad9a (\"mem: prepare memseg lists for multiprocess sync\")\nCc: anatoly.burakov@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>\n---\n lib/librte_eal/common/eal_common_memory.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex 53d9b51..6c47e11 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -56,7 +56,8 @@ eal_get_virtual_area(void *requested_addr, size_t *size,\n \tallow_shrink = (flags & EAL_VIRTUAL_AREA_ALLOW_SHRINK) > 0;\n \tunmap = (flags & EAL_VIRTUAL_AREA_UNMAP) > 0;\n \n-\tif (next_baseaddr == NULL && internal_config.base_virtaddr != 0)\n+\tif (next_baseaddr == NULL && internal_config.base_virtaddr != 0 &&\n+\t\t\trte_eal_process_type() == RTE_PROC_PRIMARY)\n \t\tnext_baseaddr = (void *) internal_config.base_virtaddr;\n \n \tif (requested_addr == NULL && next_baseaddr) {\n", "prefixes": [] }