Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41198/?format=api
http://patches.dpdk.org/api/patches/41198/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180615165224.25004-5-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180615165224.25004-5-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180615165224.25004-5-jasvinder.singh@intel.com", "date": "2018-06-15T16:52:06", "name": "[v2,04/22] net/softnic: add mempool object", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0fff997b173be25845cc0d56eb95f7f8a3a17f24", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180615165224.25004-5-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 147, "url": "http://patches.dpdk.org/api/series/147/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=147", "date": "2018-06-15T16:52:03", "name": "[v2,01/22] net/softnic: restructuring", "version": 2, "mbox": "http://patches.dpdk.org/series/147/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41198/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/41198/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1340A1C029;\n\tFri, 15 Jun 2018 18:52:40 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 6466D1BEAA\n\tfor <dev@dpdk.org>; Fri, 15 Jun 2018 18:52:30 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Jun 2018 09:52:29 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby fmsmga006.fm.intel.com with ESMTP; 15 Jun 2018 09:52:28 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,227,1526367600\"; d=\"scan'208\";a=\"237791023\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com", "Date": "Fri, 15 Jun 2018 17:52:06 +0100", "Message-Id": "<20180615165224.25004-5-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20180615165224.25004-1-jasvinder.singh@intel.com>", "References": "<20180608124155.140663-2-jasvinder.singh@intel.com>\n\t<20180615165224.25004-1-jasvinder.singh@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 04/22] net/softnic: add mempool object", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add mempool object implementation to the softnic.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n drivers/net/softnic/Makefile | 1 +\n drivers/net/softnic/rte_eth_softnic.c | 2 +\n drivers/net/softnic/rte_eth_softnic_internals.h | 38 +++++++++\n drivers/net/softnic/rte_eth_softnic_mempool.c | 103 ++++++++++++++++++++++++\n 4 files changed, 144 insertions(+)\n create mode 100644 drivers/net/softnic/rte_eth_softnic_mempool.c", "diff": "diff --git a/drivers/net/softnic/Makefile b/drivers/net/softnic/Makefile\nindex 59711ec..9b33d81 100644\n--- a/drivers/net/softnic/Makefile\n+++ b/drivers/net/softnic/Makefile\n@@ -22,6 +22,7 @@ LIBABIVER := 1\n # all source are stored in SRCS-y\n #\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += rte_eth_softnic.c\n+SRCS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += rte_eth_softnic_mempool.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += rte_eth_softnic_swq.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += rte_eth_softnic_link.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += rte_eth_softnic_tm.c\ndiff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c\nindex e6e30bd..4f57c13 100644\n--- a/drivers/net/softnic/rte_eth_softnic.c\n+++ b/drivers/net/softnic/rte_eth_softnic.c\n@@ -222,6 +222,7 @@ pmd_init(struct pmd_params *params)\n \tmemcpy(&p->params, params, sizeof(p->params));\n \n \t/* Resources */\n+\tmempool_init(p);\n \tswq_init(p);\n \tlink_init(p);\n \n@@ -236,6 +237,7 @@ pmd_free(struct pmd_internals *p)\n \n \tlink_free(p);\n \tswq_free(p);\n+\tmempool_free(p);\n \n \trte_free(p);\n }\ndiff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex c463f8f..18074b7 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -9,6 +9,7 @@\n #include <stdint.h>\n #include <sys/queue.h>\n \n+#include <rte_mempool.h>\n #include <rte_mbuf.h>\n #include <rte_ring.h>\n #include <rte_ethdev.h>\n@@ -54,6 +55,24 @@ struct pmd_params {\n };\n \n /**\n+ * MEMPOOL\n+ */\n+struct mempool_params {\n+\tuint32_t buffer_size;\n+\tuint32_t pool_size;\n+\tuint32_t cache_size;\n+};\n+\n+struct mempool {\n+\tTAILQ_ENTRY(mempool) node;\n+\tchar name[NAME_SIZE];\n+\tstruct rte_mempool *m;\n+\tuint32_t buffer_size;\n+};\n+\n+TAILQ_HEAD(mempool_list, mempool);\n+\n+/**\n * SWQ\n */\n struct swq_params {\n@@ -210,11 +229,30 @@ struct pmd_internals {\n \t\tstruct tm_internals tm; /**< Traffic Management */\n \t} soft;\n \n+\tstruct mempool_list mempool_list;\n \tstruct swq_list swq_list;\n \tstruct link_list link_list;\n };\n \n /**\n+ * MEMPOOL\n+ */\n+int\n+mempool_init(struct pmd_internals *p);\n+\n+void\n+mempool_free(struct pmd_internals *p);\n+\n+struct mempool *\n+mempool_find(struct pmd_internals *p,\n+\tconst char *name);\n+\n+struct mempool *\n+mempool_create(struct pmd_internals *p,\n+\tconst char *name,\n+\tstruct mempool_params *params);\n+\n+/**\n * SWQ\n */\n int\ndiff --git a/drivers/net/softnic/rte_eth_softnic_mempool.c b/drivers/net/softnic/rte_eth_softnic_mempool.c\nnew file mode 100644\nindex 0000000..ff2de67\n--- /dev/null\n+++ b/drivers/net/softnic/rte_eth_softnic_mempool.c\n@@ -0,0 +1,103 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2010-2018 Intel Corporation\n+ */\n+\n+#include <stdlib.h>\n+#include <string.h>\n+\n+#include <rte_mbuf.h>\n+#include <rte_string_fns.h>\n+\n+#include \"rte_eth_softnic_internals.h\"\n+\n+#define BUFFER_SIZE_MIN (sizeof(struct rte_mbuf) + RTE_PKTMBUF_HEADROOM)\n+\n+int\n+mempool_init(struct pmd_internals *p)\n+{\n+\tTAILQ_INIT(&p->mempool_list);\n+\n+\treturn 0;\n+}\n+\n+void\n+mempool_free(struct pmd_internals *p)\n+{\n+\tfor ( ; ; ) {\n+\t\tstruct mempool *mempool;\n+\n+\t\tmempool = TAILQ_FIRST(&p->mempool_list);\n+\t\tif (mempool == NULL)\n+\t\t\tbreak;\n+\n+\t\tTAILQ_REMOVE(&p->mempool_list, mempool, node);\n+\t\trte_mempool_free(mempool->m);\n+\t\tfree(mempool);\n+\t}\n+}\n+\n+struct mempool *\n+mempool_find(struct pmd_internals *p,\n+\tconst char *name)\n+{\n+\tstruct mempool *mempool;\n+\n+\tif (name == NULL)\n+\t\treturn NULL;\n+\n+\tTAILQ_FOREACH(mempool, &p->mempool_list, node)\n+\t\tif (strcmp(mempool->name, name) == 0)\n+\t\t\treturn mempool;\n+\n+\treturn NULL;\n+}\n+\n+struct mempool *\n+mempool_create(struct pmd_internals *p,\n+\tconst char *name,\n+\tstruct mempool_params *params)\n+{\n+\tchar mempool_name[NAME_SIZE];\n+\tstruct mempool *mempool;\n+\tstruct rte_mempool *m;\n+\n+\t/* Check input params */\n+\tif (name == NULL ||\n+\t\tmempool_find(p, name) ||\n+\t\tparams == NULL ||\n+\t\tparams->buffer_size < BUFFER_SIZE_MIN ||\n+\t\tparams->pool_size == 0)\n+\t\treturn NULL;\n+\n+\t/* Resource create */\n+\tsnprintf(mempool_name, sizeof(mempool_name), \"%s_%s\",\n+\t\tp->params.name,\n+\t\tname);\n+\n+\tm = rte_pktmbuf_pool_create(mempool_name,\n+\t\tparams->pool_size,\n+\t\tparams->cache_size,\n+\t\t0,\n+\t\tparams->buffer_size - sizeof(struct rte_mbuf),\n+\t\tp->params.cpu_id);\n+\n+\tif (m == NULL)\n+\t\treturn NULL;\n+\n+\t/* Node allocation */\n+\tmempool = calloc(1, sizeof(struct mempool));\n+\tif (mempool == NULL) {\n+\t\trte_mempool_free(m);\n+\t\treturn NULL;\n+\t}\n+\n+\t/* Node fill in */\n+\tstrlcpy(mempool->name, name, sizeof(mempool->name));\n+\tmempool->m = m;\n+\tmempool->buffer_size = params->buffer_size;\n+\n+\t/* Node add to list */\n+\tTAILQ_INSERT_TAIL(&p->mempool_list, mempool, node);\n+\n+\treturn mempool;\n+}\n", "prefixes": [ "v2", "04/22" ] }{ "id": 41198, "url": "