Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41183/?format=api
{ "id": 41183, "url": "http://patches.dpdk.org/api/patches/41183/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180615122448.28118-1-darek.stojaczyk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180615122448.28118-1-darek.stojaczyk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180615122448.28118-1-darek.stojaczyk@gmail.com", "date": "2018-06-15T12:24:48", "name": "memory: make eal_get_virtual_area() aware of base-virtaddr alignment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "85aee34070a12b1a2bc2dce945d7d340c03834eb", "submitter": { "id": 1051, "url": "http://patches.dpdk.org/api/people/1051/?format=api", "name": "Dariusz Stojaczyk", "email": "darek.stojaczyk@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180615122448.28118-1-darek.stojaczyk@gmail.com/mbox/", "series": [ { "id": 143, "url": "http://patches.dpdk.org/api/series/143/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=143", "date": "2018-06-15T12:24:48", "name": "memory: make eal_get_virtual_area() aware of base-virtaddr alignment", "version": 1, "mbox": "http://patches.dpdk.org/series/143/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41183/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41183/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 172F91D72B;\n\tFri, 15 Jun 2018 14:25:32 +0200 (CEST)", "from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 16AB61D72A;\n\tFri, 15 Jun 2018 14:25:30 +0200 (CEST)", "by mail-lf0-f66.google.com with SMTP id q11-v6so14365562lfc.7;\n\tFri, 15 Jun 2018 05:25:30 -0700 (PDT)", "from localhost.localdomain (89-68-115-185.dynamic.chello.pl.\n\t[89.68.115.185]) by smtp.gmail.com with ESMTPSA id\n\td19-v6sm1477770lfl.82.2018.06.15.05.25.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Jun 2018 05:25:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=D8NblHGN8B0Fh5Kvor8B7pJVBz3HEEPiHlsfKEAUwLc=;\n\tb=fr7NNvZD1LzqXNQvQU/6i8xw6d4xptYzXS04RisZPKmBRZrG9oJ7J6OJbJZm2Wg5Qf\n\tkfskJTpY56fM81nJiFoSF297p+Ax4kzltXTt8UkEJWEmGGadlV+akp/elKfQKSXiKUoe\n\tkEAUpO0X6Ha1IlWHZGXijIakGTawQeb9aZhMJk5iklWz4N6ZQKagIAeCR3KhCU1V5A6v\n\t8J2i9wig0d/+vA6jVsbLUkQwwO6N/mo8fs608zSoidLEudnds32obdv1EdJ2b68FHXct\n\tn2HSbaC+t17SoFyuWoQkQa7C2dcsgfn9CfBZuTio1er5f9vC4C658Pvv0Z3EwfDpqSFN\n\tu0vQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=D8NblHGN8B0Fh5Kvor8B7pJVBz3HEEPiHlsfKEAUwLc=;\n\tb=BRZhkdDYQg4f+tE8fKic/KzYHrqQs+G1H4KjR/7mGkScgjqBWu3FYmPGqNiJ88cT1m\n\ttOLE+ciJPntW0OxGdnusTnzyHCAfWViDaztcBbtsysOIirC2Y+wIlpu8LFRhKiMTQ16i\n\tUQmDSEreC8LIQ59zufTJ261AODflvpjfrNBw7XSX+YkxrgOEex0Lca5Ri0AifZtUhlsO\n\tESFlUPaHJ+bnczJcfAX08YTzRobi8OdQe7b27uEYyFax4ilvmo0CQadNH0uoyXi7zzFO\n\tok+as1PnQR3uef3t+4O4DIBuN/zqrhMI3aAC0sy0tNnjTI46ROq4xPUowu7+hsI/mdH/\n\tjqvw==", "X-Gm-Message-State": "APt69E3wBJkrTHB49QE/kq6mp0NE/7uPazfgolb+FV3tRSSyCFvBNeHT\n\t9RAhfbtEMT0fkcxE7VDY3mEKFw==", "X-Google-Smtp-Source": "ADUXVKIDjubURXvuGLomKhhFRWxrzmatNOwahWPfWILLkWs9bIntKjjefnfiAjQ5DmIKWLbs3/uZNw==", "X-Received": "by 2002:a19:2c94:: with SMTP id\n\ts142-v6mr1142223lfs.121.1529065529372; \n\tFri, 15 Jun 2018 05:25:29 -0700 (PDT)", "From": "Dariusz Stojaczyk <darek.stojaczyk@gmail.com>", "To": "dev@dpdk.org,\n\tAnatoly Burakov <anatoly.burakov@intel.com>", "Cc": "Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 15 Jun 2018 14:24:48 +0200", "Message-Id": "<20180615122448.28118-1-darek.stojaczyk@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH] memory: make eal_get_virtual_area() aware of\n\tbase-virtaddr alignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>\n\nWhenever a calculated base-virtaddr offset had to be\nmanually aligned to requested page_sz, we did not take\naccount of that alignment in incrementing the base-virtaddr\noffset further. The next requested virtual area could print\na warning \"hint [...] not respected!\" and let the system\npick an address instead. As a result, this breaks secondary\nprocess support on many system configurations.\n\nFixes: b7cc54187ea4 (\"mem: move virtual area function in common directory\")\nCc: anatoly.burakov@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>\n---\n lib/librte_eal/common/eal_common_memory.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c\nindex 4f0688f9d..7c8a316c2 100644\n--- a/lib/librte_eal/common/eal_common_memory.c\n+++ b/lib/librte_eal/common/eal_common_memory.c\n@@ -34,7 +34,7 @@\n \n #define MEMSEG_LIST_FMT \"memseg-%\" PRIu64 \"k-%i-%i\"\n \n-static uint64_t baseaddr_offset;\n+static void *next_baseaddr;\n static uint64_t system_page_sz;\n \n void *\n@@ -56,9 +56,11 @@ eal_get_virtual_area(void *requested_addr, size_t *size,\n \tallow_shrink = (flags & EAL_VIRTUAL_AREA_ALLOW_SHRINK) > 0;\n \tunmap = (flags & EAL_VIRTUAL_AREA_UNMAP) > 0;\n \n-\tif (requested_addr == NULL && internal_config.base_virtaddr != 0) {\n-\t\trequested_addr = (void *) (internal_config.base_virtaddr +\n-\t\t\t\t(size_t)baseaddr_offset);\n+\tif (next_baseaddr == NULL && internal_config.base_virtaddr != 0)\n+\t\tnext_baseaddr = (void *) internal_config.base_virtaddr;\n+\n+\tif (requested_addr == NULL && next_baseaddr) {\n+\t\trequested_addr = next_baseaddr;\n \t\trequested_addr = RTE_PTR_ALIGN(requested_addr, page_sz);\n \t\taddr_is_hint = true;\n \t}\n@@ -116,6 +118,8 @@ eal_get_virtual_area(void *requested_addr, size_t *size,\n \t\tRTE_LOG(WARNING, EAL, \"WARNING! Base virtual address hint (%p != %p) not respected!\\n\",\n \t\t\trequested_addr, aligned_addr);\n \t\tRTE_LOG(WARNING, EAL, \" This may cause issues with mapping memory into secondary processes\\n\");\n+\t} else {\n+\t\tnext_baseaddr = RTE_PTR_ADD(aligned_addr, *size);\n \t}\n \n \tRTE_LOG(DEBUG, EAL, \"Virtual area found at %p (size = 0x%zx)\\n\",\n@@ -148,8 +152,6 @@ eal_get_virtual_area(void *requested_addr, size_t *size,\n \t\t\tmunmap(aligned_end, after_len);\n \t}\n \n-\tbaseaddr_offset += *size;\n-\n \treturn aligned_addr;\n }\n \n", "prefixes": [] }