Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41074/?format=api
{ "id": 41074, "url": "http://patches.dpdk.org/api/patches/41074/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180613184626.13458-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180613184626.13458-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180613184626.13458-1-stephen@networkplumber.org", "date": "2018-06-13T18:46:26", "name": "mlx5: fix log initialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a6daa3f81c86e5d1b4cce73c56fe251f70f41a0b", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180613184626.13458-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 114, "url": "http://patches.dpdk.org/api/series/114/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=114", "date": "2018-06-13T18:46:26", "name": "mlx5: fix log initialization", "version": 1, "mbox": "http://patches.dpdk.org/series/114/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41074/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41074/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DD7341F007;\n\tWed, 13 Jun 2018 20:46:32 +0200 (CEST)", "from mail-pg0-f68.google.com (mail-pg0-f68.google.com\n\t[74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 0C7531F006\n\tfor <dev@dpdk.org>; Wed, 13 Jun 2018 20:46:31 +0200 (CEST)", "by mail-pg0-f68.google.com with SMTP id c9-v6so1698900pgf.5\n\tfor <dev@dpdk.org>; Wed, 13 Jun 2018 11:46:30 -0700 (PDT)", "from xeon-e3.lan (204-195-35-107.wavecable.com. [204.195.35.107])\n\tby smtp.gmail.com with ESMTPSA id\n\tq200-v6sm4388964pgq.9.2018.06.13.11.46.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Jun 2018 11:46:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=eDmjv04LWqGyDvx4OMVUyeRAtFAthLcVOeDCFOJMcc4=;\n\tb=ddmWKwvIh7yuKQahwDPrGhUv8Tbf7sGPOs6ea7jRspdog4FXmZsNrCj2foGSF5z/6c\n\tu5KemPn7Ahjlrg1zdNGka9FOZ+W5RBM+yQniqom5xnjRS+OjFyhIPtLNmotCIW972P0M\n\ta63TUU9c8L8j47Oqsd5STzhrfRLWOlu0e/5QNOiZLpuf0u0AQJul4RnUMECtsJkXj1uJ\n\t8sN/7mkR3dWo4cfOKEQeG7TSSbfVjI0rhmj4SHrLrc1went2UGMu405MPOSmVzu8pCkK\n\taCNQgAFwTOvfS7EXQJ87O4oGu6VyVCDCpA1GV8xdovjNcvWxeK16PprPDw4rU6dKDNbe\n\tMBpQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=eDmjv04LWqGyDvx4OMVUyeRAtFAthLcVOeDCFOJMcc4=;\n\tb=DpIHY5qCAU+mhzVOXxbqOrLmNWnZHQrgnJGyq7deuqn4DCLqDG89S0iUGub2o389Uv\n\t0HGUdd7zlsOU5e/0moDnPNvVTsk1GYdLKkI5sn8VUuSbuOrZ2a4Gg2ZdhrcIykNV6fKj\n\te5jElEaVMl+6S+s1l8z2ZDuGoyF1yJnKJG5H39w0/RWx6LFDWD5BJpOsjOQmDNeQ55BN\n\t8yYdYCcY/pUPn6t6TbWKU4kKnCwLCDRs19Ms2kdK+H6x8QzzALmRCIh2N6V+0Ihz+J+c\n\tF+1d75WSYu6RIuSLc2evyoFv3P9z3VjRmzDcI9642g/hwHeJAf3Wqt3/XXJO2wqLiSxz\n\t75Cw==", "X-Gm-Message-State": "APt69E2G92ZdU+4cE67BnjNZHnl8S5cGsoC1upn+gMQQo6E8AKtWC3ds\n\tKUfEgevvG2uvFECag0iFchpDuKEBrQY=", "X-Google-Smtp-Source": "ADUXVKIkJwvMQy9QJRNEQAH4YA5uB0UR5LaZcVNDOG43yf2zmp32RxIE+XWVkRmWZ4QyRvS2t137DQ==", "X-Received": "by 2002:a62:1f45:: with SMTP id\n\tf66-v6mr6010327pff.253.1528915589969; \n\tWed, 13 Jun 2018 11:46:29 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 13 Jun 2018 11:46:26 -0700", "Message-Id": "<20180613184626.13458-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] mlx5: fix log initialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The mlx5 driver had two init functions, but this could\ncause log initialization to be done after the\nother initialization. Also, the name of the function does\nnot match convention (cut/paste error?).\n\nFix by initializing log type first at start of the pmd_init.\nThis also gets rid of having two constructor functions.\n\nFixes: a170a30d22a8 (\"net/mlx5: use dynamic logging\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/mlx5/mlx5.c | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex c933e274fe32..6ec4f3178b6b 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1439,6 +1439,11 @@ RTE_INIT(rte_mlx5_pmd_init);\n static void\n rte_mlx5_pmd_init(void)\n {\n+\t/* Initialize driver log type. */\n+\tmlx5_logtype = rte_log_register(\"pmd.net.mlx5\");\n+\tif (mlx5_logtype >= 0)\n+\t\trte_log_set_level(mlx5_logtype, RTE_LOG_NOTICE);\n+\n \t/* Build the static tables for Verbs conversion. */\n \tmlx5_set_ptype_table();\n \tmlx5_set_cksum_table();\n@@ -1480,11 +1485,3 @@ rte_mlx5_pmd_init(void)\n RTE_PMD_EXPORT_NAME(net_mlx5, __COUNTER__);\n RTE_PMD_REGISTER_PCI_TABLE(net_mlx5, mlx5_pci_id_map);\n RTE_PMD_REGISTER_KMOD_DEP(net_mlx5, \"* ib_uverbs & mlx5_core & mlx5_ib\");\n-\n-/** Initialize driver log type. */\n-RTE_INIT(vdev_netvsc_init_log)\n-{\n-\tmlx5_logtype = rte_log_register(\"pmd.net.mlx5\");\n-\tif (mlx5_logtype >= 0)\n-\t\trte_log_set_level(mlx5_logtype, RTE_LOG_NOTICE);\n-}\n", "prefixes": [] }