Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41031,
    "url": "http://patches.dpdk.org/api/patches/41031/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1528890858-49222-1-git-send-email-xiangxia.m.yue@gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1528890858-49222-1-git-send-email-xiangxia.m.yue@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1528890858-49222-1-git-send-email-xiangxia.m.yue@gmail.com",
    "date": "2018-06-13T11:54:18",
    "name": "vhost: introduce new function helper",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "53258ee9111f474ca13a91e0acfff0a0de4f7f7c",
    "submitter": {
        "id": 834,
        "url": "http://patches.dpdk.org/api/people/834/?format=api",
        "name": "Tonghao Zhang",
        "email": "xiangxia.m.yue@gmail.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1528890858-49222-1-git-send-email-xiangxia.m.yue@gmail.com/mbox/",
    "series": [
        {
            "id": 109,
            "url": "http://patches.dpdk.org/api/series/109/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=109",
            "date": "2018-06-13T11:54:18",
            "name": "vhost: introduce new function helper",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/109/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/41031/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/41031/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 20AAD1E4B4;\n\tWed, 13 Jun 2018 13:54:29 +0200 (CEST)",
            "from mail-pl0-f65.google.com (mail-pl0-f65.google.com\n\t[209.85.160.65]) by dpdk.org (Postfix) with ESMTP id 437A31D531\n\tfor <dev@dpdk.org>; Wed, 13 Jun 2018 13:54:27 +0200 (CEST)",
            "by mail-pl0-f65.google.com with SMTP id 6-v6so867063plb.0\n\tfor <dev@dpdk.org>; Wed, 13 Jun 2018 04:54:27 -0700 (PDT)",
            "from local.opencloud.tech.localdomain ([13.94.31.177])\n\tby smtp.gmail.com with ESMTPSA id\n\tu90-v6sm7751364pfa.101.2018.06.13.04.54.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Jun 2018 04:54:25 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=1/Asuwed07gqt3iQQ0be98Py5DMpRDYqVKc2DEEy6hg=;\n\tb=qdiewNMS2qEHb1cSPl3azcottS16AcpAMxsC7FG3f503xZqc8OFowSBoQSmqzRm15g\n\tN7KggKiWYiJ21r9ZstcudTrAcqHj6A+hLW/sNnY92jQ/CLnaW3n0AiojmqMG6jFOYMY/\n\tiRTDqdPHYfKLVYj89H8C0vv+xr1GpmUHFUfwTgEQkThs1Bliha715bAtBjEptrhoYOl8\n\t7wjCSRE+Nir4lp7vu+E1S3c36mz6AzO9q0xn4HZQ72JrWLlQY66QVCuWl4QhudAE58Db\n\tscDkN285kS3LKoZGWzseJy/q59JGDU51+EnvanUpQcSdPlcUsjBFFrMlEQshu/kIaxu5\n\tLZ0A==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=1/Asuwed07gqt3iQQ0be98Py5DMpRDYqVKc2DEEy6hg=;\n\tb=aGUiZb6jZCnC1tPb3Q1/M3wsg9aqUFIog4kdnH1L7HNuE57BSatokBZsLFWWqMF871\n\tK7YlGrd1OdYzHUSVeQJmPw6AgsW+VajpXdwFeyz7gZqwb2j4hIvFq7x5BS8Qbjb6yVXV\n\t4JyMq3OiiUTC/rcHb6aOJ44pY8HMwphcpnlDOhMSWoilCbPRx/p9BEJQ/OUBRTQ0NJj7\n\trC94yu0PDQJlUFVS70RvV+apKk92CsrA8JGVRkDi2W5lyjNfpNWabVh9xoZvTaVI8lZc\n\t4xVRcSJPv4XgKOOI6+mo0yyuOpOuIn2LqP5WMlQMGJv5LhllizBSHEzGRwiiAA3qzhVK\n\tYZ3Q==",
        "X-Gm-Message-State": "APt69E3r+caa2UQbl64os5HOgAF/TQuLuo/gOIAlK1SQ9FBD/wdJGOG4\n\tuMpVomT/LSur+zZFZCjbR35XN9Ow",
        "X-Google-Smtp-Source": "ADUXVKLYwkrf8S3YxQk2OsUSU24y4u9SHb6N0Hl0ScKRLEBMAnHayETP7vl4MSPNhhtp2JYFfd/ikQ==",
        "X-Received": "by 2002:a17:902:7089:: with SMTP id\n\tz9-v6mr4812821plk.231.1528890866257; \n\tWed, 13 Jun 2018 04:54:26 -0700 (PDT)",
        "From": "xiangxia.m.yue@gmail.com",
        "To": "dev@dpdk.org",
        "Cc": "Tonghao Zhang <xiangxia.m.yue@gmail.com>",
        "Date": "Wed, 13 Jun 2018 04:54:18 -0700",
        "Message-Id": "<1528890858-49222-1-git-send-email-xiangxia.m.yue@gmail.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH] vhost: introduce new function helper",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n\nIntroduce an new common helper to avoid redundancy.\n\nSigned-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n---\n lib/librte_vhost/vhost.c      | 27 +++++++++++++++++----------\n lib/librte_vhost/vhost.h      |  1 +\n lib/librte_vhost/vhost_user.c | 23 ++---------------------\n 3 files changed, 20 insertions(+), 31 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c\nindex afded49..493b204 100644\n--- a/lib/librte_vhost/vhost.c\n+++ b/lib/librte_vhost/vhost.c\n@@ -295,6 +295,22 @@\n \treturn i;\n }\n \n+void\n+vhost_destroy_device_notify(struct virtio_net *dev)\n+{\n+\tstruct rte_vdpa_device *vdpa_dev;\n+\tint did;\n+\n+\tif (dev->flags & VIRTIO_DEV_RUNNING) {\n+\t\tdid = dev->vdpa_dev_id;\n+\t\tvdpa_dev = rte_vdpa_get_device(did);\n+\t\tif (vdpa_dev && vdpa_dev->ops->dev_close)\n+\t\t\tvdpa_dev->ops->dev_close(dev->vid);\n+\t\tdev->flags &= ~VIRTIO_DEV_RUNNING;\n+\t\tdev->notify_ops->destroy_device(dev->vid);\n+\t}\n+}\n+\n /*\n  * Invoked when there is the vhost-user connection is broken (when\n  * the virtio device is being detached).\n@@ -303,20 +319,11 @@\n vhost_destroy_device(int vid)\n {\n \tstruct virtio_net *dev = get_device(vid);\n-\tstruct rte_vdpa_device *vdpa_dev;\n-\tint did = -1;\n \n \tif (dev == NULL)\n \t\treturn;\n \n-\tif (dev->flags & VIRTIO_DEV_RUNNING) {\n-\t\tdid = dev->vdpa_dev_id;\n-\t\tvdpa_dev = rte_vdpa_get_device(did);\n-\t\tif (vdpa_dev && vdpa_dev->ops->dev_close)\n-\t\t\tvdpa_dev->ops->dev_close(dev->vid);\n-\t\tdev->flags &= ~VIRTIO_DEV_RUNNING;\n-\t\tdev->notify_ops->destroy_device(vid);\n-\t}\n+\tvhost_destroy_device_notify(dev);\n \n \tcleanup_device(dev, 1);\n \tfree_device(dev);\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 58c425a..cd1cfcb 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -535,6 +535,7 @@ struct virtio_net {\n void cleanup_device(struct virtio_net *dev, int destroy);\n void reset_device(struct virtio_net *dev);\n void vhost_destroy_device(int);\n+void vhost_destroy_device_notify(struct virtio_net *dev);\n \n void cleanup_vq(struct vhost_virtqueue *vq, int destroy);\n void free_vq(struct vhost_virtqueue *vq);\ndiff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 947290f..6e8d566 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -135,17 +135,7 @@\n static int\n vhost_user_reset_owner(struct virtio_net *dev)\n {\n-\tstruct rte_vdpa_device *vdpa_dev;\n-\tint did = -1;\n-\n-\tif (dev->flags & VIRTIO_DEV_RUNNING) {\n-\t\tdid = dev->vdpa_dev_id;\n-\t\tvdpa_dev = rte_vdpa_get_device(did);\n-\t\tif (vdpa_dev && vdpa_dev->ops->dev_close)\n-\t\t\tvdpa_dev->ops->dev_close(dev->vid);\n-\t\tdev->flags &= ~VIRTIO_DEV_RUNNING;\n-\t\tdev->notify_ops->destroy_device(dev->vid);\n-\t}\n+\tvhost_destroy_device_notify(dev);\n \n \tcleanup_device(dev, 0);\n \treset_device(dev);\n@@ -996,18 +986,9 @@\n \t\t\t  VhostUserMsg *msg)\n {\n \tstruct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];\n-\tstruct rte_vdpa_device *vdpa_dev;\n-\tint did = -1;\n \n \t/* We have to stop the queue (virtio) if it is running. */\n-\tif (dev->flags & VIRTIO_DEV_RUNNING) {\n-\t\tdid = dev->vdpa_dev_id;\n-\t\tvdpa_dev = rte_vdpa_get_device(did);\n-\t\tif (vdpa_dev && vdpa_dev->ops->dev_close)\n-\t\t\tvdpa_dev->ops->dev_close(dev->vid);\n-\t\tdev->flags &= ~VIRTIO_DEV_RUNNING;\n-\t\tdev->notify_ops->destroy_device(dev->vid);\n-\t}\n+\tvhost_destroy_device_notify(dev);\n \n \tdev->flags &= ~VIRTIO_DEV_READY;\n \tdev->flags &= ~VIRTIO_DEV_VDPA_CONFIGURED;\n",
    "prefixes": []
}