Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41024/?format=api
{ "id": 41024, "url": "http://patches.dpdk.org/api/patches/41024/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1528877482-5029-1-git-send-email-wei.zhao1@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528877482-5029-1-git-send-email-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528877482-5029-1-git-send-email-wei.zhao1@intel.com", "date": "2018-06-13T08:11:22", "name": "[v2] net/ixgbe: fix tunnel id format error for FDIR", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "79b0f62750d25a0dc1cc0a3a4871c78b5efd23a2", "submitter": { "id": 495, "url": "http://patches.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1528877482-5029-1-git-send-email-wei.zhao1@intel.com/mbox/", "series": [ { "id": 104, "url": "http://patches.dpdk.org/api/series/104/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=104", "date": "2018-06-13T08:11:22", "name": "[v2] net/ixgbe: fix tunnel id format error for FDIR", "version": 2, "mbox": "http://patches.dpdk.org/series/104/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/41024/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/41024/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 52F1C1EF37;\n\tWed, 13 Jun 2018 10:32:08 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 01D761EE60;\n\tWed, 13 Jun 2018 10:32:05 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jun 2018 01:32:05 -0700", "from dpdk6.bj.intel.com ([172.16.182.94])\n\tby orsmga005.jf.intel.com with ESMTP; 13 Jun 2018 01:32:03 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,218,1526367600\"; d=\"scan'208\";a=\"232196204\"", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com,\n\tstable@dpdk.org,\n\tWei Zhao <wei.zhao1@intel.com>", "Date": "Wed, 13 Jun 2018 16:11:22 +0800", "Message-Id": "<1528877482-5029-1-git-send-email-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.7.5", "In-Reply-To": "<1528189935-34943-4-git-send-email-wei.zhao1@intel.com>", "References": "<1528189935-34943-4-git-send-email-wei.zhao1@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel id format error for FDIR", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In cloud mode for FDIR, tunnel id should be set as protocol\nrequest, the lower 8 bits should be set as reserved.\n\nFixes: 82fb702077f6 (\"ixgbe: support new flow director modes for X550\")\nFixes: 11777435c727 (\"net/ixgbe: parse flow director filter\")\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n---\n\nv2:\n-fix tni bit format error in v1.\n\n---\n drivers/net/ixgbe/ixgbe_fdir.c | 2 +-\n drivers/net/ixgbe/ixgbe_flow.c | 5 +----\n 2 files changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c\nindex d5e5179..67ab627 100644\n--- a/drivers/net/ixgbe/ixgbe_fdir.c\n+++ b/drivers/net/ixgbe/ixgbe_fdir.c\n@@ -774,7 +774,7 @@ ixgbe_fdir_filter_to_atr_input(const struct rte_eth_fdir_filter *fdir_filter,\n \t\tinput->formatted.tunnel_type =\n \t\t\tfdir_filter->input.flow.tunnel_flow.tunnel_type;\n \t\tinput->formatted.tni_vni =\n-\t\t\tfdir_filter->input.flow.tunnel_flow.tunnel_id;\n+\t\t\tfdir_filter->input.flow.tunnel_flow.tunnel_id >> 8;\n \t}\n \n \treturn 0;\ndiff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c\nindex eb0644c..f47f125 100644\n--- a/drivers/net/ixgbe/ixgbe_flow.c\n+++ b/drivers/net/ixgbe/ixgbe_flow.c\n@@ -2487,10 +2487,8 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,\n \t\t\trule->b_spec = TRUE;\n \t\t\tvxlan_spec = item->spec;\n \t\t\trte_memcpy(((uint8_t *)\n-\t\t\t\t&rule->ixgbe_fdir.formatted.tni_vni + 1),\n+\t\t\t\t&rule->ixgbe_fdir.formatted.tni_vni),\n \t\t\t\tvxlan_spec->vni, RTE_DIM(vxlan_spec->vni));\n-\t\t\trule->ixgbe_fdir.formatted.tni_vni = rte_be_to_cpu_32(\n-\t\t\t\trule->ixgbe_fdir.formatted.tni_vni);\n \t\t}\n \t}\n \n@@ -2587,7 +2585,6 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,\n \t\t\t/* tni is a 24-bits bit field */\n \t\t\trte_memcpy(&rule->ixgbe_fdir.formatted.tni_vni,\n \t\t\tnvgre_spec->tni, RTE_DIM(nvgre_spec->tni));\n-\t\t\trule->ixgbe_fdir.formatted.tni_vni <<= 8;\n \t\t}\n \t}\n \n", "prefixes": [ "v2" ] }