Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 40967,
    "url": "http://patches.dpdk.org/api/patches/40967/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1528710637-8313-1-git-send-email-alejandro.lucero@netronome.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1528710637-8313-1-git-send-email-alejandro.lucero@netronome.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1528710637-8313-1-git-send-email-alejandro.lucero@netronome.com",
    "date": "2018-06-11T09:50:37",
    "name": "net/nfp: fix field initialization in TX descriptor",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "266d7ea070f4867dda73e4d8a10c2ead314b2076",
    "submitter": {
        "id": 270,
        "url": "http://patches.dpdk.org/api/people/270/?format=api",
        "name": "Alejandro Lucero",
        "email": "alejandro.lucero@netronome.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1528710637-8313-1-git-send-email-alejandro.lucero@netronome.com/mbox/",
    "series": [
        {
            "id": 73,
            "url": "http://patches.dpdk.org/api/series/73/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=73",
            "date": "2018-06-11T09:50:37",
            "name": "net/nfp: fix field initialization in TX descriptor",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/73/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/40967/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/40967/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 254681E899;\n\tMon, 11 Jun 2018 11:50:54 +0200 (CEST)",
            "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 3C0A21E882;\n\tMon, 11 Jun 2018 11:50:52 +0200 (CEST)",
            "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tw5B9obVF008351; Mon, 11 Jun 2018 10:50:37 +0100",
            "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id w5B9obrj008350;\n\tMon, 11 Jun 2018 10:50:37 +0100"
        ],
        "From": "Alejandro Lucero <alejandro.lucero@netronome.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org",
        "Date": "Mon, 11 Jun 2018 10:50:37 +0100",
        "Message-Id": "<1528710637-8313-1-git-send-email-alejandro.lucero@netronome.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "Subject": "[dpdk-dev] [PATCH] net/nfp: fix field initialization in TX\n\tdescriptor",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "TX descriptor eop_offset field is not initialized and it could\ncontain garbage. This patch fixes the potential problem setting\nEOP as the only subfield. The other subfield, data offset, is\nnot used by now.\n\nFixes: b812daadad0d (\"nfp: add Rx and Tx\")\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\n---\n drivers/net/nfp/nfp_net.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex faad1ee..3658696 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -2253,11 +2253,15 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq)\n \t\t\t\ttxq->wr_p = 0;\n \n \t\t\tpkt_size -= dma_size;\n-\t\t\tif (!pkt_size)\n-\t\t\t\t/* End of packet */\n-\t\t\t\ttxds->offset_eop |= PCIE_DESC_TX_EOP;\n+\n+\t\t\t/*\n+\t\t\t * Making the EOP, packets with just one segment\n+\t\t\t * the priority\n+\t\t\t */\n+\t\t\tif (likely(!pkt_size))\n+\t\t\t\ttxds->offset_eop = PCIE_DESC_TX_EOP;\n \t\t\telse\n-\t\t\t\ttxds->offset_eop &= PCIE_DESC_TX_OFFSET_MASK;\n+\t\t\t\ttxds->offset_eop = 0;\n \n \t\t\tpkt = pkt->next;\n \t\t\t/* Referencing next free TX descriptor */\n",
    "prefixes": []
}