Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40959/?format=api
http://patches.dpdk.org/api/patches/40959/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180608220234.10170-2-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180608220234.10170-2-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180608220234.10170-2-pablo.de.lara.guarch@intel.com", "date": "2018-06-08T22:02:29", "name": "[1/6] cryptodev: replace bus specific struct with generic dev", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ac86740bb012c42c90615fbaaa77181b740d19fe", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180608220234.10170-2-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 70, "url": "http://patches.dpdk.org/api/series/70/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=70", "date": "2018-06-08T22:02:28", "name": "Cryptodev API changes", "version": 1, "mbox": "http://patches.dpdk.org/series/70/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/40959/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/40959/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0E9541CD9F;\n\tSat, 9 Jun 2018 00:02:21 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id C4AE31CD9F\n\tfor <dev@dpdk.org>; Sat, 9 Jun 2018 00:02:18 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jun 2018 15:02:17 -0700", "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby fmsmga004.fm.intel.com with ESMTP; 08 Jun 2018 15:02:14 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,491,1520924400\"; d=\"scan'208\";a=\"61618409\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com, akhil.goyal@nxp.com, ravi1.kumar@amd.com,\n\tjerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com,\n\tfiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Fri, 8 Jun 2018 23:02:29 +0100", "Message-Id": "<20180608220234.10170-2-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.17.0", "In-Reply-To": "<20180608220234.10170-1-pablo.de.lara.guarch@intel.com>", "References": "<20180608220234.10170-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/6] cryptodev: replace bus specific struct with\n\tgeneric dev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Structure rte_cryptodev_info has currently PCI device\ninformation (\"struct rte_pci_device\") in it.\n\nThis information is not generic to all devices,\nso this gets replaced with the generic \"rte_device\" structure,\ncompatible with all crypto devices.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n doc/guides/prog_guide/cryptodev_lib.rst | 2 +-\n doc/guides/rel_notes/deprecation.rst | 2 --\n doc/guides/rel_notes/release_18_08.rst | 5 ++++-\n drivers/crypto/qat/qat_crypto.c | 1 -\n drivers/crypto/virtio/virtio_cryptodev.c | 1 -\n lib/librte_cryptodev/rte_cryptodev.c | 1 +\n lib/librte_cryptodev/rte_cryptodev.h | 2 +-\n 7 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst\nindex 30f0bcf7a..d02bb7514 100644\n--- a/doc/guides/prog_guide/cryptodev_lib.rst\n+++ b/doc/guides/prog_guide/cryptodev_lib.rst\n@@ -269,7 +269,7 @@ relevant information for the device.\n struct rte_cryptodev_info {\n const char *driver_name;\n uint8_t driver_id;\n- struct rte_pci_device *pci_dev;\n+ struct rte_device *device;\n \n uint64_t feature_flags;\n \ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 1ce692eac..b71080bb8 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -104,8 +104,6 @@ Deprecation Notices\n - Removal of ``sym`` structure in ``rte_cryptodev_info`` structure,\n containing fields not relevant anymore since the session mempool\n is not internal in the crypto device anymore.\n- - Replacement of ``pci_dev`` field with the more generic ``rte_device``\n- structure.\n - Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and\n ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from\n 18.05 and removed in 18.08, as there are no drivers doing anything useful\ndiff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst\nindex 5bc23c537..ba710e845 100644\n--- a/doc/guides/rel_notes/release_18_08.rst\n+++ b/doc/guides/rel_notes/release_18_08.rst\n@@ -55,6 +55,9 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* cryptodev: In struct ``struct rte_cryptodev_info``, field ``rte_pci_device *pci_dev``\n+ has been replaced with field ``struct rte_device *device``.\n+\n \n ABI Changes\n -----------\n@@ -113,7 +116,7 @@ The libraries prepended with a plus sign were incremented in this version.\n librte_cmdline.so.2\n librte_common_octeontx.so.1\n librte_compressdev.so.1\n- librte_cryptodev.so.4\n+ + librte_cryptodev.so.5\n librte_distributor.so.1\n librte_eal.so.7\n librte_ethdev.so.9\ndiff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c\nindex d9ce2a136..768dcbae0 100644\n--- a/drivers/crypto/qat/qat_crypto.c\n+++ b/drivers/crypto/qat/qat_crypto.c\n@@ -1656,7 +1656,6 @@ void qat_dev_info_get(struct rte_cryptodev *dev,\n \t\tinfo->capabilities = internals->qat_dev_capabilities;\n \t\tinfo->sym.max_nb_sessions = internals->max_nb_sessions;\n \t\tinfo->driver_id = cryptodev_qat_driver_id;\n-\t\tinfo->pci_dev = RTE_DEV_TO_PCI(dev->device);\n \t}\n }\n \ndiff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c\nindex df88953f6..482edea1a 100644\n--- a/drivers/crypto/virtio/virtio_cryptodev.c\n+++ b/drivers/crypto/virtio/virtio_cryptodev.c\n@@ -1409,7 +1409,6 @@ virtio_crypto_dev_info_get(struct rte_cryptodev *dev,\n \n \tif (info != NULL) {\n \t\tinfo->driver_id = cryptodev_virtio_driver_id;\n-\t\tinfo->pci_dev = RTE_DEV_TO_PCI(dev->device);\n \t\tinfo->feature_flags = dev->feature_flags;\n \t\tinfo->max_nb_queue_pairs = hw->max_dataqueues;\n \t\tinfo->sym.max_nb_sessions =\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 7e5821246..457ac5670 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -966,6 +966,7 @@ rte_cryptodev_info_get(uint8_t dev_id, struct rte_cryptodev_info *dev_info)\n \t(*dev->dev_ops->dev_infos_get)(dev, dev_info);\n \n \tdev_info->driver_name = dev->device->driver->name;\n+\tdev_info->device = dev->device;\n }\n \n \ndiff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h\nindex 92ce6d49a..80cd6b474 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.h\n+++ b/lib/librte_cryptodev/rte_cryptodev.h\n@@ -371,7 +371,7 @@ rte_cryptodev_get_feature_name(uint64_t flag);\n struct rte_cryptodev_info {\n \tconst char *driver_name;\t\t/**< Driver name. */\n \tuint8_t driver_id;\t\t\t/**< Driver identifier */\n-\tstruct rte_pci_device *pci_dev;\t\t/**< PCI information. */\n+\tstruct rte_device *device;\t\t/**< Generic device information. */\n \n \tuint64_t feature_flags;\n \t/**< Feature flags exposes HW/SW features for the given device */\n", "prefixes": [ "1/6" ] }{ "id": 40959, "url": "