Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40811/?format=api
{ "id": 40811, "url": "http://patches.dpdk.org/api/patches/40811/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com", "date": "2018-06-08T12:37:07", "name": "[dpdk-dev,2/2] eal/thread: fix return codes for rte_ctrl_thread_create()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7c97a0d60188f1aef2dc58f656ea3a1cc0dbab16", "submitter": { "id": 744, "url": "http://patches.dpdk.org/api/people/744/?format=api", "name": "Stojaczyk, DariuszX", "email": "dariuszx.stojaczyk@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com/mbox/", "series": [ { "id": 44, "url": "http://patches.dpdk.org/api/series/44/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=44", "date": "2018-06-08T12:37:06", "name": "[dpdk-dev,1/2] eal/thread: fix return codes for rte_thread_setname()", "version": 1, "mbox": "http://patches.dpdk.org/series/44/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/40811/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/40811/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C3580A496;\n\tFri, 8 Jun 2018 10:56:09 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 23286A48C;\n\tFri, 8 Jun 2018 10:56:07 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jun 2018 01:56:07 -0700", "from kraken.imu.intel.com (HELO Sent) ([10.217.246.153])\n\tby fmsmga001.fm.intel.com with SMTP; 08 Jun 2018 01:56:05 -0700", "by Sent (sSMTP sendmail emulation); Fri, 08 Jun 2018 14:41:27 +0200" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,490,1520924400\"; d=\"scan'208\";a=\"62360875\"", "From": "Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>", "To": "dev@dpdk.org", "Cc": "Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, olivier.matz@6wind.com,\n\tstable@dpdk.org", "Date": "Fri, 8 Jun 2018 14:37:07 +0200", "Message-Id": "<1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com>", "References": "<1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for\n\trte_ctrl_thread_create()", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This function returned positive error numbers instead\nof negative ones as desbribed in the doc. What's worse,\nmultiple of its callers only check for (rc < 0) to detect\nfailure.\n\nIt was incorrectly assumed that pthread_create\nand pthread_setaffinity_np return negative errnos. They\nalways returns positive ones, so this patch negates their\nreturn values before returning.\n\nFixes: 9e5afc72c909 (\"eal: add function to create control threads\")\nCc: olivier.matz@6wind.com\nCc: stable@dpdk.org\n\nSigned-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>\n---\n lib/librte_eal/common/eal_common_thread.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c\nindex 8110ac2..48ef4d6 100644\n--- a/lib/librte_eal/common/eal_common_thread.c\n+++ b/lib/librte_eal/common/eal_common_thread.c\n@@ -175,7 +175,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,\n \n \tparams = malloc(sizeof(*params));\n \tif (!params)\n-\t\treturn -1;\n+\t\treturn -ENOMEM;\n \n \tparams->start_routine = start_routine;\n \tparams->arg = arg;\n@@ -185,7 +185,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,\n \tret = pthread_create(thread, attr, rte_thread_init, (void *)params);\n \tif (ret != 0) {\n \t\tfree(params);\n-\t\treturn ret;\n+\t\treturn -ret;\n \t}\n \n \tif (name != NULL) {\n@@ -228,5 +228,5 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,\n \t}\n \tpthread_cancel(*thread);\n \tpthread_join(*thread, NULL);\n-\treturn ret;\n+\treturn -ret;\n }\n", "prefixes": [ "dpdk-dev", "2/2" ] }