Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40785/?format=api
{ "id": 40785, "url": "http://patches.dpdk.org/api/patches/40785/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1b90d1177e1bec6ba4f862ad59e888f6add0480f.1528404133.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1b90d1177e1bec6ba4f862ad59e888f6add0480f.1528404133.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1b90d1177e1bec6ba4f862ad59e888f6add0480f.1528404133.git.anatoly.burakov@intel.com", "date": "2018-06-07T21:01:56", "name": "[dpdk-dev,2/7] autotest: fix invalid code on reports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0b9d275bc6aa79edb1b713badbe611bf0891cc66", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1b90d1177e1bec6ba4f862ad59e888f6add0480f.1528404133.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 37, "url": "http://patches.dpdk.org/api/series/37/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=37", "date": "2018-06-07T21:01:54", "name": "Make unit tests great again", "version": 1, "mbox": "http://patches.dpdk.org/series/37/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/40785/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/40785/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 777EF1B1B3;\n\tThu, 7 Jun 2018 23:02:17 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id F34A7D14E;\n\tThu, 7 Jun 2018 23:02:07 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jun 2018 14:02:04 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 07 Jun 2018 14:02:02 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw57L216E023031; Thu, 7 Jun 2018 22:02:02 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w57L212w004360;\n\tThu, 7 Jun 2018 22:02:01 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w57L21x4004356;\n\tThu, 7 Jun 2018 22:02:01 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,488,1520924400\"; d=\"scan'208\";a=\"54944943\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "john.mcnamara@intel.com, reshma.pattan@intel.com,\n\tbruce.richardson@intel.com, stable@dpdk.org", "Date": "Thu, 7 Jun 2018 22:01:56 +0100", "Message-Id": "<1b90d1177e1bec6ba4f862ad59e888f6add0480f.1528404133.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1528404133.git.anatoly.burakov@intel.com>", "<cover.1528404133.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1528404133.git.anatoly.burakov@intel.com>", "<cover.1528404133.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 2/7] autotest: fix invalid code on reports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are no reports defined for any test, so this codepath was\nnever triggered, but it's still wrong because it's referencing\nvariables that aren't there. Fix it by passing target into the\ntest function, and reference correct log variable.\n\nFixes: e2cc79b75d9f (\"app: rework autotest.py\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n test/test/autotest_runner.py | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py\nindex b09b57876..bdc32da5d 100644\n--- a/test/test/autotest_runner.py\n+++ b/test/test/autotest_runner.py\n@@ -41,7 +41,7 @@ def wait_prompt(child):\n # quite a bit of effort to make it work).\n \n \n-def run_test_group(cmdline, test_group):\n+def run_test_group(cmdline, target, test_group):\n results = []\n child = None\n start_time = time.time()\n@@ -128,14 +128,15 @@ def run_test_group(cmdline, test_group):\n # make a note when the test was finished\n end_time = time.time()\n \n+ log = logfile.getvalue()\n+\n # append test data to the result tuple\n- result += (test[\"Name\"], end_time - start_time,\n- logfile.getvalue())\n+ result += (test[\"Name\"], end_time - start_time, log)\n \n # call report function, if any defined, and supply it with\n # target and complete log for test run\n if test[\"Report\"]:\n- report = test[\"Report\"](self.target, log)\n+ report = test[\"Report\"](target, log)\n \n # append report to results tuple\n result += (report,)\n@@ -343,6 +344,7 @@ def run_all_tests(self):\n for test_group in self.parallel_test_groups:\n result = pool.apply_async(run_test_group,\n [self.__get_cmdline(test_group),\n+ self.target,\n test_group])\n results.append(result)\n \n@@ -367,7 +369,7 @@ def run_all_tests(self):\n # run non_parallel tests. they are run one by one, synchronously\n for test_group in self.non_parallel_test_groups:\n group_result = run_test_group(\n- self.__get_cmdline(test_group), test_group)\n+ self.__get_cmdline(test_group), self.target, test_group)\n \n self.__process_results(group_result)\n \n", "prefixes": [ "dpdk-dev", "2/7" ] }