Patch Comment List
List patch comments
GET /api/patches/40757/comments/?format=api&order=-submitter
[ { "id": 81959, "web_url": "http://patches.dpdk.org/comment/81959/", "msgid": "<CAG2-GkkVaxrFMteCMRiAkmQKGDoUwz0K99Up3Hvfe7mYd62Pcw@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAG2-GkkVaxrFMteCMRiAkmQKGDoUwz0K99Up3Hvfe7mYd62Pcw@mail.gmail.com", "date": "2018-06-07T14:21:45", "subject": "Re: [dpdk-dev] [PATCH 13/22] net/bonding: enable port detach on\n\tsecondary process", "submitter": { "id": 341, "url": "http://patches.dpdk.org/api/people/341/?format=api", "name": "Chas Williams", "email": "3chas3@gmail.com" }, "content": "On Thu, Jun 7, 2018 at 8:38 AM, Qi Zhang <qi.z.zhang@intel.com> wrote:\n\n> Previously, detach port on secondary process will mess primary\n> process and cause same device can't be attached again, by take\n> advantage of rte_eth_release_port_local, we can support this with\n> minor change.\n>\n\nThis commit message needs some work. Otherwise, I think this particular\npatch is fine.\n\n\n>\n> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>\n> ---\n> drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c\n> b/drivers/net/bonding/rte_eth_bond_pmd.c\n> index 02d94b1b1..1221f62b2 100644\n> --- a/drivers/net/bonding/rte_eth_bond_pmd.c\n> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n> @@ -3065,6 +3065,7 @@ bond_probe(struct rte_vdev_device *dev)\n> }\n> /* TODO: request info from primary to set up Rx and Tx */\n> eth_dev->dev_ops = &default_dev_ops;\n> + eth_dev->device = &dev->device;\n> rte_eth_dev_probing_finish(eth_dev);\n> return 0;\n> }\n> @@ -3171,6 +3172,16 @@ bond_remove(struct rte_vdev_device *dev)\n> if (eth_dev == NULL)\n> return -ENODEV;\n>\n> + if (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n> + /* detach device on local pprocess only */\n>\n\nprocess?\n\n\n> + if (strlen(rte_vdev_device_args(dev)) == 0)\n> + return rte_eth_dev_release_port_local(eth_dev);\n> + /**\n> + * else this is a private device for current process\n> + * so continue with normal detach scenario\n> + */\n> + }\n> +\n> RTE_ASSERT(eth_dev->device == &dev->device);\n>\n> internals = eth_dev->data->dev_private;\n> --\n> 2.13.6\n>\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 06FFD1B1AC;\n\tThu, 7 Jun 2018 16:21:48 +0200 (CEST)", "from mail-io0-f193.google.com (mail-io0-f193.google.com\n\t[209.85.223.193]) by dpdk.org (Postfix) with ESMTP id BCCE21B023\n\tfor <dev@dpdk.org>; Thu, 7 Jun 2018 16:21:46 +0200 (CEST)", "by mail-io0-f193.google.com with SMTP id t6-v6so12001964iob.10\n\tfor <dev@dpdk.org>; Thu, 07 Jun 2018 07:21:46 -0700 (PDT)", "by 2002:a6b:e90e:0:0:0:0:0 with HTTP;\n\tThu, 7 Jun 2018 07:21:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=/kBMeM2A7Hm7y78muq1zB7A2CGaxGbiTuYrH8TYShOk=;\n\tb=iXuqYXOO8tZRljqwvLNRuCmetvCszPEBKewi4IfKFaSv+YZzoa2lEBGEWLNoq2ra/x\n\tRkGxhzkF/QIxvSIZ/eb5Sqg2iRfHoWsYBkHww9n3ihiGKVEgEnuyenrodlmqnfsWqi4X\n\tbuT3ediMcq/k2rBYDBGlsFAjCdf/PXGkMEb/r7jzoQD/gJ5gMFb5jz4EDF28diXE9Bn0\n\t4AU26nPuxRC+xm6g+tJBvE3w8bBWKu/E5YmJ3Wu7dqSW9GIbxYw6eb3n+4wrRqTv1fSi\n\tuTEGg5o6pyOkMOUqEmSoVbS8c+0uz0nsmhBrzMJcFqrwHzoEfcaBrVo38klFR7w9Hsdv\n\tCydg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=/kBMeM2A7Hm7y78muq1zB7A2CGaxGbiTuYrH8TYShOk=;\n\tb=Rr2nNOP/bZMgx0MDNpmY8NGpdQDbWl1IdscmpXXEiPIe6NwJsu5iInLaRy523OR6zN\n\tIEL82BVQy8blQ6ftg0+DZYJZMIV9wJrKKejcDJBdEQpm7TUR7LG67y8SqwnNTUaWQ4oW\n\t8m7LuspnVDfqyb/DZEoEB3RyVumSIMcAJAk6PWFOMIDTZ6sxBhUPO4zFSB6dKyfDKmza\n\tYvSBD7iYlXrSgm++b4lz4rg/CnEVQ8oGXym97grm3sPFMOWnthOhnTlfvPf1vFZf/UlZ\n\tZam1ws6D4bXYCP8A/fIVkCre8Q2knnErhJZw5ObBWSJFtYSzzfT9Jvb3eK9u5fLxlD8i\n\tFjKQ==", "X-Gm-Message-State": "APt69E0zLXE4Iwe9KYTGfAQYw+W3YbvZ7DTpoRLcpWvMwhvhDzVCOg4k\n\t7Sbc/C2ZVybkhZCKA+SoTbMkIujN1uYDYo4yOhA=", "X-Google-Smtp-Source": "ADUXVKKcdSAre9kG55q+8pJs+sFTzWMXhP66Af+j2Z3kjg2HddjK01HzVZzj85noCQ+DVs0uw4Z+Xcws0ic0uPCbUl0=", "X-Received": "by 2002:a6b:8267:: with SMTP id\n\te100-v6mr1755549iod.110.1528381306121; \n\tThu, 07 Jun 2018 07:21:46 -0700 (PDT)", "MIME-Version": "1.0", "In-Reply-To": "<20180607123849.14439-14-qi.z.zhang@intel.com>", "References": "<20180607123849.14439-1-qi.z.zhang@intel.com>\n\t<20180607123849.14439-14-qi.z.zhang@intel.com>", "From": "Chas Williams <3chas3@gmail.com>", "Date": "Thu, 7 Jun 2018 10:21:45 -0400", "Message-ID": "<CAG2-GkkVaxrFMteCMRiAkmQKGDoUwz0K99Up3Hvfe7mYd62Pcw@mail.gmail.com>", "To": "Qi Zhang <qi.z.zhang@intel.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, \"Burakov,\n\tAnatoly\" <anatoly.burakov@intel.com>, \n\t\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>, dev@dpdk.org, \n\tBruce Richardson <bruce.richardson@intel.com>,\n\tFerruh Yigit <ferruh.yigit@intel.com>, \n\tbenjamin.h.shelton@intel.com, narender.vangati@intel.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH 13/22] net/bonding: enable port detach on\n\tsecondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]