List comments

GET /api/patches/40746/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 81976,
        "web_url": "http://patches.dpdk.org/comment/81976/",
        "msgid": "<81ec16de-38a4-9d9d-ba33-26378fd00d63@nxp.com>",
        "list_archive_url": "https://inbox.dpdk.org/dev/81ec16de-38a4-9d9d-ba33-26378fd00d63@nxp.com",
        "date": "2018-06-08T12:08:20",
        "subject": "Re: [dpdk-dev] [PATCH 02/22] bus/vdev: enable one device scan",
        "submitter": {
            "id": 497,
            "url": "http://patches.dpdk.org/api/people/497/",
            "name": "Shreyansh Jain",
            "email": "shreyansh.jain@nxp.com"
        },
        "content": "On 6/7/2018 6:08 PM, Qi Zhang wrote:\n> Implemented the bus ops scan_one, besides this improve the scan\n> efficiency in hotplug case, it aslo avoid sync IPC invoke (which\n                                  ^^^^\n                                  also\n\n> happens in vdev->scan on secondary process). The benifit is it\n                                                    ^^^^^^^\n                                                    benefit\n\n> removes the potiential deadlock in the case when secondary process\n               ^^^^^^^^^^\n               potential\n\n> receive a request from primary process to attach a new device, since\n> vdev->scan will be invoked on mp thread itself at this case.\n                                                  ^^^^^^^\n                                                  in that\n\n\nBesides the above spells, is it possible to re-write the commit?\nYou mention it \"...improves the scan efficiency...\" - how? Is that an \nimplicit output of introducing the new scan_one for vdev?\n\n> \n> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>\n> ---\n>   drivers/bus/vdev/vdev.c | 30 ++++++++++++++++++++++++++++++\n>   1 file changed, 30 insertions(+)\n> \n> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\n> index 6139dd551..cdbd77df0 100644\n> --- a/drivers/bus/vdev/vdev.c\n> +++ b/drivers/bus/vdev/vdev.c\n> @@ -467,6 +467,35 @@ vdev_scan(void)\n>   \treturn 0;\n>   }\n>   \n\n[...]",
        "headers": {
            "Content-Language": "en-US",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "MIME-Version": "1.0",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-Microsoft-Exchange-Diagnostics": [
                "1; AM5PR0402MB2770;\n\t3:HR89i72st32kmgyvr9Me+ie7K1txsnzvNnxKDjEFK0Jhcz3zrPHnSu6pjXbBhqiQ9ItH9vxSJ5gtUnDS3qBAa5PY+lJJzOIMUwJnCS738eySHbHi1qwYdDN9ihuyMoNzGmbYNZRZ3ikG5uTOS4WX6GGkToICsCYMSeeViD5EwFyfpCS+r7Edm6d1ZT+qNZpxuc1TqvJGpzJ4iDIl8KZFCoAkEmesYgiuvYKVMYYpzuGoypeyMpajS9HUIFkdxWzw;\n\t25:l4wJSulEjt+I0MJoPs+vtGCG/yvttbBbjygyVI+PEt0ES41zSuZZ2Zk/cjxYmsQ0WMlZ0X2EJ4wLrdWbLmpn+3FYQRuFQVkrAYRqNh4DxwiQESZYXNoZ9Ud7w5kYcE9TU4R7b3l4WDc34qzDFDG9yB8dUVFQ0eexJYVUhmIS6rvYjnu0y4AtSjP/5mJk3uR6TJ/5d5wvBv3Z2DgfaxH2aAkdMQkL7OuB4HADSbxrLU6NVJuCOKLnlq9HlGuAUlwHtwYvVYS1UGR6bsdIzuQpX32J1VtkJj5LzrERFPRQRWmsdRd2vZW1EZMxuRDDVlu+GSA55XMag67DplaYPdfl8A==;\n\t31:I9PAbstXyifNjX5NscSGxYTjaVBV9q7yyZd5sKTafvSpBw/N7ODI90Y0Wmv88/6HTr7q4xFh6npjxIbG0qWfUBWSRGibr0Dx8I9bl4D12WbTVV55pl0tZ8XDRIn0U4AtFwP6/Eq73ZwYveYgaGFvLXvXcgOHkwSxS+sl1HZ1T2a3Vbe39WVcvJusShkp1Fo1UpsFnyIR4ZSnDled2SYhIXw0kC9goOf7MTpSE/pDx+o=",
                "1; AM5PR0402MB2770;\n\t20:w4jldDn4O7WwjRuxZuf4JLFe2/iGEZxT5xkB4TCmFV+qskvkTdd0tJB+B8WxIXYpQN7xvCMhma2DN/x6pY/Gx51D4FrfEcXCctGj3v/2/UBF9RTWGEDN8bayvf1WRhSMII516cmIgXUbX6mJ0KPNPgNePA7baUC5KDaxz+l1Ln5cE3iBsLbrMp9FqauhVxxaLbR7hiI/cppRLuD/Sbv+kq0s3bZrw5zu83gHXp0ndFTc959yzAefeh6j0wfOA2L/0HvhfJNTwAOZ0KmBovjFF90Z0sxla9XiHmnSFl+tLKDQsS0OSkJzOsRhr6L01GwLs3FI2Sp4z4oO3MGu7zk3KUiMlFHsNV2CQJLsLj+5iU0TBkCprUTgbrPxIBlSk2cNVnTH8ozrb/LiAaA5KUUuJUZrwaZnlx7dRDqZbn5ybpWwRyLW04+QWZ7Zj25PIhQUdVUv7byMJZAij9qANUDNotwbt3gtnbJw8UM278r3zstZhtzE077Wk1oglgAgcL2k;\n\t4:6vO/q+UG4Oysebt4IG6rPOLcObJPZ7JnilidLrXzDxuTMrPySOOiquQcLqYJfNNYwoXXD7Ne5CN2vEmQ8mpE31XwsCRe1B+UjqKQeOHfN2mMqdAHPQeWFCIScgW7BtxW5h/qtLiSDxmKEZsJ/4IiiTwEVsDatOfV4GfsjVIZsz6rDtuQaQDFsmKMPl0BFDPP3T8+GT/LoBM4RXKQvMlKMKiGF6lfHEhuSLlAg9E1IGCpNhpNhpncC1ZpjjElT7RGat0hiW2mA1hWi+HndnF8ofp4NoULURrcPxD1ZdpuB/OpwX4Sfkq8DMKL4G3Xq6l2",
                "=?utf-8?q?1=3BAM5PR0402MB2770=3B23=3AHu?=\n\t=?utf-8?q?rAi8ERqpz3yU7wuP7eejjKOYstb8qhUSABikFEGXR5pqFoSbkwhyv5Nu?=\n\t=?utf-8?q?csqX+sYz2Qsf2d78CJNcwDPiPCkbLCjG7iSqoShsUXgi9OYMNa0puVdf?=\n\t=?utf-8?q?NuVZV05zB3eG6byGHcSgTZOJeL7SM8zJA0swJbk6VkLysihAOE2X+UZc?=\n\t=?utf-8?q?R6MnEG7iWSg0tKgUeW0aPMNVJbInvMhpk0XOnWL55fn1ugkKe3GO8Alc?=\n\t=?utf-8?q?HeX/vbknU3YK0gXkrhIc5MfA5PFVDa2Zn2WqlLEEIxqjCY46fZxhcz0A?=\n\t=?utf-8?q?ULCVHLc6QywLNQCnGhOItpmUSplx5PdqafDpINj7Pvyb15EGElVcr4dE?=\n\t=?utf-8?q?je6u2MeQzv7lNY3I4ei/FQen/1zub7i2wQWRQHVpVptQanSOW18AEIt/?=\n\t=?utf-8?q?A1+EDzfSqlSHSSDchmm0suwyqggmYTQ36AYf6aqds+whx+zT9BDkSkGp?=\n\t=?utf-8?q?E5wE6ajUO/fjbjNcj7dNzvqIE4P+rOAXy8B4s4XA8BZaaU6iO6XhE8Bn?=\n\t=?utf-8?q?6vBRHvjP/InxEKkfD1DNKd2leGcOR6JUgg6nGE1iC+jaiCcf7n3UHBXX?=\n\t=?utf-8?q?8i0ze+StiXzmRwAAc1oy9hqlGJeGsd0DewdCwRkayKBy9ywf1F4A5UEG?=\n\t=?utf-8?q?MUo6Lg2eoSxeMadajSa5VqGYP4JhscsYQxwynL33V1JHZI+PKnGelmI0?=\n\t=?utf-8?q?PY9PaE1Gt1bCVHeWVSiFSXJ2NXH3+MEREEShHVDmCSGDna64xZKbIN8i?=\n\t=?utf-8?q?N5ycuBagueHHQEsouecuT57d0DWKPGBXNf6r/vgJz85IphNrUyFDbAg9?=\n\t=?utf-8?q?m0OaNCzxKy1QEtFG/ol5PCo7kJZjwbPUTz4SGaHIuM8ahv+wzb0r5zmw?=\n\t=?utf-8?q?rqOlTJ7lgw+nlT14VztvMwbneSM3qGTL7hSVwhbDsXIxuPyji+6J5rWk?=\n\t=?utf-8?q?ddE6CWHcLFxyXL1mHmjylwB7y/HiIyzCWmLX2RjmDYagmzUDmrqXhb9Y?=\n\t=?utf-8?q?QEKaNc1mdjh68ISCOGNuiTSFvSTzZslF2ToMf5Vt2K4yAYZ/Aa5Zo0bc?=\n\t=?utf-8?q?bH5Lk26DD/mxAA00QwItoxDeYa+Yru3E0I06su1lMg/Ow8LS8wTPGx2X?=\n\t=?utf-8?q?2b6MxCC0zQUpiQV5pYhQJfrA5Z37tAc7/sUEG8lBNfalRSQt89bvCgiy?=\n\t=?utf-8?q?RK1I0qc6z9vpVSrft7sQ1EV5hoJPxF6gVxmmOvcEHwDrxsIFOT6kQGM0?=\n\t=?utf-8?q?oYR3lvFPPK9+MolPjeu1olaZ1WQht7PoNh6Xz9Iuu+qifF4hzCMGnMSn?=\n\t=?utf-8?q?kur3YUAcw8hnCbNJendqlXy3BVYNjDjZ+vRBrWmnWpK0Kz0Y/Ic2nxlh?=\n\t=?utf-8?q?ylDNdw2OnV28bdJ9HaSdF9LfHpFCVREFqs6fAGf2Zl50WzZ7KzMq/FtF?=\n\t=?utf-8?q?lZLDVeOgXcUMEXyr/PsZc5S3Pe4wG15NY8+XGGed0bIB1f5VY3LhSxdL?=\n\t=?utf-8?q?v1p8mfKIyRTWMH1+sbczfv8vqm9xn5Smn3LNT5IDLHiMh8dkgITjtuMf?=\n\t=?utf-8?q?G1OMiqOCipZkpc3+2jl9YeucBX6EU7d16yWXhvPNLIGNmcvHMXIkMNkQ?=\n\t=?utf-8?q?3m1VB501EJ20RLeRBLoabbgdyMmtNEGjbrYDnaTybyI+JNifP8Uj4CIi?=\n\t=?utf-8?q?Ug6iyaPVnyQJ1ej52sEV+q7felb7I1EQCGOueAJ7IZzT//5M0ofw=3D?=\n\t=?utf-8?q?=3D?=",
                "1; AM5PR0402MB2770;\n\t6:PeAKviD4yrWAawJd6hP/mffNzFETzwPW+jlaPxrW7GNV619yWQhVNZvBvT+M/xW3ILePs5Pq5xTmoE1g1YDiZVpPRF++zWmoloLU2Z3XkLIeab7NGstBDx0dIoamz5j1rPOtQkvUvDoVrhRlnH9rH3KnsSgIy/QilqFF2KRXFOJx1qWPWXasqeGoLY4wB0RUWrSkQ1quq9fScUYB8gjU4a3UCUtaqhzWwdUcmyitwb953EEvnPzUyx3FX/P2cUkmoWSA4Sn3FV2hOHsRwXdZvkYFh9wg7B7PQd/wPTHiMjkfOHyJLKZZB7OKaGCAMwCWwyGYbsnzwbmYX7t1tao4cksvR6vqnvxxjGhCryjC/epQyIifTNOwV6/rT3qr30dPUW5lx7CadHGhSYN0+/Mlu1XKaDRhOwDe/5leu0dGMo1uJAEBaYMAydBbc0UUyHVCqFZEH6ENL4mkzm87yJZTYg==;\n\t5:EukZBt6f20/HyQpwgZTA3UsEnemgssZxt5pcXgzlYSrr9h7r8h7Rc2C9bLPnCDsyB+yqlwk4M2MxWLgOp5b5Yi5qVVZt8ue8ZIUvmHiy7YT0DcjUrKeM9CP2hZdGDpuWHU1EArOVIJ1vETtCeEFxU6FEW6Hv9aFsFfHFbRgBhfg=;\n\t24:gTsV94Xv+zsWfCH9WC1onzvNTaymTouD9cqsdeEUMRRacO5IS3uNNDHH+i0c5SQ3C4PXePcEc8sslr0Jz8DiBVPYfwvD/1hv4FEIofWsuo0=",
                "1; AM5PR0402MB2770;\n\t7:HouBHaSPEydajj9WSJWzJZBd+myWR2AzC6JZovDljTWjYWcfv4FPb+itxZnOL5ye38FXN/9MEnG13/OugEHETf4RpK6Mm5oWinFYU6esH6PFppHqQDfDrXznLxgFCsb+ZfExspDlfFxGXzFAbxgyiQyyyYAKaxcL+xdGKNHY4/BDW8g9Tm6SeL4lqkZa0pmbTg+4m2SZOM5cLWQUhBWBAS6J6Z+ODq6CKKmWekVC4S3gaiWv92s08DrIYUjzywfr"
            ],
            "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(6049001)(396003)(39860400002)(346002)(39380400002)(376002)(366004)(189003)(199004)(67846002)(478600001)(52116002)(446003)(11346002)(23676004)(2486003)(52146003)(26005)(44832011)(77096007)(16526019)(186003)(59450400001)(7736002)(476003)(305945005)(25786009)(386003)(53546011)(486006)(55236004)(3260700006)(47776003)(65956001)(76176011)(2616005)(65806001)(229853002)(6486002)(66066001)(105586002)(316002)(16576012)(956004)(5890100001)(31686004)(8676002)(64126003)(4326008)(58126008)(106356001)(2906002)(68736007)(81166006)(81156014)(230700001)(36756003)(6116002)(31696002)(3846002)(86362001)(50466002)(65826007)(6246003)(97736004)(5009440100003)(6666003)(5660300001)(6916009)(53936002)(8936002)(110426005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0402MB2770; H:[10.232.40.129];\n\tFPR:; \n\tSPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; ",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "References": "<20180607123849.14439-1-qi.z.zhang@intel.com>\n\t<20180607123849.14439-3-qi.z.zhang@intel.com>",
            "In-Reply-To": "<20180607123849.14439-3-qi.z.zhang@intel.com>",
            "SpamDiagnosticOutput": "1:99",
            "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM5PR0402MB2770",
            "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "08 Jun 2018 12:08:35.2515\n\t(UTC)",
            "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "SpamDiagnosticMetadata": "NSPM",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "X-MS-PublicTrafficType": "Email",
            "X-Originating-IP": "[14.142.187.166]",
            "Content-Transfer-Encoding": "7bit",
            "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
            "X-BeenThere": "dev@dpdk.org",
            "X-Forefront-PRVS": "06973FFAD3",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "4a97dd36-76df-43e8-6caf-08d5cd389160",
            "Date": "Fri, 8 Jun 2018 17:38:20 +0530",
            "Errors-To": "dev-bounces@dpdk.org",
            "X-Microsoft-Antispam-Message-Info": "jPe5Vp08gITminQ0D81srF/ickohNkNBKeIAnKrvNIt9FyJEdUsz/pzJyLnGZ4MXS/KG1cVMd0Hvw+T+H72Wulf9858GZwTdnlh+iSeADw48ziCX3eUWERQ0ZW283pYkZv2ZWN54xS+4B2gxJVZhO3/9y5x9SHIuOQECQYJONBopRoFeztpYfvOYd+0giq6Z",
            "Received-SPF": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=J3UlprkpcobUiCX9+tO9WC1ZYv0w1nJodxeJbramzx8=;\n\tb=XAIJVtQTzdvN8VxjCKPjSorFIbU/e8PyDU9qRx5JK/nZwvO9PixcinuynSlmbQ3Dy/uz/ZRwYLO9LqdcbntagbQfs6jPVgeBVhxYt3+1AAhQgS3tbUzcdruQ7ZIFNqOkr/WbSL4VylkyDzYZA8WQWe8rL/W9yjkBaRok7s8EU7c=",
            "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635",
            "From": "Shreyansh Jain <shreyansh.jain@nxp.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "To": "Qi Zhang <qi.z.zhang@intel.com>",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 17D826841;\n\tFri,  8 Jun 2018 14:08:41 +0200 (CEST)",
                "from EUR04-DB3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr60040.outbound.protection.outlook.com [40.107.6.40])\n\tby dpdk.org (Postfix) with ESMTP id D77ED5F72\n\tfor <dev@dpdk.org>; Fri,  8 Jun 2018 14:08:39 +0200 (CEST)",
                "from [10.232.40.129] (14.142.187.166) by\n\tAM5PR0402MB2770.eurprd04.prod.outlook.com (2603:10a6:203:98::12) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.16;\n\tFri, 8 Jun 2018 12:08:35 +0000"
            ],
            "X-MS-Office365-Filtering-Correlation-Id": "4a97dd36-76df-43e8-6caf-08d5cd389160",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0",
            "X-MS-TrafficTypeDiagnostic": "AM5PR0402MB2770:",
            "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020);\n\tSRVR:AM5PR0402MB2770; ",
            "X-Microsoft-Antispam-PRVS": "<AM5PR0402MB2770724483EB6F11653489AF907B0@AM5PR0402MB2770.eurprd04.prod.outlook.com>",
            "Delivered-To": "patchwork@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Message-ID": "<81ec16de-38a4-9d9d-ba33-26378fd00d63@nxp.com>",
            "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016);\n\tSRVR:AM5PR0402MB2770; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0402MB2770; ",
            "X-MS-Office365-Filtering-HT": "Tenant",
            "X-MS-Exchange-SenderADCheck": "1",
            "X-Mailman-Version": "2.1.15",
            "X-ClientProxiedBy": "SG2PR04CA0145.apcprd04.prod.outlook.com\n\t(2603:1096:3:16::29) To AM5PR0402MB2770.eurprd04.prod.outlook.com\n\t(2603:10a6:203:98::12)",
            "X-OriginatorOrg": "nxp.com",
            "X-Exchange-Antispam-Report-Test": "UriScan:(228905959029699);",
            "Subject": "Re: [dpdk-dev] [PATCH 02/22] bus/vdev: enable one device scan",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Precedence": "list",
            "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shreyansh.jain@nxp.com; ",
            "Cc": "thomas@monjalon.net, anatoly.burakov@intel.com,\n\tkonstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, benjamin.h.shelton@intel.com,\n\tnarender.vangati@intel.com"
        }
    },
    {
        "id": 82134,
        "web_url": "http://patches.dpdk.org/comment/82134/",
        "msgid": "<039ED4275CED7440929022BC67E7061153237739@SHSMSX103.ccr.corp.intel.com>",
        "list_archive_url": "https://inbox.dpdk.org/dev/039ED4275CED7440929022BC67E7061153237739@SHSMSX103.ccr.corp.intel.com",
        "date": "2018-06-13T13:32:48",
        "subject": "Re: [dpdk-dev] [PATCH 02/22] bus/vdev: enable one device scan",
        "submitter": {
            "id": 504,
            "url": "http://patches.dpdk.org/api/people/504/",
            "name": "Qi Zhang",
            "email": "qi.z.zhang@intel.com"
        },
        "content": "> -----Original Message-----\n> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]\n> Sent: Friday, June 8, 2018 8:08 PM\n> To: Zhang, Qi Z <qi.z.zhang@intel.com>\n> Cc: thomas@monjalon.net; Burakov, Anatoly <anatoly.burakov@intel.com>;\n> Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org;\n> Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh\n> <ferruh.yigit@intel.com>; Shelton, Benjamin H\n> <benjamin.h.shelton@intel.com>; Vangati, Narender\n> <narender.vangati@intel.com>\n> Subject: Re: [dpdk-dev] [PATCH 02/22] bus/vdev: enable one device scan\n> \n> On 6/7/2018 6:08 PM, Qi Zhang wrote:\n> > Implemented the bus ops scan_one, besides this improve the scan\n> > efficiency in hotplug case, it aslo avoid sync IPC invoke (which\n>                                   ^^^^\n>                                   also\n> \n> > happens in vdev->scan on secondary process). The benifit is it\n>                                                     ^^^^^^^\n>                                                     benefit\n> \n> > removes the potiential deadlock in the case when secondary process\n>                ^^^^^^^^^^\n>                potential\n> \n> > receive a request from primary process to attach a new device, since\n> > vdev->scan will be invoked on mp thread itself at this case.\n>                                                   ^^^^^^^\n>                                                   in that\n> \n> \n> Besides the above spells, is it possible to re-write the commit?\n> You mention it \"...improves the scan efficiency...\" - how? Is that an implicit\n> output of introducing the new scan_one for vdev?\n\n\"Improve scan efficiency\" should be general to all buses in hot plug case.\nsince compare to bus->scan, bus->scan_one no need to iterate all devargs.\nBut yes, it's not the original purpose for this patch set, but a bonus.\n\nI will re-write comment with below format to make it more clear.\nThe patch implemented bus ops scan_one for vdev, it gives two benefits\n1. improve scan efficiency ....\n2. avoid sync IPC invoke .....\n\nRegards\nQi\n\n> \n> >\n> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>\n> > ---\n> >   drivers/bus/vdev/vdev.c | 30 ++++++++++++++++++++++++++++++\n> >   1 file changed, 30 insertions(+)\n> >\n> > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index\n> > 6139dd551..cdbd77df0 100644\n> > --- a/drivers/bus/vdev/vdev.c\n> > +++ b/drivers/bus/vdev/vdev.c\n> > @@ -467,6 +467,35 @@ vdev_scan(void)\n> >   \treturn 0;\n> >   }\n> >\n> \n> [...]",
        "headers": {
            "To": "Shreyansh Jain <shreyansh.jain@nxp.com>",
            "x-originating-ip": "[10.239.127.40]",
            "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDkxOWY0YWUtNGE1OC00YzZjLTg3ZTUtMjlkMTJjNTk5ZTJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNk16bk15VEx5MjArSmtDOWFmT1J6Zk9kakswXC9JcWplWVhudFZHTzA1Rlh4djVQYlZYMnd2SzFDd2Jkemh0WWMifQ==",
            "x-ctpclassification": "CTP_NT",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "MIME-Version": "1.0",
            "X-MS-TNEF-Correlator": "",
            "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>",
            "Message-ID": "<039ED4275CED7440929022BC67E7061153237739@SHSMSX103.ccr.corp.intel.com>",
            "CC": "\"thomas@monjalon.net\" <thomas@monjalon.net>, \"Burakov, Anatoly\"\n\t<anatoly.burakov@intel.com>, \"Ananyev, Konstantin\"\n\t<konstantin.ananyev@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>,\n\t\"Richardson, Bruce\" <bruce.richardson@intel.com>, \"Yigit, Ferruh\"\n\t<ferruh.yigit@intel.com>, \"Shelton, Benjamin H\"\n\t<benjamin.h.shelton@intel.com>, \"Vangati, Narender\"\n\t<narender.vangati@intel.com>",
            "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Accept-Language": "en-US",
            "X-MS-Has-Attach": "",
            "References": "<20180607123849.14439-1-qi.z.zhang@intel.com>\n\t<20180607123849.14439-3-qi.z.zhang@intel.com>\n\t<81ec16de-38a4-9d9d-ba33-26378fd00d63@nxp.com>",
            "In-Reply-To": "<81ec16de-38a4-9d9d-ba33-26378fd00d63@nxp.com>",
            "Delivered-To": "patchwork@dpdk.org",
            "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "dlp-version": "11.0.200.100",
            "X-BeenThere": "dev@dpdk.org",
            "dlp-reaction": "no-action",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F5471EF8A;\n\tWed, 13 Jun 2018 15:32:54 +0200 (CEST)",
                "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id D7EAB1EF89\n\tfor <dev@dpdk.org>; Wed, 13 Jun 2018 15:32:52 +0200 (CEST)",
                "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jun 2018 06:32:51 -0700",
                "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n\tby orsmga005.jf.intel.com with ESMTP; 13 Jun 2018 06:32:51 -0700",
                "from fmsmsx112.amr.corp.intel.com (10.18.116.6) by\n\tFMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Wed, 13 Jun 2018 06:32:51 -0700",
                "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tFMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Wed, 13 Jun 2018 06:32:50 -0700",
                "from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.223]) with mapi id\n\t14.03.0319.002; Wed, 13 Jun 2018 21:32:48 +0800"
            ],
            "X-Original-To": "patchwork@dpdk.org",
            "Content-Type": "text/plain; charset=\"utf-8\"",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-Amp-File-Uploaded": "False",
            "Content-Transfer-Encoding": "base64",
            "Thread-Index": "AQHT/lx7R1ren+J2PUqFWouqUNSW1KRVv/IAgAhzpQA=",
            "X-IronPort-AV": "E=Sophos;i=\"5.51,218,1526367600\"; d=\"scan'208\";a=\"232264854\"",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-ExtLoop1": "1",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Date": "Wed, 13 Jun 2018 13:32:48 +0000",
            "Thread-Topic": "[dpdk-dev] [PATCH 02/22] bus/vdev: enable one device scan",
            "dlp-product": "dlpe-windows",
            "Subject": "Re: [dpdk-dev] [PATCH 02/22] bus/vdev: enable one device scan",
            "Precedence": "list",
            "Content-Language": "en-US",
            "X-Mailman-Version": "2.1.15",
            "X-Amp-Result": "SKIPPED(no attachment in message)"
        }
    }
]