get:
Show a patch.

patch:
Update a patch.

put:
Update a patch.

GET /api/patches/40718/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 40718,
    "url": "http://patches.dpdk.org/api/patches/40718/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180607094322.14312-5-mk@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180607094322.14312-5-mk@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180607094322.14312-5-mk@semihalf.com",
    "date": "2018-06-07T09:43:00",
    "name": "[dpdk-dev,v3,05/27] net/ena: add stop and uninit routines",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "12438e98a794279932a7005dae616dddb86f87bc",
    "submitter": {
        "id": 786,
        "url": "http://patches.dpdk.org/api/people/786/?format=api",
        "name": "Michal Krawczyk",
        "email": "mk@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180607094322.14312-5-mk@semihalf.com/mbox/",
    "series": [
        {
            "id": 26,
            "url": "http://patches.dpdk.org/api/series/26/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26",
            "date": "2018-06-07T09:43:00",
            "name": "net/ena: new features and fixes",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/26/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/40718/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/40718/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4852F1B1B6;\n\tThu,  7 Jun 2018 11:43:42 +0200 (CEST)",
            "from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67]) by dpdk.org (Postfix) with ESMTP id E8A761B16F\n\tfor <dev@dpdk.org>; Thu,  7 Jun 2018 11:43:35 +0200 (CEST)",
            "by mail-lf0-f67.google.com with SMTP id i83-v6so13654280lfh.5\n\tfor <dev@dpdk.org>; Thu, 07 Jun 2018 02:43:35 -0700 (PDT)",
            "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tp28-v6sm3612368lfh.24.2018.06.07.02.43.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Jun 2018 02:43:34 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=kSfrk1ixmmU0rmSZiEsXPVSn0SlN73jJpENv2FPlmN4=;\n\tb=higXkTF0ndmccJWwG4oN00S0Uev6O8nLwHiQBzXo7M5r1duHGCkvdojk5dyQHmVbb+\n\tQ0qYRssqv6sLYdpZNP6q8pXN2hJVgj7GVsmZUR0Nt2Koo7VvN7QJJl377CNdFQ2ufj0u\n\taZbGB4MA9zCRrmaZOnSK90hNFaZB3iLaFCBimfJiedV9HjRkr+eQuNmMYcC5XG4bx8O8\n\tQ/cUGsrcLOBveRy9+GfEMtH+0u1BnjAj4wto7wX8WUBoAzRQIcxXCqGkxeXGmQuv/mtB\n\twHenFEIpsfiVflnEl7KmxgGyzNhBVzWCEl58PwuvsTE1fVff92fhkezyutTGx+1Y6ClU\n\trTSA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=kSfrk1ixmmU0rmSZiEsXPVSn0SlN73jJpENv2FPlmN4=;\n\tb=a/aYrste0k9BfOashVdxELexX7ljbXy2dQGYpnF5A15HaRPTq0IYjTQ24fJ74g+6u8\n\tTIdgMMqdDX6DvpAry8L5O3cMci30Z0vwATWlzoruzcPmHmyjQNqOEWrVQC3prWfF0Mor\n\tbroGcFRcfqUulRxiH1a1YytVRIYp6EKFYkzXSKfNWaL1lVASXBJpL0BiNxY4D0HpyT4s\n\tfpD9qvRqwFwU/+3KBBllc1MP5752UVUXgnHB5jX4pUFm9zOMgrReQHmq9hgaWYAN+ZtV\n\t2I9u8WKAuSir9VuAc1eUv8iFHKLfEdr0INUnoX7pJxO+0mftqOKPHn+oeQcBw5vOUsBR\n\trJDA==",
        "X-Gm-Message-State": "APt69E2acu4DvEmTh0UKTAmnNdTvxz8pLFB61O5NNB90dgFBAI6oWep8\n\tke9baRmmJt9daXeEQyt92GJwEQ==",
        "X-Google-Smtp-Source": "ADUXVKKvzzow+juENix90m6frkbrXcr3k9+c3GCK1ygQVjh7xW+gc6RjCXT1iqPOzFeFQtV8ppQHJg==",
        "X-Received": "by 2002:a2e:575c:: with SMTP id\n\tr28-v6mr941335ljd.51.1528364615350; \n\tThu, 07 Jun 2018 02:43:35 -0700 (PDT)",
        "From": "Michal Krawczyk <mk@semihalf.com>",
        "To": "Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,\n\tGuy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>, \n\tAnatoly Burakov <anatoly.burakov@intel.com>",
        "Cc": "dev@dpdk.org,\n\tmatua@amazon.com",
        "Date": "Thu,  7 Jun 2018 11:43:00 +0200",
        "Message-Id": "<20180607094322.14312-5-mk@semihalf.com>",
        "X-Mailer": "git-send-email 2.14.1",
        "In-Reply-To": "<20180607094322.14312-1-mk@semihalf.com>",
        "References": "<20180607094322.14312-1-mk@semihalf.com>",
        "Subject": "[dpdk-dev] [PATCH v3 05/27] net/ena: add stop and uninit routines",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Lack of uninit routine could lead to memory leak.\nStop was added to fulfill allowed PMD operations.\n\nChecks for the PMD states in the start and configure routine were\nremoved, as the upper layer is already checking for them.\n\nThe interrupt setup was moved from start to init function.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 95 +++++++++++++++++++++++++-------------------\n drivers/net/ena/ena_ethdev.h |  3 +-\n 2 files changed, 56 insertions(+), 42 deletions(-)",
    "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 515d17fee..4ca19c57c 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -223,6 +223,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count);\n static void ena_init_rings(struct ena_adapter *adapter);\n static int ena_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n static int ena_start(struct rte_eth_dev *dev);\n+static void ena_stop(struct rte_eth_dev *dev);\n static void ena_close(struct rte_eth_dev *dev);\n static int ena_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats);\n static void ena_rx_queue_release_all(struct rte_eth_dev *dev);\n@@ -254,6 +255,7 @@ static const struct eth_dev_ops ena_dev_ops = {\n \t.rx_queue_setup       = ena_rx_queue_setup,\n \t.tx_queue_setup       = ena_tx_queue_setup,\n \t.dev_start            = ena_start,\n+\t.dev_stop             = ena_stop,\n \t.link_update          = ena_link_update,\n \t.stats_get            = ena_stats_get,\n \t.mtu_set              = ena_mtu_set,\n@@ -460,15 +462,9 @@ static void ena_close(struct rte_eth_dev *dev)\n {\n \tstruct ena_adapter *adapter =\n \t\t(struct ena_adapter *)(dev->data->dev_private);\n-\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n-\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n-\n-\tadapter->state = ENA_ADAPTER_STATE_STOPPED;\n \n-\trte_intr_disable(intr_handle);\n-\trte_intr_callback_unregister(intr_handle,\n-\t\t\t\t     ena_interrupt_handler_rte,\n-\t\t\t\t     adapter);\n+\tena_stop(dev);\n+\tadapter->state = ENA_ADAPTER_STATE_CLOSED;\n \n \tena_rx_queue_release_all(dev);\n \tena_tx_queue_release_all(dev);\n@@ -916,16 +912,8 @@ static int ena_start(struct rte_eth_dev *dev)\n {\n \tstruct ena_adapter *adapter =\n \t\t(struct ena_adapter *)(dev->data->dev_private);\n-\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n-\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tint rc = 0;\n \n-\tif (!(adapter->state == ENA_ADAPTER_STATE_CONFIG ||\n-\t      adapter->state == ENA_ADAPTER_STATE_STOPPED)) {\n-\t\tPMD_INIT_LOG(ERR, \"API violation\");\n-\t\treturn -1;\n-\t}\n-\n \trc = ena_check_valid_conf(adapter);\n \tif (rc)\n \t\treturn rc;\n@@ -947,16 +935,19 @@ static int ena_start(struct rte_eth_dev *dev)\n \n \tena_stats_restart(dev);\n \n-\trte_intr_callback_register(intr_handle,\n-\t\t\t\t   ena_interrupt_handler_rte,\n-\t\t\t\t   adapter);\n-\trte_intr_enable(intr_handle);\n-\n \tadapter->state = ENA_ADAPTER_STATE_RUNNING;\n \n \treturn 0;\n }\n \n+static void ena_stop(struct rte_eth_dev *dev)\n+{\n+\tstruct ena_adapter *adapter =\n+\t\t(struct ena_adapter *)(dev->data->dev_private);\n+\n+\tadapter->state = ENA_ADAPTER_STATE_STOPPED;\n+}\n+\n static int ena_queue_restart(struct ena_ring *ring)\n {\n \tint rc, bufs_num;\n@@ -1317,6 +1308,7 @@ static void ena_interrupt_handler_rte(__rte_unused void *cb_arg)\n static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n {\n \tstruct rte_pci_device *pci_dev;\n+\tstruct rte_intr_handle *intr_handle;\n \tstruct ena_adapter *adapter =\n \t\t(struct ena_adapter *)(eth_dev->data->dev_private);\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n@@ -1347,6 +1339,8 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \t\t     pci_dev->addr.devid,\n \t\t     pci_dev->addr.function);\n \n+\tintr_handle = &pci_dev->intr_handle;\n+\n \tadapter->regs = pci_dev->mem_resource[ENA_REGS_BAR].addr;\n \tadapter->dev_mem_base = pci_dev->mem_resource[ENA_MEM_BAR].addr;\n \n@@ -1406,36 +1400,55 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn -ENOMEM;\n \t}\n \n+\trte_intr_callback_register(intr_handle,\n+\t\t\t\t   ena_interrupt_handler_rte,\n+\t\t\t\t   adapter);\n+\trte_intr_enable(intr_handle);\n+\tena_com_set_admin_polling_mode(ena_dev, false);\n+\n \tadapters_found++;\n \tadapter->state = ENA_ADAPTER_STATE_INIT;\n \n \treturn 0;\n }\n \n+static int eth_ena_dev_uninit(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n+\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n+\tstruct ena_adapter *adapter =\n+\t\t(struct ena_adapter *)(eth_dev->data->dev_private);\n+\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -EPERM;\n+\n+\tif (adapter->state != ENA_ADAPTER_STATE_CLOSED)\n+\t\tena_close(eth_dev);\n+\n+\teth_dev->dev_ops = NULL;\n+\teth_dev->rx_pkt_burst = NULL;\n+\teth_dev->tx_pkt_burst = NULL;\n+\teth_dev->tx_pkt_prepare = NULL;\n+\n+\trte_free(adapter->drv_stats);\n+\tadapter->drv_stats = NULL;\n+\n+\trte_intr_disable(intr_handle);\n+\trte_intr_callback_unregister(intr_handle,\n+\t\t\t\t     ena_interrupt_handler_rte,\n+\t\t\t\t     adapter);\n+\n+\tadapter->state = ENA_ADAPTER_STATE_FREE;\n+\n+\treturn 0;\n+}\n+\n static int ena_dev_configure(struct rte_eth_dev *dev)\n {\n \tstruct ena_adapter *adapter =\n \t\t(struct ena_adapter *)(dev->data->dev_private);\n \n-\tif (!(adapter->state == ENA_ADAPTER_STATE_INIT ||\n-\t      adapter->state == ENA_ADAPTER_STATE_STOPPED)) {\n-\t\tPMD_INIT_LOG(ERR, \"Illegal adapter state: %d\",\n-\t\t\t     adapter->state);\n-\t\treturn -1;\n-\t}\n-\n-\tswitch (adapter->state) {\n-\tcase ENA_ADAPTER_STATE_INIT:\n-\tcase ENA_ADAPTER_STATE_STOPPED:\n-\t\tadapter->state = ENA_ADAPTER_STATE_CONFIG;\n-\t\tbreak;\n-\tcase ENA_ADAPTER_STATE_CONFIG:\n-\t\tRTE_LOG(WARNING, PMD,\n-\t\t\t\"Ivalid driver state while trying to configure device\\n\");\n-\t\tbreak;\n-\tdefault:\n-\t\tbreak;\n-\t}\n+\tadapter->state = ENA_ADAPTER_STATE_CONFIG;\n \n \tadapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads;\n \tadapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads;\n@@ -1838,7 +1851,7 @@ static int eth_ena_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \n static int eth_ena_pci_remove(struct rte_pci_device *pci_dev)\n {\n-\treturn rte_eth_dev_pci_generic_remove(pci_dev, NULL);\n+\treturn rte_eth_dev_pci_generic_remove(pci_dev, eth_ena_dev_uninit);\n }\n \n static struct rte_pci_driver rte_ena_pmd = {\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex 394d05e02..79fb14aeb 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -97,9 +97,10 @@ struct ena_ring {\n enum ena_adapter_state {\n \tENA_ADAPTER_STATE_FREE    = 0,\n \tENA_ADAPTER_STATE_INIT    = 1,\n-\tENA_ADAPTER_STATE_RUNNING  = 2,\n+\tENA_ADAPTER_STATE_RUNNING = 2,\n \tENA_ADAPTER_STATE_STOPPED = 3,\n \tENA_ADAPTER_STATE_CONFIG  = 4,\n+\tENA_ADAPTER_STATE_CLOSED  = 5,\n };\n \n struct ena_driver_stats {\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "05/27"
    ]
}